~apport-hackers/apport/main : changes

~apport-hackers/apport/main » Changes from revision 3916

From Revision 3916 to 3897

Rev	Summary	Authors	Date
3916	refactor: Add ProblemReport._get_sorted_keys (#187) refactor: Add ProblemReport._get_sorted_keys (#187)	BMaxV	11 months ago
3915	fix(apport): Replace os.path.exists check by try-except fix(apport): Replace os.path.exists check by try-except Replace `os.path.exists` check by trying to open the file and catching `FileNotFoundError` to avoid race conditions. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3914	fix(tests): Fix false positives for test_run_crash_anonymity fix(tests): Fix false positives for test_run_crash_anonymity The test `test_run_crash_anonymity` can fail if the user or host name is short: ``` ====================================================================== FAIL: test_run_crash_anonymity (tests.integration.test_ui.T) run_crash() anonymization ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python3.10/unittest/mock.py", line 1369, in patched return func(newargs, *newkeywargs) File "/<<PKGBUILDDIR>>/tests/integration/test_ui.py", line 1650, in test_run_crash_anonymity self.assertNotIn( AssertionError: 'kin' unexpectedly found in 'ProblemType: Crash\nArchitecture: amd64\n[...]' ``` The string `kin` can be found in the report (for example in the tag `kinetic`). So only search for full words in the report if the string is short (less than five characters and not the string `ubuntu`). Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3913	fix: Use ProblemReport for running generic hook manually fix: Use ProblemReport for running generic hook manually Running the generic general hook manually fails: ``` $ python3 data/general-hooks/generic.py Traceback (most recent call last): File "/home/bdrung/projects/apport/apport/data/general-hooks/generic.py", line 129, in <module> add_info(r, None) File "/home/bdrung/projects/apport/apport/data/general-hooks/generic.py", line 123, in add_info if report["ProblemType"] == "Crash": ~~~~~~^^^^^^^^^^^^^^^ KeyError: 'ProblemType' ``` Use an instance of `ProblemReport` like Apport would use. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3912	fix: Fix raising OSError if _command_output() runs into a ti... fix: Fix raising OSError if _command_output() runs into a timeout mypy complains: ``` apport/report.py:179: error: On Python 3 formatting "b'abc'" with "{}" produces "b'abc'", not "abc"; use "{!r}" if this is desired behavior [str-bytes-safe] apport/report.py:180: error: Item "None" of "Optional[bytes]" has no attribute "rstrip" [union-attr] ``` The mypy complains can be converted into a test case that fail: ``` ERROR: test_command_output_timeout_no_output (tests.integration.test_report.T.test_command_output_timeout_no_output) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/bdrung/projects/apport/apport/apport/report.py", line 169, in _command_output sp = subprocess.run( ^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/subprocess.py", line 550, in run stdout, stderr = process.communicate(input, timeout=timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/subprocess.py", line 1207, in communicate stdout, stderr = self._communicate(input, endtime, timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/subprocess.py", line 2060, in _communicate self._check_timeout(endtime, orig_timeout, stdout, stderr) File "/usr/lib/python3.11/subprocess.py", line 1251, in _check_timeout raise TimeoutExpired( subprocess.TimeoutExpired: Command '['sleep', '3600']' timed out after 0.1 seconds During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/bdrung/projects/apport/apport/tests/integration/test_report.py", line 1938, in test_command_output_timeout_no_output apport.report._command_output(["sleep", "3600"], timeout=0.1) File "/home/bdrung/projects/apport/apport/apport/report.py", line 182, in _command_output f" after {error.timeout} seconds: {error.stdout.rstrip()}" ^^^^^^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'rstrip' ``` Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3911	refactor(apport): Drop using proc_pid_fd from is_same_ns refactor(apport): Drop using proc_pid_fd from is_same_ns Instead of using `proc_pid_fd` in `is_same_ns()` just specify the path to the cgroup file. The other code in the function does that already. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3910	refactor: Move pylint's invalid-name overrides to affected f... refactor: Move pylint's invalid-name overrides to affected files Move pylint's invalid-name overrides to affected files to allow getting this alert for new cases. Address the pylint complains for files that only have a few complains. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3909	refactor(gtk/kde): Add assertions to make mypy happy refactor(gtk/kde): Add assertions to make mypy happy mypy complains: ``` gtk/apport-gtk:238: error: "None" has no attribute "get" [attr-defined] gtk/apport-gtk:280: error: Value of type "None" is not indexable [index] gtk/apport-gtk:413: error: Unsupported right operand type for in ("None") [operator] gtk/apport-gtk:414: error: Value of type "None" is not indexable [index] kde/apport-kde:130: error: "QObject" has no attribute "setRange" [attr-defined] kde/apport-kde:131: error: "QObject" has no attribute "setValue" [attr-defined] kde/apport-kde:133: error: "QObject" has no attribute "setRange" [attr-defined] kde/apport-kde:134: error: "QObject" has no attribute "setValue" [attr-defined] kde/apport-kde:413: error: Incompatible types in assignment (expression has type "ReportDialog", variable has type "None") [assignment] kde/apport-kde:417: error: "None" has no attribute "exec_" [attr-defined] kde/apport-kde:426: error: "None" has no attribute "continue_button" [attr-defined] kde/apport-kde:429: error: "None" has no attribute "send_error_report" [attr-defined] kde/apport-kde:431: error: "None" has no attribute "ignore_future_problems" [attr-defined] kde/apport-kde:516: error: "None" has no attribute "set" [attr-defined] kde/apport-kde:518: error: "None" has no attribute "set" [attr-defined] ``` Add assertions to ensure that the variables are not `None`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3908	refactor(apport-cli): Move saving the report into a separate... refactor(apport-cli): Move saving the report into a separate function Move saving the problem report in a temporary directory into a separate function. Assert that `self.report` is not `None` to make mypy happy. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3907	fix(tests): Correct type of local_path in get_data_directory... fix(tests): Correct type of local_path in get_data_directory to str All calls to `get_data_directory` that specify `local_path` pass a string. So correct that type. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3906	refactor: Increase pylint's maximum public methods to 25 refactor: Increase pylint's maximum public methods to 25 Increase the allowed maximum public methods to 25 and move the overrides to the individual classes. It is okay for test case classes to have more than 25 tests inside. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3905	fix(tests): Fix type hint for _write_crashdb_config_hook fix(tests): Fix type hint for _write_crashdb_config_hook ``` tests/integration/test_ui.py:523: error: Incompatible default for argument "bash_hook" (default has type "None", argument has type "str") [assignment] tests/integration/test_ui.py:523: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True tests/integration/test_ui.py:523: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase ``` Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3904	fix(tests): Fix check for full name in test_run_crash_anonym... fix(tests): Fix check for full name in test_run_crash_anonymity The value `pw_gecos` contains a comma separated list where the first element might be the full user name. Split the first element from `pw_gecos` (if it is not empty) to check that the full name is not in the crash report. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3903	refactor(tests): Introduce _get_sensitive_strings refactor(tests): Introduce _get_sensitive_strings Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3902	refactor(tests): Use names instead of index of pwd.getpwuid(... refactor(tests): Use names instead of index of pwd.getpwuid() response The property names are easier to read than the index numbers of the `pwd.getpwuid` response.	Benjamin Drung	1 year ago
3901	fix: Correct range of system users/groups from 499 to dynami... fix: Correct range of system users/groups from 499 to dynamic 999 The test case `test_crash_apport` will fail if the test executing user is member of a system group with an ID between 500 and 999: ``` ====================================================================== FAIL: test_crash_apport (tests.integration.test_signal_crashes.T.test_crash_apport) Report generation with apport. ---------------------------------------------------------------------- Traceback (most recent call last): File "/<<PKGBUILDDIR>>/tests/integration/test_signal_crashes.py", line 211, in test_crash_apport self.assertLess(grp.getgrnam(g).gr_gid, 500) AssertionError: 992 not less than 500 ====================================================================== ``` The default maximum system user/group ID on Debian based systems in 999 (defined in `/etc/login.defs`), but the Linux Standard Base (LSB) only specifies 499 as maximum (in "User ID Ranges"). Read the maximum system user group ID from `/etc/login.defs` and default to 999 if it is not set. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3900	fix(apport): Demote non-error log messages to info level fix(apport): Demote non-error log messages to info level Apport only used error log message even for purely informational logs. Since `logging` is used nowadays, demote the non-error log messages to info level. Reduce the log level from warning to info to still print these messages. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3899	refactor: Move pylint's too-many-lines overrides to affected... refactor: Move pylint's too-many-lines overrides to affected files Move pylint's too-many-lines overrides to affected files to allow getting this alert for new cases. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3898	refactor(apport): Make cwd a private variable refactor(apport): Make cwd a private variable The global variable `cwd` is only used in `write_user_coredump`. So defining it can be deferred until `write_user_coredump` is called and `cwd` can be private to `write_user_coredump`. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago
3897	refactor: Increase pylint's max attributes to 9 refactor: Increase pylint's max attributes to 9 Increase the allowed maximum attributes to nine and move the overrides to the individual classes. Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>	Benjamin Drung	1 year ago

Older »