← Back to branch summary

~arthru/prestashoperpconnect/import-product-combinations

« back to all changes in this revision

Viewing changes to prestashoperpconnect/product_combination.py

  • Committer: Arthur Vuillard
  • Date: 2013-10-29 09:23:52 UTC
  • Revision ID: arthur.vuillard@akretion.com-20131029092352-1ji14cuymgx2eag2
Use isinstance instead of type comparisons

Show diffs side-by-side

added added

removed removed

Lines of Context:
prestashoperpconnect/product_combination.py
137
137
                continue
138
138
            if hasattr(main_product[attribute], 'id'):
139
139
                result[attribute] = main_product[attribute].id
140
 
            elif type(main_product[attribute]) is list:
 
140
            elif isinstance(main_product[attribute]), list):
141
141
                ids = []
142
142
                for element in main_product[attribute]:
143
143
                    ids.append(element.id)
172
172
    def attributes_values(self, record):
173
173
        option_values = record['associations']['product_option_values'][
174
174
            'product_option_value']
175
 
        if type(option_values) is dict:
 
175
        if isinstance(option_values, dict):
176
176
            option_values = [option_values]
177
177
 
178
178
        results = {}
313
313
        if 'language' in record['name']:
314
314
            language_binder = self.get_binder_for_model('prestashop.res.lang')
315
315
            languages = record['name']['language']
316
 
            if type(languages) != list:
 
316
            if not isinstance(languages, list):
317
317
                languages = [languages]
318
318
            for lang in languages:
319
319
                erp_language_id = language_binder.to_openerp(