← Back to branch summary

~beuno/python-oops-tools/show-newest-oopses

« back to all changes in this revision

Viewing changes to src/oopstools/oops/dbsummaries.py

  • Committer: Tarmac
  • Author(s): Robert Collins
  • Date: 2012-09-10 06:15:42 UTC
  • mfrom: (38.1.1 bug-1048470)
  • Revision ID: launchpad@pqm.canonical.com-20120910061542-ae7lifmkmde4s9dx
This fixes handling of non-unicode pageids, which were stored OK in the DB, but broke HTML report rendering.

Show diffs side-by-side

added added

removed removed

Lines of Context:
src/oopstools/oops/dbsummaries.py
134
134
                data['pageid'] = 'Unknown'
135
135
            if data['pageid'] == '':
136
136
                data['pageid'] = 'Unknown'
 
137
            data['pageid'] = _escape(data['pageid'])
137
138
            data['escaped_url'] = _escape(data['url'])
138
139
            data['errors'] = data['errors'].split(',')
139
140
            data['errors'].sort()
457
458
            fp.write('<td>%s</td>\n<td><a href="%s">%s</a></td>'
458
459
                     '\n<td>%s</td>\n' % (
459
460
                        self.field_format % value,
460
 
                        get_absolute_url(oopsids[0]), oopsids[0], pageid))
 
461
                        get_absolute_url(oopsids[0]), oopsids[0].encode('utf8'),
 
462
                        _escape(pageid)))
461
463
            fp.write('</tr>\n')
462
464
        fp.write('</table>')
463
465
        fp.write('</div>')