1
This documents the expections that the project has on what both submitters
2
and reviewers should ensure that they've done for a merge into the project.
6
The menu items may not be visible until the x-canonical-types
7
"com.canonical.indicator.transfer" and "com.canonical.indicator.bulk-action"
8
are supported by the renderer. Until then, if you're willing to build
9
manually, you can force them to look like normal menuitems by removing these
10
two lines from src/view-gmenu.cpp's create_transfer_menuitem():
12
> g_menu_item_set_attribute (menu_item, "x-canonical-type",
13
> "s", "com.canonical.indicator.transfer");
15
and these two lines from the same file's create_bulk_action_menuitem():
17
> const char * type = "com.canonical.indicator.transfer-bulk-action";
18
> g_menu_item_set_attribute (menu_item, "x-canonical-type", "s", type);
21
== Submitter Responsibilities ==
23
* Ensure the project compiles and the test suite executes without error
24
* Ensure that non-obvious code has comments explaining it
25
* Ensure the manual tests in tests/manual pass
27
== Reviewer Responsibilities ==
29
* Did the Jenkins build compile? Pass? Run unit tests successfully?
30
* Are there appropriate tests to cover any new functionality?
31
* Confirm that the manual tests pass
1
* '''Checklist for component''': indicator-transfer
2
* '''Component Test Plan''': https://wiki.ubuntu.com/Process/Merges/TestPlan/indicator-transfer
3
* '''Trunk URL''': lp:indicator-transfer
4
* '''Ubuntu Package URL (LP)''': http://launchpad.net/ubuntu/+source/indicator-transfer
6
This documents the expections that the project has on what submitters,
7
reviewers, and landers should ensure that they've done for a merge into
10
The source for this document can be gotten from Bazaar:
12
$ bzr cat lp:indicator-transfer/MERGE-REVIEW
15
== MP Submission Checklist Template ==
17
'''Note: Please ensure you include the following form filled out and submitted along side your code to the MP ticket.'''
19
* Are there any related MPs required for this MP to build/function as expected? Please list.
20
* Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)
21
* Did the code build without warnings?
22
* Did the tests run successfully?
23
* Did you perform an exploratory manual test run of your code change and any related functionality?
24
* Has your component test plan been executed successfully on emulator or a physical device?
25
* Please list which manual tests are germane for the reviewer in this MP.
27
== MP Review Checklist Template ==
29
'''Note: Please ensure you include the following form filled out and submitted along side your code to the MP ticket.'''
31
* Have you checked that the submitter has accurately filled out the submitter checklist and has taken no shortcuts?
32
* Did you run the manual tests listed by the submitter?
33
* Did you do exploratory testing related to the component you own with the MP changeset included?
34
* If new features have been added, are the manual tests sufficient to cover them?
36
== MP Landing Checklist Template ==
38
'''Note: Please ensure you include the following form filled out and submitted along side your code to the MP ticket.'''
40
* Ensure that the checklists have been properly filled out by submitter and all reviewers
added
removed
MERGE-REVIEW
