~ci-train-bot/syncevolution/syncevolution-ubuntu-yakkety-landing-098 : changes

~ci-train-bot/syncevolution/syncevolution-ubuntu-yakkety-landing-098 » Changes from revision 4644

From Revision 4644 to 4625

Rev	Summary	Authors	Tags	Date
4644	Releasing 1.5.1+16.10.20160820-0ubuntu1 Releasing 1.5.1+16.10.20160820-0ubuntu1	Bileto Bot	1.5.1+16.10.20160820-0ubuntu1	7 years ago
4643	* Add 0003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-... * Add 0003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-FTB.patch to add missing casts from shared_ptr to bool, fixes FTBFS with GCC 6 * Fix remaining FTBFS with GCC 6 by downgrading the C++ dialect to gnu++98 (Closes: #811624) (LP: #1613405)	Bileto Bot		7 years ago
4642	Releasing 1.5.1+16.10.20160706-0ubuntu1 Releasing 1.5.1+16.10.20160706-0ubuntu1	Bileto Bot	1.5.1+16.10.20160706-0ubuntu1	7 years ago
4641	New upstream release New upstream release -debian/patches/Avoid-crash-if-the-g_variant_new_string-fails.patch, merged upstream	Bileto Bot		7 years ago
4640	wrap-and-sort wrap-and-sort	Ken VanDine		7 years ago
4639	initial packaging branch initial packaging branch	Ken VanDine		7 years ago
4638	syncing: avoid segfault for invalid text inside items (FDO #... syncing: avoid segfault for invalid text inside items (FDO #90118) As reported by Canonical, syncing fails if data items contain text which is not correct UTF-8 in one of the fields that SyncEvolution logs in the command line output (like SUMMARY of a calendar event). That is because the byte string coming from the item is passed unchecked to the D-Bus implementation for transmission via D-Bus. But D-Bus strings must be correct UTF-8, so depending on the D-Bus library in use, one gets a segfault (GIO D-Bus, due to an unchecked NULL pointer access) or an "out of memory" error (libdbus, which checks for NULL). What the D-Bus bindings now do is checking the string in advance (to avoid error messages inside the D-Bus implementations) and then replacing all invalid bytes with question marks. The rest of the string is preserved. Handling this inside the D-Bus binding layer is not the "correct" solution (which would be to check for UTF-8 in the higher layers were such bad data might get into SyncEvolution), but it is the less intrusive and more complete one. Changing the bindings such that all strings must be declared explicitly as "UTF-8 string" would have been a way to find all places where such checks are missing, but it turned out to be too complex and requiring too many changes.	Patrick Ohly		8 years ago
4637	file backend: log item manipulation file backend: log item manipulation Extracting a meaningful description of each item from the Synthesis engine when updating and adding items is easy to do for items of certain known types (contacts and calendar items) and arguably an improvement; in particular it makes tests like TestCmdline.testSyncOutput more realistic.	Patrick Ohly		8 years ago
4636	D-Bus testing: check sync result on both sides of TestLocalS... D-Bus testing: check sync result on both sides of TestLocalSync.testSync Checking that the item still exists on the side where it was created is okay, but it is more important to check that it also reached the other side.	Patrick Ohly		8 years ago
4635	command line: preserve log prefix of target side of local sy... command line: preserve log prefix of target side of local sync In some cases, the prefix which was supposed to be embedded in the log messages from the target side of a local sync got lost on the way to the command line tool. Primarily this affected the added/updated/deleted messages, as in: [INFO remote@client] @client/addressbook: started [INFO remote@client] updating "Joan Doe" [INFO remote@client] @client/addressbook: received 1/1 This was not caught by automated testing because the corresponding test (TestCmdline.testSyncOutput and TestCmdline.testSyncOutput2) is using the file backend, which does not generate such messages at the moment (to be changed separately).	Patrick Ohly		8 years ago
4634	Use ${PKG_CONFIG} instead of pkg-config. Use ${PKG_CONFIG} instead of pkg-config. This fixes the build on Exherbo that only has prefixed versions of pkg-config.	Niels Ole Salscheide...		9 years ago
4633	WebDAV: handle 403 during Google OAuth authentication WebDAV: handle 403 during Google OAuth authentication When sending an access token with insufficient scope (for example, because the Ubuntu Online Accounts service definition was incomplete, as documented in FDO #86824), Google responds with a 403 "service denied" error. Neon (arguably correctly) treats this as a permanent error and not as a transient authentication error. Google should better send a 401 error. To activate the 401 error handling in SyncEvolution, detect this special case and turn the general SE_ERROR error into SE_AUTH.	Patrick Ohly		9 years ago
4632	signon: ensure consistent use of "username" provider prefix signon: ensure consistent use of "username" provider prefix The Ubuntu Online Accounts signon backend complained about invalid "username" content with an error message containing "sso", the string used for gSSO. Define these magic strings once and then use only the defines.	Patrick Ohly		9 years ago
4631	signon-accounts: implement getCredentials signon-accounts: implement getCredentials Use the information contained in the AgAuthData object to decide which authentication method is being used. Move the common authentication code into a private authenticate() method. [PO: fixed g_variant_builder_end() mem leak] [PO: avoid issue found via cppcheck: returning std::string::c_str() in a method returning a std::string forces a string copy, which is inefficient.] [PO: UiPolicy was not set because of an invalid g_variant_builder_add() "sv" parameter.]	Alberto Mardegan		9 years ago
4630	signon-accounts: pass the AgAuthData to the SignonAuthProvid... signon-accounts: pass the AgAuthData to the SignonAuthProvider Instead of passing the session data and the mechanism, pass the full AgAuthData object to the SignonAuthProvider constructor. This object can be used to build the session data without converting all dictionaries to and from GHashTable. [PO: fixed g_variant_builder_end() mem leak] [PO: ForceTokenRefresh was not set because of an invalid g_variant_builder_add() "sv" parameter.]	Alberto Mardegan		9 years ago
4629	signon-accounts: do not create identities on the fly signon-accounts: do not create identities on the fly It's not sync-evolution task to complete the account creation; in those platforms where this backend is deployed (Ubuntu, Elementary, KDE) the account should already be created with a proper SignonIdentity attached to it.	Alberto Mardegan		9 years ago
4628	AuthProvider: removed failure count AuthProvider: removed failure count Remove the failure count from the getOAuth2Bearer() method, and add an invalidateCachedSecrets() method instead. This moves the logic of how to deal with failures back to the AuthProvider backend and simplifies the session code, which only needs to call invalidateCachedSecrets() when the token is wrong. This will help implementing a similar logic for the getCredentials() method, where authentication errors could lead to requesting a new password. [PO: avoid issue found via cppcheck: returning std::string::c_str() in a method returning a std::string forces a string copy, which is inefficient.]	Alberto Mardegan		9 years ago
4627	signon: move libaccounts-based plugins into their own source... signon: move libaccounts-based plugins into their own source file The libaccounts-based backends ("gsso" and "uoa") are going to use more of libaccounts-glib, making sharing of code with the plain "signon" plugin much harder to maintain.	Alberto Mardegan		9 years ago
4626	CalDAV: more efficient "is empty" check (FDO #86335) CalDAV: more efficient "is empty" check (FDO #86335) Since 1.4.99.4, syncing WebDAV collections always checks first whether there are items in the collections. This was partly done for slow sync prevention (which is not necessary for empty collections), partly for the "is the datastore usable" check. However, this did not take into account that for CalDAV collections, the entire content gets downloaded for this check. That is because filtering by item type (VEVENT vs. VJOURNAL) is not implemented correctly by all servers. So now all CalDAV syncs, whether incremental or slow, always transfered all items, which is not the intention (incremental syncs should be fast and efficient). This commit adds a more efficient isEmpty() check: for simple CardDAV collections, only luid and etag get transferred, as in listAllItems(). This is the behavior from 1.5. For CalDAV, a report with a filter for the content type is used and the transfer gets aborted after the first item, without actually double-checking the content of the item. This is different from listAllItems(), which really transfers the content. This extra content check would only be needed for some old servers (Radical 0.7) and is not essential, because reporting "not empty" even when empty is safe.	Patrick Ohly		9 years ago
4625	WebDAV: utility class for ne_status WebDAV: utility class for ne_status Besides offering C++ wrappers for the C API, this class also ensures that memory for the "reason_string" is properly freed.	Patrick Ohly		9 years ago

Older »