~cjwatson/rabbitfixture/rabbitmq-server-3.8.10

Viewing changes to rabbitfixture/server.py

Committer: Gavin Panella
Date: 2013-09-16 16:45:09 UTC
mfrom: (29.1.5 untangle-host)
Revision ID: gavin.panella@canonical.com-20130916164509-hbs81wfxdd3s0k37

[r=rvba][bug=1225980] Fix port reuse issues when restarting the fixture.

Previously RabbitMQ was started on all addresses, the fq_hostname
property was incorrectly using gethostname() regardless of the
hostname given, and allocate_ports() only ever checked ports on
localhost.

files modified:
rabbitfixture/server.py

rabbitfixture/tests/test_server.py

Show diffs side-by-side

added added

removed removed

rabbitfixture/server.py

signal.signal(signal.SIGPIPE, signal.SIG_DFL)

def allocate_ports(n=1):

"""Allocate `n` unused ports.

def get_port(socket):

"""Return the port to which a socket is bound."""

addr, port = socket.getsockname()

return port

def allocate_ports(*addrs):

"""Allocate `len(addrs)` unused ports.

A port is allocated for each element in `addrs`.

There is a small race condition here (between the time we allocate the

port, and the time it actually gets used), but for the purposes for which

this function gets used it isn't a problem in practice.

"""

sockets = map(lambda _: socket.socket(), xrange(n))

sockets = [socket.socket() for addr in addrs]

try:

for s in sockets:

s.bind(('localhost', 0))

return map(lambda s: s.getsockname()[1], sockets)

for addr, sock in zip(addrs, sockets):

sock.bind((addr, 0))

return [get_port(sock) for sock in sockets]

finally:

for s in sockets:

s.close()

for sock in sockets:

sock.close()

# Pattern to parse rabbitctl status output to find the nodename of a running

107

115

if self.hostname is None:

108

116

self.hostname = 'localhost'

109

117

if self.port is None:

110

[self.port] = allocate_ports(1)

118

[self.port] = allocate_ports(self.hostname)

111

119

if self.homedir is None:

112

120

self.homedir = self.useFixture(TempDir()).path

113

121

if self.mnesiadir is None:

121

129

@property

122

130

def fq_nodename(self):

123

131

"""The node of the RabbitMQ that is being exported."""

124

# Note that socket.gethostname is recommended by the rabbitctl manpage

125

# even though we're always on localhost, its what the erlang cluster

126

# code wants.

127

return "%s@%s" % (self.nodename, socket.gethostname())

132

return "%s@%s" % (self.nodename, self.hostname)

128

133

129

134

130

135

class RabbitServerEnvironment(Fixture):

134

139

135

140

- ``RABBITMQ_MNESIA_BASE``

136

141

- ``RABBITMQ_LOG_BASE``

142

- ``RABBITMQ_NODE_IP_ADDRESS``

137

143

- ``RABBITMQ_NODE_PORT``

138

144

- ``RABBITMQ_NODENAME``

139

145

- ``RABBITMQ_PLUGINS_DIR``

156

162