- Committer: Tyler Hicks
- Date: 2017-06-09 15:39:12 UTC
- Revision ID: tyhicks@canonical.com-20170609153912-ltw0lodo5ps0aukl
Remove unreachable code when parsing mount opt name value pairs
Revision 886 introduced a change to the mount option parsing code for
name-value pairs. A break was added to a loop once the first '=' is seen.
Before the break was added, it was possible that a '=' would be seen, then
memory allocated for the name portion of the string, then another '=' could be
seen and the previous name string be freed and then reallocated. However,
there's no longer a chance of needing to reallocate the name string so the
free() is not needed.
Discovered by Coverity (CID 1375979)
Revision 886 introduced a change to the mount option parsing code for
name-value pairs. A break was added to a loop once the first '=' is seen.
Before the break was added, it was possible that a '=' would be seen, then
memory allocated for the name portion of the string, then another '=' could be
seen and the previous name string be freed and then reallocated. However,
there's no longer a chance of needing to reallocate the name string so the
free() is not needed.
Discovered by Coverity (CID 1375979)
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
cmd_ln_parser.c |
894 | 8 years ago | Tyler Hicks | Remove unreachable code when parsing mount opt nam | 9.7 KB |
|
|
|
decision_graph.c |
888 | 8 years ago | Tyler Hicks | Fix loop in ecryptfs-manager when there are no opt | 32.5 KB |
|
|
|
ecryptfs-stat.c |
804 | 11 years ago | Tyler Hicks | Fix some of the signed and unsigned int comparison | 5.1 KB |
|
|
|
key_management.c |
853 | 10 years ago | Dustin Kirkland | - Reject empty passphrases passed into ecryptfs_ | 34 KB |
|
|
|
key_mod.c |
831 | 11 years ago | Tyler Hicks | * src/libecryptfs/key_mod.c: Show path in the erro | 11.4 KB |
|
|
|
libecryptfs.pc.in |
406 | 15 years ago | Dustin Kirkland | * README, configure.ac, debian/control, debian/r | 245 bytes |
|
|
|
main.c |
851.2.2 | 10 years ago | Tyler Hicks | * src/libecryptfs/key_management.c: - Reject emp | 22.1 KB |
|
|
|
Makefile.am |
741 | 12 years ago | Tyler Hicks | * src/daemon/main.c, src/include/ecryptfs.h, src | 717 bytes |
|
|
|
messaging.c |
792 | 11 years ago | Tyler Hicks | * configure.ac: - Set AM_CPPFLAGS to always incl | 4.5 KB |
|
|
|
miscdev.c |
813 | 11 years ago | Tyler Hicks | Fix a -Wsign-compare warning on i386 by casting th | 7.4 KB |
|
|
|
module_mgr.c |
815 | 11 years ago | Tyler Hicks | r801 introduced the use of strtoumax(), which retu | 26.2 KB |
|
|
|
packets.c |
792 | 11 years ago | Tyler Hicks | * configure.ac: - Set AM_CPPFLAGS to always incl | 10.2 KB |
|
|
|
sysfs.c |
792 | 11 years ago | Tyler Hicks | * configure.ac: - Set AM_CPPFLAGS to always incl | 3.8 KB |
|
|