~frankban/juju-quickstart/bundlelib-019 : changes

~frankban/juju-quickstart/bundlelib-019 » Changes from revision 139

From Revision 131 to 112

Rev	Summary	Authors	Tags	Date
131	[r=bac] Bump version to 2.0.2 [r=bac] Bump version to 2.0.2	Brad Crittenden		9 years ago
130	[r=evarlast, rick_h] Add support for Google Compute Engine [r=evarlast, rick_h] Add support for Google Compute Engine	Brad Crittenden		9 years ago
129	Update provider fields. Update provider fields. Update the list of fields that quickstart expects for each provider type. Also make some OpenStack fields optional (use-floating-ip, tenant-name and region). Update the links to the provider documentation (use jujucharms.com). Update the jujubundlelib dependency to use the latest one. Tests: `make check`. QA: - check that the environment editing in the interactive session looks good (especially the openstack/azure environments creation). - use quickstart as usual (`devenv/bin/juju-quickstart`), to start (for instance) an ec2 or an azure environment. R= CC= https://codereview.appspot.com/234150043	Francesco Banconi		9 years ago
128	Update to new jujubundlelib 0.1.5. Update to new jujubundlelib 0.1.5. R=matthew.scott CC= https://codereview.appspot.com/229480043	Francesco Banconi		9 years ago
127	Some small changes in preparation for change sets. Some small changes in preparation for change sets. Extend the services method of the bundle model to include the number of units for each service. Use the newer jujubundlelib. R=rharding CC= https://codereview.appspot.com/231120043	Francesco Banconi		9 years ago
126	Juju bundlelib validation in quickstart. Juju bundlelib validation in quickstart. Validate bundles using jujubundlelib. Also add to the bundle model the ability to return its change set. R=jeff.pihach, matthew.scott CC= https://codereview.appspot.com/232890043	Francesco Banconi		9 years ago
125	Introduce jujubundlelib dependency. Introduce jujubundlelib dependency. Use the Reference model defined there. R=matthew.scott CC= https://codereview.appspot.com/228460043	Francesco Banconi		9 years ago
124	Always retrieve bundle from new cs endpoint. Always retrieve bundle from new cs endpoint. This is a follow up from previous branch, and also includes the remaining bits before 2.0.1 release. Even if a legacy bundle is specified, and even if the legacy bundle data is retrieved for name validation, always use the new bundle.yaml charm store endpoint when returning the bundle contents. This branch also include a drive by fix to always run `apt-get update` before installing packages, even in the case --distro-only is enabled. Tests: `make check`. QA: install bundles with quickstart: `devenv/bin/juju-quickstart {bundle}` Try the following bundles: - devenv/bin/juju-quickstart mediawiki-single - devenv/bin/juju-quickstart u/bigdata-dev/apache-analytics-sql - devenv/bin/juju-quickstart bundle:mediawiki/scalable - devenv/bin/juju-quickstart bundle:~landscape/landscape-dense-maas/landscape-dense-maas - devenv/bin/juju-quickstart bundle:django/example-single Those instead should return errors: - devenv/bin/juju-quickstart mediawiki/trusty - devenv/bin/juju-quickstart mediawiki-nosuch - devenv/bin/juju-quickstart no-such - devenv/bin/juju-quickstart bundle:no/such - devenv/bin/juju-quickstart bundle:invalid - devenv/bin/juju-quickstart bundle:~landscape/landscape-dense-maas/landscape Thank you! R=bac, rharding CC= https://codereview.appspot.com/215750043	Francesco Banconi	2.0.1	9 years ago
123	Fix the old-style bundle regression. Fix the old-style bundle regression. This branch fixes https://bugs.launchpad.net/juju-quickstart/+bug/1429129 In essence, legacy bundles are converted by the ingestion process like the following: - if a basked includes multiple bundles, the resulting v4 bundle name is {basket-name}-{bundle-name} for each {bundle-name}; - if a basket only includes one bundle, the v4 bundle is just {basket-name}. Previously quickstart always assumed the former: this branch adds a check for the latter before exiting with an error. This branch also introduces a charmstore module in quickstart. All the interactions between quickstart and the charm store are now collected in this module. As part of this refactoring, quickstart is now able to distinguish HTTP 404 errors and all the other generic IOErrors that can be raised when connecting to the network. Also simplified the logging format and bootstrap logging earlier in the application execution. Tests: `make check`. QA: install bundles with quickstart: `devenv/bin/juju-quickstart {bundle}` Try the following bundles: - devenv/bin/juju-quickstart mediawiki-single - devenv/bin/juju-quickstart u/bigdata-dev/apache-analytics-sql - devenv/bin/juju-quickstart bundle:mediawiki/scalable - devenv/bin/juju-quickstart bundle:~landscape/landscape-dense-maas/landscape-dense-maas - devenv/bin/juju-quickstart bundle:django/example-single Those instead should return errors: - devenv/bin/juju-quickstart mediawiki/trusty - devenv/bin/juju-quickstart mediawiki-nosuch - devenv/bin/juju-quickstart no-such - devenv/bin/juju-quickstart bundle:no/such - devenv/bin/juju-quickstart bundle:invalid - devenv/bin/juju-quickstart bundle:~landscape/landscape-dense-maas/landscape R=jeff.pihach, rharding, bac CC= https://codereview.appspot.com/215070043	Francesco Banconi		9 years ago
122	Support retrieving bundles from charm store v4. Support retrieving bundles from charm store v4. This branch implements the ability to deploy bundles from the new charm store, retrieving them with the v4 API. Also introduce the new preferred bundle id spelling, i.e. reflecting jujucharms.com paths, like "mediawiki-single" or "u/who/bundle-name". The old "bundle:basket/name" identifiers are still supported but deprecated. Deploying a bundle by specifying a directory containing the YAML file is instead not supported anymore. Ok, after this brief summary let me take two lines to really apologize for the huge diff. While I was there, I refactored some historical inconsistencies (e.g. models.Charm really being just a charm or bundle reference), and I also improved the bundle model API so that the work is done in the model and not in manage as before. There are a lot of tests too, and some documentation. Nonetheless, let me say sorry again, this is really too much stuff. With this branch Juju Quickstart is quite ready for the v4 world. The "deploy bundle" API call to the GUI server still uses the legacy format, but the ugliness of being backward compatible with namespaced bundles is very restrained and implemented in private logic in the bundles model module. Tests: `make check`. QA: run `devenv/bin/juju-quickstart` to deploy new style and old style bundles, with both version 3 and 4 formats. Note that version 3 can only be provided with arbitrary URLs or local files. Thanks a lot! R=rharding, matthew.scott CC= https://codereview.appspot.com/207040043	Francesco Banconi	2.0.0	9 years ago
121	Add support for new Juju WebSocket API endpoints. Add support for new Juju WebSocket API endpoints. Recent Juju versions introduced a new API endpoint path. In essence, instead of the usual "wss://<address>:17070", the new "wss://<address>:17070/environment/<env-uuid>/api" is used to connect to the API. This allows for connecting to a specific environment in a multi-environment state server scenario. In this branch the new API endpoint is used if a recent Juju version is in use, and if it is possible to retrieve the environment UUID from the jenv file. Also, when connecting to the GUI server (for creating the auth token or for deploying bundles), use the new GUI server API endpoints when possible, i.e. when the charm is recent enough to support redirecting requests to the new Juju endpoints. Note that this feature is assumed to land in the next juju-gui charm release (see settings.py). If that's not the case, we'll need to increase the charm revisions in settings.MINIMUM_REVISIONS_FOR_NEW_API_ENDPOINT before releasing the new Quickstart. Tests: `make check` QA: - bootstrap quickstart as usual: `devenv/bin/juju-quickstart`; - check that, if you are using juju devel (1.22beta), quickstart properly connect to the new API endpoint; - run quickstart again to deploy a bundle, e.g.: `devenv/bin/juju-quickstart bundle:mediawiki/single`; - ensure that the deployment request succeeds; - if possible, do the above with and older version of Juju, to ensure backward compatibility. Done, thank you! R=martin.hilton, jeff.pihach CC= https://codereview.appspot.com/199490043	Francesco Banconi		9 years ago
120	Refactor/split utils code. Refactor/split utils code. Move code from utils to the new jujutools and models/bundles modules. This branch only include moved code and it's done in preparation for the Juju API new login work. R=bac CC= https://codereview.appspot.com/204770043	Francesco Banconi		9 years ago
119	Avoid requiring sudo privileges on lbox submit. Avoid requiring sudo privileges on lbox submit. R= CC= https://codereview.appspot.com/199470043	Francesco Banconi		9 years ago
118	Make ftests fail if Juju env is not ready. Make ftests fail if Juju env is not ready. The functional tests are no longer silently skipped if the default Juju environment cannot be found. Also fail if the environment is running, as this would cause it to be destroyed at the end of the suite. QA: - bootstrap your default environment; - run `make ftest`/`make fcheck` and ensure the functional tests fail (environment already bootstrapped); - destroy your environment; - run `make fcheck` again and ensure all the suites complete successfully. R=jeff.pihach, kadams54 CC= https://codereview.appspot.com/195690043	Francesco Banconi		9 years ago
117	Enable tests for trusty and utopic. Enable tests for trusty and utopic. Fix the unit test suite so that tests pass when run in trusty and utopic scenarios. Also add some simple functional tests. In those tests, Quickstart is run against a real Juju env. See the changes in the HACKING file for instructions about running functional tests. To QA this, run `make check` and `make fcheck`: the latter can take some time. R=bac, jeff.pihach CC= https://codereview.appspot.com/197240043	Francesco Banconi		9 years ago
116	Introduce tox for testing multiple sets of deps. Introduce tox for testing multiple sets of deps. Quickstart must be run on several platforms/Ubuntu series, each one with its own versions of the packages that Quickstart depends on. The tox utility is used for both: - handling those kind of separate scenarios; - creating the development virtual environments. The latter was previously done using virtualenv directly in the Makefile. The new infrastructure should be more flexible. Update the relevant parts of the Makefile, also handling the automatic installation of system dependencies. Implement the ability to calculate the requirements for the PyPI package automatically by parsing the tox.ini file. I am not really sure about the method I used (take a look at the setup.py file), but the alternative is to manually update those and violate DRY. I think we could give it a try and fall back to the manual approach if required. Also implement a correct behavior for "python setup.py test", which now runs all the tests. To test and QA this branch, run `make clean` and then follow what described in the HACKING.rst file, in the following paragraphs: - Creating a development environment - Testing and debugging the application - Requirements - Updating application and test dependencies Thank you! R=bac, benjamin.saller, jeff.pihach CC= https://codereview.appspot.com/189580044	Francesco Banconi		9 years ago
115	Fix failing test on MacOS. Fix failing test on MacOS. Also update docs to include vivid. Tests: `make check`. No QA required. R=bac, martin.hilton CC= https://codereview.appspot.com/191640043	Francesco Banconi	1.6.0	9 years ago
114	Use charm store API to retrieve GUI revision. Use charm store API to retrieve GUI revision. This branch includes the following small fixes in preparation for the 1.6 release: - bump version up to 1.6.0; - use the charm store API to retrieve the URL of the last revision of the juju-gui charm; - add initial support for vivid: the new series can now be selected as default bootstrap node series when creating/editing environments. Tests: `make check`. QA: - just run `.venv/bin/python juju-quickstart` as usual, locally and on a ec2 environment (it would be nice if both precise and trusty are used as default series in this QA); check that vivid can be added as a default-series in the environment edit view; check that the last Juju GUI revision is correctly retrieved. R=martin.hilton, rog CC= https://codereview.appspot.com/197740043	Francesco Banconi		9 years ago
113	Jenv files removal functionality. Jenv files removal functionality. Add the ability to remove jenv files from the Juju home. Test: `make check`. QA: - `juju bootstrap` an environment; - create a new user for the environment: `juju user add myuser --generate -o ~/.juju/environments/myenv`; - run quickstart in interactive mode: `.venv/bin/python juju-quickstart -i`; - the "myenv" environment should be listed under "Other active environments": select it; - ensure the corresponding environment description in the jenv detail view makes sense; - click to remove the environment, cancel the removal in the confirm dialog and ensure the environment is still there; - click the "remove" button again, confirm the deletion and ensure that a message is displayed and the environment file has been deleted. Also quickstart redirects to the environments index view and "myenv" is no longer there; - destroy the environment: done, thank you! R=martin.hilton, bac CC= https://codereview.appspot.com/189540043	Francesco Banconi		9 years ago
112	Reorganize view code. Reorganize view code. Replace most of the view closures with external private functions. This has several good side effects in my opinion: - view functions are shorter; - we know which objects are used for each callback function, because we need to explicitly pass them as arguments; - external functions can be reused by multiple views if required (and we have the _use example here); - if an external callback become less straightforward, it is now possible to directly unit test it. Tests: `make check`. QA: If unit tests pass we have some confidence that the interactive session is not broken. However, some time spent on it would be great, creating/editing/destroying environments, setting them as default, canceling the changes, starting one of them, etc... Thanks a lot. R=matthew.scott, bac CC= https://codereview.appspot.com/194080043	Francesco Banconi		9 years ago

Older »