← Back to branch summary

~gary-lasker/software-center/fix-crash-lp1021308

« back to all changes in this revision

Viewing changes to softwarecenter/ui/gtk3/views/appdetailsview.py

  • Committer: Gary Lasker
  • Date: 2012-10-02 02:00:24 UTC
  • mfrom: (3206.2.1 lp1047494)
  • Revision ID: gary.lasker@canonical.com-20121002020024-udja88o4x9ngwa3m
https://launchpad.net/bugs/1047494
* lp:~mvo/software-center/lp1047494:
  - fix AttributeError crash in _on_reviews_ready_callback()
    (LP: #1047494)

Show diffs side-by-side

added added

removed removed

Lines of Context:
softwarecenter/ui/gtk3/views/appdetailsview.py
816
816
        self.cache.connect("cache-ready", self._on_cache_ready)
817
817
        self.connect("destroy", self._on_destroy)
818
818
        self.datadir = softwarecenter.paths.datadir
819
 
        self.app = None
820
 
        self.appdetails = None
821
819
        self.addons_to_install = []
822
820
        self.addons_to_remove = []
823
821
        self.properties_helper = AppPropertiesHelper(
999
997
        # the reviews become ready
1000
998
        # (we only check for pkgname currently to avoid breaking on
1001
999
        #  software-center totem)
1002
 
        if self.app.pkgname != app.pkgname:
 
1000
        if self.app is None or self.app.pkgname != app.pkgname:
1003
1001
            return
1004
1002
 
1005
1003
        # Start fetching relaxed reviews if we retrieved no data
1735
1733
                    force = True
1736
1734
        self.pkg_state = self.app_details.pkg_state
1737
1735
 
1738
 
        # for compat with the base class
1739
 
        self.appdetails = self.app_details
1740
 
 
1741
1736
        # update content
1742
1737
        # layout page
1743
1738
        if same_app and not force:
1795
1790
        #parent_xid = get_parent_xid(self)
1796
1791
        self.reviews.new_review.disable()
1797
1792
        self.review_loader.spawn_write_new_review_ui(
1798
 
            self.app, version, self.appdetails.icon, origin,
 
1793
            self.app, version, self.app_details.icon, origin,
1799
1794
            parent_xid, self.datadir)
1800
1795
 
1801
1796
    def _review_report_abuse(self, review_id):
1814
1809
        parent_xid = ''
1815
1810
        #parent_xid = get_parent_xid(self)
1816
1811
        self.review_loader.spawn_modify_review_ui(
1817
 
            parent_xid, self.appdetails.icon, self.datadir, review_id)
 
1812
            parent_xid, self.app_details.icon, self.datadir, review_id)
1818
1813
 
1819
1814
    def _review_delete(self, review_id):
1820
1815
        parent_xid = ''