~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483

« back to all changes in this revision

Viewing changes to softwarecenter/ui/gtk3/panes/availablepane.py

  • Committer: Gary Lasker
  • Date: 2012-06-13 22:19:57 UTC
  • mto: This revision was merged to the branch mainline in revision 3051.
  • Revision ID: gary.lasker@canonical.com-20120613221957-yjsd2sa24i651xun
send an empty string for the transaction ID value, this is expected in Bilal's corresponding Unity-side fix at lp:~bilalakhtar/unity/waiting-to-install-tooltip-925014

Show diffs side-by-side

added added

removed removed

Lines of Context:
449
449
        icon_path = get_file_path_from_iconname(
450
450
                                self.icons,
451
451
                                iconname=appdetails.icon)
 
452
        # Note that the transaction ID is not specified because we are firing
 
453
        # the dbus signal at the very end of the installation now, and the
 
454
        # corresponding fix in Unity is expecting this value to be empty (it
 
455
        # would not be useful to the Unity launcher at this point anyway,
 
456
        # as the corresponding transaction would be complete).
 
457
        # Please see bug LP: #925014 and corresponding Unity branch for
 
458
        # further details.
 
459
        # TODO: If and when we re-implement firing the dbus signal at the
 
460
        # start of the transaction, at that time we will need to replace
 
461
        # the empty string below with the trans_id value.
452
462
        launcher_info = UnityLauncherInfo(app.name,
453
463
                                          appdetails.icon,
454
464
                                          icon_path,
456
466
                                          icon_y,
457
467
                                          icon_size,
458
468
                                          installed_desktop_file_path,
459
 
                                          trans_id)
 
469
                                          "")
460
470
        return launcher_info
461
471
 
462
472
    def _get_onscreen_icon_details_for_launcher_service(self, app):