~haggai-eran/unity-2d/rtl-rebased

Viewing changes to panel/applets/appindicator/appindicatorapplet.cpp

Committer: Tarmac
Author(s): Albert Astals
Date: 2011-11-24 15:34:03 UTC
mfrom: (789.1.1 foreachconstref)
Revision ID: tarmac-20111124153403-p037jibq133f9ip4

[code] Add const & for foreach "iterators"

Avoids a copy of each object. It is true that most of those objects are
implicitly shared so the win isn't huge but we still save some atomic/mutex/something locking

files modified:
libunity-2d-private/src/indicatorswidget.cpp

libunity-2d-private/src/launcherapplication.cpp

libunity-2d-private/src/launcherapplicationslist.cpp

libunity-2d-private/src/launcherdropitem.cpp

libunity-2d-private/src/mimedata.cpp

libunity-2d-private/src/trash.cpp

panel/app/panelmanager.cpp

panel/applets/appindicator/appindicatorapplet.cpp

panel/applets/appname/menubarwidget.cpp

Show diffs side-by-side

added added

removed removed

panel/applets/appindicator/appindicatorapplet.cpp

void AppIndicatorApplet::createItems()

{

QStringList ids = m_watcher->property("RegisteredStatusNotifierItems").toStringList();

Q_FOREACH(QString id, ids) {

Q_FOREACH(const QString& id, ids) {

createItem(id);

}

Older »