← Back to branch summary

~jameinel/+junk/godirstate

  • Committer: John Arbash Meinel
  • Date: 2011-05-27 14:32:51 UTC
  • Revision ID: john@arbash-meinel.com-20110527143251-tlqirkem2mnfrbhz
Remove the error returns in favor of panic().

The immediate feeling, less clear state because we no longer add extra
state info to the error message. Probably a worthy trade for getting
a real traceback that has *even more* error info. (At the expense that
Parse() suppresses getting a traceback.)
Much clearer code without all the 'err' checking statements.

Possibly marginally faster (183ms). Probably fewer if checks
in trade for panic which probably has to be runtime checked
anyway.
Filename Latest Rev Last Changed Committer Comment Size
..
.bzrignore 14 13 years ago John Arbash Meinel Write a 'main' function that we can use for timing 28 bytes Diff Download File
dirstate.go 14 13 years ago John Arbash Meinel Write a 'main' function that we can use for timing 2.2 KB Diff Download File
dirstate_test.go 24 13 years ago John Arbash Meinel Remove the error returns in favor of panic(). The 14.2 KB Diff Download File
main.go 17 13 years ago John Arbash Meinel Relative pattern holds for 'gcc' sized tree: go: 1 1.1 KB Diff Download File
Makefile 2 13 years ago John Arbash Meinel Trying to get gocheck to work again 562 bytes Diff Download File
parser.go 24 13 years ago John Arbash Meinel Remove the error returns in favor of panic(). The 7.8 KB Diff Download File
parser_test.go 24 13 years ago John Arbash Meinel Remove the error returns in favor of panic(). The 5.8 KB Diff Download File
README.txt 1 13 years ago John Arbash Meinel Start playing with go for parsing dirstate. 296 bytes Diff Download File
suite_test.go 1 13 years ago John Arbash Meinel Start playing with go for parsing dirstate. 1.5 KB Diff Download File