~jameinel/juju-core/reflect-facades : changes

~jameinel/juju-core/reflect-facades » Changes from revision 2718

From Revision 2718 to 2699

Rev	Summary	Authors	Date
2718	playing around with it, but not quite what I want yet. playing around with it, but not quite what I want yet.	John Arbash Meinel	10 years ago
2717	The RPC codebase can use the generic func() interface The RPC codebase can use the generic func() interface	John Arbash Meinel	10 years ago
2716	Bring in the Facade registry from the describe-api-versions ... Bring in the Facade registry from the describe-api-versions branch	John Arbash Meinel	10 years ago
2715	We don't use the Method.ObjType anymore, so we can get rid o... We don't use the Method.ObjType anymore, so we can get rid of it.	John Arbash Meinel	10 years ago
2714	Start cleaning up the test suite. Start cleaning up the test suite.	John Arbash Meinel	10 years ago
2713	tweak the spelling for unknown versions tweak the spelling for unknown versions	John Arbash Meinel	10 years ago
2712	MethodCaller.Call doesn't need the Id anymore. MethodCaller.Call doesn't need the Id anymore. We've already resolved the concrete object, cache it and use it rather than looking it up a second time.	John Arbash Meinel	10 years ago
2711	Since now methods may exist on different versions of the Int... Since now methods may exist on different versions of the Interface, we need to put more detail into the error message. For backwards compatibility if id = "" we omit that portion.	John Arbash Meinel	10 years ago
2710	add a bunch of tests for how the VariableMethods code is wor... add a bunch of tests for how the VariableMethods code is working.	John Arbash Meinel	10 years ago
2709	Add a test that when you expose an interface it actually onl... Add a test that when you expose an interface it actually only exposes that interface.	John Arbash Meinel	10 years ago
2708	test if it is possible to actually restrict what is exposed. test if it is possible to actually restrict what is exposed. It is, you just have to wrap the interface in a concrete type, and then reflect.Value(v.Interface()) will return that concrete type, rather than the embedded one.	John Arbash Meinel	10 years ago
2707	If the func is exposing a raw interface{}, unwrap it. If the func is exposing a raw interface{}, unwrap it. This seems to prevent us from exposing just a subset via a different interface, but I think it is a net win.	John Arbash Meinel	10 years ago
2706	no need to take a parameter that is always false no need to take a parameter that is always false	John Arbash Meinel	10 years ago
2705	Add a test for untransformed errors. Add a test for untransformed errors. The old code was missing the case where you got a CallNotImplementedError. Since that code is explicitly used client-side, I figured it is best to not translate that (as the old code wasn't doing so). The test passed in the old code, and the new code is updated to match the behavior.	John Arbash Meinel	10 years ago
2704	transform early rather than late. transform early rather than late. It still satisfies the interface and means you don't have to think about an object when err != nil.	John Arbash Meinel	10 years ago
2703	Initial implementation that allows late binding of types Initial implementation that allows late binding of types It calls the RootMethod slightly earlier, so that it can introspect the type of the concrete value rather than the type from the function.	John Arbash Meinel	10 years ago
2702	[r=axwalk] state: reduce default dial timeout to 30s [r=axwalk] state: reduce default dial timeout to 30s Previously we could have been dialling state connections across the Internet, since the CLI would connect to Mongo directly. Now, with the CLI going to API only, we can safely reduce the timeout. It is possible that the timeout will be exceeded if the peers in an HA setup are not all ready. In this case the dial operation will fail and the caller (state server agent) will restart. This change will reduce the time to failure in tests, and allow us to capture some information about the failed test without exceeding the Go test timeout. https://codereview.appspot.com/97100045/	Andrew Wilkins	10 years ago
2701	[r=menno.smits],[bug=1302005] cmd/juju: refactor --series to... [r=menno.smits],[bug=1302005] cmd/juju: refactor --series to use StringsValue seriesVar is now called seriesValue and is implemented using StringsValue. This reuses StringValue while preserving the series validation logic. https://codereview.appspot.com/94060044/ R=fwereade, jameinel	Menno Smits	10 years ago
2700	[r=dimitern] environs: Add AllocateAddress(instId, netId) ca... [r=dimitern] environs: Add AllocateAddress(instId, netId) call This introduces a new Environ interface method which will be used to allocate extra addresses for an instance. It is the first step towards enabling container addressability for EC2 and MAAS in a unified way. Right now only the dummy provider has an implementation for the new method (for testing), EC2 will be first to implement it (in a follow-up, not to clutter the review). https://codereview.appspot.com/91150044/ R=fwereade, natefinch	Dimiter Naydenov	10 years ago
2699	[r=menno.smits] cmd/juju: refactor --series to use StringsVa... [r=menno.smits] cmd/juju: refactor --series to use StringsValue seriesVar is now called seriesValue and is implemented using StringsValue. This reuses StringValue while preserving the series validation logic. https://codereview.appspot.com/94060044/ R=fwereade, jameinel	Menno Smits	10 years ago

Older »