- Committer: William Reade
- Date: 2012-04-04 12:29:56 UTC
- mfrom: (510.1.3 fix-charm-symlinks)
- Revision ID: fwereade@gmail.com-20120404122956-ew1xusf09udwc0fm
When extracting charms, use only filetype mode bits to detect symlinkicity
We had been writing, and checking for, a magic value (in external_attr)
which happened to equal `(stat.S_IFLNK | 0755) << 16`; the charm store was
giving us one equal to `(stat.S_IFLNK | 0777) << 16`, and we weren't
considering that to be a symlink. We now just check the filetype and ignore
permissions on symlinks.
R=hazmat
CC=
https://codereview.appspot.com/5980045
We had been writing, and checking for, a magic value (in external_attr)
which happened to equal `(stat.S_IFLNK | 0755) << 16`; the charm store was
giving us one equal to `(stat.S_IFLNK | 0777) << 16`, and we weren't
considering that to be a symlink. We now just check the filetype and ignore
permissions on symlinks.
R=hazmat
CC=
https://codereview.appspot.com/5980045
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 .. |
|||||||
bin
|
237 | 12 years ago | Gustavo Niemeyer | Merged packaging branch by Clint. [r=niemeyer] Th |
|
||
|
docs
|
237 | 12 years ago | Gustavo Niemeyer | Merged packaging branch by Clint. [r=niemeyer] Th |
|
||
|
examples
|
237 | 12 years ago | Gustavo Niemeyer | Merged packaging branch by Clint. [r=niemeyer] Th |
|
||
|
juju
|
321.2.15 | 12 years ago | kapil.thangavelu at canonical | more conflict resolving against juju rename |
|
||
|
misc
|
256.2.2 | 12 years ago | Benjamin Saller | review changes, spacing, indentation, quoting |
|
||
.bzrignore |
467.4.8 | 12 years ago | kapil.thangavelu at canonical | merge trunk | 128 bytes |
|
|
|
COPYING |
375.2.2 | 12 years ago | Clint Byrum | re-adding copyright and license from removed debia | 33.7 KB |
|
|
|
Makefile |
348.1.13 | 12 years ago | Gustavo Niemeyer | Fixed several broken tests, including some coming | 1.3 KB |
|
|
|
README |
437 | 12 years ago | Clint Byrum | [trivial] type-o fix noticed by Eduardo Otubo | 1.1 KB |
|
|
|
setup.py |
494 | 12 years ago | kapil.thangavelu at canonical | [trivial] remove setuptools dependencies, switch c | 1.2 KB |
|
|
test |
348.1.9 | 12 years ago | Gustavo Niemeyer | Migrating top-level metadata. | 1.2 KB |
|
|