-
Committer:
William Reade
-
Author(s):
William Reade
-
Date:
2012-04-04 12:29:56 UTC
-
mfrom:
(510.1.3 fix-charm-symlinks)
-
Revision ID:
fwereade@gmail.com-20120404122956-ew1xusf09udwc0fm
When extracting charms, use only filetype mode bits to detect symlinkicity
We had been writing, and checking for, a magic value (in external_attr)
which happened to equal `(stat.S_IFLNK | 0755) << 16`; the charm store was
giving us one equal to `(stat.S_IFLNK | 0777) << 16`, and we weren't
considering that to be a symlink. We now just check the filetype and ignore
permissions on symlinks.
R=hazmat
CC=
https://codereview.appspot.com/5980045