← Back to branch summary

~jml/pkgme-devportal/multiple-deps

« back to all changes in this revision

Viewing changes to devportalbinary/database.py

  • Committer: Jonathan Lange
  • Date: 2012-10-26 12:21:03 UTC
  • Revision ID: jml@canonical.com-20121026122103-8f977dyogd3tg6qg
Hide get_dependencies (temporarily) and point all the tests & code at
get_multiple_dependencies.

Show diffs side-by-side

added added

removed removed

Lines of Context:
devportalbinary/database.py
442
442
    def from_options(cls, options):
443
443
        return cls(cls.get_store_from_config(options))
444
444
 
445
 
    def get_dependencies(self, library_name, arch='i386'):
 
445
    def _get_dependencies(self, library_name, arch='i386'):
446
446
        """Get the binary packages that provide 'library_name'."""
447
447
        result = self._store.execute(
448
448
            "SELECT dependency FROM libdep WHERE library = ? AND architecture = ?",
460
460
        found = {}
461
461
        for lib in library_names:
462
462
            # XXX: Really inefficient, multiple queries.
463
 
            deps = self.get_dependencies(lib, arch)
 
463
            deps = self._get_dependencies(lib, arch)
464
464
            if deps:
465
465
                found[lib] = deps
466
466
            else:
517
517
    def from_options(cls, options):
518
518
        return cls(Client(options.database_base_url))
519
519
 
520
 
    def get_dependencies(self, library_name, arch='i386'):
 
520
    def _get_dependencies(self, library_name, arch='i386'):
521
521
        deps = self._client.get_binaries_for_libraries([library_name], [arch])
522
522
        return set(deps[arch].get(library_name, []))
523
523
 
532
532
        found = {}
533
533
        for lib in library_names:
534
534
            # XXX: Really inefficient, multiple queries.
535
 
            deps = self.get_dependencies(lib, arch)
 
535
            deps = self._get_dependencies(lib, arch)
536
536
            if deps:
537
537
                found[lib] = deps
538
538
            else: