← Back to branch summary

~kalikiana/ubuntu-ui-toolkit/cutedocs

« back to all changes in this revision

Viewing changes to modules/Ubuntu/Components/plugin/ucqquickimageextension.h

  • Committer: Tarmac
  • Author(s): Albert Astals
  • Date: 2013-10-22 09:09:30 UTC
  • mfrom: (798.1.3 micro-optimizations)
  • Revision ID: tarmac-20131022090930-qcnl6vdglhh4agol
Minor optimzations

Add const & to foreach to save copies of "complex" types
Remove initializations of QStrings to "" since they do nothing
Return QString instead of "" since its faster
Pass "complex" types as const & instead of copy to functions
Not an optimization: Added const qualifier to two functions
.

Approved by PS Jenkins bot, Zsombor Egri.

Show diffs side-by-side

added added

removed removed

Lines of Context:
modules/Ubuntu/Components/plugin/ucqquickimageextension.h
45
45
    void reloadSource();
46
46
 
47
47
protected:
48
 
    bool rewriteSciFile(QString sciFilePath, QString scaleFactor, QTextStream& output);
49
 
    QString scaledBorder(QString border, QString scaleFactor);
50
 
    QString scaledSource(QString source, QString sciFilePath, QString scaleFactor);
 
48
    bool rewriteSciFile(const QString &sciFilePath, const QString &scaleFactor, QTextStream& output);
 
49
    QString scaledBorder(const QString &border, const QString &scaleFactor);
 
50
    QString scaledSource(QString source, const QString &sciFilePath, const QString &scaleFactor);
51
51
 
52
52
private:
53
53
    QQuickImageBase* m_image;