~kubuntu-members/juk/4.11 : changes

~kubuntu-members/juk/4.11 » Changes from revision 2401

From Revision 2401 to 2382

Rev	Summary	Authors	Tags	Date
2401	GIT_SILENT: Bump JuK version for KDE SC 4.11.2 release. GIT_SILENT: Bump JuK version for KDE SC 4.11.2 release.	Michael Pyne		10 years ago
2400	scrobbler: Change Scrobbler owner to be JuK, not PlayerManag... scrobbler: Change Scrobbler owner to be JuK, not PlayerManager. PlayerManager will always emit a track changed signal, which means the Scrobbler will always have to receive it even if we're not scrobbling (my last change to avoid making network requests when not using last.fm broke this, it seems). Instead move the Scrobbler into the base application class where we can track whether scrobbling is enabled or not, and Do the Right Thing. I don't have a last.fm account so although this should still work (I think), I can't verify. I have verified that we at least don't crash anymore. Martin, can you double-check when you get a chance? FIXED-IN:4.11.2 BUG:323703	Michael Pyne		10 years ago
2399	SVN_SILENT made messages (.desktop file) SVN_SILENT made messages (.desktop file)	l10n daemon script	v4.10.97	10 years ago
2398	coverinfo: Do not crash if an MP3 file has no ID3 tag. coverinfo: Do not crash if an MP3 file has no ID3 tag. This rarely happens since taglib will simply create an ID3 tag if one didn't exist before... but taglib can't do this if it can't find the file, which now seems to occur for files with a non-UTF8 filename encoding. You see this as a 'Couldn't resolve the mime type of <<foo>> -- this shouldn't happen' message on the console. In this situation JuK is able to resolve the file to an appropriate TagLib::File subclass, but the TagLib object is in an invalid state. CoverInfo wasn't checking for this (it was assuming any TagLib::File* that it was given was valid). I took a look through the reported JuK crasher bugs and didn't see anything relevant. I'm not sure whether this will end up in the KDE SC 4.11 or 4.11.1.	Michael Pyne		10 years ago
2397	cache: Remove unneeded FileHandleHash class. cache: Remove unneeded FileHandleHash class.	Michael Pyne	v4.10.95	10 years ago
2396	cache: Port completely off of FileHandleHash. cache: Port completely off of FileHandleHash. Since Cache no longer also acts as a collection of FileHandles there's no need for FileHandleHash. Get rid of it, replace its one use by the equivalent data structure within CollectionList.	Michael Pyne		10 years ago
2395	mpris2: Make some adapter methods async. mpris2: Make some adapter methods async. This is another attempt to work around JuK <=> Plasma DBus deadlocks, but making some of the DBus methods that Plasma would call into via the MPRIS2 interface be async.	Michael Pyne		10 years ago
2394	mpris2: Move DBus adapter creation until after GUI setup. mpris2: Move DBus adapter creation until after GUI setup. This helps a little bit with JuK freezing Plasma due to DBus deadlocks from synchronous calls being made between KStatusNotifierItem, its Plasma notification area counterpart, and the MPRIS2 adapter and its Plasma counterpart(s). Proper fix is async everywhere as far as I can tell.	Michael Pyne		10 years ago
2393	play-queue: Remove an unneeded processEvents. play-queue: Remove an unneeded processEvents. The effect is simulated by using deleteLater(). I have been unable to reproduce any crash this way so hopefully whatever is mentioned in the old comment does not apply to this new code.	Michael Pyne		10 years ago
2392	lyrics: Don't make network requests when lyrics are invisibl... lyrics: Don't make network requests when lyrics are invisible.	Michael Pyne		10 years ago
2391	startup: Async-ify cached item loading on startup, add timer... startup: Async-ify cached item loading on startup, add timers. In an attempt to get rid of processEvents() (related to several existing crash bugs) I am trying to port the startup code towards more async-friendly schemes. There's no threading but we at least get back to the event loop much more frequently while loading files. Additionally I have added debug output with instrumentation to show how long it takes to advance through each step of the startup (I think this might be the first time anyone has understood JuK startup sequence in years). This leaves some essentially dead code with Cache (which no longer acts as a container), which I will try to cleanup in later commits.	Michael Pyne		10 years ago
2390	Some additional bits about Rename Dialog written using the m... Some additional bits about Rename Dialog written using the material proposed by Burkhard Lueck	Yuri Chornoivan	v4.10.90	10 years ago
2389	replace outdated app used for MusicBrainz with TunePimp libr... replace outdated app used for MusicBrainz with TunePimp library, add comments about missing stuff	Burkhard Lück		10 years ago
2388	fix xml markup fix xml markup	Burkhard Lück		10 years ago
2387	Fix my error Fix my error	Yuri Chornoivan		10 years ago
2386	typo fix typo fix	Burkhard Lück		10 years ago
2385	Fix GUI flaws on startup. Fix GUI flaws on startup. Kind of embarassing it took so long to track down why multiple seemingly-random PlaylistBox::Items were selected.	Michael Pyne		10 years ago
2384	Cosmetic update of the docs Cosmetic update of the docs	Yuri Chornoivan		10 years ago
2383	scrobbler: Don't create QNAM unless we need it (most don't). scrobbler: Don't create QNAM unless we need it (most don't).	Michael Pyne		10 years ago
2382	scrobbler: Move auth token message. scrobbler: Move auth token message. This helps avoid the perception that a network request is being made when it's actually still evaluating whether to send the request or not, really helps with JuK debug spam.	Michael Pyne		10 years ago

Older »