← Back to branch summary

~launchpad-pqm/launchpad/devel

« back to all changes in this revision

Viewing changes to lib/lp/registry/browser/tests/test_distribution_views.py

  • Committer: Launchpad Patch Queue Manager
  • Date: 2012-09-21 15:09:29 UTC
  • mfrom: (15997.2.2 bug-897999)
  • Revision ID: launchpad@pqm.canonical.com-20120921150929-fvigujo69ssu4f1z
[r=stevenk][bug=897999] Rip out the restriction that non-virtualized
 main archives have to build on all restricted processor families. It doesn't
 make much sense, is a fair bit of code, and the form integration is buggy.

Show diffs side-by-side

added added

removed removed

Lines of Context:
lib/lp/registry/browser/tests/test_distribution_views.py
169
169
    def test_add_distro_enabled_restricted_families(self):
170
170
        creation_form = self.getDefaultAddDict()
171
171
        creation_form['field.enabled_restricted_families'] = []
172
 
        creation_form['field.require_virtualized'] = 'on'
173
172
        create_initialized_view(
174
173
            self.distributionset, '+add', principal=self.admin,
175
174
            method='POST', form=creation_form)
176
175
 
177
176
        distribution = self.distributionset.getByName('newbuntu')
178
 
        self.assertEqual(
179
 
            True,
180
 
            distribution.main_archive.require_virtualized)
181
177
        self.assertContentEqual(
182
 
            [],
183
 
            distribution.main_archive.enabled_restricted_families)
184
 
 
185
 
    def test_add_distro_enabled_restricted_families_error(self):
186
 
        # If require_virtualized is False, enabled_restricted_families
187
 
        # cannot be changed.
188
 
        creation_form = self.getDefaultAddDict()
189
 
        creation_form['field.enabled_restricted_families'] = []
190
 
        creation_form['field.require_virtualized'] = ''
191
 
        view = create_initialized_view(
192
 
            self.distributionset, '+add', principal=self.admin,
193
 
            method='POST', form=creation_form)
194
 
 
195
 
        error_msg = (
196
 
            u"This distribution's main archive can not be restricted to "
197
 
            "certain architectures unless the archive is also set to build "
198
 
            "on virtualized builders.")
199
 
        self.assertEqual(
200
 
           error_msg,
201
 
           view.widget_errors.get('enabled_restricted_families'))
202
 
        self.assertEqual(
203
 
           error_msg,
204
 
           view.widget_errors.get('require_virtualized'))
 
178
            [], distribution.main_archive.enabled_restricted_families)
205
179
 
206
180
 
207
181
class TestDistroEditView(TestCaseWithFactory):
227
201
            widget._getCurrentValue())
228
202
 
229
203
    def test_edit_distro_init_value_enabled_restricted_families(self):
230
 
        self.distribution.main_archive.require_virtualized = False
 
204
        self.distribution.main_archive.enabled_restricted_families = (
 
205
            self.restricted_families)
231
206
        view = create_initialized_view(
232
207
            self.distribution, '+edit', principal=self.admin,
233
208
            method='GET')
264
239
            self.distribution.main_archive.require_virtualized)
265
240
 
266
241
    def test_change_enabled_restricted_families(self):
267
 
        # If require_virtualized is True, enabled_restricted_families
268
 
        # can be changed.
269
242
        edit_form = self.getDefaultEditDict()
270
 
        edit_form['field.require_virtualized'] = 'on'
271
243
        edit_form['field.enabled_restricted_families'] = []
272
244
 
273
 
        self.distribution.main_archive.require_virtualized = False
274
 
        self.assertContentEqual(
275
 
            self.restricted_families,
276
 
            self.distribution.main_archive.enabled_restricted_families)
 
245
        self.distribution.main_archive.enabled_restricted_families = (
 
246
            self.restricted_families)
277
247
        create_initialized_view(
278
248
            self.distribution, '+edit', principal=self.admin,
279
249
            method='POST', form=edit_form)
282
252
            [],
283
253
            self.distribution.main_archive.enabled_restricted_families)
284
254
 
285
 
    def test_cannot_change_enabled_restricted_families(self):
286
 
        # If require_virtualized is False, enabled_restricted_families
287
 
        # cannot be changed.
288
 
        edit_form = self.getDefaultEditDict()
289
 
        edit_form['field.require_virtualized'] = ''
290
 
        edit_form['field.enabled_restricted_families'] = []
291
 
 
292
 
        view = create_initialized_view(
293
 
            self.distribution, '+edit', principal=self.admin,
294
 
            method='POST', form=edit_form)
295
 
        error_msg = (
296
 
            u"This distribution's main archive can not be restricted to "
297
 
            "certain architectures unless the archive is also set to build "
298
 
            "on virtualized builders.")
299
 
        self.assertEqual(
300
 
           error_msg,
301
 
           view.widget_errors.get('enabled_restricted_families'))
302
 
        self.assertEqual(
303
 
           error_msg,
304
 
           view.widget_errors.get('require_virtualized'))
305
 
 
306
255
    def test_package_derivatives_email(self):
307
256
        # Test that the edit form allows changing package_derivatives_email
308
257
        edit_form = self.getDefaultEditDict()