~lttng/lttng-ust/lttng-ust : changes

~lttng/lttng-ust/lttng-ust » Changes from revision 3033

From Revision 2928 to 2909

Rev	Summary	Authors	Date
2928	doc: xmlto output to stdout on a verbose build doc: xmlto output to stdout on a verbose build When running 'make V=1' send the output of xmlto to stdout to help with debugging command failures. Change-Id: Ia974bb0ca9671129499b7966e8790a594ce034b2 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	2 years ago
2927	Cleanup: remove useless lttng_ust_probe_supports_event_notif... Cleanup: remove useless lttng_ust_probe_supports_event_notifier LTTng-UST 2.13 bumps the accepted probe provider major version to 3, therefore we can remove the lttng_ust_probe_supports_event_notifier version check, which requires that the probe provider major version is >= 2, because it is now useless. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Id31581d2728f1197788ce4e7a79c6c494c444b08	Mathieu Desnoyers	2 years ago
2926	fix: disable some abi conflict tests on FreeBSD fix: disable some abi conflict tests on FreeBSD On FreeBSD, symbol resolution when dlopening a shared object will always favor symbols local to this shared object and thus our canary function will never be called which breaks our abi conflict detection when abi1 is loaded first. Disable the test cases with this scenario on FreeBSD as we have no way to fix this at the moment. Change-Id: Ic0451ce61e21f94ece55429b41bf76db3ad74b3a Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	2 years ago
2925	Fix: handle leak in abi tests Fix: handle leak in abi tests Coverity finds that dlopen_ust leaks handles. Modify the code structure to keep track of those handles in library descriptors so they are not leaked. *** CID 1453155: (RESOURCE_LEAK) /tests/regression/abi0-conflict/app_ust_dlopen.c: 35 in dlopen_ust() 29 printf("Error: dlopen of liblttng-ust shared library (%s).\n", lib_soname); 30 ret = EXIT_FAILURE; 31 } else { 32 printf("Success: dlopen of liblttng-ust shared library (%s).\n", lib_soname); 33 } 34 >>> CID 1453155: (RESOURCE_LEAK) >>> Variable "handle" going out of scope leaks the storage it points to. 35 return ret; 36 } 37 38 static 39 int dlopen_abi0(void) 40 { /tests/regression/abi0-conflict/app_noust_dlopen.c: 31 in dlopen_ust() 25 printf("Error: dlopen of liblttng-ust shared library (%s).\n", lib_soname); 26 ret = EXIT_FAILURE; 27 } else { 28 printf("Success: dlopen of liblttng-ust shared library (%s).\n", lib_soname); 29 } 30 >>> CID 1453155: (RESOURCE_LEAK) >>> Variable "handle" going out of scope leaks the storage it points to. 31 return ret; 32 } 33 34 static 35 int dlopen_abi0(void) 36 { Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I967c2e8741c6d42c0c12e19fbadc81e1c91d1e0f	Mathieu Desnoyers	2 years ago
2924	Fix: ustcomm: application name uses the '-ust'-suffixed thre... Fix: ustcomm: application name uses the '-ust'-suffixed thread name During the 2.13 development cycle, the compatibility pthread_setname_np compatibility layer was fixed (see 0db3d6ee). Unfortunately, this had a detrimental effect. Upon the registration of an application to the session daemon, its name is sent as part of the 'struct lttng_ust_ctl_reg_msg' registration message. The application name is sampled using lttng_pthread_getname_np during the preparation of the message. However, when the listener thread is launched, its name is changed early-on to add a '-ust' suffix (see 01f0e40c). This suffixed name is sampled and sent to the session daemon. Since, until recently, the pthread_setname_np had no effect on most configurations, this had no consequence. I noticed that this has a ripple-effect in the generation of some path names. For instance, in per-pid mode, snapshots end-up with the following hierarchy: /home/jgalar/lttng-traces └── Mercury └── florence_jacques-20210514-162630 └── snapshot-0-20210514-162726-1 └── ust └── pid └── hello-ust-332607-20210514-162538 ├── lol_0 ├── lol_1 ├── lol_10 ├── lol_11 ├── lol_2 ├── lol_3 ├── lol_4 ├── lol_5 ├── lol_6 ├── lol_7 ├── lol_8 ├── lol_9 └── metadata Notice how the 'hello' application presents itself with the '-ust' prefix. For such a short application name, it doesn't really matter much beyond repeating the 'ust' unnecessarily. However, longer application names quickly become less readable as we lose four of the 16 precious allowed characters for a process name. The procname sampled during the execution of the constructors is reused. My understanding is that the procname stored in the sock_info is already used for the 'procname' context. The resulting hierarchy becomes: /home/jgalar/lttng-traces └── Mercury └── sylvie_rouillard-20210514-193524 └── snapshot-0-20210514-193553-0 └── ust └── pid └── hello-466576-20210514-193514 ├── lol_0 ├── lol_1 ├── lol_10 ├── lol_11 ├── lol_2 ├── lol_3 ├── lol_4 ├── lol_5 ├── lol_6 ├── lol_7 ├── lol_8 ├── lol_9 └── metadata Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Ibd6f4763c96ea5fb680f55e5cc3d250baca175b0	Jérémie Galarneau	2 years ago
2923	Add abi0 conflict tests Add abi0 conflict tests Add tests to make sure abi0 detection works properly in different linking and dlopen scenarios. Change-Id: I70927298163e5961e255250f7d8d6dd849d9d135 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	2 years ago
2922	Detect unsupported use of .so.0 and .so.1 libraries within s... Detect unsupported use of .so.0 and .so.1 libraries within same process Abort process if unsupported use of liblttng-ust and liblttng-ust-tracepoint .so.0 vs .so.1 within the same process is detected. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I2842ec43bf8840ddf88e0dd04bddb4c9e04e3a04	Mathieu Desnoyers	2 years ago
2921	Add critical log level Add critical log level Rename the unused BUG() macro to CRIT() to signify an error that can't be recovered from. Add a new environment variable LTTNG_UST_ABORT_ON_CRITICAL that when set will abort() on a critical log statement. Change-Id: Ib3384a66b7efa4004677b3c153f86cb97b06a091 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	2 years ago
2920	Fix: shutdown communication socket on -EINVAL Fix: shutdown communication socket on -EINVAL Found by Coverity: >>> CID 1453150: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "(void)ustcomm_shutdown_unix...". Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I151e86167e8467ce3b602ddd0258284e0ef53eaa	Mathieu Desnoyers	2 years ago
2919	Fix: lttng-ust control protocol handling of variable length ... Fix: lttng-ust control protocol handling of variable length command data The scheme for sending variable length data and file descriptors after the command message causes irrecoverable "unknown commands" errors when communicating with older versions of lttng-ust, because the receiver (lttng-ust in applications) does not know that it needs to consume the variable length data on the communication socket. For the new commands introduced in the 2.13 cycle, we can change the protocol on both ends (liblttng-ust-ctl and liblttng-ust) now to add a reply to the fixed-size part of the command before sending the variable length data and file descriptors. For pre-existing commands sending variable length data and file descriptors right after the fixed-size command, handle this irrecoverable "unknown command" error by doing a socket shutdown from liblttng-ust-ctl. Also document the protocol for each command sending variable length data and file descriptors after the fixed-size command structure. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: If048c739dd37147ffb2a54715c2101177d2df4f7	Mathieu Desnoyers	2 years ago
2918	ustcomm: implement shutdown API ustcomm: implement shutdown API Implement socket shutdown API to allow the ust-ctl library to shutdown the communication socket when it cannot recover from errors which make the sender and receiver out-of-sync. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: If896396d9104b21aee09981cac773996ed79aa4d	Mathieu Desnoyers	2 years ago
2917	Fix: add missing fields in struct lttng_ust_abi_channel_conf... Fix: add missing fields in struct lttng_ust_abi_channel_config struct lttng_ust_abi_channel_config is meant to have the same binary layout as struct lttng_channel in lttng-ust 2.12. Some fields were removed (and should not be). Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I8c520b53e2c94244dcdb188fc3214e7cec72e876	Mathieu Desnoyers	2 years ago
2916	Fix: liblttng-ust-ctl: keep using lttng-ust-sock-8 and lttng... Fix: liblttng-ust-ctl: keep using lttng-ust-sock-8 and lttng-ust-wait-8 filenames commit 6a359b8a4006 ("Bump LTTNG_UST_ABI version from 8.1 to 9.0") attempted to ensure that a session daemon linked against an old lttng-ust-ctl (2.12) would not attempt to interact with newer applications. This was done by increasing the major ABI version number, but introducing LTTNG_UST_ABI_MAJOR_VERSION_OLDEST_COMPATIBLE (set to 8) as a mean to allow session daemon to accept both major versions 8 and 9. Unfortunately, changing LTTNG_UST_ABI_MAJOR_VERSION means the filenames used for communication changed as well, meaning that applications linked against older lttng-ust 2.12 cannot interact with lttng sessiond linked against lttng-ust-ctl 2.13, which is unintended. Therefore, go back to using the previous filenames: lttng-ust-sock-8, and lttng-ust-wait-8 for communication. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Ieeabc23c1d7c58eb1b6d4387c1e2b0f35b171bf3	Mathieu Desnoyers	2 years ago
2915	liblttng-ust-ctl: Implement SIGBUS handling liblttng-ust-ctl: Implement SIGBUS handling There is an issue with the security model of lib ring buffer (lttng-ust) vs SIGBUS handling by consumer daemon. We do not handle SIGBUS in the consumer daemon. An application using ftruncate on a ring buffer shm could cause the consumer to be killed with SIGBUS. Expose the relevant APIs to allow consumer daemon to handle SIGBUS. It requires the user application (consumerd) to define the TLS sigbus state with DEFINE_LTTNG_UST_SIGBUS_STATE(), and to invoke lttng_ust_ctl_sigbus_handle() when a SIGBUS is received, passing the address causing the SIGBUS (siginfo->si_addr) as parameter. Internally, liblttng-ust-ctl uses sigsetjmp and siglongjmp to recover from SIGBUS, and track all accesses to shared memory ranges within the library. This modifies the API of liblttng-ust-ctl, and requires the user application to define the TLS sigbus state with DEFINE_LTTNG_UST_SIGBUS_STATE(). It therefore needs to be introduced in locked-step between lttng-ust and lttng-tools. It requires a major version bump of liblttng-ust-ctl soname. Fixes: #1284 Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I7ade988e3e68a87930fbcee3e14e59c3fb66e755	Mathieu Desnoyers	2 years ago
2914	Fix: Java application context: pass application context argu... Fix: Java application context: pass application context argument to callbacks The callbacks require the complete application context field names to compare against the tables received from the TLS area. We also need to free memory allocated by for the context event field and context name in a destroy callback. Therefore, allocate a data structure for each application context, and use that data structure as private data. This allows callback to reach the context name, and a destroy callback to free the allocated memory. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Ia34fe00f5945fb58ef991f9d40dec36ac9ab322c	Mathieu Desnoyers	2 years ago
2913	Fix: java application context segmentation fault Fix: java application context segmentation fault Type mismatch for application context private data causes segmentation faults in the lttng-ust java testsuite. This can be solved by using the private data provided by the application context rather than struct lttng_ust_app_ctx, which is not needed anymore. This also fixes a memory leak on context add error. Those issues were introduced by the 2.13 development cycle refactorings. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I19c4e2d0ef6bcb7d4f9c2ffa43a9425661df05c1	Mathieu Desnoyers	2 years ago
2912	Add api0 compile tests Add api0 compile tests These compile tests will detect if we break the build of tracepoint providers using the api0 of lttng-ust <= 2.12. Change-Id: I208cfcbb624a799b3e32fc22bcbcfc03c547a466 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	3 years ago
2911	Move current compile tests to 'api1' Move current compile tests to 'api1' Move the current compile tests to the 'api1' directory and build them with LTTNG_UST_COMPAT_API_VERSION=0 and LTTNG_UST_COMPAT_API_VERSION=1. Change-Id: Ic46d549b5ec0735931bb2aa64115909fb2e25414 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	3 years ago
2910	fix: namespacing of 'tp_rcu_read_lock' fix: namespacing of 'tp_rcu_read_lock' Namespace a forgotten instance of 'tp_rcu_read_lock'. Change-Id: I7572684c5c6de1bb7b7721e81a8a706c5f2d3f02 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	3 years ago
2909	Validate provider version for event enum field types Validate provider version for event enum field types Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I77c17f45eb8e57dfa906ed061a4ab09bace9d248	Mathieu Desnoyers	3 years ago