← Back to branch summary

~mardy/signon/lp1415492-rtm

« back to all changes in this revision

Viewing changes to src/signond/signonsessioncore.cpp

  • Committer: Tarmac
  • Author(s): Alberto Mardegan
  • Date: 2013-12-10 16:10:36 UTC
  • mfrom: (608.1.1 packaging)
  • Revision ID: tarmac-20131210161036-6ebjxsbdwyio7rjy
Do not use qDeleteAll() on the QObject's children. Fixes: https://bugs.launchpad.net/bugs/1156776, https://bugs.launchpad.net/bugs/1237782, https://bugs.launchpad.net/bugs/1258578.

Approved by PS Jenkins bot, Ken VanDine.

Show diffs side-by-side

added added

removed removed

Lines of Context:
src/signond/signonsessioncore.cpp
927
927
    else
928
928
        sessionsOfNonStoredCredentials.removeOne(this);
929
929
 
930
 
    QObjectList authSessions = children();
931
 
    qDeleteAll(authSessions);
 
930
    QObjectList authSessions;
 
931
    while (authSessions = children(), !authSessions.isEmpty()) {
 
932
        delete authSessions.first();
 
933
    }
932
934
    deleteLater();
933
935
}
934
936