1
Add testcases to test renaming directories as well as files. Remove the
2
l bit from the ok perms as that's no longer needed.
4
tests/regression/subdomain/rename.sh | 60 +++++++++++++++++++----------------
5
1 file changed, 34 insertions(+), 26 deletions(-)
7
Index: subdomain/rename.sh
8
===================================================================
9
--- subdomain.orig/rename.sh
10
+++ subdomain/rename.sh
16
-# The rename system call changes the name of a file in the filesystem. The
17
-# test verifies that this operation (which involves AppArmor write and link
19
+# The rename system call changes the name of a file in the filesystem.
20
+# The test verifies that this operation (which involves AppArmor write
21
# permission checks) functions correctly for a confined process.
24
@@ -24,63 +24,71 @@ bin=$pwd
42
+ test -d $dir1 || mkdir $dir1
51
-genprofile $file1:$okfile1perm $file2:$okfile2perm
52
+genprofile $file1:$okfile1perm $file2:$okfile2perm $dir1:$okfile1perm $dir2:$okfile2perm
54
-runchecktest "RENAME RWL W" pass $file1 $file2
55
+runchecktest "RENAME RW W" pass $file1 $file2
56
+runchecktest "RENAME RW W (dir)" pass $dir1 $dir2
58
# FAILURE TEST (1) - Bad permissions on target
64
-genprofile $file1:$okfile1perm $file2:$badfile2perm
65
+genprofile $file1:$okfile1perm $file2:$badfile2perm $dir1:$okfile1perm $dir2:$badfile2perm
67
-runchecktest "RENAME RWL R" fail $file1 $file2
68
+runchecktest "RENAME RW R" fail $file1 $file2
69
+runchecktest "RENAME RW R (dir)" fail $dir1 $dir2
71
# FAILURE TEST (2) - no permissions on target
77
-genprofile $file1:$okfile1perm
78
+genprofile $file1:$okfile1perm $dir1:$okfile1perm
80
-runchecktest "RENAME RWL -" fail $file1 $file2
81
+runchecktest "RENAME RW -" fail $file1 $file2
82
+runchecktest "RENAME RW - (dir)" fail $dir1 $dir2
84
# FAILURE TEST (3) - Bad permissions on source
90
-genprofile $file1:$badfile1perm1 $file2:$okfile2perm
91
+genprofile $file1:$badfile1perm1 $file2:$okfile2perm $dir1:$badfile1perm1 $dir2:$okfile2perm
93
runchecktest "RENAME R W" fail $file1 $file2
94
+runchecktest "RENAME R W (dir)" fail $dir1 $dir2
96
# FAILURE TEST (4) - Bad permissions on source
102
-genprofile $file1:$badfile1perm2 $file2:$okfile2perm
103
+genprofile $file1:$badfile1perm2 $file2:$okfile2perm $dir1:$badfile1perm2 $dir2:$okfile2perm
105
runchecktest "RENAME W W" fail $file1 $file2
106
+runchecktest "RENAME W W (dir)" fail $dir1 $dir2
108
# FAILURE TEST (5) - No permissions on source
114
-genprofile $file2:$okfile2perm
115
+genprofile $file2:$okfile2perm $dir2:$okfile2perm
117
runchecktest "RENAME - W" fail $file1 $file2
118
+runchecktest "RENAME - W (dir)" fail $dir1 $dir2