← Back to branch summary

~mterry/telephony-service/ok

« back to all changes in this revision

Viewing changes to tests/libtelephonyservice/PhoneUtilsTest.cpp

Use libphonenumber for comparison and normalization

Show diffs side-by-side

added added

removed removed

Lines of Context:
tests/libtelephonyservice/PhoneUtilsTest.cpp
42
42
    QTest::newRow("number with dash") << "1234-5678" << true;
43
43
    QTest::newRow("number with area code") << "(123)12345678" << true;
44
44
    QTest::newRow("number with extension") << "12345678#123" << true;
45
 
    QTest::newRow("number with comma") << "33333333,1,1" << true;
46
 
    QTest::newRow("number with semicolon") << "33333333;1" << true;
47
45
    QTest::newRow("number with slash") << "+421 2/123 456 78" << true;
48
46
    QTest::newRow("short/emergency number") << "190" << true;
49
47
    QTest::newRow("non phone numbers") << "abcdefg" << false;
67
65
    QTest::newRow("string equal") << "12345678" << "12345678" << true;
68
66
    QTest::newRow("number with dash") << "1234-5678" << "12345678" << true;
69
67
    QTest::newRow("number with area code") << "12312345678" << "12345678" << true;
70
 
    QTest::newRow("number with extension") << "12345678#123" << "12345678" << false;
 
68
    QTest::newRow("number with extension") << "12345678#123" << "12345678" << true;
71
69
    QTest::newRow("both numbers with extension") << "(123)12345678#1" << "12345678#1" << true;
72
70
    QTest::newRow("numbers with different extension") << "1234567#1" << "1234567#2" << false;
73
 
    QTest::newRow("number with comma") << "33333333,1,1" << "33333333" << true;
74
 
    QTest::newRow("both numbers with comma") << "22222222,1" << "22222222,2,1" << true;
75
 
    QTest::newRow("number with semicolon") << "33333333;1" << "33333333" << true;
76
 
    QTest::newRow("both numbers with semicolon") << "22222222;1" << "22222222;2" << true;
77
71
    QTest::newRow("short/emergency numbers") << "190" << "190" << true;
78
72
    QTest::newRow("different numbers") << "12345678" << "1234567" << false;
79
73
    QTest::newRow("both non phone numbers") << "abcdefg" << "abcdefg" << true;
80
74
    QTest::newRow("different non phone numbers") << "abcdefg" << "bcdefg" << false;
81
 
    QTest::newRow("phone number and custom string") << "abc12345678" << "12345678" << false;
 
75
    QTest::newRow("phone number and custom string") << "abc12345678" << "12345678" << true;
82
76
    // FIXME: check what other cases we need to test here"
83
77
}
84
78