~mterry/unity8/greeter-misc-cleanups

« back to all changes in this revision

Viewing changes to plugins/Dash/listviewwithpageheader.cpp

  • Committer: CI bot
  • Author(s): Albert Astals
  • Date: 2014-07-25 10:47:08 UTC
  • mfrom: (1070.1.2 deleteLaterLVWPH)
  • Revision ID: ps-jenkins@lists.canonical.com-20140725104708-n2edvxutdeviw9me
Use deleteLater instead of a direct delete

We are seeing a crash in QQuickWindowPrivate::polishItems because LVWPH is deleting items to polish from it's updatePolish
which means the set in QQuickWindowPrivate::polishItems may end up with some yet-to-process-but-now-deleted items. Switching to deleteLater fixes this 
Approved by: Michał Sawicz

Show diffs side-by-side

added added

removed removed

Lines of Context:
656
656
    if (flags & QQmlDelegateModel::Destroyed) {
657
657
        item->setParentItem(nullptr);
658
658
    }
659
 
    delete listItem->sectionItem();
 
659
    listItem->sectionItem()->deleteLater();
660
660
    delete listItem;
661
661
}
662
662