← Back to branch summary

~mvo/software-center/pyflakes

« back to all changes in this revision

Viewing changes to softwarecenter/db/reviews.py

  • Committer: Michael Vogt
  • Date: 2011-05-19 10:03:00 UTC
  • Revision ID: michael.vogt@ubuntu.com-20110519100300-qqfpt2ebh6g729dn
more pyflakes fixes

Show diffs side-by-side

added added

removed removed

Lines of Context:
softwarecenter/db/reviews.py
22
22
import datetime
23
23
import gio
24
24
import gzip
 
25
import gtk
25
26
import glib
 
27
import logging
26
28
import os
27
29
import random
28
30
import StringIO
31
33
import urllib
32
34
import simplejson
33
35
 
34
 
from softwarecenter.backend.rnrclient import RatingsAndReviewsAPI, ReviewDetails
 
36
from softwarecenter.backend.rnrclient import RatingsAndReviewsAPI
 
37
from softwarecenter.backend.rnrclient_pristine import ReviewDetails
35
38
from softwarecenter.db.database import Application
36
39
import softwarecenter.distro
37
 
from softwarecenter.utils import *
38
 
from softwarecenter.paths import *
39
 
from softwarecenter.enums import *
40
 
from piston_mini_client import APIError
 
40
from softwarecenter.utils import (upstream_version_compare,
 
41
                                  uri_to_filename,
 
42
                                  get_language,
 
43
                                  save_person_to_config,
 
44
                                  get_person_from_config,
 
45
                                  )
 
46
from softwarecenter.paths import (SOFTWARE_CENTER_CACHE_DIR,
 
47
                                  SUBMIT_REVIEW_APP,
 
48
                                  REPORT_REVIEW_APP,
 
49
                                  SUBMIT_USEFULNESS_APP,
 
50
                                  GET_REVIEWS_HELPER,
 
51
                                  GET_REVIEW_STATS_HELPER,
 
52
                                  GET_USEFUL_VOTES_HELPER,
 
53
                                  )
 
54
#from softwarecenter.enums import *
41
55
 
42
56
from softwarecenter.netstatus import network_state_is_connected
43
57
 
102
116
        LOG.debug("_usefulness_loaded started")
103
117
        # get status code
104
118
        res = os.WEXITSTATUS(status)
 
119
        LOG.debug("usefulness loader exited with status: '%i'" % res)
105
120
        # check stderr
106
121
        err = os.read(stderr, 4*1024)
107
122
        if err:
496
511
        except OSError:
497
512
            days_delta = 0
498
513
        LOG.debug("refresh with days_delta: %s" % days_delta)
499
 
        origin = "any"
500
 
        distroseries = self.distro.get_codename()
 
514
        #origin = "any"
 
515
        #distroseries = self.distro.get_codename()
501
516
        cmd = [os.path.join(
502
517
                softwarecenter.paths.datadir, GET_REVIEW_STATS_HELPER),
503
518
               # FIXME: the server currently has bug (#757695) so we
557
572
        callback = source.get_data("callback")
558
573
        try:
559
574
            (json_str, length, etag) = source.load_contents_finish(result)
560
 
        except glib.GError, e:
 
575
        except glib.GError:
561
576
            # ignore read errors, most likely transient
562
577
            return callback(app, [])
563
578
        # check for gzip header
599
614
        callback = source.get_data("callback")
600
615
        try:
601
616
            (json_str, length, etag) = source.load_contents_finish(result)
602
 
        except glib.GError, e:
 
617
        except glib.GError:
603
618
            # ignore read errors, most likely transient
604
619
            return
605
620
        # check for gzip header
609
624
        review_stats_json = simplejson.loads(json_str)
610
625
        review_stats = {}
611
626
        for review_stat_json in review_stats_json:
612
 
            appname = review_stat_json["app_name"]
 
627
            #appname = review_stat_json["app_name"]
613
628
            pkgname = review_stat_json["package_name"]
614
629
            app = Application('', pkgname)
615
630
            stats = ReviewStats(app)