1
Prerequisites to approving a Merge Proposal (MP)
2
================================================
4
Over time, it has been found that insufficient testing by reviewers sometimes
5
leads to clock app trunk not buildable in Qtcreator due to manifest errors, or
6
translation pot file not updated. As such, please follow the checklist below
7
before top-approving a MP.
12
* Does the MP add/remove user visible strings? If Yes, has the pot file been
15
* Does the MP change the UI? If Yes, has it been approved by design?
17
* Did you perform an exploratory manual test run of your code change and any
18
related functionality?
20
* If the MP fixes a bug or implements a feature, are there accompanying unit
23
* Is the clock app trunk buildable and runnable using Qtcreator?
25
* Was the debian changelog updated?
27
* Was the copyright years updated if necessary?
29
The above checklist is more of a guideline to help clock app trunk stay buildable,
30
stable and up to date.
32
Note: As of vivid 15.04, Autopilot are broken in trunk. As such autopilot failures
33
can be excused until they are fixed in trunk.
added
removed
README.mergeproposal
