3
# Date 1435612356 18000
4
# Mon Jun 29 16:12:36 2015 -0500
5
# Node ID 27f13c1de8a645ec76cee013a55ea0ea3443f5b5
6
# Parent 3e3a22acc5be4eb4b860b4b4c0080473f5605988
7
8129611: Accessbridge error handling improvement
8
Reviewed-by: prr, ahgross, asmotrak
9
Contributed-by: peter.brunet@oracle.com
11
diff --git a/src/windows/native/sun/bridge/AccessBridgeDebug.cpp b/src/windows/native/sun/bridge/AccessBridgeDebug.cpp
12
--- openjdk/jdk/src/windows/native/sun/bridge/AccessBridgeDebug.cpp
13
+++ openjdk/jdk/src/windows/native/sun/bridge/AccessBridgeDebug.cpp
19
- * print a GetLastError message
21
-char *printError(char *msg) {
22
- LPVOID lpMsgBuf = NULL;
23
- static char retbuf[256];
26
- strncpy((char *)retbuf, msg, sizeof(retbuf));
29
- FORMAT_MESSAGE_ALLOCATE_BUFFER |
30
- FORMAT_MESSAGE_FROM_SYSTEM |
31
- FORMAT_MESSAGE_IGNORE_INSERTS,
34
- MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), // Default language
39
- PrintDebugString(" %s: FormatMessage failed", msg);
41
- PrintDebugString(" %s: %s", msg, (char *)lpMsgBuf);
43
- if (lpMsgBuf != NULL) {
44
- strncat((char *)retbuf, ": ", sizeof(retbuf) - strlen(retbuf) - 1);
45
- strncat((char *)retbuf, (char *)lpMsgBuf, sizeof(retbuf) - strlen(retbuf) - 1);
47
- return (char *)retbuf;
52
* Send debugging info to the appropriate place
54
diff --git a/src/windows/native/sun/bridge/AccessBridgeDebug.h b/src/windows/native/sun/bridge/AccessBridgeDebug.h
55
--- openjdk/jdk/src/windows/native/sun/bridge/AccessBridgeDebug.h
56
+++ openjdk/jdk/src/windows/native/sun/bridge/AccessBridgeDebug.h
61
- char *printError(char *msg);
62
void PrintDebugString(char *msg, ...);
63
void PrintJavaDebugString(char *msg, ...);
64
void wPrintJavaDebugString(wchar_t *msg, ...);
65
diff --git a/src/windows/native/sun/bridge/WinAccessBridge.cpp b/src/windows/native/sun/bridge/WinAccessBridge.cpp
66
--- openjdk/jdk/src/windows/native/sun/bridge/WinAccessBridge.cpp
67
+++ openjdk/jdk/src/windows/native/sun/bridge/WinAccessBridge.cpp
69
theWindowsAccessBridge = this;
70
isVMInstanceChainInUse = false;
73
- // notify the user if new JVMs are found
75
- newJVMs = (char **)malloc(MAX_NEW_JVMS_FOUND);
76
- for (int i = 0; i < MAX_NEW_JVMS_FOUND; i++) {
77
- newJVMs[i] = (char *)malloc(SHORT_STRING_SIZE);
81
- BOOL newJ2SEFound = findNewJVMs(J2SE_REG_PATH, newJVMs);
82
- BOOL newJ2REFound = TRUE; // findNewJVMs(J2RE_REG_PATH, newJVMs);
84
- if (newJ2SEFound || newJ2REFound) {
86
- int result = DialogBox(windowsInstance,
87
- "FOUNDNEWJVMDIALOG",
89
- (DLGPROC)newJVMFoundDialogProc);
91
- printError("DialogBox failed");
94
- PrintDebugString(" FOUNDNEWJVMDIALOG: result = %d", result);
96
- ShowWindow((HWND)result, SW_SHOW);
100
ShowWindow(theDialogWindow, SW_SHOW);