← Back to branch summary

~openstack-charmers/charms/trusty/nova-cloud-controller/keystonev3

« back to all changes in this revision

Viewing changes to unit_tests/test_actions_openstack_upgrade.py

  • Committer: james.page at ubuntu
  • Date: 2015-09-24 16:29:26 UTC
  • mfrom: (186.2.3 nova-cloud-controller)
  • Revision ID: james.page@ubuntu.com-20150924162926-8ie37t6zeq12nun3
[thedac,r=james-page] Add support for action managed openstack upgrades.

Also fix misc assert_called problems in unit tests.

Show diffs side-by-side

added added

removed removed

Lines of Context:
unit_tests/test_actions_openstack_upgrade.py
 
1
from mock import patch, MagicMock
 
2
import os
 
3
 
 
4
os.environ['JUJU_UNIT_NAME'] = 'nova-cloud-controller'
 
5
 
 
6
 
 
7
with patch('charmhelpers.core.hookenv.config') as config:
 
8
    config.return_value = 'nova'
 
9
    import nova_cc_utils as utils  # noqa
 
10
 
 
11
_reg = utils.register_configs
 
12
_map = utils.restart_map
 
13
 
 
14
utils.register_configs = MagicMock()
 
15
utils.restart_map = MagicMock()
 
16
 
 
17
with patch('nova_cc_utils.guard_map') as gmap:
 
18
    with patch('charmhelpers.core.hookenv.config') as config:
 
19
        config.return_value = False
 
20
        gmap.return_value = {}
 
21
        import openstack_upgrade
 
22
 
 
23
utils.register_configs = _reg
 
24
utils.restart_map = _map
 
25
 
 
26
from test_utils import (
 
27
    CharmTestCase
 
28
)
 
29
 
 
30
TO_PATCH = [
 
31
    'do_openstack_upgrade',
 
32
    'relation_ids',
 
33
    'neutron_api_relation_joined',
 
34
    'config_changed',
 
35
]
 
36
 
 
37
 
 
38
class TestNovaCCUpgradeActions(CharmTestCase):
 
39
 
 
40
    def setUp(self):
 
41
        super(TestNovaCCUpgradeActions, self).setUp(openstack_upgrade,
 
42
                                                    TO_PATCH)
 
43
 
 
44
    @patch('charmhelpers.contrib.openstack.utils.config')
 
45
    @patch('charmhelpers.contrib.openstack.utils.action_set')
 
46
    @patch('charmhelpers.contrib.openstack.utils.git_install_requested')
 
47
    @patch('charmhelpers.contrib.openstack.utils.openstack_upgrade_available')
 
48
    def test_openstack_upgrade_true(self, upgrade_avail, git_requested,
 
49
                                    action_set, config):
 
50
        git_requested.return_value = False
 
51
        upgrade_avail.return_value = True
 
52
        config.return_value = True
 
53
        self.relation_ids.return_value = ['relid1']
 
54
 
 
55
        openstack_upgrade.openstack_upgrade()
 
56
 
 
57
        self.assertTrue(self.do_openstack_upgrade.called)
 
58
        self.assertTrue(
 
59
            self.neutron_api_relation_joined.called_with(rid='relid1',
 
60
                                                         remote_restart=True))
 
61
        self.assertTrue(self.config_changed.called)
 
62
 
 
63
    @patch('charmhelpers.contrib.openstack.utils.config')
 
64
    @patch('charmhelpers.contrib.openstack.utils.action_set')
 
65
    @patch('charmhelpers.contrib.openstack.utils.git_install_requested')
 
66
    @patch('charmhelpers.contrib.openstack.utils.openstack_upgrade_available')
 
67
    def test_openstack_upgrade_false(self, upgrade_avail, git_requested,
 
68
                                     action_set, config):
 
69
        git_requested.return_value = False
 
70
        upgrade_avail.return_value = True
 
71
        config.return_value = False
 
72
 
 
73
        openstack_upgrade.openstack_upgrade()
 
74
 
 
75
        self.assertFalse(self.do_openstack_upgrade.called)
 
76
        self.assertFalse(self.config_changed.called)