← Back to branch summary

~osomon/webbrowser-app/dropbox-desktop-ua-override

« back to all changes in this revision

Viewing changes to src/app/webbrowser/webbrowser-app.qml

  • Committer: Olivier Tilloy
  • Author(s): Florian Boucault
  • Date: 2017-03-03 14:52:15 UTC
  • mfrom: (1620.2.5 fix_fullscreen)
  • Revision ID: olivier.tilloy@canonical.com-20170303145215-y98oqvdt2jdouwrh
https://launchpad.net/bugs/1665727
Fullscreen improvements:
* Simplify fullscreen: single entry point BrowserWindow.setFullscreen()
* Do not go fullscreen if already fullscreen. Fixes case where fullscreen could not be exited anymore.
* Make chrome hide when webview is fullscreen. Remove unused property Browser.fullscreen.

Show diffs side-by-side

added added

removed removed

Lines of Context:
src/app/webbrowser/webbrowser-app.qml
147
147
 
148
148
            function toggleApplicationLevelFullscreen() {
149
149
                setFullscreen(visibility !== Window.FullScreen)
150
 
                if (browser.currentWebview.fullscreen) {
151
 
                    browser.currentWebview.fullscreen = false
152
 
                }
153
150
            }
154
151
 
155
152
            Shortcut {
230
227
                    // ESC to exit fullscreen, regardless of whether it was
231
228
                    // requested by the page or toggled on by the user.
232
229
                    window.setFullscreen(false)
233
 
                    browser.currentWebview.fullscreen = false
234
230
                }
235
231
            }
236
232