~phablet-team/media-hub/fix-1538703 : changes

~phablet-team/media-hub/fix-1538703 » Changes from revision 186

From Revision 186 to 167

Rev	Summary	Authors	Tags	Date
186	Pass a Service* instead of ServiceSkeleton* to avoid weird i... Pass a Service* instead of ServiceSkeleton* to avoid weird inheritance segfault	Jim Hodapp		8 years ago
185	Fix resetting the current player on disconnection and interf... Fix resetting the current player on disconnection and interface pollution This commit changes: * The condition under which the current player is reset. Originally this happened only for multimedia role however this turned out to be faulty and trigger an unwanted behavior [1]. This change allows the reset to happen only when it is a multimedia role [already there] and the player is the current player i.e. the Player instance that disconnected was the last player to play audio/video [added]. In order to achieve this the ServiceSkeleton class has been extended with a new function to return the current player. * Reduces the pollution of the Service interface, which has been introduced in rev 152 & 153, by moving the added functions to the ServiceSkeleton class. This is because the Service interface should be used only for DBus exported stuff. 1. The issue as described by jibel was: I see 1 issue with the silo, play a video, open the music app (video will pause), enqueue several tracks and start playing (verify that MPRIS switched to music app), reveal the spread and close the mediaplayer the controls switch to the mediaplayer but the music continues playing then if you switch back to the music app, the controls are still for the mediaplayer even if music app is in the foreground and music is playign. I've to pause/play the track in the music app for the music app to take control of mpris.	Konrad Zapałowicz		8 years ago
184	Revert change which was reviewed as bad Revert change which was reviewed as bad	Konrad Zapałowicz		8 years ago
183	Fix resetting the current player on disconnection Fix resetting the current player on disconnection This commit changes the condition under which the current player is reset. Orginally this happened only for multimedia role however this turned out to be faulty and trigger an unwanted behavior [1]. This change allows the reset to happen only when it is a multimedia role [already there] and the player is the current player i.e. the Player instance that disconnected was the last player to play audio/video [added]. In order to achieve this the Service interface has been extended with a new function to return the current player. This is implemented in derived classess as well as in ServiceSkeleton. Note that the empty implementation in service_stub is because this function is not meant to be exported over DBus. 1. the issue as described by jibel was: I see 1 issue with the silo, play a video, open the music app (video will pause), enqueue several tracks and start playing (verify that MPRIS switched to music app), reveal the spread and close the mediaplayer the controls switch to the mediaplayer but the music continues playing then if you switch back to the music app, the controls are still for the mediaplayer even if music app is in the foreground and music is playign. I've to pause/play the track in the music app for the music app to take control of mpris.	Konrad Zapałowicz		8 years ago
182	Make sure that a non-multimedia audio role Player doesn't ca... Make sure that a non-multimedia audio role Player doesn't cause the current player to reset. This should only happen when a multimedia audio role Player dies	Jim Hodapp		8 years ago
181	No need to update the current player for open_uri(). Only ne... No need to update the current player for open_uri(). Only need to update the current player when calling play()	Jim Hodapp		8 years ago
180	Adding some useful comments Adding some useful comments	Jim Hodapp		8 years ago
179	Make sure to "disconnect" the MPRIS Player interface signals Make sure to "disconnect" the MPRIS Player interface signals	Jim Hodapp		8 years ago
178	Set the current player based on when a Player instance begin... Set the current player based on when a Player instance begins playback	Jim Hodapp		8 years ago
177	Releasing 4.1.0+16.04.20160308.2-0ubuntu1 Releasing 4.1.0+16.04.20160308.2-0ubuntu1	CI Train Bot	4.1.0+16.04.20160308.2-0ubuntu1	8 years ago
176	Fix deadlock issue when adding/removing Player instances fro... Fix deadlock issue when adding/removing Player instances from the HashedKeyedPlayerStore Fixes: #1542947 Approved by: Alfonso Sanchez-Beato	Jim Hodapp		8 years ago
175	Releasing 4.1.0+16.04.20160307.1-0ubuntu1 Releasing 4.1.0+16.04.20160307.1-0ubuntu1	CI Train Bot	4.1.0+16.04.20160307.1-0ubuntu1	8 years ago
174	Only call encode_uri() for local files, pass everything else... Only call encode_uri() for local files, pass everything else straight through unmodified. Fixes: #1546963 Approved by: Simon Fels, PS Jenkins bot, Konrad Zapałowicz	Jim Hodapp		8 years ago
173	Releasing 4.1.0+16.04.20160223-0ubuntu1 Releasing 4.1.0+16.04.20160223-0ubuntu1	CI Train Bot	4.1.0+16.04.20160223-0ubuntu1	8 years ago
172	Add apparmor exception to media-hub for unity8 Fixes: #14198... Add apparmor exception to media-hub for unity8 Fixes: #1419829 Approved by: PS Jenkins bot, Pawel Stolowski, Alfonso Sanchez-Beato	Jim Hodapp		8 years ago
171	Releasing 4.1.0+16.04.20160222-0ubuntu1 Releasing 4.1.0+16.04.20160222-0ubuntu1	CI Train Bot	4.1.0+16.04.20160222-0ubuntu1	8 years ago
170	Make sure to interpret the incoming path as a URI which make... Make sure to interpret the incoming path as a URI which makes sure media-hub will always be able to open the track with an encoded URI Fixes: #1449790 Approved by: Alfonso Sanchez-Beato, PS Jenkins bot	Jim Hodapp		8 years ago
169	Releasing 4.1.0+16.04.20160127-0ubuntu1 Releasing 4.1.0+16.04.20160127-0ubuntu1	CI Train Bot	4.1.0+16.04.20160127-0ubuntu1	8 years ago
168	Don't depend on a specific hybris version anymore. Don't depend on a specific hybris version anymore.	Simon Fels		8 years ago
167	Adjust apparmor profile to enable flawless audio/video playb... Adjust apparmor profile to enable flawless audio/video playback. Approved by: Jamie Strandboge, PS Jenkins bot	Thomas Voß		8 years ago

Older »