120
|
|
|
Brian Waldon |
|
13 years ago
|
|
|
119
|
|
|
Brian Waldon |
|
13 years ago
|
|
|
118
|
|
|
Brian Waldon |
|
13 years ago
|
|
|
117
|
|
Fixing tests. Sorry for late response.
Rick Harris wrote on 2011-04-12 Really nice job, Eldar.
> 46 + image_swift = StringIO.StringIO("nevergonnamakeit") > 47 + options = SWIFT_OPTIONS.copy() > 48 + del options['swift_store_user'] > 49 + self.assertRaises(BackendException, > 50 + SwiftBackend.add, > 51 + 2, image_swift, options)
Might be better to DRY up the code some by adding a helper-method, like:
def assertOptionRequiredForSwift(self, key): image_swift = StringIO.StringIO("nevergonnamakeit") options = SWIFT_OPTIONS.copy() del options[key] self.assertRaises(BackendException, SwiftBackend.add, 2, image_swift, options)
Marking as Needs Fixing, but if you don't like the idea, I'd be willing to set this as Approved (since the suggestion is so minor :-)
|
Eldar Nugaev |
|
13 years ago
|
|
|
116
|
|
|
Thierry Carrez |
|
13 years ago
|
|
|
115
|
|
|
Soren Hansen |
|
13 years ago
|
|
|
114
|
|
|
Thierry Carrez |
2011.2 |
13 years ago
|
|
|
113
|
|
|
jaypipes at gmail |
2011.2rc1 |
13 years ago
|
|
|
112
|
|
|
jaypipes at gmail |
|
13 years ago
|
|
|
111
|
|
|
Eldar Nugaev |
|
13 years ago
|
|
|
110
|
|
|
jaypipes at gmail |
|
13 years ago
|
|
|
109
|
|
|
jaypipes at gmail |
|
13 years ago
|
|
|
108
|
|
|
Soren Hansen |
|
13 years ago
|
|
|
107
|
|
|
jaypipes at gmail |
|
13 years ago
|
|
|
106
|
|
|
Dan Prince |
|
13 years ago
|
|
|
105
|
|
|
jaypipes at gmail |
|
13 years ago
|
|
|
104
|
|
|
Donal Lafferty |
2011.2gamma1 |
13 years ago
|
|
|
103
|
|
|
jaypipes at gmail |
|
13 years ago
|
|
|
102
|
|
|
jaypipes at gmail |
|
13 years ago
|
|
|
101
|
|
|
jaypipes at gmail |
|
13 years ago
|
|
|