~registry/kmod/master : changes

~registry/kmod/master » Changes from revision 1338

From Revision 1338 to 1319

Rev	Summary	Authors	Date
1338	libkmod: tidy-up kmod_file_open() libkmod: tidy-up kmod_file_open() This commit cleans up the indentation and the error path of the function. It bears no functional changes. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> [ Move assert to avoid warning with -Wdeclaration-after-statement ] Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1337	libkmod: swap alloca usage for a few assert_cc libkmod: swap alloca usage for a few assert_cc Since all the compression magic is always available now, we don't need to loop at runtime nor use alloca - latter of which comes with a handful of caveats. Simply throw in a few assert_cc(), which will trigger at build-time. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1336	libkmod: always detect the module compression libkmod: always detect the module compression Currently, when built w/o given compression we'll incorrectly report a "compression_none". As we reach do_finit_module(), we'll naively assume that the kernel can handle the compressed module, yet omit the MODULE_INIT_COMPRESSED_FILE flag. As result the kernel will barf at us, do_finit_module will fail with non -ENOSYS and we won't end in the do_init_module codepath (which will also fail). In other words: with this change, you can build kmod without zstd, xz and zlib support and the kernel will load the modules, assuming it supports the format \o/ Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1335	libkmod: move kmod_file_load_contents as applicable libkmod: move kmod_file_load_contents as applicable When dealing with an elf, we don't know or care about loading the file. The kmod_elf subsystem/API will deal with the required parts itself. Which in this case, already calls kmod_file_load_contents() as applicable. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1334	libkmod: propagate {zstd,xz,zlib}_load errors libkmod: propagate {zstd,xz,zlib}_load errors Propagate any errors during decompression further up the call stack. Without this we could easily pass NULL as mem to init_module(2). Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1333	libkmod: nuke struct file_ops libkmod: nuke struct file_ops With the previous commits, we removed the need for a distinct unload callback. So nuke the struct all together and only use/keep the load one around. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1332	libkmod: clear file->memory if map fails libkmod: clear file->memory if map fails On mmap failure file->memory is set to -1, which we'll happily pass down to munmap later on. More importantly, since we do a NULL check in kmod_file_load_contents() we will exit the function without (re)attempting the load again. Since we ignore the return code for the load function(s), one can end up calling kmod_elf_get_memory() and feed that -1 into init_module. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1331	libkmod: remove kmod_file::{zstd,xz}_used flags libkmod: remove kmod_file::{zstd,xz}_used flags These are used to protect a free(file->memory), within their respective unload functions. Where the sole caller of the unload function already does a NULL check prior. Even so, free(NULL) is guaranteed to be safe by the standard. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1330	libkmod: keep gzFile gzf local to load_zlib() libkmod: keep gzFile gzf local to load_zlib() There is no need to keep the root gzFile context open for the whole duration. Once we've copied the decompressed module to file->memory we can close the handle. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1329	libkmod: use a dup()'d fd for zlib libkmod: use a dup()'d fd for zlib The gzdopen() API used, takes ownership of the fd. To make that more explicit we clear it (-1) as applicable. Yet again, kmod has explicit API to return the fd to the user - which currently is used solely when uncompressed, so we're safe. Regardless - simply duplicate the fd locally and use that with zlib. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	5 months ago
1328	build: Ignore directories commonly used for out-of-tree buil... build: Ignore directories commonly used for out-of-tree build build/ and build-*/ are commonly used to have multiple out-out-tree builds. Add them to gitignore. Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Lucas De Marchi	5 months ago
1327	testsuite: Fix warnings due to -Wmissing-prototypes testsuite: Fix warnings due to -Wmissing-prototypes /testsuite/module-playground/mod-foo-b.c:13:6: warning: no previous prototype for ‘print_fooB’ [-Wmissing-prototypes] 13 \| void print_fooB(void) \| ^~~~~~~~~~ /testsuite/module-playground/mod-foo-a.c:13:6: warning: no previous prototype for ‘print_fooA’ [-Wmissing-prototypes] 13 \| void print_fooA(void) \| ^~~~~~~~~~ /testsuite/module-playground/mod-foo-c.c:13:6: warning: no previous prototype for ‘print_fooC’ [-Wmissing-prototypes] 13 \| void print_fooC(void) \| ^~~~~~~~~~ /testsuite/module-playground/mod-fake-scsi-mod.c:15:6: warning: no previous prototype for ‘dummy_export’ [-Wmissing-prototypes] 15 \| void dummy_export(void) \| ^~~~~~~~~~~~ Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Lucas De Marchi	5 months ago
1326	Install kmod.pc in ${datadir}/pkgconfig Install kmod.pc in ${datadir}/pkgconfig The data in this file isn't related to installed libraries, so put it in an abi-neutral location. pkg.m4 provides macros that also allow the user to override the location with configure switches. Bug: https://bugs.gentoo.org/926431 Signed-off-by: Mike Gilbert <floppym@gentoo.org> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Mike Gilbert	7 months ago
1325	build: Allow to install over dirty dir build: Allow to install over dirty dir Before commit e98cef6f3f8c ("make: install/uninstall tools symlinks to kmod") it was possible to call `make install DESTDIR=<dir>` multiple times. Use `ln -sf` so the symlink is always re-created. It would be preferred to remove install in an empty dir, but there's not a bad consequence of re-using the same, so let the user decide. Fixes the following errors while installing for the second time: ln: failed to create symbolic link '/tmp/inst/usr/bin/insmod': File exists ln: failed to create symbolic link '/tmp/inst/usr/bin/lsmod': File exists ln: failed to create symbolic link '/tmp/inst/usr/bin/rmmod': File exists ln: failed to create symbolic link '/tmp/inst/usr/bin/depmod': File exists ln: failed to create symbolic link '/tmp/inst/usr/bin/modprobe': File exists ln: failed to create symbolic link '/tmp/inst/usr/bin/modinfo': File exists make[3]: * [Makefile:2679: install-exec-hook] Error 1 make[2]: * [Makefile:2553: install-exec-am] Error 2 make[1]: * [Makefile:2439: install-am] Error 2 make: * [Makefile:1848: install-recursive] Error 1 Cc: Emil Velikov <emil.l.velikov@gmail.com> Closes: https://github.com/kmod-project/kmod/issues/35 Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Link: https://lore.kernel.org/r/20240306145804.135709-1-lucas.de.marchi@gmail.com Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Lucas De Marchi	7 months ago
1324	kmod 32 kmod 32	Lucas De Marchi	7 months ago
1323	Remove unmaintained experimental tools Remove unmaintained experimental tools The kmod insert/remove tools were introduced back in 2015. Since then they have recieved zero attention, unlike the insmod/rmmod variants. Glancing around - neither of the following distributions (Arch, Fedora, Gentoo, Debian) build them, so we're safe to say they have no users. Remove them and alongside it the --enable-experimental toggle, which no longer controls anything. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: https://lore.kernel.org/r/20240212-rm-experimental-v1-1-b97ab3004ae3@gmail.com Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	8 months ago
1322	man: silence autoconf warnings man: silence autoconf warnings Currently we have a pattern rule, which effective states that two output files are produced - %.5 and %.8. Although that's not the case in practise, since each input xml will be generated to a single manual page. Add the manpage section as part of the xml filename and tweak the pattern (match) rule, accordingly. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Link: https://lore.kernel.org/r/20240217-autoconf-manpage-warns-v1-1-e1570cfc286e@gmail.com Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	8 months ago
1321	make: install/uninstall tools symlinks to kmod make: install/uninstall tools symlinks to kmod Currently we create symlinks like modprobe (pointing to kmod), during the normal `make` build. Although those were never installed. Add a few lines in the install-exec-hook, to ensure they're present at `make install` time. Thus one can actually use those without additional changes. As an added bonus, distributions can drop the similar hunk from their packaging. Signed-off-by: Emil Velikov <emil.velikov@collabora.com> [ Use a relative symlink ] Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Emil Velikov	8 months ago
1320	configure: tweak the module_directory help string configure: tweak the module_directory help string Drop the somewhat misleading ${prefix}/lib/modules and explicitly mention what's the default. Signed-off-by: Emil Velikov <emil.velikov@collabora.com>	Emil Velikov	8 months ago
1319	gitignore: Ignore .pc files gitignore: Ignore .pc files tools/kmod.pc is generated by build system. Any new .pc we may have should follow a similar approach. So, just ignore from git, like we do for e.g. .o. Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>	Lucas De Marchi	8 months ago

Older »