129
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
128
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
127
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
126
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
125
|
|
Rip out ConnectionMonitor and Signaler, since they no longer make sense.
ConnectionMonitor existed mostly only to wrap the NetworkManager API, to isolate us against incompatibilities between NM 0.8 and NM 0.9... however, it turns out that Ubuntu 10.04 was the last Ubuntu release to ship with 0.8. Additionally, since all it does is listen for NM events over DBus, it doesn't actually do much of anything while friends-service is not running; so this means that Ken's new vala daemon is going to have to take over that role. It'll have to be smart enough not to invoke our dbus methods during times that there is no internet connection present.
As for Signaler, well, that was a very elegant design by Barry Warsaw, but we were only using it to signal between ConnectionMonitor and the Dispatcher (eg, to avoid unnecessary dbus round-trips), so there is no longer any point in keeping that around.
This commit also adds a new dbus method onto our Dispatcher object, for the purposes of downloading new contacts from all connected protocols. This will be necessary in order for our new vala overlords to invoke it over dbus periodically.
|
Robert Bruce Park |
11 years ago
|
|
|
124
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
123
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
122
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
121
|
|
Disallow posting to disabled accounts. (Closes LP: 1103717)
This one was a bit more involved than I had originally anticipated. It turns out, revision 113 where we drop this '#/protocol' business and just use the libaccounts account # directly was incomplete. Our AccountManager class was still constructing this id string, and it was inconsistent with the way the ids were being handled everywhere else in the code.
As a result of this, we experienced a regression such that disabled accounts weren't being removed from memory correctly, and thus calling SendMessage began sending messages to accounts that were, in theory, deleted. This is now fixed.
In addition to this, FakeAccount mock class has been updated to reflect an id string that is more like what actually gets used in practise, and many, many, many tests have been updated to reflect this new value.
While troubleshooting this, I also discovered a new issue that was introduced in revision 102: when we reduced memory usage by storing only row index ints rather than DeeModelRowIter objects. The problem was that when you delete a row, all the rows after it get shifted up one, so the index ints become stale and incorrect, causing Dee to raise an unhandled exception about the row index being incorrect next time you try to access a stale int. So I've thrown in a small check to bump up the cached index ints each time a row is deleted.
|
Robert Bruce Park |
11 years ago
|
|
|
120
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
119
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
118
|
|
|
Ken VanDine |
11 years ago
|
|
|
117
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
116
|
|
|
Ken VanDine |
11 years ago
|
|
|
115
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
114
|
|
|
Ken VanDine |
11 years ago
|
|
|
113
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
112
|
|
|
Ken VanDine |
11 years ago
|
|
|
111
|
|
|
Robert Bruce Park |
11 years ago
|
|
|
110
|
|
|
Robert Bruce Park |
11 years ago
|
|
|