« back to all changes in this revision
Viewing changes to worker/provisioner/provisioner_test.go
- Committer: Dave Cheney
- Date: 2013-03-22 04:18:55 UTC
- mfrom: (1041.2.2 107a-increase-timeout-delay)
- Revision ID: david.cheney@canonical.com-20130322041855-v76oseftdyf924d8
state: add dialTimeout parameter to state.Open
Updates LP#1084867
Remove the package level dialTimeout and replace it with a parameter passed to state.Open and state.Initalise.
This is part 1 of 3 changes addressing jam's comments from https://codereview.appspot.com/7528047/#msg2. As jam suspected, we were not using the SetDialTimeout helper consistently, nor was it even available outside the state package. To resolve this the helper has been removed and replaced by an explicit value passed to state.Open and state.Initalise.
The next proposal will build on this to pass a retryDelay value as originally proposed in https://codereview.appspot.com/7528047.
The last proposal will address the heavy duplication of calls to state.Open/Initalise as a cleanup before reapplying https://codereview.appspot.com/7528047.
R=fwereade, wallyworld
CC=
https://codereview.appspot.com/7782049
Updates LP#1084867
Remove the package level dialTimeout and replace it with a parameter passed to state.Open and state.Initalise.
This is part 1 of 3 changes addressing jam's comments from https://codereview.appspot.com/7528047/#msg2. As jam suspected, we were not using the SetDialTimeout helper consistently, nor was it even available outside the state package. To resolve this the helper has been removed and replaced by an explicit value passed to state.Open and state.Initalise.
The next proposal will build on this to pass a retryDelay value as originally proposed in https://codereview.appspot.com/7528047.
The last proposal will address the heavy duplication of calls to state.Open/Initalise as a cleanup before reapplying https://codereview.appspot.com/7528047.
R=fwereade, wallyworld
CC=
https://codereview.appspot.com/7782049
- files modified:
- cmd/jujud/bootstrap.go
added
removed
worker/provisioner/provisioner_test.go
