- Committer: Dimiter Naydenov
- Date: 2013-02-15 17:56:00 UTC
- mfrom: (896.1.5 bug-864164-executable-hooks)
- Revision ID: dimiter.naydenov@canonical.com-20130215175600-38m7rr1blhdk2ie2
charm: Fix bug #864164 - non-exec hooks
Changed ExpandTo() and BundleTo() to set
executable permissions while processing
charm hook files. In the case of BundleTo(),
as mentioned in the bug, a warning is issued
to the log about this, while in ExpandTo()
it happens silently.
Permissions of hooks are set executable by owner.
Added tests and a testing charm with all hooks
defined.
R=fwereade, rog
CC=
https://codereview.appspot.com/7305096
Changed ExpandTo() and BundleTo() to set
executable permissions while processing
charm hook files. In the case of BundleTo(),
as mentioned in the bug, a warning is issued
to the log about this, while in ExpandTo()
it happens silently.
Permissions of hooks are set executable by owner.
Added tests and a testing charm with all hooks
defined.
R=fwereade, rog
CC=
https://codereview.appspot.com/7305096
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 .. |
|||||||
cert
|
734.5.14 | 11 years ago | Roger Peppe | add cert package |
|
||
|
charm
|
11 | 13 years ago | Gustavo Niemeyer | Applied the juju/charm renaming to the Go code bas |
|
||
|
cloudinit
|
25.2.1 | 12 years ago | Roger Peppe | add cloudinit package |
|
||
|
cmd
|
37.3.14 | 12 years ago | William Reade | hefty rearrangement, few actual changes |
|
||
|
contrib
|
632.1.2 | 11 years ago | Dave Cheney | responding to review feedbac |
|
||
|
doc
|
773.7.1 | 11 years ago | William Reade | added some draft documentation |
|
||
|
downloader
|
358.2.4 | 12 years ago | Roger Peppe | downloader: first test passes |
|
||
|
environs
|
25.5.4 | 12 years ago | Roger Peppe | rename environ->environs |
|
||
|
juju
|
37.3.14 | 12 years ago | William Reade | hefty rearrangement, few actual changes |
|
||
|
log
|
20.1.1 | 12 years ago | Mathieu Lonjaret | logger: use global vars, becomes a package |
|
||
|
rpc
|
766.2.1 | 11 years ago | Roger Peppe | rpc: initial commit |
|
||
|
schema
|
1 | 13 years ago | Gustavo Niemeyer | Bootstrapped package. |
|
||
|
state
|
525.1.1 | 12 years ago | Roger Peppe | mstate: rename to state |
|
||
|
store
|
894.1.1 | 11 years ago | Dave Cheney | undo charm store removal, rev 886 |
|
||
|
testing
|
83.1.2 | 12 years ago | William Reade | renamed testutils; broke it in anticipation of goz |
|
||
|
thirdparty
|
623.3.1 | 11 years ago | Roger Peppe | environs: add PasswordHash and RandomBytes |
|
||
|
trivial
|
377.8.8 | 12 years ago | William Reade | moved relation/util to new trivial package; remove |
|
||
|
upstart
|
152.5.1 | 12 years ago | William Reade | first cut, untested |
|
||
|
version
|
124.2.2 | 12 years ago | Roger Peppe | version: simplify |
|
||
|
worker
|
295.1.1 | 12 years ago | Dave Cheney | service => worker |
|
||
.bzrignore |
896.1.3 | 11 years ago | Dimiter Naydenov | Changes after review | 122 bytes |
|
|
|
.lbox |
269.4.7 | 12 years ago | William Reade | whoops: readd .lbox | 30 bytes |
|
|
.lbox.check |
840.1.2 | 11 years ago | Roger Peppe | additional format check | 408 bytes |
|
|
|
CONTRIBUTING |
826.1.1 | 11 years ago | Dave Cheney | fix incorrect src path | 6.7 KB |
|
|
|
LICENCE |
703.1.1 | 11 years ago | Dave Cheney | + LICENCE | 33.7 KB |
|
|
|
README |
800.1.3 | 11 years ago | Martin Packman | Add example mongo tools url in public bucket to re | 4.4 KB |
|
|