« back to all changes in this revision
Viewing changes to include/core/option.h
- Committer: smspillaz
- Date: 2012-02-16 05:31:28 UTC
- mto: (2974.2.36 compiz-core.actually-merges)
- mto: This revision was merged to the branch mainline in revision 2986.
- Revision ID: sam.spilsbury@canonical.com-20120216053128-4vqmbbcmk57eax0k
Only call removeAction on the CompOption destructor and not the CompOption::Value
destructor, since plugins that make copies of CompOption::Value can cause actions to
be added through setOptionForPlugin and then those actions will be removed when the
value temporary goes away.
The action adding and removing only happens within the bounds of CompOption anyways, so
its its more appropriate to have it in its destructor.
Of course, this brings up another issue, which is that CompOption should be noncopyable
but this opens up a whole another can of worms.
How this even worked before is beyond me...
LP #931927
destructor, since plugins that make copies of CompOption::Value can cause actions to
be added through setOptionForPlugin and then those actions will be removed when the
value temporary goes away.
The action adding and removing only happens within the bounds of CompOption anyways, so
its its more appropriate to have it in its destructor.
Of course, this brings up another issue, which is that CompOption should be noncopyable
but this opens up a whole another can of worms.
How this even worked before is beyond me...
LP #931927
added
removed
include/core/option.h
