~themue/juju-core/053-env-more-script-friendly : changes

~themue/juju-core/053-env-more-script-friendly » Changes from revision 1548.3.1

From Revision 1548.3.1 to 1530

Rev	Summary	Authors	Date
1548.3.1	names: new package names: new package	Dimiter Naydenov	10 years ago
1548	worker/upgrader: adjust NewUpgrader worker/upgrader: adjust NewUpgrader Rename upgrader.NewUpgrader to upgrader.New. Put the tag first in the arguments. https://codereview.appspot.com/12021043/	Roger Peppe	10 years ago
1547	worker/upgrader: new package worker/upgrader: new package Substantially simplified logic from when it lived in cmd/jujud, but it still has the same basic contract (it dies with a NeedsUpgrade error when upgraded). https://codereview.appspot.com/11932043/	Roger Peppe	10 years ago
1546	deployer: Replace state calls with API calls deployer: Replace state calls with API calls This is the last step needed to enable the API connection for the deployer worker. Several other things needed to be moved around and reused (in state, api/deployer). Contains a workaround to get the correct API and State addresses, which needs to be fixed properly once we store machine addresses in state and can get the public addresses of all machines with JobManageState. https://codereview.appspot.com/11800045/	Dimiter Naydenov	10 years ago
1545	worker/minunitsworker: Added minimum units worker worker/minunitsworker: Added minimum units worker The worker receives events from the minUnitsWatcher and reacts calling EnsureMinUnits on the services. https://codereview.appspot.com/11826043/ R=dimitern, fwereade	Francesco Banconi	10 years ago
1544	[r=themue] sync: pull out sync tools logic [r=themue] sync: pull out sync tools logic The is the first of a number of CLs regarding autosync. Here the logic for the synchronization of the tools moved from the explicit command to the package environs/sync and the command has been changed to use this package. In a later step the bootstrap command shall be changed to use this logic too in case the need for an automatic synchronization is detected. https://codereview.appspot.com/11588043/	Frank Mueller	10 years ago
1543	[r=julian-edwards] Better handling of Azure's profanity filt... [r=julian-edwards] Better handling of Azure's profanity filter. Make use of gwacl's CheckHostedServiceNameAvailability call which will test to see if a random service name falls foul of Azure's profanity and trademark filter before using it.	Julian Edwards	10 years ago
1542	[r=rogpeppe] state/api/worker: use Tools in params [r=rogpeppe] state/api/worker: use Tools in params This simplifies the SetAgentTools call generally. https://codereview.appspot.com/11800044/	Roger Peppe	10 years ago
1541	[r=jtv] Default to not-quite-smallest Azure machine type. [r=jtv] Default to not-quite-smallest Azure machine type. The smallest machine type that Azure defines is ExtraSmall, which has a shared core and 768MB of memory. That isn't quite enough for common charms, such as the MySQL one. So, similar to what the EC2 provider does, this sets a baseline for requests that do not specify a memory constraint. If you do specify a lower memory constraint, of course, that's what takes precedence and if it's not enough memory for you then that's your own damn fault.	jtv at canonical	10 years ago
1540	[r=axwalk],[bug=1154942] Reset dummy environ in teardown for... [r=axwalk],[bug=1154942] Reset dummy environ in teardown for config tests https://codereview.appspot.com/11806043/	Andrew Wilkins	10 years ago
1539	[r=dave-cheney] set development version to 1.13.0 [r=dave-cheney] set development version to 1.13.0	Dave Cheney	10 years ago
1538	[r=rogpeppe] state/api/params: redefine ErrorResults [r=rogpeppe] state/api/params: redefine ErrorResults This is future-proofing - it potentially allows us to change an API call from returning some no data to returning some data, in a backwardly compatible way. It means that the standard result of a bulk API call is {Results: [{Error: {error contents}, other returned data}, ...]} whether it returns some data from the result of each element in the bulk operation or not. https://codereview.appspot.com/11674045/	Roger Peppe	10 years ago
1537	[r=rogpeppe] agent/tools: do not embed Binary [r=rogpeppe] agent/tools: do not embed Binary I want to serialise Tools as part of the API and it doesn't read well with an embedded field (also there's a difference between Go1.0.2 and Go1.1 with embedded fields. We could just define a Tools.MarshalJSON method, but I prefer to make Tools marshal nicely as-is. I think it actually reads better without the embedding too. https://codereview.appspot.com/11760045/	Roger Peppe	10 years ago
1536	[r=gz] Add Instance.Addresses() and use for openstack [r=gz] Add Instance.Addresses() and use for openstack Changes the Instance interface to require a new Addresses() method. This will be used to present cloud-specific address details in the generic fashion, which a future branch will record in state. The code includes the required implementation for Openstack, maintaining support for the current quirks but shifting some of the general logic into the shared instance/address.go file. Currently all calls still go back through the cloud api, but when the results are recorded in state and can be updated by the state server, it will be possible make users of DNSName and WaitDNSName consumers of machineDoc only.	Martin Packman	10 years ago
1535	[r=dimitern] state/api(server)/deployer: Addresses, CACert [r=dimitern] state/api(server)/deployer: Addresses, CACert Three calls implemented in the Deployer API facades (client- and server-side), needed by the deployer worker: StateAddresses(), APIAddresses(), and CACert(). They match the same methods found in state/open.go, except for StateAddresses(), which corresponds to Addresses(), but was renamed as a suggestion in the review. https://codereview.appspot.com/11765043/ R=rogpeppe, themue	Dimiter Naydenov	10 years ago
1534	[r=gz] instance: Add Address type matching that in state [r=gz] instance: Add Address type matching that in state Splits new state Address type out into instance, which will hold all relevant logic, leaving state with just a basic mapping of the same data.	Martin Packman	10 years ago
1533	[r=rogpeppe] version: marshal to JSON string [r=rogpeppe] version: marshal to JSON string This will make the API look nicer. https://codereview.appspot.com/11589043/	Roger Peppe	10 years ago
1532	[r=thumper] Apply gc prefix for gocheck in agent. [r=thumper] Apply gc prefix for gocheck in agent. https://codereview.appspot.com/11754043/	Tim Penhey	10 years ago
1531	[r=julian-edwards] Allow config to override the OS image use... [r=julian-edwards] Allow config to override the OS image used for Azure instances. Useful long term but required right now because simplestreams is not hooked in and there is only one alpha image for saucy that can be used which supports the right cloud-init.	Julian Edwards	10 years ago
1530	[r=jtv] Select instance type on Azure. [r=jtv] Select instance type on Azure. Selecting an instance type on Azure is very simple: regions don't come into it, and there are few enough types that you can just pick the cheapest type that matches technical requirements and always know you got the best possible fit. Nevertheless Azure has some mismatches with Juju's selection logic. Disk sizes come into play, which aren't currently modeled in constraints. We're not even really sure yet what Azure's documented limitations on OS disk size mean. The image we use is 30 GB (OS images dictate OS disk size in Azure) and the ExtraSmall machine type is documented as having 19 or 20 GB of OS disk space, yet Julian has tried deploying that combination, and succeeded. Juju's constraints model does allow for coupling between images and instance types. But since we don't have image selection at all yet, for now I found it much easier to implement instance-type selection than to fit in with the existing code for this. We'll have to re-think this after a good look at simplestreams.	jtv at canonical	10 years ago

Older »