~thumper/juju-core/move-environs-tools : changes

~thumper/juju-core/move-environs-tools » Changes from revision 1413

From Revision 1411 to 1392

Rev	Summary	Authors	Date
1411	More moves and tests in tools pass. More moves and tests in tools pass.	Tim Penhey	10 years ago
1410	builds now. builds now.	Tim Penhey	10 years ago
1409	Part way through the move. Part way through the move.	Tim Penhey	10 years ago
1408	[r=thumper] Move state initialization out of jujud bootstrap [r=thumper] Move state initialization out of jujud bootstrap Methods to configure the initial state connection and dealing with passwords were inside the jujud bootstrap command, which isn't going to be used by the local provider, so the functions need to be extracted. https://codereview.appspot.com/10990043/	Tim Penhey	10 years ago
1407	[r=thumper] Implement Storage and PublicStorage for local. [r=thumper] Implement Storage and PublicStorage for local. In the restructuring of the directories, I realized that we should just have a configurable root directory for the environment, and have other directories off that. The local config now just has a root-dir. The namespace takes into consideration the root user, and will look for the SUDO_USER environment variable if set to identify the user calling sudo. I also renamed the storage to "storage" and "sharedStorage" based on email conversations. The directories are no longer created when the config is validated as the config may be being parsed and created when the user isn't root, especially when the default directory is in a restricted area. There are now two tests in the config_local.go file that are only run when run as root. To run these locally I had to make sure that the GOPATH was set: sudo GOPATH=/home/tim/go go test -gocheck.f configRootTest https://codereview.appspot.com/10987043/	Tim Penhey	10 years ago
1406	[r=thumper] Further break up cloudinit. [r=thumper] Further break up cloudinit. Move the definitions of the mongo and machine agent services into the upstart package. These have been parameterized to allow reuse in the local provider. https://codereview.appspot.com/10952043/	Tim Penhey	10 years ago
1405	[r=dimitern] deployer: omitted suggestions from a prev revie... [r=dimitern] deployer: omitted suggestions from a prev review As promised in https://codereview.appspot.com/10746044/ I'm adding the omitted suggestions from fwereade's review. https://codereview.appspot.com/10858050/	Dimiter Naydenov	10 years ago
1404	[r=dimitern],[bug=1195344] Add the environment UUID to the [r=dimitern],[bug=1195344] Add the environment UUID to the EnvironmentInfo API call response.	Alberto Donato	10 years ago
1403	[r=dimitern],[bug=1198936] environs/ec2: fix a failing test ... [r=dimitern],[bug=1198936] environs/ec2: fix a failing test (bug 1198936) https://codereview.appspot.com/11002043/	Dimiter Naydenov	10 years ago
1402	[r=fwereade] params: put like things near each other [r=fwereade] params: put like things near each other ...approximately. progress not perfection; main point is that it puts all the stuff I'm going to be kicking hard into internal.go https://codereview.appspot.com/10886047/	William Reade	10 years ago
1401	[r=jameinel] worker/cleaner: use new NotifyWorker structure [r=jameinel] worker/cleaner: use new NotifyWorker structure Just reimplements the Cleaner worker as a WatchHandler passed to the NotifyWorker. Cleaner was pretty simple, but I'm still able to remove about 20 lines of boilerplate. (And replace it with heavily tested logic.) https://codereview.appspot.com/10876048/	John Arbash Meinel	10 years ago
1400	[r=jameinel] worker/notifyworker.go: Common worker logic [r=jameinel] worker/notifyworker.go: Common worker logic While I was looking to implement Upgrader as a worker, I realized that there was a lot of bits necessary to implement a Worker. You have to integrate with a tomb, and monitor the worker, and handle a modest interface, etc. It isn't a terrible amount, but it turns out to be a lot of boilerplate that actually takes a lot if you want to test all the edge cases. This patch pulls all of that edge-case logic into a NotifyWorker helper. Essentially you implement a smaller api (WatchHandler), and hand that to the NotifyWorker. It then handles all the logic about shutting down cleanly, and you just integrate your couple of actions based on triggers. I have a follow up patch so you can see what the Cleaner worker looks like with this change. Probably the biggest advantage of this patch is that I have a very well tested edge-case-handling code, which can now just be re-used for all the other workers, and you don't have to worry about if your code is stopping the watcher it started, or if it is shutting down at the right time, etc. https://codereview.appspot.com/10978043/	John Arbash Meinel	10 years ago
1399	[r=jameinel] state/api/watcher: Refactor API watchers [r=jameinel] state/api/watcher: Refactor API watchers This moves the state/api/watcher.go file into state/api/watcher/watcher.go. The main benefit of that is to avoid circular imports as we start having APIs themselves returning Watcher objects. In doing that move I found a few things: 1) We needed api.ErrCode for a few things, so it got moved to params.ErrCode, which caused some small duplication with the existing params.Errors. However, they were pratically identical (apierrors.go had a GoString that params.Errors didn't have.) 2) Most callers that were calling api.ErrCode already had imported params anyway. 3) AllWatcher is very entwined with its Client, so I didn't move that specific part of the code. (Client can return an AllWatcher, and AllWatcher points to its Client.) 4) I changed the Watcher code so it needs a Caller rather than an api.State. The only thing any of the code did was call .Call anyway, which means we have a nice opportunity that we could mock out actual calls to the remote State api if we want some tighter testing of the client-side code. So I like switching to a simple interface. I'm not sure about that being a "Caller" interface because that seems a bit generic. 5) api.params.NotifyWatcher implements the same interface as state.NotifyWatcher. So we can be reasonably confident that code that was using an existing watcher will be compatible. Yay. https://codereview.appspot.com/10939043/	John Arbash Meinel	10 years ago
1398	[r=jtv] Run "make simplify" to clean up the code a bit. [r=jtv] Run "make simplify" to clean up the code a bit. This is something we should do periodically. It's easy to forget because, last I checked, gofmt's -s option didn't work with recursive invocations ("format my entire project"). But the Makefile hides the workaround, so it's easy enough now. I'm not entirely without self-interest: this takes some diff out of my upcoming merge proposal.	jtv at canonical	10 years ago
1397	[r=jameinel] tools: add a tools package [r=jameinel] tools: add a tools package In working on the Upgrader code, I was unhappy about a few things: a) Having to import all of state just to get the Tools struct b) Having to pass a dataDir to Upgrader (it feels like the logic in Upgrader should have no idea that there is even a disk around) c) tools handling is in environs/agent/tools.go, but yet again, nothing in tools should be depending on things in environs. Yes we store them and download them from there, but it should all be abstracted away. So this is my initial attempt at creating that abstraction, and starting to pull things into a tools package. For now, it is sort of a minimal interface that I needed for Uploader, and the actual functionality just proxies over to the environs/agent package. If people like it, I can see getting rid of/deprecating environs/agent and *state.Tools and gathering that stuff up into tools/. I don't want to spend too much time on this right now, but I'd be happy to file a tech-debt bug about moving more stuff into tools. https://codereview.appspot.com/10984043/	John Arbash Meinel	10 years ago
1396	[r=jameinel] worker/deployer: Clarify imports [r=jameinel] worker/deployer: Clarify imports deployer_test imports a lot of 'testing' packages. This just changes it so all of them are prefixed to make it easier to figure out where each bit of code comes from. https://codereview.appspot.com/10871045/	John Arbash Meinel	10 years ago
1395	[r=rvb] Azure provider: map instances onto Azure services. [r=rvb] Azure provider: map instances onto Azure services.	Raphael Badin	10 years ago
1394	[r=wallyworld] AssignNew now knows about container constrain... [r=wallyworld] AssignNew now knows about container constraints If there's a service constraint that says a charm should be deployed into a container, AssignNew policy knows how to do that. It is also possible to set an environment constraint to do the same thing. https://codereview.appspot.com/10858043/	Ian Booth	10 years ago
1393	[r=wallyworld] Implement AssignClean and AssignCleanEmpty [r=wallyworld] Implement AssignClean and AssignCleanEmpty This branch removes the AssignUnused policy and instead provides an implementation for AssignClean and AssignEmpty. The tests were refactored so that all the existing AssignUnused tests were added to a suite and run using the same code for the clean and clean/empty cases. https://codereview.appspot.com/10854043/	Ian Booth	10 years ago
1392	[r=jameinel] Utility function to find IPv4 address. [r=jameinel] Utility function to find IPv4 address. There was no simple way to get an IPv4 address for a particular net.Interface. So I added this. https://codereview.appspot.com/10951043/	Tim Penhey	10 years ago

Older »