← Back to branch summary

~trb143/openlp/themecombo-24

« back to all changes in this revision

Viewing changes to tests/functional/openlp_plugins/songs/test_openlpimporter.py

  • Committer: Tim Bentley
  • Author(s): s.mehrbrodt at gmail
  • Date: 2016-04-29 18:42:14 UTC
  • mfrom: (2627.1.2 bug-1552563-2.4)
  • Revision ID: tim.bentley@gmail.com-20160429184214-21rvc55mpu0fc5wq
https://launchpad.net/bugs/1552563
Fix performance regression with Songbook search

The problem was that in each iteration the database was accessed (the song object).
Fixed this by loading all neccessary information directly in the query.

Also this reintroduces natural sorting.

Show diffs side-by-side

added added

removed removed

Lines of Context:
tests/functional/openlp_plugins/songs/test_openlpimporter.py
73
73
                self.assertIsNone(importer.do_import(), 'do_import should return None when import_source is not a list')
74
74
                self.assertEqual(mocked_import_wizard.progress_bar.setMaximum.called, False,
75
75
                                 'setMaximum on import_wizard.progress_bar should not have been called')
76