1
Subject: acpi: Make gbl_[hardware|gpe]_lock raw
2
From: Thomas Gleixner <tglx@linutronix.de>
3
Date: Mon, 28 Nov 2011 17:09:54 +0100
5
These locks are taken in the guts of the idle code and cannot be
6
converted to "sleeping" spinlocks on RT
8
Cc: stable-rt@vger.kernel.org
9
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
11
drivers/acpi/acpica/acglobal.h | 4 ++--
12
drivers/acpi/acpica/evgpe.c | 4 ++--
13
drivers/acpi/acpica/evgpeblk.c | 8 ++++----
14
drivers/acpi/acpica/evgpeutil.c | 12 ++++++------
15
drivers/acpi/acpica/evxface.c | 10 +++++-----
16
drivers/acpi/acpica/evxfgpe.c | 24 ++++++++++++------------
17
drivers/acpi/acpica/hwregs.c | 4 ++--
18
drivers/acpi/acpica/hwxface.c | 4 ++--
19
drivers/acpi/acpica/utmutex.c | 21 +++------------------
20
9 files changed, 38 insertions(+), 53 deletions(-)
22
Index: linux-3.2/drivers/acpi/acpica/acglobal.h
23
===================================================================
24
--- linux-3.2.orig/drivers/acpi/acpica/acglobal.h
25
+++ linux-3.2/drivers/acpi/acpica/acglobal.h
26
@@ -235,8 +235,8 @@ ACPI_EXTERN u8 acpi_gbl_global_lock_pend
27
* Spinlocks are used for interfaces that can be possibly called at
30
-ACPI_EXTERN acpi_spinlock acpi_gbl_gpe_lock; /* For GPE data structs and registers */
31
-ACPI_EXTERN acpi_spinlock acpi_gbl_hardware_lock; /* For ACPI H/W except GPE registers */
32
+extern raw_spinlock_t acpi_gbl_gpe_lock; /* For GPE data structs and registers */
33
+extern raw_spinlock_t acpi_gbl_hardware_lock; /* For ACPI H/W except GPE registers */
35
/*****************************************************************************
37
Index: linux-3.2/drivers/acpi/acpica/evgpe.c
38
===================================================================
39
--- linux-3.2.orig/drivers/acpi/acpica/evgpe.c
40
+++ linux-3.2/drivers/acpi/acpica/evgpe.c
41
@@ -357,7 +357,7 @@ u32 acpi_ev_gpe_detect(struct acpi_gpe_x
42
* Note: Not necessary to obtain the hardware lock, since the GPE
43
* registers are owned by the gpe_lock.
45
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
46
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
48
/* Examine all GPE blocks attached to this interrupt level */
50
@@ -440,7 +440,7 @@ u32 acpi_ev_gpe_detect(struct acpi_gpe_x
54
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
55
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
59
Index: linux-3.2/drivers/acpi/acpica/evgpeblk.c
60
===================================================================
61
--- linux-3.2.orig/drivers/acpi/acpica/evgpeblk.c
62
+++ linux-3.2/drivers/acpi/acpica/evgpeblk.c
63
@@ -95,7 +95,7 @@ acpi_ev_install_gpe_block(struct acpi_gp
65
/* Install the new block at the end of the list with lock */
67
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
68
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
69
if (gpe_xrupt_block->gpe_block_list_head) {
70
next_gpe_block = gpe_xrupt_block->gpe_block_list_head;
71
while (next_gpe_block->next) {
72
@@ -109,7 +109,7 @@ acpi_ev_install_gpe_block(struct acpi_gp
75
gpe_block->xrupt_block = gpe_xrupt_block;
76
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
77
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
80
status = acpi_ut_release_mutex(ACPI_MTX_EVENTS);
81
@@ -156,7 +156,7 @@ acpi_status acpi_ev_delete_gpe_block(str
83
/* Remove the block on this interrupt with lock */
85
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
86
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
87
if (gpe_block->previous) {
88
gpe_block->previous->next = gpe_block->next;
90
@@ -167,7 +167,7 @@ acpi_status acpi_ev_delete_gpe_block(str
91
if (gpe_block->next) {
92
gpe_block->next->previous = gpe_block->previous;
94
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
95
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
98
acpi_current_gpe_count -= gpe_block->gpe_count;
99
Index: linux-3.2/drivers/acpi/acpica/evgpeutil.c
100
===================================================================
101
--- linux-3.2.orig/drivers/acpi/acpica/evgpeutil.c
102
+++ linux-3.2/drivers/acpi/acpica/evgpeutil.c
103
@@ -70,7 +70,7 @@ acpi_ev_walk_gpe_list(acpi_gpe_callback
105
ACPI_FUNCTION_TRACE(ev_walk_gpe_list);
107
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
108
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
110
/* Walk the interrupt level descriptor list */
112
@@ -101,7 +101,7 @@ acpi_ev_walk_gpe_list(acpi_gpe_callback
116
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
117
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
118
return_ACPI_STATUS(status);
121
@@ -237,7 +237,7 @@ struct acpi_gpe_xrupt_info *acpi_ev_get_
123
/* Install new interrupt descriptor with spin lock */
125
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
126
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
127
if (acpi_gbl_gpe_xrupt_list_head) {
128
next_gpe_xrupt = acpi_gbl_gpe_xrupt_list_head;
129
while (next_gpe_xrupt->next) {
130
@@ -249,7 +249,7 @@ struct acpi_gpe_xrupt_info *acpi_ev_get_
132
acpi_gbl_gpe_xrupt_list_head = gpe_xrupt;
134
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
135
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
137
/* Install new interrupt handler if not SCI_INT */
139
@@ -306,7 +306,7 @@ acpi_status acpi_ev_delete_gpe_xrupt(str
141
/* Unlink the interrupt block with lock */
143
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
144
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
145
if (gpe_xrupt->previous) {
146
gpe_xrupt->previous->next = gpe_xrupt->next;
148
@@ -318,7 +318,7 @@ acpi_status acpi_ev_delete_gpe_xrupt(str
149
if (gpe_xrupt->next) {
150
gpe_xrupt->next->previous = gpe_xrupt->previous;
152
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
153
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
157
Index: linux-3.2/drivers/acpi/acpica/evxface.c
158
===================================================================
159
--- linux-3.2.orig/drivers/acpi/acpica/evxface.c
160
+++ linux-3.2/drivers/acpi/acpica/evxface.c
161
@@ -751,7 +751,7 @@ acpi_install_gpe_handler(acpi_handle gpe
162
goto unlock_and_exit;
165
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
166
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
168
/* Ensure that we have a valid GPE number */
170
@@ -799,14 +799,14 @@ acpi_install_gpe_handler(acpi_handle gpe
171
~(ACPI_GPE_XRUPT_TYPE_MASK | ACPI_GPE_DISPATCH_MASK);
172
gpe_event_info->flags |= (u8) (type | ACPI_GPE_DISPATCH_HANDLER);
174
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
175
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
178
(void)acpi_ut_release_mutex(ACPI_MTX_EVENTS);
179
return_ACPI_STATUS(status);
182
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
183
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
185
goto unlock_and_exit;
187
@@ -853,7 +853,7 @@ acpi_remove_gpe_handler(acpi_handle gpe_
188
return_ACPI_STATUS(status);
191
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
192
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
194
/* Ensure that we have a valid GPE number */
196
@@ -904,7 +904,7 @@ acpi_remove_gpe_handler(acpi_handle gpe_
200
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
201
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
203
(void)acpi_ut_release_mutex(ACPI_MTX_EVENTS);
204
return_ACPI_STATUS(status);
205
Index: linux-3.2/drivers/acpi/acpica/evxfgpe.c
206
===================================================================
207
--- linux-3.2.orig/drivers/acpi/acpica/evxfgpe.c
208
+++ linux-3.2/drivers/acpi/acpica/evxfgpe.c
209
@@ -122,7 +122,7 @@ acpi_status acpi_enable_gpe(acpi_handle
211
ACPI_FUNCTION_TRACE(acpi_enable_gpe);
213
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
214
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
216
/* Ensure that we have a valid GPE number */
218
@@ -131,7 +131,7 @@ acpi_status acpi_enable_gpe(acpi_handle
219
status = acpi_ev_add_gpe_reference(gpe_event_info);
222
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
223
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
224
return_ACPI_STATUS(status);
226
ACPI_EXPORT_SYMBOL(acpi_enable_gpe)
227
@@ -159,7 +159,7 @@ acpi_status acpi_disable_gpe(acpi_handle
229
ACPI_FUNCTION_TRACE(acpi_disable_gpe);
231
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
232
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
234
/* Ensure that we have a valid GPE number */
236
@@ -168,7 +168,7 @@ acpi_status acpi_disable_gpe(acpi_handle
237
status = acpi_ev_remove_gpe_reference(gpe_event_info) ;
240
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
241
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
242
return_ACPI_STATUS(status);
244
ACPI_EXPORT_SYMBOL(acpi_disable_gpe)
245
@@ -215,7 +215,7 @@ acpi_setup_gpe_for_wake(acpi_handle wake
246
return_ACPI_STATUS(AE_BAD_PARAMETER);
249
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
250
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
252
/* Ensure that we have a valid GPE number */
254
@@ -271,7 +271,7 @@ acpi_setup_gpe_for_wake(acpi_handle wake
258
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
259
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
260
return_ACPI_STATUS(status);
262
ACPI_EXPORT_SYMBOL(acpi_setup_gpe_for_wake)
263
@@ -301,7 +301,7 @@ acpi_status acpi_set_gpe_wake_mask(acpi_
265
ACPI_FUNCTION_TRACE(acpi_set_gpe_wake_mask);
267
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
268
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
271
* Ensure that we have a valid GPE number and that this GPE is in
272
@@ -347,7 +347,7 @@ acpi_status acpi_set_gpe_wake_mask(acpi_
276
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
277
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
278
return_ACPI_STATUS(status);
281
@@ -373,7 +373,7 @@ acpi_status acpi_clear_gpe(acpi_handle g
283
ACPI_FUNCTION_TRACE(acpi_clear_gpe);
285
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
286
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
288
/* Ensure that we have a valid GPE number */
290
@@ -386,7 +386,7 @@ acpi_status acpi_clear_gpe(acpi_handle g
291
status = acpi_hw_clear_gpe(gpe_event_info);
294
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
295
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
296
return_ACPI_STATUS(status);
299
@@ -416,7 +416,7 @@ acpi_get_gpe_status(acpi_handle gpe_devi
301
ACPI_FUNCTION_TRACE(acpi_get_gpe_status);
303
- flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);
304
+ raw_spin_lock_irqsave(&acpi_gbl_gpe_lock, flags);
306
/* Ensure that we have a valid GPE number */
308
@@ -434,7 +434,7 @@ acpi_get_gpe_status(acpi_handle gpe_devi
309
*event_status |= ACPI_EVENT_FLAG_HANDLE;
312
- acpi_os_release_lock(acpi_gbl_gpe_lock, flags);
313
+ raw_spin_unlock_irqrestore(&acpi_gbl_gpe_lock, flags);
314
return_ACPI_STATUS(status);
317
Index: linux-3.2/drivers/acpi/acpica/hwregs.c
318
===================================================================
319
--- linux-3.2.orig/drivers/acpi/acpica/hwregs.c
320
+++ linux-3.2/drivers/acpi/acpica/hwregs.c
321
@@ -263,14 +263,14 @@ acpi_status acpi_hw_clear_acpi_status(vo
322
ACPI_BITMASK_ALL_FIXED_STATUS,
323
ACPI_FORMAT_UINT64(acpi_gbl_xpm1a_status.address)));
325
- lock_flags = acpi_os_acquire_lock(acpi_gbl_hardware_lock);
326
+ raw_spin_lock_irqsave(&acpi_gbl_hardware_lock, lock_flags);
328
/* Clear the fixed events in PM1 A/B */
330
status = acpi_hw_register_write(ACPI_REGISTER_PM1_STATUS,
331
ACPI_BITMASK_ALL_FIXED_STATUS);
333
- acpi_os_release_lock(acpi_gbl_hardware_lock, lock_flags);
334
+ raw_spin_unlock_irqrestore(&acpi_gbl_hardware_lock, lock_flags);
336
if (ACPI_FAILURE(status))
338
Index: linux-3.2/drivers/acpi/acpica/hwxface.c
339
===================================================================
340
--- linux-3.2.orig/drivers/acpi/acpica/hwxface.c
341
+++ linux-3.2/drivers/acpi/acpica/hwxface.c
342
@@ -387,7 +387,7 @@ acpi_status acpi_write_bit_register(u32
343
return_ACPI_STATUS(AE_BAD_PARAMETER);
346
- lock_flags = acpi_os_acquire_lock(acpi_gbl_hardware_lock);
347
+ raw_spin_lock_irqsave(&acpi_gbl_hardware_lock, lock_flags);
350
* At this point, we know that the parent register is one of the
351
@@ -448,7 +448,7 @@ acpi_status acpi_write_bit_register(u32
355
- acpi_os_release_lock(acpi_gbl_hardware_lock, lock_flags);
356
+ raw_spin_unlock_irqrestore(&acpi_gbl_hardware_lock, lock_flags);
357
return_ACPI_STATUS(status);
360
Index: linux-3.2/drivers/acpi/acpica/utmutex.c
361
===================================================================
362
--- linux-3.2.orig/drivers/acpi/acpica/utmutex.c
363
+++ linux-3.2/drivers/acpi/acpica/utmutex.c
364
@@ -52,6 +52,9 @@ static acpi_status acpi_ut_create_mutex(
366
static void acpi_ut_delete_mutex(acpi_mutex_handle mutex_id);
368
+DEFINE_RAW_SPINLOCK(acpi_gbl_gpe_lock);
369
+DEFINE_RAW_SPINLOCK(acpi_gbl_hardware_lock);
371
/*******************************************************************************
373
* FUNCTION: acpi_ut_mutex_initialize
374
@@ -81,18 +84,6 @@ acpi_status acpi_ut_mutex_initialize(voi
378
- /* Create the spinlocks for use at interrupt level */
380
- status = acpi_os_create_lock (&acpi_gbl_gpe_lock);
381
- if (ACPI_FAILURE (status)) {
382
- return_ACPI_STATUS (status);
385
- status = acpi_os_create_lock (&acpi_gbl_hardware_lock);
386
- if (ACPI_FAILURE (status)) {
387
- return_ACPI_STATUS (status);
390
/* Mutex for _OSI support */
391
status = acpi_os_create_mutex(&acpi_gbl_osi_mutex);
392
if (ACPI_FAILURE(status)) {
393
@@ -132,13 +123,7 @@ void acpi_ut_mutex_terminate(void)
395
acpi_os_delete_mutex(acpi_gbl_osi_mutex);
397
- /* Delete the spinlocks */
399
- acpi_os_delete_lock(acpi_gbl_gpe_lock);
400
- acpi_os_delete_lock(acpi_gbl_hardware_lock);
402
/* Delete the reader/writer lock */
404
acpi_ut_delete_rw_lock(&acpi_gbl_namespace_rw_lock);