~ubuntu-branches/ubuntu/intrepid/samba/intrepid-updates

« back to all changes in this revision

Viewing changes to debian/patches/upstream_bug5517.patch

  • Committer: Bazaar Package Importer
  • Author(s): Jamie Strandboge
  • Date: 2008-06-30 09:17:40 UTC
  • Revision ID: james.westby@ubuntu.com-20080630091740-nwz9mmtszc27aeur
Tags: 2:3.0.30-2ubuntu3
* debian/patches/upstream_bug5517.patch: adjust cli_negprot() to properly
  calculate buffer sizes. This bug was introduced in the fix for
  CVE-2008-1105
* References
  LP: #241448
  https://bugzilla.samba.org/show_bug.cgi?id=5517

Show diffs side-by-side

added added

removed removed

Lines of Context:
 
1
diff -Nur samba-3.0.30/source/libsmb/cliconnect.c samba-3.0.30.new/source/libsmb/cliconnect.c
 
2
--- samba-3.0.30/source/libsmb/cliconnect.c     2008-05-28 08:41:11.000000000 -0400
 
3
+++ samba-3.0.30.new/source/libsmb/cliconnect.c 2008-06-30 09:17:06.000000000 -0400
 
4
@@ -1328,9 +1328,9 @@
 
5
                if (cli->capabilities & (CAP_LARGE_READX|CAP_LARGE_WRITEX)) {
 
6
                        SAFE_FREE(cli->outbuf);
 
7
                        SAFE_FREE(cli->inbuf);
 
8
-                       cli->outbuf = (char *)SMB_MALLOC(CLI_SAMBA_MAX_LARGE_READX_SIZE+SAFETY_MARGIN);
 
9
-                       cli->inbuf = (char *)SMB_MALLOC(CLI_SAMBA_MAX_LARGE_READX_SIZE+SAFETY_MARGIN);
 
10
-                       cli->bufsize = CLI_SAMBA_MAX_LARGE_READX_SIZE;
 
11
+                       cli->outbuf = (char *)SMB_MALLOC(CLI_SAMBA_MAX_LARGE_READX_SIZE+LARGE_WRITEX_HDR_SIZE+SAFETY_MARGIN);
 
12
+                       cli->inbuf = (char *)SMB_MALLOC(CLI_SAMBA_MAX_LARGE_READX_SIZE+LARGE_WRITEX_HDR_SIZE+SAFETY_MARGIN);
 
13
+                       cli->bufsize = CLI_SAMBA_MAX_LARGE_READX_SIZE + LARGE_WRITEX_HDR_SIZE;
 
14
                }
 
15
 
 
16
        } else if (cli->protocol >= PROTOCOL_LANMAN1) {