« back to all changes in this revision
Viewing changes to WebCore/ChangeLog
- browse files at revision 1.1.8
- compare with another revision
- download diff
- download tarball
- view history from revision 1.1.8
- Committer: Bazaar Package Importer
- Author(s): Gustavo Noronha Silva
- Date: 2009-05-15 18:30:58 UTC
- mto: (4.4.1 sid) (1.2.2 upstream) (16.1.1 lucid)
- mto: This revision was merged to the branch mainline in revision 8.
- Revision ID: james.westby@ubuntu.com-20090515183058-35m5or0ufm5tutud
Tags: upstream-1.1.7
Import upstream version 1.1.7
- files added:
- JavaScriptCore/assembler/MacroAssemblerX86_64.h
- WebCore/English.lproj
- WebCore/editing/gtk
- files removed:
- WebCore/dom/FormControlElement.cpp
- files modified:
- ChangeLog
added
removed
WebCore/ChangeLog
1
2009-05-13 Darin Adler <darin@apple.com>
2
3
Reviewed by Cameron Zwarich.
4
5
Bug 25674: syntax tree nodes should use arena allocation
6
https://bugs.webkit.org/show_bug.cgi?id=25674
7
8
* bindings/js/JSDOMBinding.h: Removed include of JSFunction.h.
9
We don't want the entire DOM binding to depend on that file.
10
11
* bindings/js/JSAudioConstructor.cpp: Added include of Error.h.
12
Before we inherited this automatically because JDDOMBinding.h
13
included JSFunction.h, but that was excessive.
14
* bindings/js/JSDOMWindowCustom.cpp: Ditto.
15
* bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
16
* bindings/js/JSImageConstructor.cpp: Ditto.
17
* bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
18
* bindings/js/JSMessageChannelConstructor.cpp: Ditto.
19
* bindings/js/JSOptionConstructor.cpp: Ditto.
20
* bindings/js/JSWorkerConstructor.cpp: Ditto.
21
* bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
22
* bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
23
* inspector/InspectorController.cpp: Ditto.
24
25
* inspector/JavaScriptDebugServer.cpp:
26
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
27
Moved mose of this function into the base class in JavaScriptCore,
28
so the details of compilation don't have to be exposed.
29
30
2009-05-13 Douglas R. Davidson <ddavidso@apple.com>
31
32
Reviewed by Darin Adler.
33
34
<rdar://problem/6879145>
35
Generate a contextual menu item allowing autocorrections to
36
easily be changed back. Refrain from re-correcting items
37
that have already been autocorrected once.
38
39
* dom/DocumentMarker.h:
40
* editing/Editor.cpp:
41
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
42
(WebCore::Editor::changeBackToReplacedString):
43
* editing/Editor.h:
44
* page/ContextMenuController.cpp:
45
(WebCore::ContextMenuController::contextMenuItemSelected):
46
* page/mac/WebCoreViewFactory.h:
47
* platform/ContextMenu.cpp:
48
(WebCore::ContextMenu::populate):
49
(WebCore::ContextMenu::checkOrEnableIfNeeded):
50
* platform/ContextMenuItem.h:
51
* platform/LocalizedStrings.h:
52
* platform/mac/LocalizedStringsMac.mm:
53
(WebCore::contextMenuItemTagChangeBack):
54
* rendering/HitTestResult.cpp:
55
(WebCore::HitTestResult::replacedString):
56
* rendering/HitTestResult.h:
57
* rendering/InlineTextBox.cpp:
58
(WebCore::InlineTextBox::computeRectForReplacementMarker):
59
(WebCore::InlineTextBox::paintDocumentMarkers):
60
* rendering/InlineTextBox.h:
61
62
2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
63
64
Rubber Stamped by Oliver Hunt.
65
66
[GTK] Fix Gtk+/X11 build on OSX
67
68
Including the CoreFoundation header here and X11 headers
69
later will result in different definitions of Boolean. The
70
CoreFoundation include does not seem to be necessary here
71
and my mac build was successfull without it. I will remove
72
it for now. If the build bots disagree this will be replaced
73
by a #if PLATFORM(CF).
74
75
* platform/FileSystem.h:
76
77
2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
78
79
Rubber Stamped by Gustavo Noronha.
80
81
[GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX
82
83
When building Gtk+ on OSX we ended up declaring
84
setNPWindowIfNeeded twice. Fix that by moving
85
the #if PLATFORM(GTK) up and using elif instead of
86
else.
87
88
* plugins/PluginView.h:
89
90
2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>
91
92
Reviewed by Xan Lopez.
93
94
https://bugs.webkit.org/show_bug.cgi?id=25685
95
[GTK] Middle click paste form the pasteboard
96
97
The kit wants to paste from at least two different
98
clipboards. By introducing getCurrentTarget to the
99
PasteboardHelper interface we can make this decision
100
in the kit.
101
Use the new method in PasteboardGtk to get the right
102
GdkClipboard for the paste operation.
103
104
* platform/gtk/PasteboardGtk.cpp:
105
(WebCore::Pasteboard::documentFragment):
106
(WebCore::Pasteboard::plainText):
107
* platform/gtk/PasteboardHelper.h:
108
109
2009-05-13 Eric Carlson <eric.carlson@apple.com>
110
111
Reviewed by Darin Adler.
112
113
<rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
114
<rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard
115
116
QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
117
on Tiger or Leopard.
118
119
* html/HTMLMediaElement.cpp:
120
(WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.
121
122
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
123
(WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute
124
when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD.
125
(WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute
126
when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,
127
128
2009-05-12 Roland Steiner <rolandsteiner@google.com>
129
130
Reviewed by Eric Seidel.
131
132
Bug 25738: Skia: CSS border style not cleared for SVG object
133
https://bugs.webkit.org/show_bug.cgi?id=25738
134
135
If no dashing is set, this change reverts to solid stroke
136
(previously the code bailed and left the old setting, whatever it was)
137
138
Test case listed in above bug entry.
139
(Additional complications due to each platform rendering dotted lines differently -
140
c.f. https://bugs.webkit.org/show_bug.cgi?id=25737)
141
142
* platform/graphics/skia/GraphicsContextSkia.cpp:
143
(WebCore::GraphicsContext::setLineDash):
144
145
2009-05-11 Erik Arvidsson <arv@chromium.org>
146
147
Reviewed by Eric Seidel.
148
149
Bug 21903: Adds DOM bindings for the placeholder property of the
150
HTMLInputElement.
151
https://bugs.webkit.org/show_bug.cgi?id=21903
152
153
Test: fast/forms/placeholder-dom-property.html
154
155
* dom/InputElement.cpp:
156
(WebCore::InputElement::updatePlaceholderVisibility):
157
* dom/InputElement.h:
158
* html/HTMLInputElement.cpp:
159
(WebCore::HTMLInputElement::placeholder):
160
(WebCore::HTMLInputElement::setPlaceholder):
161
* html/HTMLInputElement.h:
162
* html/HTMLInputElement.idl:
163
* rendering/RenderTextControlSingleLine.cpp:
164
(WebCore::RenderTextControlSingleLine::updateFromElement):
165
* wml/WMLInputElement.h:
166
(WebCore::WMLInputElement::placeholder):
167
(WebCore::WMLInputElement::setPlaceholder):
168
169
2009-05-12 Adam Barth <abarth@webkit.org>
170
171
Reviewed by Dimitri Glazkov.
172
173
https://bugs.webkit.org/show_bug.cgi?id=25706
174
175
Change V8 bindings to match JSC bindings with respect to using
176
the lexical or dynamic global object.
177
178
Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html
179
http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
180
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html
181
182
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
183
(WebCore::CALLBACK_FUNC_DECL):
184
185
2009-03-19 Oliver Hunt <oliver@apple.com>
186
187
Reviewed by Darin Adler.
188
189
<rdar://problem/6702386> Incorrect bound check in SVGList::insertItemBefore
190
191
SVGList::insertItemBefore would not perform a bounds check on the
192
index it was provided, potentially leading to a buffer overflow.
193
194
Test: svg/dom/svglist-exception-on-out-bounds-error.html
195
196
* svg/SVGList.h:
197
(WebCore::SVGList::insertItemBefore):
198
199
2009-05-12 Paul Godavari <paul@chromium.org>
200
201
Reviewed by Dimitri Glazkov.
202
203
Bug 25708: Cannot choose menu items in popups with many entries in Chromium
204
https://bugs.webkit.org/show_bug.cgi?id=25708
205
206
This change sets the window size for popups on Mac to include all items
207
in the menu. This is required for hit testing on Mac, where we use native
208
controls to manage the popups and don't want to artificially limit the
209
valid hit testing region to a limited scroll window.
210
211
* platform/chromium/PopupMenuChromium.cpp:
212
(WebCore::PopupListBox::layout):
213
214
2009-05-12 Stephen White <senorblanco@chromium.org>
215
216
Reviewed by Dimitri Glazkov.
217
218
Fixes to build with latest skia: SkTypeface::Create() is now
219
SkTypeface::CreateFromName(); computeBounds() has been reworked
220
as getBounds(). The changes are placed behind an #ifdef for now,
221
so that we can roll back the skia version in Chromium if necessary
222
without having to roll back this change.
223
224
https://bugs.webkit.org/show_bug.cgi?id=25705
225
226
* platform/graphics/chromium/FontCacheLinux.cpp:
227
(WebCore::FontCache::createFontPlatformData):
228
* platform/graphics/skia/PathSkia.cpp:
229
(WebCore::Path::boundingRect):
230
(WebCore::boundingBoxForCurrentStroke):
231
* platform/graphics/skia/SkiaUtils.cpp:
232
(WebCore::SkPathContainsPoint):
233
234
2009-05-12 Nate Chapin <japhet@google.com>
235
236
Reviewed by Dimitri Glazkov.
237
238
https://bugs.webkit.org/show_bug.cgi?id=25732
239
Update V8ElementCustom.cpp to match the current API of V8Proxy.
240
241
(WebCore::ACCESSOR_SETTER): Change retrieveActiveFrame() to retrieveFrameForEnteredContext().
242
243
2009-05-12 Alexey Proskuryakov <ap@webkit.org>
244
245
Reviewed by Darin Adler.
246
247
https://bugs.webkit.org/show_bug.cgi?id=25694
248
HTMLParser::createHead() ASSERT: Creating an element, calling document.open() and writing
249
to the document NULL ptr
250
251
Test: fast/parser/implicit-head-in-fragment-crash.html
252
253
* html/HTMLParser.cpp: (WebCore::HTMLParser::bodyCreateErrorCheck): Do not try to implicitly
254
create <head> when parsing a fragment.
255
256
2009-05-12 Soren Gjesse <sgjesse@chromium.org>
257
258
Reviewed by Dimitri Glazkov.
259
260
https://bugs.webkit.org/show_bug.cgi?id=25687
261
Missing check for valid function in V8 bindings for toString function for event listeners.
262
263
* bindings/v8/V8LazyEventListener.cpp:
264
(WebCore::V8LazyEventListener::getWrappedListenerFunction): Added empty handle checks.
265
266
2009-05-11 Yael Aharon <yael.aharon@nokia.com>
267
268
Reviewed by Holger Freyther.
269
270
Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
271
Not doing that can cause assersion failure.
272
https://bugs.webkit.org/show_bug.cgi?id=25702
273
274
* plugins/qt/PluginViewQt.cpp:
275
(WebCore::PluginView::stop):
276
277
2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
278
279
Reviewed by Holger Freyther.
280
281
Bug 25714: [Qt] Decouple HTML5 Database support from the
282
SQLite/generic database support in the Qt port
283
284
<https://bugs.webkit.org/show_bug.cgi?id=25714>
285
286
* WebCore.pro:
287
288
2009-05-11 Chris Fleizach <cfleizach@apple.com>
289
290
Reviewed by Beth Dakin.
291
292
Bug 25713: AX: Control Elements not identified in HTML content
293
https://bugs.webkit.org/show_bug.cgi?id=25713
294
295
Test: accessibility/onclick-handlers.html
296
297
* page/AccessibilityRenderObject.cpp:
298
(WebCore::AccessibilityRenderObject::mouseButtonListener):
299
300
2009-05-11 Darin Adler <darin@apple.com>
301
302
Reviewed by Dan Bernstein.
303
304
<rdar://problem/6276843> REGRESSION: TextIterator generates
305
an extra newline for ranges that start outside of body
306
307
* editing/TextIterator.cpp:
308
(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
309
Check startPos for null, not just currPos.
310
311
2009-05-11 Chris Fleizach <cfleizach@apple.com>
312
313
Reviewed by Darin Adler.
314
315
Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail
316
https://bugs.webkit.org/show_bug.cgi?id=25700
317
318
Keyboard selection movement handlers need to also watch for the Cmd key when Accessibility is enabled.
319
Note: This code is only used when accessibility is enabled.
320
321
* page/EventHandler.cpp:
322
(WebCore::EventHandler::handleKeyboardSelectionMovement):
323
324
2009-05-11 David Kilzer <ddkilzer@apple.com>
325
326
Bug 25087: Test for ENABLE_FOO macros consistently in IDL files
327
328
<https://bugs.webkit.org/show_bug.cgi?id=25087>
329
330
Reviewed by Timothy Hatcher.
331
332
Change tests for ENABLE macros to check for both existence and
333
value:
334
335
- Negative: #if !defined(ENABLE_FOO) || !ENABLE_FOO
336
- Positive: #if defined(ENABLE_FOO) && ENABLE_FOO
337
338
* css/CSSCharsetRule.idl:
339
* css/CSSPrimitiveValue.idl:
340
* css/RGBColor.idl:
341
* dom/Attr.idl:
342
* dom/DOMCoreException.idl:
343
* dom/DOMImplementation.idl:
344
* dom/Document.idl:
345
* dom/Element.idl:
346
* dom/Event.idl:
347
* dom/EventException.idl:
348
* dom/KeyboardEvent.idl:
349
* dom/MessagePort.idl:
350
* dom/MouseEvent.idl:
351
* dom/Node.idl:
352
* dom/ProcessingInstruction.idl:
353
* dom/Range.idl:
354
* dom/RangeException.idl:
355
* dom/WheelEvent.idl:
356
* html/CanvasPixelArray.idl:
357
* html/HTMLAnchorElement.idl:
358
* html/HTMLAppletElement.idl:
359
* html/HTMLAreaElement.idl:
360
* html/HTMLBaseFontElement.idl:
361
* html/HTMLCanvasElement.idl:
362
* html/HTMLDocument.idl:
363
* html/HTMLElement.idl:
364
* html/HTMLEmbedElement.idl:
365
* html/HTMLFrameElement.idl:
366
* html/HTMLIFrameElement.idl:
367
* html/HTMLImageElement.idl:
368
* html/HTMLInputElement.idl:
369
* html/HTMLLinkElement.idl:
370
* html/HTMLObjectElement.idl:
371
* html/HTMLOptionElement.idl:
372
* html/HTMLOptionsCollection.idl:
373
* html/HTMLSelectElement.idl:
374
* html/HTMLStyleElement.idl:
375
* html/ImageData.idl:
376
* inspector/InspectorController.idl:
377
* loader/appcache/DOMApplicationCache.idl:
378
* page/Console.idl:
379
* page/Coordinates.idl:
380
* page/DOMSelection.idl:
381
* page/DOMWindow.idl:
382
* page/Geoposition.idl:
383
* page/History.idl:
384
* page/Location.idl:
385
* page/Navigator.idl:
386
* svg/SVGElementInstance.idl:
387
* svg/SVGException.idl:
388
* workers/WorkerContext.idl:
389
* xml/XMLHttpRequestException.idl:
390
* xml/XPathException.idl:
391
392
2009-05-11 Norbert Leser <norbert.leser@nokia.com>
393
394
Reviewed by Darin Adler.
395
396
Bug 24538: class/struct mixup in forward declarations
397
https://bugs.webkit.org/show_bug.cgi?id=24538
398
399
* inspector/InspectorResource.h:
400
* loader/CachedFont.h:
401
* loader/appcache/ApplicationCache.h:
402
* rendering/RenderBlock.h:
403
* rendering/RootInlineBox.h:
404
* rendering/SVGInlineTextBox.h:
405
* svg/SVGGlyphElement.h:
406
* svg/SVGHKernElement.h:
407
408
2009-05-11 Norbert Leser <norbert.leser@nokia.com>
409
410
Reviewed by Darin Adler.
411
412
Bug 24539: Unresolved CSSMutableStyleDeclaration
413
https://bugs.webkit.org/show_bug.cgi?id=24539
414
415
The Symbian tools can't compile and link this without this include.
416
It's not clear why this is different from other toolsets or why it affects
417
only this header file, but adding the include for now.
418
419
* editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.
420
421
2009-05-11 Alice Liu <alice.liu@apple.com>
422
423
Reviewed by Dan Bernstein.
424
425
https://bugs.webkit.org/show_bug.cgi?id=25701
426
REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook
427
428
Test: fast/forms/search-styled.html
429
430
* css/themeWin.css:
431
Remove the overriding of -webkit-appearance for searchfields. This will cause background
432
images to not be honored when styling searchfields
433
434
* rendering/RenderThemeWin.cpp:
435
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
436
* rendering/RenderThemeWin.h:
437
Re-instate final adjustments to searchfield styling that were removed in r42020
438
439
2009-05-11 Brady Eidson <beidson@apple.com>
440
441
Fix Windows build
442
443
* platform/network/cf/ResourceHandleCFNet.cpp:
444
(WebCore::createCFURLResponseWithDefaultMIMEType):
445
446
2009-05-11 Nate Chapin <japhet@google.com>
447
448
Reviewed by Dimitri Glazkov.
449
450
https://bugs.webkit.org/show_bug.cgi?id=25626
451
Update V8ElementCustom.cpp to match the current API of Node.
452
453
* bindings/v8/custom/V8ElementCustom.cpp:
454
(WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names.
455
(WebCore::ACCESSOR_GETTER): Changed a method name to match current name.
456
457
2009-05-11 Brady Eidson <beidson@apple.com>
458
459
Fix Windows build
460
461
* platform/network/cf/ResourceHandleCFNet.cpp:
462
(WebCore::createCFURLResponseWithDefaultMIMEType):
463
(WebCore::WebCoreSynchronousLoader::load):
464
465
2009-05-11 Brady Eidson <beidson@apple.com>
466
467
Fix Windows build
468
469
* platform/network/cf/ResourceHandleCFNet.cpp:
470
(WebCore::createCFURLResponseWithDefaultMIMEType):
471
472
2009-05-11 Nate Chapin <japhet@google.com>
473
474
Reviewed by Dimitri Glazkov.
475
476
V8CustomBinding.cpp is missing a header file
477
478
https://bugs.webkit.org/show_bug.cgi?id=25644
479
480
* bindings/v8/custom/V8CustomBinding.cpp: Added #include "V8Proxy.h".
481
482
2009-05-11 Aaron Boodman <aa@chromium.org>
483
484
Reviewed by Darin Fisher.
485
486
https://bugs.webkit.org/show_bug.cgi?id=25634
487
Change V8Proxy::retrieveActiveFrame() call sites to V8Proxy::retrieveFrameForEnteredContext().
488
489
Also, change instances of ScriptController::retrieveActiveFrame() to
490
V8::retrieveFrameForEnteredContext() for consistency.
491
492
493
See http://codereview.chromium.org/113085 for the corresponding Chromium change.
494
495
* bindings/v8/custom/V8DOMWindowCustom.cpp:
496
(WebCore::V8Custom::WindowSetLocation):
497
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
498
(WebCore::CALLBACK_FUNC_DECL):
499
* bindings/v8/custom/V8LocationCustom.cpp:
500
(WebCore::navigateIfAllowed):
501
(WebCore::ACCESSOR_SETTER):
502
(WebCore::CALLBACK_FUNC_DECL):
503
504
2009-05-11 Brady Eidson <beidson@apple.com>
505
506
Reviewed by Darin Adler.
507
508
<rdar://problem/5972751> Local image files (BMP, ico) can be misidentified as HTML.
509
510
First part of the fix - Disable content sniffing for file resources which never should've been happening anyways.
511
Second part of the fix - If the networking layer doesn't give us back a MIME type default to "application/octet-stream".
512
513
* platform/MIMETypeRegistry.cpp:
514
(WebCore::defaultMIMEType): "application/octet-stream"
515
* platform/MIMETypeRegistry.h:
516
517
* platform/network/ResourceHandle.cpp:
518
(WebCore::ResourceHandle::create): If content sniffing is true, double check with "shouldContentSniffRequest()" which
519
might override it to false.
520
(WebCore::ResourceHandle::shouldContentSniffURL): Return false for file:// urls, true for everything else.
521
* platform/network/ResourceHandle.h:
522
523
* platform/network/cf/ResourceHandleCFNet.cpp:
524
(WebCore::createCFURLResponseWithDefaultMIMEType): Create a copy of the CFURLRequest with the default MIME type instead
525
of null.
526
(WebCore::didReceiveResponse): If the MIME type for the response is null, create a copy with the default MIME type.
527
(WebCore::WebCoreSynchronousLoader::load): Use shouldContentSniffRequest() to make synchronous loads have the same
528
sniffing policy as asynchronous loads. Also, correct a null MIME type by creating a copy with the default type.
529
530
* platform/network/mac/ResourceHandleMac.mm:
531
(WebCore::ResourceHandle::loadResourceSynchronously): Use shouldContentSniffRequest() to make synchronous loads have the
532
same sniffing policy as asynchronous loads.
533
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Set up the [NSURLResponse MIMEType] swizzling if
534
it hasn't been set up yet.
535
(_web_NSURLResponse_MIMEType): Either return the actual MIME type of the response, or the default MIME type if it's nil.
536
537
* xml/XMLHttpRequest.cpp:
538
(WebCore::XMLHttpRequest::loadRequestAsynchronously): Remove the workaround added in r29370 as it will now be covered by
539
the new mechanism.
540
541
2009-05-11 David Kilzer <ddkilzer@apple.com>
542
543
Fix typo "APPLICATION_CAHE_DYNAMIC_ENTRIES" to "APPLICATION_CACHE_DYNAMIC_ENTRIES"
544
545
This was added in r39816 to disable dynamic entries. They are
546
still disabled after fixing the typo since this feature define
547
is never set anywhere.
548
549
* bindings/js/JSDOMApplicationCacheCustom.cpp:
550
* loader/appcache/DOMApplicationCache.idl:
551
552
2009-05-11 Dmitry Titov <dimich@chromium.org>
553
554
Reviewed by Alexey Proskuryakov and Adam Roben.
555
556
https://bugs.webkit.org/show_bug.cgi?id=25348
557
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
558
559
Most of the change is in WTF.
560
Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
561
method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
562
is now a class rather then an integer.
563
Also, there is no need to initialize threadID in constructors to 0 now.
564
565
* dom/XMLTokenizerLibxml2.cpp:
566
(WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
567
since now ThreadIdentifier needs construction and we avoid having global initializers.
568
(WebCore::matchFunc): use the new accessor function.
569
(WebCore::openFunc): ditto.
570
(WebCore::createStringParser): ditto.
571
(WebCore::createMemoryParser): ditto.
572
* loader/icon/IconDatabase.cpp:
573
(WebCore::IconDatabase::open):
574
* platform/sql/SQLiteDatabase.cpp:
575
(WebCore::SQLiteDatabase::SQLiteDatabase):
576
(WebCore::SQLiteDatabase::close):
577
* storage/DatabaseThread.cpp:
578
(WebCore::DatabaseThread::start):
579
(WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
580
* storage/LocalStorageThread.cpp:
581
(WebCore::LocalStorageThread::start):
582
(WebCore::LocalStorageThread::scheduleImport):
583
(WebCore::LocalStorageThread::scheduleSync):
584
(WebCore::LocalStorageThread::terminate):
585
* workers/WorkerThread.cpp:
586
(WebCore::WorkerThread::start):
587
(WebCore::WorkerThread::WorkerThread):
588
(WebCore::WorkerThread::start):
589
590
2009-05-11 Brady Eidson <beidson@apple.com>
591
592
Reviewed by Darin Adler.
593
594
Remove unused header that declared one function which was never defined anywhere.
595
596
* WebCore.vcproj/WebCore.vcproj:
597
* platform/network/cf/ResourceResponseCFNet.cpp: Change to include ResourceResponse.h (which really means
598
platform/network/cf/ResourceResponse.h)
599
* platform/network/cf/ResourceResponseCFNet.h: Removed.
600
601
2009-05-11 Dimitri Glazkov <dglazkov@chromium.org>
602
603
Reviewed by Timothy Hatcher.
604
605
https://bugs.webkit.org/show_bug.cgi?id=25213
606
Fix assert during Inspector destruction.
607
608
* inspector/InspectorController.cpp:
609
(WebCore::InspectorController::inspectedPageDestroyed): Moved closing
610
inspector above removing InspectorController object to fix JS errors,
611
added clearing inspector page ptr.
612
613
2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
614
615
Reviewed by Holger Freyther.
616
617
[Qt] Make sure that public APIs are properly exported on all Qt platforms
618
https://bugs.webkit.org/show_bug.cgi?id=25601
619
620
* WebCore.pro: Define QT_MAKEDLL for all non-static builds, not just for win
621
622
2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
623
624
Reviewed by Holger Freyther.
625
626
https://bugs.webkit.org/show_bug.cgi?id=24284
627
628
* WebCore.pro: duplicated values removed from INCLUDEPATH
629
630
2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
631
632
Reviewed by Eric Seidel.
633
634
Build fix Symbian; clean Up WebKit/Qt if ENABLE_NETSCAPE_PLUGIN_API=0
635
https://bugs.webkit.org/show_bug.cgi?id=24688
636
637
* WebCore.pro: Use platform independent plugin stubs if ENABLE_NETSCAPE_PLUGIN_API=0
638
* platform/qt/TemporaryLinkStubs.cpp: Remove stub functions for plugins
639
640
2009-05-10 Dan Bernstein <mitz@apple.com>
641
642
Reviewed by Darin Adler.
643
644
- fix a crash when deactivating a document that had adopted a <form>
645
element
646
647
Test: fast/dom/HTMLFormElement/document-deactivation-callback-crash.html
648
649
* html/HTMLFormElement.cpp:
650
(WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Corrected the
651
logic here: <form> elements should be registered for document activation
652
callbacks if and only if autocomplete is off.
653
654
2009-05-10 Alexey Proskuryakov <ap@webkit.org>
655
656
Reviewed by Dan Bernstein.
657
658
<rdar://problem/6867598> REGRESSION (r42483): Have to enter credentials twice when trying
659
to view protected MobileMe video
660
661
Add a temporary workaround.
662
663
* platform/network/ResourceHandleInternal.h:
664
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
665
Added an m_useSiteSpecificQuirks boolean (Mac-only). A Frame pointer is only available when
666
starting a request, so we need to store this data for later use.
667
668
* platform/network/mac/ResourceHandleMac.mm:
669
(WebCore::ResourceHandle::start): Initialize m_useSiteSpecificQuirks.
670
(WebCore::ResourceHandle::receivedCredential): Use per-session credentials with gallery.me.com.
671
672
2009-05-10 Alexey Proskuryakov <ap@webkit.org>
673
674
Reviewed by Dan Bernstein.
675
676
<rdar://problem/6870383> Have to enter credentials twice when downloading from a protected page
677
678
* platform/network/cf/AuthenticationCF.cpp:
679
* platform/network/cf/AuthenticationCF.h:
680
(WebCore::WebCoreCredentialStorage::set):
681
(WebCore::WebCoreCredentialStorage::get):
682
* platform/network/cf/ResourceHandleCFNet.cpp:
683
Move WebCore credential storage to AuthenticationCF, so that WebKit could use it (macthing
684
an earlier Mac change).
685
686
2009-05-10 Alexey Proskuryakov <ap@webkit.org>
687
688
Reviewed by Dan Bernstein.
689
690
Match newer XMLHttpRequest draft and make withCredential setter raise an exception when
691
called at a wrong time.
692
693
No test, because we are waiting for a newer version of system frameworks to test the attribute.
694
695
* xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setWithCredentials):
696
* xml/XMLHttpRequest.h:
697
* xml/XMLHttpRequest.idl:
698
Raise INVALID_STATE_ERR if the state is not OPENED, or if the send() flag is true.
699
700
2009-05-10 Dan Bernstein <mitz@apple.com>
701
702
Reviewed by Dave Kilzer.
703
704
- fix https://bugs.webkit.org/show_bug.cgi?id=25602
705
REGRESSION: fast/overflow/overflow-focus-ring.html seems double-drawn
706
on ToT
707
708
Test: fast/layers/self-painting-outline.html
709
710
* rendering/RenderLayer.cpp:
711
(WebCore::RenderLayer::paintLayer): Paint the layer's own outline only
712
if it is a self-painting layer.
713
714
2009-05-09 Dan Bernstein <mitz@apple.com>
715
716
Reviewed by Geoffrey Garen and Mark Rowe.
717
718
- fix https://bugs.webkit.org/show_bug.cgi?id=25666
719
Assertion failure in Node::setDocument()
720
(willMoveToNewOwnerDocumentWasCalled) when adopting a <form> element
721
722
Test: fast/dom/HTMLFormElement/adopt-assertion.html
723
724
* html/HTMLFormElement.cpp:
725
(WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Overrides of
726
this method are required to call the base class implementation. Do it.
727
(WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto.
728
729
2009-03-29 Kevin Ollivier <kevino@theolliviers.com>
730
731
Reviewed by Maciej Stachowiak.
732
733
WebCore::DocumentLoader::mainReceivedError now asserts if error.isNull(), so
734
make sure CURL does not create empty ResourceError() objects.
735
736
https://bugs.webkit.org/show_bug.cgi?id=24927
737
738
* platform/network/curl/ResourceHandleManager.cpp:
739
(WebCore::ResourceHandleManager::downloadTimerCallback):
740
741
2009-05-09 Gustavo Noronha Silva <gns@gnome.org>
742
743
Build fix, adding missing files to make dist.
744
745
* GNUmakefile.am:
746
747
2009-05-08 Simon Fraser <simon.fraser@apple.com>
748
749
Reviewed by Dan Bernstein
750
751
https://bugs.webkit.org/show_bug.cgi?id=25656
752
753
Reduce the inline capacity of CSSParserValueList's m_values
754
vector to reduce the size of CSSParserValueList from 544 to 160 bytes in 64-bit.
755
756
* css/CSSParserValues.h:
757
758
2009-05-08 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
759
760
Not reviewed. Used sort-Xcode-project-file to sort the XCode project file - it hasn't been done for a while.
761
762
* WebCore.xcodeproj/project.pbxproj:
763
764
2009-05-08 Dan Bernstein <mitz@apple.com>
765
766
Reviewed by Darin Adler.
767
768
- fix <rdar://problem/6864786> REGRESSION: Crash below
769
ApplyStyleCommand::applyInlineStyleToRange when reviewing a patch in
770
Bugzilla
771
772
Test: editing/style/apply-through-end-of-document.html
773
774
* editing/ApplyStyleCommand.cpp:
775
(WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null
776
check for the case of a range extending through the end of the document,
777
in which pastEndNode is 0.
778
779
2009-05-08 Douglas R. Davidson <ddavidso@apple.com>
780
781
Reviewed by Beth Dakin.
782
783
<rdar://problem/6857446> REGRESSION (Safari 3-4): Contraction base
784
marked as misspelled even though contraction is a word
785
Make sure spelling underline does not persist on words like
786
<doesn't>.
787
788
* editing/TypingCommand.cpp:
789
(WebCore::TypingCommand::typingAddedToOpenCommand):
790
791
2009-05-08 Kevin Watters <kevinwatters@gmail.com>
792
793
Reviewed by Kevin Ollivier.
794
795
Make sure the path's refdata isn't deleted before we're done with the object.
796
797
https://bugs.webkit.org/show_bug.cgi?id=25652
798
799
* platform/graphics/wx/PathWx.cpp:
800
(WebCore::Path::~Path):
801
(WebCore::Path::Path):
802
(WebCore::Path::translate):
803
804
2009-05-08 Kevin Watters <kevinwatters@gmail.com>
805
806
Reviewed by Darin Adler.
807
808
Fix for memory leak on Mac.
809
810
https://bugs.webkit.org/show_bug.cgi?id=25650
811
812
* platform/wx/wxcode/mac/carbon/fontprops.cpp:
813
(wxFontProperties::wxFontProperties):
814
815
2009-05-08 Beth Dakin <bdakin@apple.com>
816
817
Reviewed by Dan Bernstein.
818
819
<rdar://problem/6857446> REGRESSION (r37591): Cannot print or
820
preview from maps.yandex.ru
821
822
We need to fall into the stretchesToViewHeight() quirk when we are
823
printing and we are the root and the root has percentage height OR
824
when we are the body and the root has percentage height. Otherwise
825
we have a height of 0 and can run into painting troubles.
826
827
* rendering/RenderBox.cpp:
828
(WebCore::RenderBox::calcHeight):
829
830
2009-05-08 Douglas Davidson <ddavidso@apple.com>
831
832
Reviewed by Darin Adler.
833
834
Fixes for <rdar://problem/6852771>.
835
Prevent text checking replacement immediately after an apostrophe
836
and automatic link addition except immediately after typing.
837
838
* editing/Editor.cpp:
839
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
840
841
2009-05-08 Eric Carlson <eric.carlson@apple.com>
842
843
Reviewed by Darin Adler.
844
845
https://bugs.webkit.org/show_bug.cgi?id=25627
846
Bug 25627: HTMLMediaElement: some errors should fire on <source> elements
847
848
Update for HTML5 spec change to fire 'error' events on <source> element
849
when there is a failure while processing/loading a <source>.
850
851
Test: media/video-source-error.html
852
853
* html/HTMLMediaElement.cpp:
854
(WebCore::HTMLMediaElement::enqueueEvent): Remove white-space.
855
(WebCore::HTMLMediaElement::loadInternal): Call cancelPendingEventsAndCallbacks instead
856
of just calling m_pendingEvents.clear() as we now also need to cancel pending errors on
857
all <source> element.
858
(WebCore::HTMLMediaElement::selectMediaResource): Call isSafeToLoadURL() here instead of in
859
loadResource() as we need to report errors differently depending on the type of failure. Use
860
KURL instead of String.
861
(WebCore::HTMLMediaElement::loadNextSourceChild): nextSourceChild -> selectNextSourceChild.
862
Fail silently when there are no more <source> canditates because that is what spec mandates.
863
Keep url as KURL instead of converting to String.
864
(WebCore::HTMLMediaElement::loadResource): ASSERT that the URL is safe to load as we now
865
assume the safety check now done before this function. Takes KURL instead of String.
866
(WebCore::HTMLMediaElement::isSafeToLoadURL): New, checks to see if a url is safe to load, logs
867
failure if not.
868
(WebCore::HTMLMediaElement::noneSupported): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
869
(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks): New, clear all events pending on
870
the media and all source elements.
871
(WebCore::HTMLMediaElement::setNetworkState): Fire an error on the source element when the
872
the failure happened while processing one. Only call nonSupported() when the failure happened
873
while processing media element 'src' attribute.
874
(WebCore::HTMLMediaElement::havePotentialSourceChild): nextSourceChild -> selectNextSourceChild.
875
Deal with selectNextSourceChild returning a KURL instead of a String.
876
(WebCore::HTMLMediaElement::selectNextSourceChild): Renamed from nextSourceChild, add optional
877
param to control whether or not errors are fired on a source element when it will not be used.
878
Check safety of url here instead of waiting until loadResource(). Return a KURL instead of a
879
String.
880
(WebCore::HTMLMediaElement::initialURL): nextSourceChild -> selectNextSourceChild. Keep url as
881
a KURL instead of a String.
882
* html/HTMLMediaElement.h:
883
(WebCore::HTMLMediaElement::):
884
885
* html/HTMLSourceElement.cpp:
886
(WebCore::HTMLSourceElement::HTMLSourceElement): Initialize timer related variables.
887
(WebCore::HTMLSourceElement::scheduleErrorEvent): New, start one-shot timer to fire an error
888
event ASAP.
889
(WebCore::HTMLSourceElement::cancelPendingErrorEvent): New, cancel pending error event.
890
(WebCore::HTMLSourceElement::errorEventTimerFired): New, fire error event if it has not been
891
cancelled.
892
* html/HTMLSourceElement.h:
893
894
* html/MediaError.h:
895
(WebCore::MediaError::): MEDIA_ERR_NONE_SUPPORTED -> MEDIA_ERR_SRC_NOT_SUPPORTED
896
* html/MediaError.idl: Ditto
897
898
2009-05-08 Dan Bernstein <mitz@apple.com>
899
900
Reviewed by Maciej Stachowiak.
901
902
- fix <rdar://problem/6859955> Undoing typed text after selecting all
903
leaves non-text areas highlighted
904
905
Test: fast/repaint/selection-clear.html
906
907
When RenderView::clearSelection() is called from
908
SelectionController::nodeWillBeRemoved(), selected renderers may already
909
be marked for layout, which means that they can no longer compute
910
their selection repaint info. Instead, an empty IntRect (or GapRects) is
911
returned, leading to incomplete repaint.
912
913
The fix is not to rely on individual renderers when clearing the
914
selection, but instead, cache the bounding rectangle of the selected
915
blocks' GapRects when setting the selection, and invalidate that
916
entire rectangle when clearing it.
917
918
* rendering/RenderView.cpp:
919
(WebCore::RenderView::setSelection): Added a parameter saying whether
920
the repainting of selected blocks should include both
921
previously-selected areas and newly-selected areas or only
922
newly-selected areas. The default is both. Also compute
923
m_cachedSelectionBounds to be the bounding rectangle of the
924
new selection's BlockSelectionInfos' GapRects.
925
(WebCore::RenderView::clearSelection): Repaint m_cachedSelectionBounds,
926
and tell setSelection() that it should not paint areas that were in
927
the old selection's BlockSelectionInfos' GapRects.
928
* rendering/RenderView.h:
929
(WebCore::RenderView::):
930
931
2009-05-08 Alexey Proskuryakov <ap@webkit.org>
932
933
Reviewed by Maciej Stachowiak.
934
935
<rdar://problem/6868773> NPN_GetAuthenticationInfo does not work with non-permanent credentials
936
937
* WebCore.base.exp:
938
* platform/network/mac/AuthenticationMac.h:
939
(WebCore::WebCoreCredentialStorage::set):
940
(WebCore::WebCoreCredentialStorage::get):
941
* platform/network/mac/AuthenticationMac.mm:
942
* platform/network/mac/ResourceHandleMac.mm:
943
Moved WebCoreCredentialStorage to AuthenticationMac, so that it could be used from WebKit.
944
945
2009-05-08 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
946
947
Reviewed by Simon Hausmann.
948
949
Fix the Qt build, add missing JSC_HOST_CALL macros to the runtime
950
call methods.
951
952
* bridge/qt/qt_runtime.h:
953
954
2009-05-08 Jan Michael Alonzo <jmalonzo@webkit.org>
955
956
Reviewed by Mark Rowe.
957
958
Add missing strings to localizedStrings.js
959
https://bugs.webkit.org/show_bug.cgi?id=25635
960
961
Add the strings "Delete", "Key", "Refresh" and "Value".
962
963
* English.lproj/localizedStrings.js:
964
965
2009-05-08 Robert Hogan <robert@roberthogan.net>
966
967
Reviewed, tweaked and landed by Alexey Proskuryakov.
968
969
https://bugs.webkit.org/show_bug.cgi?id=24992
970
[Qt] crash at http://browserspy.dk/browser.php
971
972
This cannot be easily tested in DRT, because it relies on interaction with QApplication,
973
but the added assertions guard against re-introducing this issue.
974
975
* loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): Don't make client calls
976
while the frame is being constructed, because the intermediate state without a document
977
is something we don't want to expose.
978
979
* page/Frame.cpp:
980
(WebCore::Frame::setJSStatusBarText): Assert that the frame has a document, which is an
981
approximation of it being in a consistent state for client calls.
982
(WebCore::Frame::setJSDefaultStatusBarText): Ditto.
983
984
2009-05-07 Mark Rowe <mrowe@apple.com>
985
986
Rubber-stamped by Oliver Hunt.
987
988
Fix <https://bugs.webkit.org/show_bug.cgi?id=25640>.
989
Bug 25640: Crash on quit in r43384 nightly build on Leopard w/ Safari 4 beta installed
990
991
Roll out r43366 as it removed symbols that Safari 4 Beta uses.
992
993
* dom/XMLTokenizerLibxml2.cpp:
994
(WebCore::matchFunc):
995
(WebCore::openFunc):
996
(WebCore::createStringParser):
997
(WebCore::createMemoryParser):
998
* loader/icon/IconDatabase.cpp:
999
(WebCore::IconDatabase::open):
1000
* platform/sql/SQLiteDatabase.cpp:
1001
(WebCore::SQLiteDatabase::SQLiteDatabase):
1002
(WebCore::SQLiteDatabase::close):
1003
* storage/DatabaseThread.cpp:
1004
(WebCore::DatabaseThread::DatabaseThread):
1005
(WebCore::DatabaseThread::start):
1006
(WebCore::DatabaseThread::databaseThread):
1007
* storage/LocalStorageThread.cpp:
1008
(WebCore::LocalStorageThread::LocalStorageThread):
1009
(WebCore::LocalStorageThread::start):
1010
(WebCore::LocalStorageThread::localStorageThread):
1011
(WebCore::LocalStorageThread::scheduleImport):
1012
(WebCore::LocalStorageThread::scheduleSync):
1013
(WebCore::LocalStorageThread::terminate):
1014
* workers/WorkerThread.cpp:
1015
(WebCore::WorkerThread::WorkerThread):
1016
(WebCore::WorkerThread::start):
1017
1018
2009-05-08 Xan Lopez <xlopez@igalia.com>
1019
1020
Reviewed by Gustavo Noronha.
1021
1022
Unify scrolling code via adjustments and keys. Use the WebCore
1023
defined constants, since that's what people are most used to at
1024
this point.
1025
1026
* platform/gtk/ScrollViewGtk.cpp:
1027
(WebCore::ScrollView::platformHandleHorizontalAdjustment):
1028
(WebCore::ScrollView::platformHandleVerticalAdjustment):
1029
1030
2009-05-07 David Levin <levin@chromium.org>
1031
1032
Reviewed by NOBODY.
1033
Suggested by Oliver Hunt.
1034
1035
Rolling back http://trac.webkit.org/changeset/43385
1036
because we have to use mac artwork for the underline on OSX.
1037
1038
* platform/graphics/cg/GraphicsContextCG.cpp:
1039
* platform/graphics/mac/GraphicsContextMac.mm:
1040
(WebCore::createPatternColor):
1041
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
1042
* platform/graphics/win/GraphicsContextCGWin.cpp:
1043
(WebCore::setCGStrokeColor):
1044
(WebCore::spellingPatternColor):
1045
(WebCore::grammarPatternColor):
1046
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
1047
1048
2009-05-07 John Grabowski <jrg@chromium.org>
1049
1050
Reviewed by Simon Fraser.
1051
1052
https://bugs.webkit.org/show_bug.cgi?id=25573
1053
Unify use of CG-common routine for drawLineForMisspellingOrBadGrammar.
1054
Cleanup for WebKit, but required for Chromium happiness.
1055
1056
* platform/graphics/cg/GraphicsContextCG.cpp:
1057
(WebCore::spellingPatternColor):
1058
(WebCore::grammarPatternColor):
1059
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
1060
* platform/graphics/mac/GraphicsContextMac.mm:
1061
* platform/graphics/win/GraphicsContextCGWin.cpp:
1062
1063
2009-05-07 Darin Adler <darin@apple.com>
1064
1065
Reviewed by Simon Fraser.
1066
1067
Bug 25575: Registered mutation event listener crashes HTMLMediaElement
1068
https://bugs.webkit.org/show_bug.cgi?id=25575
1069
1070
Test: fast/media/video-controls-with-mutation-event-handler.html
1071
1072
* rendering/MediaControlElements.cpp:
1073
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Don't call setAttribute.
1074
* rendering/RenderMedia.cpp:
1075
(WebCore::RenderMedia::createTimeline): Call setAttribute here.
1076
1077
2009-05-07 Simon Fraser <simon.fraser@apple.com>
1078
1079
Rubber Stamped by Dave Hyatt
1080
1081
Shuffle the data members to minimize padding.
1082
1083
* rendering/RenderTableSection.cpp:
1084
(WebCore::RenderTableSection::RenderTableSection):
1085
* rendering/RenderTableSection.h:
1086
1087
2009-05-07 Simon Fraser <simon.fraser@apple.com>
1088
1089
Rubber Stamped by Dave Hyatt
1090
1091
Shuffle the data members to make Events 8 bytes smaller in 64-bit.
1092
1093
* dom/Event.cpp:
1094
(WebCore::Event::Event):
1095
* dom/Event.h:
1096
1097
2009-05-07 Eric Seidel <eric@webkit.org>
1098
1099
Reviewed by Beth Dakin.
1100
1101
Fix regression caused by r41469, add test case to prevent it from
1102
happening again.
1103
https://bugs.webkit.org/show_bug.cgi?id=25252
1104
1105
hasLayer() was true during removeOnlyThisLayer()/
1106
updateLayerPositions()
1107
which caused updateLayerPosition()'s walk up the render tree to
1108
include offsets from the layer we were about to remove.
1109
1110
I'm not 100% convinced that this wasn't a bug in
1111
updateLayerPosition() or in RenderBoxModelObject::styleDidChange,
1112
because the layer in question is not the containing block for the
1113
block which gets laid out wrong. But this restores the previous
1114
behavior and adds a test. So the next time someone is in here re-
1115
factoring, they will at least know if they break something.
1116
1117
Test: fast/layers/remove-only-this-layer-update.html
1118
1119
* rendering/RenderBoxModelObject.cpp:
1120
(WebCore::RenderBoxModelObject::destroyLayer):
1121
* rendering/RenderLayer.cpp:
1122
(WebCore::RenderLayer::removeOnlyThisLayer):
1123
* rendering/RenderObject.cpp:
1124
(WebCore::RenderObject::destroy):
1125
* rendering/RenderWidget.cpp:
1126
(WebCore::RenderWidget::destroy):
1127
1128
2009-05-07 Dmitry Titov <dimich@chromium.org>
1129
1130
Attempt to fix GTK build.
1131
1132
* platform/graphics/GlyphPageTreeNode.h: add #include <string.h> to ensure memcpy and memset are defined.
1133
1134
2009-05-07 Oliver Hunt <oliver@apple.com>
1135
1136
Reviewed by Gavin Barraclough.
1137
1138
Improve native call performance
1139
1140
Add calling convention declarations where necessary, and update bindings
1141
script to generate them as well.
1142
1143
* bindings/js/JSHTMLCollectionCustom.cpp:
1144
(WebCore::callHTMLCollection):
1145
* bindings/js/JSNodeListCustom.cpp:
1146
(WebCore::callNodeList):
1147
* bindings/js/JSPluginElementFunctions.cpp:
1148
(WebCore::callPlugin):
1149
* bindings/js/JSQuarantinedObjectWrapper.h:
1150
* bindings/scripts/CodeGeneratorJS.pm:
1151
* bridge/runtime_method.cpp:
1152
(JSC::callRuntimeMethod):
1153
* bridge/runtime_object.cpp:
1154
(JSC::callRuntimeObject):
1155
1156
2009-05-07 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
1157
1158
Reviewed by Dave Hyatt.
1159
1160
Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
1161
1162
Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
1163
1164
Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
1165
gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
1166
1167
The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
1168
This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
1169
To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
1170
methods are renamed to clarify where they belong to. All renames are listed here:
1171
1172
From FormControlElement:
1173
- isEnabled() -> isEnabledFormControl()
1174
- isReadOnly() -> isReadOnlyFormControl()
1175
- isTextControl() -> isTextFormControl()
1176
- valueMatchesRenderer() -> formControlValueMatchesRenderer()
1177
- setValueMatchesRenderer() -> setFormControlValueMatchesRenderer()
1178
- name() -> formControlName()
1179
- type() -> formControlType()
1180
1181
From FormControlElementWithState:
1182
- saveState() -> saveFormControlState()
1183
- restoreState() -> restoreFormControlState()
1184
1185
A lot of Element -> FormControlElement(WithState) casting is gone again, so it's not only a memory, but also a performance progression.
1186
1187
No testcases affected, no new tests needed.
1188
1189
* GNUmakefile.am:
1190
* WebCore.pro:
1191
* WebCore.vcproj/WebCore.vcproj:
1192
* WebCore.xcodeproj/project.pbxproj:
1193
* WebCoreSources.bkl:
1194
* css/CSSStyleSelector.cpp:
1195
(WebCore::CSSStyleSelector::canShareStyleWithElement):
1196
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1197
* dom/Document.cpp:
1198
(WebCore::Document::formElementsState):
1199
* dom/Document.h:
1200
(WebCore::Document::registerFormElementWithState):
1201
(WebCore::Document::unregisterFormElementWithState):
1202
* dom/Element.h:
1203
(WebCore::Element::isFormControlElement):
1204
(WebCore::Element::isEnabledFormControl):
1205
(WebCore::Element::isReadOnlyFormControl):
1206
(WebCore::Element::isTextFormControl):
1207
(WebCore::Element::formControlValueMatchesRenderer):
1208
(WebCore::Element::setFormControlValueMatchesRenderer):
1209
(WebCore::Element::formControlName):
1210
(WebCore::Element::formControlType):
1211
(WebCore::Element::saveFormControlState):
1212
(WebCore::Element::restoreFormControlState):
1213
* dom/FormControlElement.cpp: Removed.
1214
* dom/FormControlElement.h: Removed.
1215
* dom/FormControlElementWithState.cpp: Removed.
1216
* dom/FormControlElementWithState.h: Removed.
1217
* dom/InputElement.cpp:
1218
(WebCore::InputElement::setValueFromRenderer):
1219
* html/HTMLButtonElement.cpp:
1220
(WebCore::HTMLButtonElement::formControlType):
1221
* html/HTMLButtonElement.h:
1222
* html/HTMLFieldSetElement.cpp:
1223
(WebCore::HTMLFieldSetElement::formControlType):
1224
* html/HTMLFieldSetElement.h:
1225
* html/HTMLFormControlElement.cpp:
1226
(WebCore::HTMLFormControlElement::attach):
1227
(WebCore::HTMLFormControlElement::formControlName):
1228
(WebCore::HTMLFormControlElement::willValidate):
1229
(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
1230
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
1231
(WebCore::HTMLFormControlElementWithState::willMoveToNewOwnerDocument):
1232
(WebCore::HTMLFormControlElementWithState::didMoveToNewOwnerDocument):
1233
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
1234
* html/HTMLFormControlElement.h:
1235
(WebCore::HTMLFormControlElement::isTextFormControl):
1236
(WebCore::HTMLFormControlElement::isEnabledFormControl):
1237
(WebCore::HTMLFormControlElement::formControlValueMatchesRenderer):
1238
(WebCore::HTMLFormControlElement::setFormControlValueMatchesRenderer):
1239
(WebCore::HTMLFormControlElement::isReadOnlyFormControl):
1240
(WebCore::HTMLFormControlElement::type):
1241
(WebCore::HTMLFormControlElement::name):
1242
* html/HTMLInputElement.cpp:
1243
(WebCore::HTMLInputElement::formControlName):
1244
(WebCore::HTMLInputElement::formControlType):
1245
(WebCore::HTMLInputElement::saveFormControlState):
1246
(WebCore::HTMLInputElement::restoreFormControlState):
1247
(WebCore::HTMLInputElement::parseMappedAttribute):
1248
(WebCore::HTMLInputElement::detach):
1249
(WebCore::HTMLInputElement::setValue):
1250
(WebCore::HTMLInputElement::setFileListFromRenderer):
1251
* html/HTMLInputElement.h:
1252
(WebCore::HTMLInputElement::readOnly):
1253
(WebCore::HTMLInputElement::isTextFormControl):
1254
* html/HTMLKeygenElement.cpp:
1255
(WebCore::HTMLKeygenElement::formControlType):
1256
* html/HTMLKeygenElement.h:
1257
* html/HTMLLegendElement.cpp:
1258
(WebCore::HTMLLegendElement::formControlType):
1259
* html/HTMLLegendElement.h:
1260
* html/HTMLOptGroupElement.cpp:
1261
(WebCore::HTMLOptGroupElement::formControlType):
1262
* html/HTMLOptGroupElement.h:
1263
* html/HTMLOptionElement.cpp:
1264
(WebCore::HTMLOptionElement::formControlType):
1265
* html/HTMLOptionElement.h:
1266
* html/HTMLSelectElement.cpp:
1267
(WebCore::HTMLSelectElement::formControlType):
1268
(WebCore::HTMLSelectElement::saveFormControlState):
1269
(WebCore::HTMLSelectElement::restoreFormControlState):
1270
* html/HTMLSelectElement.h:
1271
* html/HTMLTextAreaElement.cpp:
1272
(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
1273
(WebCore::HTMLTextAreaElement::formControlType):
1274
(WebCore::HTMLTextAreaElement::saveFormControlState):
1275
(WebCore::HTMLTextAreaElement::restoreFormControlState):
1276
(WebCore::HTMLTextAreaElement::updateValue):
1277
(WebCore::HTMLTextAreaElement::setValue):
1278
* html/HTMLTextAreaElement.h:
1279
(WebCore::HTMLTextAreaElement::readOnly):
1280
(WebCore::HTMLTextAreaElement::isTextFormControl):
1281
* page/AccessibilityRenderObject.cpp:
1282
(WebCore::AccessibilityRenderObject::isEnabled):
1283
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
1284
* page/DragController.cpp:
1285
(WebCore::DragController::concludeEditDrag):
1286
* rendering/RenderMenuList.cpp:
1287
(WebCore::RenderMenuList::itemIsEnabled):
1288
* rendering/RenderTextControl.cpp:
1289
(WebCore::updateUserModifyProperty):
1290
(WebCore::RenderTextControl::setInnerTextValue):
1291
* rendering/RenderTextControl.h:
1292
* rendering/RenderTextControlMultiLine.cpp:
1293
(WebCore::RenderTextControlMultiLine::subtreeHasChanged):
1294
* rendering/RenderTextControlSingleLine.cpp:
1295
(WebCore::RenderTextControlSingleLine::updateFromElement):
1296
* rendering/RenderTheme.cpp:
1297
(WebCore::RenderTheme::isEnabled):
1298
(WebCore::RenderTheme::isReadOnlyControl):
1299
* rendering/RenderThemeChromiumMac.mm:
1300
(WebCore::RenderThemeChromiumMac::adjustMenuListStyle):
1301
* rendering/RenderThemeMac.mm:
1302
(WebCore::RenderThemeMac::adjustMenuListStyle):
1303
* rendering/RenderThemeSafari.cpp:
1304
(WebCore::RenderThemeSafari::adjustMenuListStyle):
1305
* wml/WMLFormControlElement.cpp:
1306
* wml/WMLFormControlElement.h:
1307
(WebCore::WMLFormControlElement::isReadOnlyFormControl):
1308
(WebCore::WMLFormControlElement::isTextFormControl):
1309
(WebCore::WMLFormControlElement::formControlValueMatchesRenderer):
1310
(WebCore::WMLFormControlElement::setFormControlValueMatchesRenderer):
1311
* wml/WMLInputElement.cpp:
1312
(WebCore::WMLInputElement::WMLInputElement):
1313
(WebCore::WMLInputElement::isKeyboardFocusable):
1314
(WebCore::WMLInputElement::isMouseFocusable):
1315
(WebCore::WMLInputElement::dispatchBlurEvent):
1316
(WebCore::WMLInputElement::formControlType):
1317
(WebCore::WMLInputElement::formControlName):
1318
(WebCore::WMLInputElement::setValue):
1319
(WebCore::WMLInputElement::saveFormControlState):
1320
(WebCore::WMLInputElement::restoreFormControlState):
1321
(WebCore::WMLInputElement::parseMappedAttribute):
1322
(WebCore::WMLInputElement::detach):
1323
(WebCore::WMLInputElement::appendFormData):
1324
(WebCore::WMLInputElement::init):
1325
* wml/WMLInputElement.h:
1326
(WebCore::WMLInputElement::isTextFormControl):
1327
* wml/WMLOptGroupElement.cpp:
1328
(WebCore::WMLOptGroupElement::formControlType):
1329
* wml/WMLOptGroupElement.h:
1330
* wml/WMLOptionElement.cpp:
1331
(WebCore::WMLOptionElement::formControlType):
1332
* wml/WMLOptionElement.h:
1333
1334
2009-05-07 Dmitry Titov <dimich@chromium.org>
1335
1336
Reviewed by Alexey Proskuryakov and Adam Roben.
1337
1338
https://bugs.webkit.org/show_bug.cgi?id=25348
1339
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.
1340
1341
Most of the change is in WTF.
1342
Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
1343
method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
1344
is now a class rather then an integer.
1345
Also, there is no need to initialize threadID in constructors to 0 now.
1346
1347
* dom/XMLTokenizerLibxml2.cpp:
1348
(WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id,
1349
since now ThreadIdentifier needs construction and we avoid having global initializers.
1350
(WebCore::matchFunc): use the new accessor function.
1351
(WebCore::openFunc): ditto.
1352
(WebCore::createStringParser): ditto.
1353
(WebCore::createMemoryParser): ditto.
1354
* loader/icon/IconDatabase.cpp:
1355
(WebCore::IconDatabase::open):
1356
* platform/sql/SQLiteDatabase.cpp:
1357
(WebCore::SQLiteDatabase::SQLiteDatabase):
1358
(WebCore::SQLiteDatabase::close):
1359
* storage/DatabaseThread.cpp:
1360
(WebCore::DatabaseThread::start):
1361
(WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
1362
* storage/LocalStorageThread.cpp:
1363
(WebCore::LocalStorageThread::start):
1364
(WebCore::LocalStorageThread::scheduleImport):
1365
(WebCore::LocalStorageThread::scheduleSync):
1366
(WebCore::LocalStorageThread::terminate):
1367
* workers/WorkerThread.cpp:
1368
(WebCore::WorkerThread::start):
1369
(WebCore::WorkerThread::WorkerThread):
1370
(WebCore::WorkerThread::start):
1371
1372
2009-05-07 Simon Fraser <simon.fraser@apple.com>
1373
1374
Rubber Stamped by Dave Hyatt
1375
1376
Shuffle the data members to minimize padding.
1377
1378
* dom/ClassNames.h:
1379
1380
2009-05-07 Simon Fraser <simon.fraser@apple.com>
1381
1382
Reviewed by Darin Adler
1383
1384
<rdar://problem/6864062> Shrink GlyphPage from 4112 to 2576 bytes in 64-bit
1385
https://bugs.webkit.org/show_bug.cgi?id=25605
1386
1387
Shrink GlyphPage by splitting the array of GlyphData, which has lots
1388
of padding, into separate Glyph and SimpleFontData* arrays.
1389
1390
* platform/graphics/Font.h:
1391
glyphDataForCharacter has to return a GlyphData by value now.
1392
1393
* platform/graphics/FontFastPath.cpp:
1394
(WebCore::Font::glyphDataForCharacter):
1395
Return GlyphData by value.
1396
1397
* platform/graphics/GlyphPageTreeNode.cpp:
1398
(WebCore::GlyphPageTreeNode::initializePage):
1399
Better encapsulation of GlyphPage, using the new methods.
1400
1401
* platform/graphics/Font.h:
1402
* platform/graphics/FontFastPath.cpp:
1403
(WebCore::Font::glyphDataForCharacter):
1404
* platform/graphics/GlyphPageTreeNode.cpp:
1405
(WebCore::GlyphPageTreeNode::initializePage):
1406
* platform/graphics/GlyphPageTreeNode.h:
1407
(WebCore::GlyphData::GlyphData):
1408
(WebCore::GlyphPage::indexForCharacter):
1409
(WebCore::GlyphPage::glyphDataForCharacter):
1410
(WebCore::GlyphPage::glyphDataForIndex):
1411
(WebCore::GlyphPage::glyphAt):
1412
(WebCore::GlyphPage::fontDataForCharacter):
1413
(WebCore::GlyphPage::setGlyphDataForCharacter):
1414
(WebCore::GlyphPage::setGlyphDataForIndex):
1415
(WebCore::GlyphPage::copyFrom):
1416
(WebCore::GlyphPage::clear):
1417
1418
2009-05-07 Dimitri Glazkov <dglazkov@chromium.org>
1419
1420
Reviewed by Darin Fisher.
1421
1422
https://bugs.webkit.org/show_bug.cgi?id=25625
1423
Implement Image/Option constructors in V8 bindings.
1424
1425
* bindings/v8/custom/V8DOMWindowCustom.cpp:
1426
(WebCore::NAMED_PROPERTY_GETTER): Removed old JS-based code.
1427
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Added.
1428
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Added.
1429
1430
2009-05-07 Brady Eidson <beidson@apple.com>
1431
1432
I hate myself for doing this, but need to fix that ChangeLog entry.
1433
1434
* ChangeLog:
1435
1436
2009-05-07 Brady Eidson <beidson@apple.com>
1437
1438
Rubberstamped by Darin Adler
1439
1440
* html/HTMLParser.cpp: Use the correct style of BUILDING_ON_* for WebCore.
1441
* html/HTMLParser.h: Ditto
1442
1443
2009-05-07 David Hyatt <hyatt@apple.com>
1444
1445
Restore intrinsic margins to all form controls on Mac and Windows. Some of this regressed in 43007
1446
when textareas were given explicit margins. Some of it had already regressed earlier whenever intrinsic
1447
margins were turned off in themeWin.css.
1448
1449
Reviewed by Beth Dakin.
1450
1451
* css/html4.css:
1452
* css/themeWin.css:
1453
1454
2009-05-07 Brady Eidson <beidson@apple.com>
1455
1456
Reviewed by Darin Adler and Alexey Proskuryakov.
1457
1458
<rdar://problem/6863795> Exception occurs in Mail when attempting to create signatures due to <head> element creation
1459
1460
* dom/Document.cpp:
1461
(WebCore::Document::implicitClose): Check shouldCreateImplicitHead() before creating it.
1462
1463
* html/HTMLParser.cpp:
1464
(WebCore::HTMLParser::handleError): Check shouldCreateImplicitHead() before creating it.
1465
(WebCore::HTMLParser::bodyCreateErrorCheck): Ditto.
1466
(WebCore::shouldCreateImplicitHead): For Tiger/Leopard when running under Mail, the implicit <head> shouldn't be created.
1467
* html/HTMLParser.h:
1468
(WebCore::shouldCreateImplicitHead): Inline implementation for non-Tiger/Leopard platforms
1469
1470
2009-05-07 Antony Sargent <asargent@chromium.org>
1471
1472
Reviewed by Darin Fisher.
1473
1474
Fix a memory leak in V8EventListenerList::remove.
1475
1476
https://bugs.webkit.org/show_bug.cgi?id=25618
1477
1478
No new functionality so no new tests.
1479
1480
* bindings/v8/V8EventListenerList.cpp:
1481
(WebCore::V8EventListenerList::remove):
1482
1483
2009-05-07 Darin Fisher <darin@chromium.org>
1484
1485
Fix Chromium build bustage.
1486
1487
* bindings/v8/custom/V8HTMLFormElementCustom.cpp: Add missing
1488
HTMLCollection.h include.
1489
1490
2009-05-07 Chris Fleizach <cfleizach@apple.com>
1491
1492
Reviewed by Beth Dakin.
1493
1494
Bug 25598: AX: if a radio button has a label and a title, the label is not exposed
1495
https://bugs.webkit.org/show_bug.cgi?id=25598
1496
1497
Test: accessibility/radio-button-title-label.html
1498
1499
* page/AccessibilityObject.h:
1500
(WebCore::AccessibilityObject::exposesTitleUIElement):
1501
* page/AccessibilityRenderObject.cpp:
1502
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):
1503
(WebCore::AccessibilityRenderObject::titleUIElement):
1504
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1505
* page/AccessibilityRenderObject.h:
1506
1507
2009-05-07 Darin Fisher <darin@chromium.org>
1508
1509
Fix Chromium build bustage.
1510
1511
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
1512
(WebCore::INDEXED_PROPERTY_GETTER): ":" should be "::"
1513
1514
2009-05-07 Xan Lopez <xlopez@igalia.com>
1515
1516
Reviewed by Gustavo Noronha.
1517
1518
https://bugs.webkit.org/show_bug.cgi?id=25610
1519
[GTK] text.caretOffset is reportedly always 0
1520
1521
Use the right function to get the caret offset in an
1522
element. selectionStart() would only work for text
1523
controls (there's even an ASSERT when calculating the selected
1524
text range). Instead just get the selection and get the offset of
1525
the start position.
1526
1527
* page/gtk/AccessibilityObjectWrapperAtk.cpp:
1528
1529
2009-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1530
1531
Reviewed by Simon Hausmann.
1532
1533
[Qt] Fix support for antialiased CSS border-radius
1534
1535
WebKit implements border-radius by drawing a double-size border,
1536
and then letting the clip constrain the border to the right width
1537
and position. This requires support for antialiased clipping, as
1538
well as painting, to get a nice smooth border.
1539
1540
Qt only does antialiased clipping if the anti-alias flag is set
1541
at the time of clipping, so we have to enable this in the method
1542
addInnerRoundedRectClip(), as well as when we draw the border.
1543
1544
Currently the raster-engine is the only Qt paint engine to support
1545
anti-aliased clipping, but the OpenGL and Mac paint engines could
1546
potentially support this in the future.
1547
1548
* platform/graphics/qt/GraphicsContextQt.cpp:
1549
(WebCore::GraphicsContext::strokeArc):
1550
(WebCore::GraphicsContext::addInnerRoundedRectClip):
1551
1552
2009-05-07 Adam Langley <agl@google.com>
1553
1554
Reviewed by Eric Seidel.
1555
1556
Render empty optgroup elements.
1557
1558
https://bugs.webkit.org/show_bug.cgi?id=24900
1559
1560
Currently, optgroup elements which are empty are not rendered. The
1561
HTML specification gives no guidance on this situation.
1562
1563
However, the test for being empty is that they have no children, thus
1564
this will not render:
1565
<optgroup label="test"></optgroup>
1566
while this /will/ render (because of the text node child):
1567
<optgroup label="test"> </optgroup>
1568
1569
This patch will cause both cases to render which matches IE's and
1570
Firefox's behaviour.
1571
1572
The difference only appears when opening the select element and does
1573
not appear in the render tree. Thus, a manual layout-test is required.
1574
1575
* html/HTMLSelectElement.cpp:
1576
(WebCore::HTMLSelectElement::recalcListItems):
1577
* manual-tests/optgroup-empty-and-nested.html: Added.
1578
1579
2009-05-06 Julie Parent <jparent@google.com>
1580
1581
Reviewed by Eric Seidel.
1582
1583
Bug 25608: Unused m_frame in ChromiumClipboard.
1584
https://bugs.webkit.org/show_bug.cgi?id=25608
1585
1586
* platform/chromium/ClipboardChromium.h:
1587
1588
No tests added as this is only removing dead code, no functional changes.
1589
1590
2009-05-06 Dan Bernstein <mitz@apple.com>
1591
1592
Reviewed by Simon Fraser and Justin Garcia.
1593
1594
- fix another part of <rdar://problem/6703873> Triple-click quoted line
1595
and type Return creates an extra quoted blank line
1596
1597
Test: editing/inserting/6703873-2.html
1598
1599
* editing/BreakBlockquoteCommand.cpp:
1600
(WebCore::BreakBlockquoteCommand::doApply): Corrected the logic for
1601
determining the first node that should go into the new blockquote
1602
given the split position: if it is at the end of a container, use the
1603
next node after the container. Otherwise, use the child at the
1604
position's offset.
1605
1606
2009-05-06 Kevin Ollivier <kevino@theolliviers.com>
1607
1608
wx build fix, fixes for wx trunk builds.
1609
1610
* platform/graphics/wx/ImageWx.cpp:
1611
(WebCore::BitmapImage::draw):
1612
* platform/wx/RenderThemeWx.cpp:
1613
* platform/wx/wxcode/mac/carbon/fontprops.cpp:
1614
(wxFontProperties::wxFontProperties):
1615
1616
2009-05-06 Albert J. Wong <ajwong@chromium.org>
1617
1618
Reviewed by Darin Fisher.
1619
1620
https://bugs.webkit.org/show_bug.cgi?id=25597
1621
Fix API drift compile errors that occurred while this was ifdef-ed out.
1622
The two big issues were that RenderObject::element() became
1623
RenderObject::node() and some of the wk* drawing functions had
1624
an extra theme parameter added to the argument list.
1625
1626
* rendering/RenderThemeChromiumMac.mm:
1627
(WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
1628
(WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
1629
(WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
1630
(WebCore::RenderThemeChromiumMac::paintMediaSeekBackButton):
1631
(WebCore::RenderThemeChromiumMac::paintMediaSeekForwardButton):
1632
(WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
1633
(WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
1634
1635
2009-05-06 Jian Li <jianli@chromium.org>
1636
1637
Reviewed by Dimitri Glazkov.
1638
1639
https://bugs.webkit.org/show_bug.cgi?id=25385
1640
Upstream changes to V8 bindings for supporting nested workers.
1641
1642
* bindings/v8/WorkerContextExecutionProxy.cpp:
1643
(WebCore::WorkerContextExecutionProxy::ToV8Object):
1644
(WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
1645
* bindings/v8/custom/V8WorkerCustom.cpp:
1646
(WebCore::getEventListener):
1647
(WebCore::ACCESSOR_SETTER WorkerOnmessage):
1648
(WebCore::CALLBACK_FUNC_DECL WorkerAddEventListener):
1649
1650
2009-05-06 Dave Moore <davemoore@google.com>
1651
1652
Reviewed by Dimitri Glazkov.
1653
1654
https://bugs.webkit.org/show_bug.cgi?id=25513
1655
The V8 bindings convert every javascript property to its associated css style
1656
name. It then calls functions that convert that name to an id. This makes
1657
getting or setting css styles on elements slow.
1658
1659
The patch fixes this by caching the results of the transformation, mapping a
1660
javascript property name to its css property id. It then calls the already
1661
public webkit methods that take the id in place of the string property names.
1662
1663
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1664
1665
2009-05-06 Nate Chapin <japhet@google.com>
1666
1667
Reviewed by Dimitri Glazkov.
1668
1669
https://bugs.webkit.org/show_bug.cgi?id=25591
1670
Upstream V8HTMLFormElement from the Chromium repository.
1671
1672
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
1673
(WebCore::INDEXED_PROPERTY_GETTER HTMLFormElement): Upstreamed from Chromium repository
1674
(WebCore::NAMED_PROPERTY_GETTER HTMLFormElement): Changed empty element return case to return notHandledByInterceptor();
1675
(WebCore::CALLBACK_FUNC_DECL HTMLFormElementSubmit): Upstreamed from Chromium repository
1676
1677
2009-05-06 Albert J. Wong <ajwong@chromium.org>
1678
1679
Reviewed by Dimitri Glazkov.
1680
1681
https://bugs.webkit.org/show_bug.cgi?id=25595
1682
Upstream V8CanvasPixelArrayCustom from chromium port tree.
1683
1684
* bindings/v8/V8CanvasPixelArrayCustom.cpp: Added.
1685
1686
2009-05-06 Simon Fraser <simon.fraser@apple.com>
1687
1688
Rubber-stampted by Eric Seidel
1689
1690
Add braces to clarify logic flow in RenderObject::adjustStyleDifference.
1691
Only affects ACCELERATED_COMPOSITING builds.
1692
1693
* rendering/RenderObject.cpp:
1694
(WebCore::RenderObject::adjustStyleDifference):
1695
1696
2009-05-06 Simon Fraser <simon.fraser@apple.com>
1697
1698
Reviewed by Dan Bernstein
1699
1700
<rdar://problem/6862550> Reduce size of RenderText in 64-bit
1701
1702
Rearrange data members of RenderText so that an int comes
1703
first, to minimize padding.
1704
1705
* rendering/RenderText.cpp:
1706
(WebCore::RenderText::RenderText):
1707
* rendering/RenderText.h:
1708
1709
2009-05-06 Simon Fraser <simon.fraser@apple.com>
1710
1711
Reviewed by Dan Bernstein
1712
1713
<rdar://problem/6862823> Reduce size of RenderStyle in 64-bit
1714
1715
Rearrange data members of RenderStyle to minimize padding
1716
when building for 64-bit.
1717
1718
* rendering/style/RenderStyle.cpp:
1719
(WebCore::RenderStyle::RenderStyle):
1720
* rendering/style/RenderStyle.h:
1721
(WebCore::):
1722
1723
2009-05-06 Darin Fisher <darin@chromium.org>
1724
1725
Reviewed by Dimitri Glazkov.
1726
1727
https://bugs.webkit.org/show_bug.cgi?id=25596
1728
1729
Fixes Chromium build bustage caused by r43317 (making
1730
RefCountedBase::m_refCount private)
1731
1732
* page/chromium/AccessibilityObjectWrapper.h:
1733
(WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper):
1734
1735
2009-05-06 Hin-Chung Lam <hclam@chromium.org>
1736
1737
Reviewed by Darin Fisher.
1738
1739
https://bugs.webkit.org/show_bug.cgi?id=25593
1740
1741
Refactor for MediaPlayerPrivate for Chromium port. Remove
1742
the implementation of MediaPlayerPrivateInferface from it.
1743
1744
* platform\graphics\chromium\MediaPlayerPrivateChromium.h:
1745
1746
2009-05-06 Simon Fraser <simon.fraser@apple.com>
1747
1748
Reviewed by Dave Hyatt, Dan Bernstein
1749
1750
<rdar://problem/6860197> Reduce the size of FontFallbackList in 64-bit
1751
1752
Re-order the data members of FontFallbackList to save 8 bytes when building 64-bit.
1753
1754
* platform/graphics/FontFallbackList.cpp:
1755
(WebCore::FontFallbackList::FontFallbackList):
1756
* platform/graphics/FontFallbackList.h:
1757
1758
2009-05-06 Simon Fraser <simon.fraser@apple.com>
1759
1760
Reviewed by Darin Adler, Dan Bernstein
1761
1762
<rdar://problem/6860068> Reduce size of InlineBox in 64-bit
1763
1764
Re-order the data members of InlineBox to save 8 bytes when building 64-bit.
1765
1766
* rendering/InlineBox.h:
1767
(WebCore::InlineBox::InlineBox):
1768
1769
2009-05-06 David Levin <levin@chromium.org>
1770
1771
Reviewed by Dimitri Glazkov.
1772
1773
https://bugs.webkit.org/show_bug.cgi?id=25588
1774
Adding the custom v8 bindings Document.location.
1775
1776
* bindings/v8/custom/V8DocumentLocationCustom.cpp: Added.
1777
1778
2009-05-06 Kevin McCullough <kmccullough@apple.com>
1779
1780
-Clarified a comment
1781
1782
* editing/InsertParagraphSeparatorCommand.cpp:
1783
(WebCore::InsertParagraphSeparatorCommand::doApply):
1784
1785
2009-05-06 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
1786
1787
Not reviewed. Fix WML enabled builds by including "MappedAttribute.h" in several places.
1788
1789
* wml/WMLAElement.cpp:
1790
* wml/WMLAccessElement.cpp:
1791
* wml/WMLBRElement.cpp:
1792
* wml/WMLCardElement.cpp:
1793
* wml/WMLDoElement.cpp:
1794
* wml/WMLElement.cpp:
1795
* wml/WMLFieldSetElement.cpp:
1796
* wml/WMLGoElement.cpp:
1797
* wml/WMLImageElement.cpp:
1798
* wml/WMLInputElement.cpp:
1799
* wml/WMLMetaElement.cpp:
1800
* wml/WMLOnEventElement.cpp:
1801
* wml/WMLOptGroupElement.cpp:
1802
* wml/WMLOptionElement.cpp:
1803
* wml/WMLPElement.cpp:
1804
* wml/WMLPostfieldElement.cpp:
1805
* wml/WMLSetvarElement.cpp:
1806
* wml/WMLTableElement.cpp:
1807
* wml/WMLTemplateElement.cpp:
1808
* wml/WMLTimerElement.cpp:
1809
1810
2009-05-06 Xan Lopez <xlopez@igalia.com>
1811
1812
Reviewed by Gustavo Noronha.
1813
1814
https://bugs.webkit.org/show_bug.cgi?id=25526
1815
[Gtk] Additional support is needed for caret browsing
1816
1817
Emit AtkText::text-selection-changed when the selection changes
1818
and the current selection is of Range (ie, the start and end
1819
positions are different) type. This seems to match what Gecko
1820
does.
1821
1822
* editing/gtk/SelectionControllerGtk.cpp:
1823
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
1824
1825
2009-05-05 Xan Lopez <xlopez@igalia.com>
1826
1827
Reviewed by Gustavo Noronha.
1828
1829
https://bugs.webkit.org/show_bug.cgi?id=25526
1830
[Gtk] Additional support is needed for caret browsing
1831
1832
Emit AtkText::text-caret-moved when selection changes.
1833
1834
* GNUmakefile.am:
1835
* editing/SelectionController.h:
1836
* editing/gtk/SelectionController.cpp: Added.
1837
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
1838
1839
2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
1840
1841
Reviewed by Gustavo Noronha.
1842
1843
Use mozilla cursors for the previously not implemented
1844
cursors. The manual-tests/cursor.html is looking complete
1845
now.
1846
1847
* platform/gtk/CursorGtk.cpp:
1848
(WebCore::cellCursor):
1849
(WebCore::noDropCursor):
1850
(WebCore::progressCursor):
1851
(WebCore::noneCursor):
1852
(WebCore::notAllowedCursor):
1853
(WebCore::grabCursor):
1854
(WebCore::grabbingCursor):
1855
* platform/gtk/CursorGtk.h:
1856
1857
2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
1858
1859
Reviewed by Xan Lopez.
1860
1861
Properly indent the header file.
1862
1863
* platform/gtk/CursorGtk.h:
1864
1865
2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
1866
1867
Reviewed by Gustavo Noronha.
1868
1869
Use the mozilla copyright header. Use MPL1.1/GPL2.0
1870
and LGPL2.1 as the license compared to LGPL2.0.
1871
1872
* platform/gtk/CursorGtk.h:
1873
1874
2009-05-06 Holger Hans Peter Freyther <zecke@selfish.org>
1875
1876
Reviewed by Gustavo Noronha.
1877
1878
Move PluginView::invalidateRegion from the
1879
TemporaryLinkStubs to PluginViewGtk.cpp and implement
1880
it with a call to Widget::invalidate() just like
1881
mac is doing. Optimisations would have to be window
1882
system specific.
1883
1884
* platform/gtk/TemporaryLinkStubs.cpp:
1885
* plugins/gtk/PluginViewGtk.cpp:
1886
(WebCore::PluginView::invalidateRegion):
1887
1888
2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
1889
1890
Reviewed by Holger Freyther.
1891
1892
Misc fixes to InspectorClientGtk.
1893
1894
* GNUmakefile.am: Add localizedStrings.js to webinspector_DATA.
1895
This prevents copious amounts "Localized string not found" errors
1896
in the console
1897
1898
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
1899
1900
Reviewed by Ariya Hidayat.
1901
1902
Fix the Qt build on Windows.
1903
1904
* platform/graphics/GraphicsContext.h:
1905
(WebCore::GraphicsContext::shouldIncludeChildWindows): Implemented dummy accessor.
1906
1907
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
1908
1909
Reviewed by Tor Arne Vestbø.
1910
1911
Tweak WebCore.pro for being able to override the generated sources dir for the
1912
generated_files target.
1913
1914
* WebCore.pro:
1915
1916
2009-05-06 Simon Hausmann <simon.hausmann@nokia.com>
1917
1918
Reviewed by Holger Freyther.
1919
1920
Fix the Qt/Windows build, use iface instead of interface to avoid conflict
1921
with VS2005 headers.
1922
1923
* css/CSSStyleSelector.cpp:
1924
(WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
1925
1926
2009-05-06 Joerg Bornemann <joerg.bornemann@trolltech.com>
1927
1928
Reviewed by Simon Hausmann.
1929
1930
We need to include StringExtras.h on Windows CE to access the strdup function.
1931
1932
* plugins/PluginStream.cpp:
1933
1934
2009-05-06 Soren Gjesse <sgjesse@chromium.org>
1935
1936
Reviewed by Eric Seidel.
1937
1938
Changed the toString behaviour for non document dom node event handlers in the V8 bindings.
1939
https://bugs.webkit.org/show_bug.cgi?id=25544
1940
1941
In the V8 bindings non document dom node event handlers are wrapped in a number of with blocks and uses an inner
1942
function. This causes the default toString on such a handler to return all this wrapper code. As some web sites
1943
use the source of an event handler to create new functions this wrapper code causes compatibility problems.
1944
1945
Create a specific toString function for these handlers which will return a function source compatible with the
1946
source returned by the JSC bindings and other browsers.
1947
1948
Test: fast/events/event-function-toString.html
1949
1950
* bindings/v8/ScriptEventListener.cpp:
1951
(WebCore::createAttributeEventListener):
1952
* bindings/v8/V8LazyEventListener.cpp:
1953
(WebCore::V8LazyEventListener::V8LazyEventListener):
1954
(WebCore::V8LazyEventListener::getListenerFunction):
1955
(WebCore::V8LazyEventListenerToString):
1956
(WebCore::V8LazyEventListener::getWrappedListenerFunction):
1957
* bindings/v8/V8LazyEventListener.h:
1958
(WebCore::V8LazyEventListener::create):
1959
1960
2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1961
1962
Reviewed by Simon Hausmann.
1963
1964
Build QtWebKit as a framework on Mac
1965
1966
This implies both debug and release build by default, unless
1967
one of the --debug or --release config options are passed to
1968
the build-webkit script.
1969
1970
Frameworks can be disabled by passing CONFIG+=webkit_no_framework
1971
to the build-webkit script.
1972
1973
To be able to build both debug and release targets in parallel
1974
we have to use separate output directories for the generated
1975
sources, which is not optimal, but required to avoid race conditions.
1976
1977
An optimization would be to only require this spit-up on Mac.
1978
1979
* WebCore.pro:
1980
1981
2009-05-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1982
1983
Reviewed by Simon Hausmann.
1984
1985
[Qt] Use $$GENERATED_SOURCES_DIR as output when running bison
1986
1987
A couple of the generators left the bison output file in the source
1988
tree, and then moved it into $$GENERATED_SOURCES_DIR, which did not
1989
work well when building release and debug configurations in parallel.
1990
1991
* WebCore.pro:
1992
1993
2009-05-06 Dan Bernstein <mitz@apple.com>
1994
1995
Reviewed by Justin Garcia.
1996
1997
- fix an assertion failure in RemoveNodeCommand() when deleting a <br>
1998
between a block and a mail blockquote
1999
2000
Test: editing/deleting/removeNodeCommand-assert.html
2001
2002
* editing/DeleteSelectionCommand.cpp:
2003
(WebCore::DeleteSelectionCommand::mergeParagraphs): Pass the start block
2004
to prune() instead of passing m_upstreamStart.node(), because the latter
2005
may have been removed already.
2006
2007
2009-05-05 Eric Seidel <eric@webkit.org>
2008
2009
No review, roll out only.
2010
2011
Roll out r23072 since it broke layout tests
2012
2013
* page/AccessibilityRenderObject.cpp:
2014
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2015
2016
2009-05-05 Ben Murdoch <benm@google.com>
2017
2018
Reviewed by Eric Seidel.
2019
2020
Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
2021
https://bugs.webkit.org/show_bug.cgi?id=24776
2022
2023
No functional changes, thus no tests.
2024
2025
* bindings/js/JSCustomSQLStatementCallback.cpp:
2026
* bindings/js/JSCustomSQLStatementCallback.h:
2027
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
2028
* bindings/js/JSCustomSQLStatementErrorCallback.h:
2029
* bindings/js/JSCustomSQLTransactionCallback.cpp:
2030
* bindings/js/JSCustomSQLTransactionCallback.h:
2031
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
2032
* bindings/js/JSCustomSQLTransactionErrorCallback.h:
2033
* bindings/js/JSDatabaseCustom.cpp:
2034
* bindings/js/JSSQLTransactionCustom.cpp:
2035
* loader/EmptyClients.h:
2036
* page/ChromeClient.h:
2037
* storage/ChangeVersionWrapper.cpp:
2038
* storage/ChangeVersionWrapper.h:
2039
* storage/Database.cpp:
2040
(WebCore::Database::databaseInfoTableName):
2041
* storage/Database.h:
2042
* storage/Database.idl:
2043
* storage/DatabaseTask.cpp:
2044
* storage/DatabaseTask.h:
2045
* storage/DatabaseThread.cpp:
2046
* storage/DatabaseThread.h:
2047
* storage/DatabaseTracker.cpp:
2048
* storage/DatabaseTracker.h:
2049
* storage/DatabaseTrackerClient.h:
2050
* storage/OriginQuotaManager.cpp:
2051
* storage/OriginQuotaManager.h:
2052
* storage/SQLStatement.cpp:
2053
* storage/SQLStatement.h:
2054
* storage/SQLTransaction.cpp:
2055
* storage/SQLTransaction.h:
2056
* storage/SQLTransaction.idl:
2057
2058
2009-05-05 Jeremy Moskovich <jeremy@chromium.org>
2059
2060
Reviewed by Eric Seidel.
2061
2062
Add some documentation to InlineBox::x(),y().
2063
https://bugs.webkit.org/show_bug.cgi?id=25378
2064
2065
* rendering/InlineBox.h:
2066
2067
2009-05-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
2068
2069
Reviewed by Eric Seidel.
2070
2071
Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0
2072
https://bugs.webkit.org/show_bug.cgi?id=24693
2073
2074
* WebCore.pro:
2075
2076
2009-05-05 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
2077
2078
Reviewed by Eric Seidel.
2079
2080
Anonymous blocks should not be exposed in accessibility tree.
2081
Part of https://bugs.webkit.org/show_bug.cgi?id=23072
2082
2083
Tests: accessibility/ignore-anonymous-block.html
2084
platform/win/accessibility/document-role.html
2085
2086
* page/AccessibilityRenderObject.cpp:
2087
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):Return
2088
true for Anonymous blocks. Matching Firefox 2.0.0.14
2089
2090
2009-05-05 Jungshik Shin <jshin@chromium.org>
2091
2092
Reviewed by Alexey Proskuryakov.
2093
2094
http://bugs.webkit.org/show_bug.cgi?id=25487
2095
2096
For euc-kr and other 8bit Korean encodings
2097
(similar to euc-kr/windows-949), make document.charset return
2098
EUC-KR instead of windows-949. The latter is not recognized by
2099
Korean web servers.
2100
2101
Add domName method to TextEncoding to deal with cases where
2102
our internal encoding name does not match what's widely recognized
2103
by web servers. Currently, the only case is 'windows-949' (internal
2104
name) vs 'EUC-KR'.
2105
2106
Test: fast/encoding/euckr-name.html
2107
2108
* dom/Document.cpp:
2109
(WebCore::Document::encoding): Call TextEncoding.domName() instead
2110
of TextEncoding.name().
2111
* platform/text/TextEncoding.cpp:
2112
(WebCore::TextEncoding::domName): For the canonical name 'windows-949',
2113
return 'EUC-KR'. Otherwise, just return the canonical name.
2114
* platform/text/TextEncoding.h:
2115
2116
2009-05-05 Adam Langley <agl@google.com>
2117
2118
Reviewed by Darin Adler.
2119
2120
Rendering fix for <select> elements.
2121
https://bugs.webkit.org/show_bug.cgi?id=25558
2122
2123
When switching a <select> element from display:none to default
2124
display, we would fail to invalidate the parent's pref widths in some
2125
situations:
2126
2127
When attaching the element, RenderMenuList::updateOptionsWidth would
2128
call setNeedsLayoutAndPrefWidthsRecalc before the parent pointer was
2129
set. This would mark the pref widths as dirty, but not for any parent
2130
objects.
2131
2132
When RenderObjectChildList::appendChildNode later calls
2133
setNeedsLayoutAndPrefWidthsRecalc again, with a valid parent pointer,
2134
nothing would be done because the pref widths were already dirty for.
2135
the RenderMenuList.
2136
2137
* rendering/RenderMenuList.cpp:
2138
(WebCore::RenderMenuList::updateOptionsWidth):
2139
2140
2009-05-05 Antony Sargent <asargent@chromium.org>
2141
2142
Reviewed by Dimitri Glazkov.
2143
2144
Switch V8EventListenerList to use HashTable<T>.
2145
https://bugs.webkit.org/show_bug.cgi?id=25496
2146
2147
This avoids some tricky issues with event listener removal in the
2148
current implementation and has slightly better performance.
2149
2150
No new functionality so no new tests.
2151
2152
* bindings/v8/V8EventListenerList.cpp: Added V8EventListenerListIterator.
2153
* bindings/v8/V8EventListenerList.h:
2154
(WebCore::V8EventListenerList::size):
2155
* bindings/v8/WorkerContextExecutionProxy.cpp:
2156
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2157
2158
2009-05-05 Darin Fisher <darin@chromium.org>
2159
2160
Fixing build bustage.
2161
2162
Add some missing includes to fix the Chromium build.
2163
2164
* bindings/v8/custom/V8DOMWindowCustom.cpp:
2165
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
2166
2167
2009-05-05 Darin Fisher <darin@chromium.org>
2168
2169
Reviewed by Darin Adler.
2170
2171
https://bugs.webkit.org/show_bug.cgi?id=25570
2172
2173
history.{back,forward,go} should always be dispatched asynchronously,
2174
even when the history navigation would just result in scrolling the
2175
page. This matches the behavior of other browsers like IE and FF.
2176
2177
Test: fast/history/back-forward-is-asynchronous.html
2178
2179
* loader/FrameLoader.cpp:
2180
(WebCore::FrameLoader::scheduleHistoryNavigation):
2181
2182
2009-05-05 Eric Seidel <eric@webkit.org>
2183
2184
Reviewed by Simon Fraser.
2185
2186
Add an ASSERT(useTransforms) to mapLocalToContainer implementations in SVG.
2187
https://bugs.webkit.org/show_bug.cgi?id=25532
2188
https://bugs.webkit.org/show_bug.cgi?id=25568
2189
2190
Adding this ASSERT exposed a bug in SVGPaintServerPattern::setup
2191
which was causing transformed SVG text when filled/stroked with a
2192
pattern using patternUnits=objectBoundingBox to draw incorrectly.
2193
2194
I fixed the incorrect drawing (by removing the broken code) and added
2195
two test cases to test the fix:
2196
* svg/transforms/text-with-pattern-inside-transformed-html.xhtml
2197
* svg/transforms/text-with-pattern-with-svg-transform.svg
2198
2199
* rendering/RenderSVGRoot.cpp:
2200
(WebCore::RenderSVGRoot::mapLocalToContainer):
2201
* rendering/SVGRenderSupport.cpp:
2202
(WebCore::SVGRenderBase::mapLocalToContainer):
2203
* svg/graphics/SVGPaintServerPattern.cpp:
2204
(WebCore::SVGPaintServerPattern::setup):
2205
2206
2009-05-05 Greg Bolsinga <bolsinga@apple.com>
2207
2208
Reviewed by Sam Weinig.
2209
2210
https://bugs.webkit.org/show_bug.cgi?id=25554
2211
2212
Support HTML5 text control input types: email, number, tel, url
2213
2214
Test: fast/html/text-field-input-types.html
2215
2216
* bindings/objc/DOMHTML.mm:
2217
(-[DOMHTMLInputElement _isTextField]): Call HTMLInputElement::isTextField directly.
2218
* html/HTMLInputElement.cpp: Use the new types where appropriate.
2219
(WebCore::HTMLInputElement::setInputType):
2220
(WebCore::HTMLInputElement::type):
2221
(WebCore::HTMLInputElement::saveState):
2222
(WebCore::HTMLInputElement::restoreState):
2223
(WebCore::HTMLInputElement::accessKeyAction):
2224
(WebCore::HTMLInputElement::rendererIsNeeded):
2225
(WebCore::HTMLInputElement::createRenderer):
2226
(WebCore::HTMLInputElement::appendFormData):
2227
(WebCore::HTMLInputElement::valueWithDefault):
2228
(WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
2229
(WebCore::HTMLInputElement::defaultEventHandler):
2230
* html/HTMLInputElement.h: Ditto.
2231
(WebCore::HTMLInputElement::):
2232
(WebCore::HTMLInputElement::isTextField):
2233
2234
2009-04-01 miggilin <mr.diggilin@gmail.com>
2235
2236
Reviewed by Kevin Ollivier.
2237
2238
Mouse wheel scrolling and keyboard shortcut support for wx.
2239
2240
https://bugs.webkit.org/show_bug.cgi?id=24797
2241
2242
* platform/ScrollView.cpp:
2243
(WebCore::ScrollView::wheelEvent):
2244
* platform/wx/KeyboardEventWx.cpp:
2245
(WebCore::windowsKeyCodeForKeyEvent):
2246
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
2247
* platform/wx/ScrollViewWx.cpp:
2248
(WebCore::ScrollView::platformSetScrollPosition):
2249
2250
2009-05-05 Kevin Ollivier <kevino@theolliviers.com>
2251
2252
wx build fix for Windows, add missing include.
2253
2254
https://bugs.webkit.org/show_bug.cgi?id=24798
2255
2256
* platform/wx/wxcode/win/non-kerned-drawing.cpp:
2257
2258
2009-05-05 Chris Fleizach <cfleizach@apple.com>
2259
2260
Reviewed by Beth Dakin.
2261
2262
Bug 25574: AXImageMap children links don't respond properly to accessibilityHitTest:
2263
https://bugs.webkit.org/show_bug.cgi?id=25574
2264
2265
Enable accessibility hit-testing for image map links.
2266
Allow image map links to return AXURLs and AXAccessKey information.
2267
2268
Test: platform/mac/accessibility/imagemap-hittest.html
2269
2270
* page/AccessibilityImageMapLink.cpp:
2271
(WebCore::AccessibilityImageMapLink::url):
2272
* page/AccessibilityImageMapLink.h:
2273
* page/AccessibilityObject.h:
2274
(WebCore::AccessibilityObject::minValueForRange):
2275
* page/AccessibilityRenderObject.cpp:
2276
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
2277
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
2278
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
2279
* page/AccessibilityRenderObject.h:
2280
* page/mac/AccessibilityObjectWrapper.mm:
2281
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
2282
2283
2009-05-05 Kevin McCullough <kmccullough@apple.com>
2284
2285
Reviewed by Dan Bernstein.
2286
2287
<rdar://problem/6552129> Select a quote line and paste elsewhere, you
2288
get that line and an extra quoted blank line
2289
<rdar://problem/6609308> Triple-click a quoted header line, copy, paste
2290
onto an empty line makes an extra quoted line
2291
2292
- When pasting a blockquote with a newline, make sure we put the newline
2293
outside of the blockquote so that it is not quoted.
2294
2295
* editing/InsertParagraphSeparatorCommand.cpp:
2296
(WebCore::InsertParagraphSeparatorCommand::doApply):
2297
2298
2009-05-05 Jan Michael Alonzo <jmalonzo@webkit.org>
2299
2300
Reviewed by Xan Lopez.
2301
2302
Call moz_gtk_shutdown on RenderThemeGtk destruction.
2303
2304
* platform/gtk/RenderThemeGtk.cpp:
2305
(WebCore::RenderThemeGtk::~RenderThemeGtk):
2306
* platform/gtk/RenderThemeGtk.h:
2307
2308
2009-05-05 Darin Adler <darin@apple.com>
2309
2310
Reviewed by Steve Falkenburg.
2311
2312
<rdar://problem/6858340> REGRESSION: can't drag local HTML files into Safari because CFURLCreateWithFileSystemPath inserts "localhost"
2313
2314
* platform/win/ClipboardUtilitiesWin.cpp: (WebCore::urlFromPath): Remove localhost.
2315
2316
2009-05-05 Peter Kasting <pkasting@google.com>
2317
2318
Reviewed by Brady Eidson.
2319
2320
Safety-check m_documentLoader before dereferencing. While it seems
2321
unlikely this could fail (as Safari 3 shipped without this),
2322
technically almost any call can change or reset m_documentLoader.
2323
2324
* loader/FrameLoader.cpp:
2325
(WebCore::FrameLoader::receivedFirstData):
2326
2327
2009-05-05 Dan Bernstein <mitz@apple.com>
2328
2329
- Tiger build fix
2330
2331
* css/CSSComputedStyleDeclaration.cpp:
2332
(WebCore::toCSSIdentifier):
2333
2334
2009-05-05 Peter Kasting <pkasting@google.com>
2335
2336
Reviewed by Eric Seidel.
2337
2338
https://bugs.webkit.org/show_bug.cgi?id=25303
2339
No need to ref the internal buffer inside the Skia ImageDecoder.
2340
2341
* platform/image-decoders/skia/ImageDecoder.h:
2342
(WebCore::RGBA32Buffer::RGBA32Buffer):
2343
(WebCore::RGBA32Buffer::operator=):
2344
(WebCore::RGBA32Buffer::clear):
2345
(WebCore::RGBA32Buffer::copyBitmapData):
2346
(WebCore::RGBA32Buffer::bitmap):
2347
(WebCore::RGBA32Buffer::setSize):
2348
(WebCore::RGBA32Buffer::width):
2349
(WebCore::RGBA32Buffer::height):
2350
(WebCore::RGBA32Buffer::hasAlpha):
2351
(WebCore::RGBA32Buffer::setStatus):
2352
(WebCore::RGBA32Buffer::setHasAlpha):
2353
(WebCore::RGBA32Buffer::setRGBA):
2354
2355
2009-05-05 Dan Bernstein <mitz@apple.com>
2356
2357
Reviewed by Darin Adler.
2358
2359
- fix https://bugs.webkit.org/show_bug.cgi?id=24192
2360
<rdar://problem/5760774> Replying to a Mail message that contains
2361
fixed width text can change the size of the text
2362
2363
Covered by existing tests: editing/pasteboard/5027857.html
2364
editing/pasteboard/paste-pre-002.html
2365
2366
* css/CSSComputedStyleDeclaration.cpp:
2367
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
2368
Added. If the font-size is keyword-based, returns the keyword value
2369
instead of the pixel size.
2370
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): If
2371
font-family is a generic family, return the generic family instead of
2372
the the internal string -webkit-[serif|sans-serif|cursive|fantasy
2373
|monospace].
2374
(WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
2375
For the font-size property, prefer a keyword value over a pixel size.
2376
* css/CSSComputedStyleDeclaration.h:
2377
* editing/ApplyStyleCommand.cpp:
2378
(WebCore::StyleChange::currentlyHasStyle): For the font-size property,
2379
call getFontSizeCSSValuePreferringKeyword().
2380
* platform/graphics/FontDescription.h:
2381
(WebCore::FontDescription::keywordSize): Changed the return type to
2382
unsigned.
2383
(WebCore::FontDescription::setKeywordSize): Changed the parameter type
2384
to unsigned.
2385
(WebCore::FontDescription::m_keywordSize): Changed the type of this
2386
4-bit field to unsigned, because it takes values as high as 8.
2387
2388
2009-05-05 Oliver Hunt <oliver@apple.com>
2389
2390
Reviewed by Maciej Stachowiak.
2391
2392
Fix http/tests/misc/DOMContentLoaded-event.html
2393
2394
The native call performance improvement removed a few places where we
2395
unintentionally performed a toThisObject conversion. This patch updates
2396
the bindings codegen to not rely on this bug.
2397
2398
* bindings/scripts/CodeGeneratorJS.pm:
2399
2400
2009-05-05 Holger Hans Peter Freyther <zecke@selfish.org>
2401
2402
Reviewed by Xan Lopez and Gustavo Noronha.
2403
2404
Implement WebCore::directoryName for Gtk+.
2405
2406
* platform/gtk/FileSystemGtk.cpp:
2407
(WebCore::directoryName):
2408
2409
2009-05-05 Eric Seidel <eric@webkit.org>
2410
2411
Reviewed by Adam Roben.
2412
2413
Fix mappedAttributes() access without NULL check
2414
https://bugs.webkit.org/show_bug.cgi?id=25553
2415
2416
SVGStyledElement::getPresentationAttribute was using mappedAttributes()
2417
without checking for NULL.
2418
2419
HTMLInputElement::setInputType also doesn't NULL check, but I was not
2420
able to get it to crash with a test case so I just added an ASSERT.
2421
2422
* html/HTMLInputElement.cpp:
2423
(WebCore::HTMLInputElement::setInputType):
2424
* svg/SVGStyledElement.cpp:
2425
(WebCore::SVGStyledElement::getPresentationAttribute):
2426
2427
2009-05-05 Holger Hans Peter Freyther <zecke@selfish.org>
2428
2429
Reviewed by Xan Lopez.
2430
2431
Implement WebCore::imageTitle for Gtk+.
2432
2433
* platform/gtk/LocalizedStringsGtk.cpp:
2434
(WebCore::imageTitle):
2435
2436
2009-05-05 Oliver Hunt <oliver@apple.com>
2437
2438
Reviewed by Gavin Barraclough.
2439
2440
Bug 25559: Improve native function call performance
2441
<https://bugs.webkit.org/show_bug.cgi?id=25559>
2442
2443
Add forwarding header necessary for compilation, and fix debugger
2444
to correctly account for change in JSFunction behaviour.
2445
2446
* ForwardingHeaders/jit/JITCode.h: Added.
2447
* inspector/JavaScriptDebugServer.cpp:
2448
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
2449
2450
2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
2451
2452
Reviewed by Ariya Hidayat.
2453
2454
Make convertValueToQVariant more robust against null JSValues.
2455
2456
Don't require the caller to do the null check.
2457
2458
* bridge/qt/qt_runtime.cpp:
2459
(JSC::Bindings::convertValueToQVariant):
2460
2461
2009-05-05 Eric Seidel <eric@webkit.org>
2462
2463
No review, just a revert.
2464
2465
Roll out http://trac.webkit.org/changeset/43213 as it caused 4 tests to crash.
2466
2467
* rendering/RenderSVGRoot.cpp:
2468
(WebCore::RenderSVGRoot::mapLocalToContainer):
2469
* rendering/SVGRenderSupport.cpp:
2470
(WebCore::SVGRenderBase::mapLocalToContainer):
2471
2472
2009-05-04 Alexey Proskuryakov <ap@webkit.org>
2473
2474
Reviewed by Dave Hyatt.
2475
2476
<rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
2477
2478
The problem was caused by missing <head> element - we used to create it when moving a
2479
misplaced <style> element, but we now handle those in place. Other browsers always create
2480
a <head> element.
2481
2482
There is no guarantee that a <head> element always exists - first, it can be removed with
2483
removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
2484
for manually created ones (e.g. ImageDocument).
2485
2486
Test: fast/parser/head-element-for-yahoo-player.html
2487
2488
* dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
2489
A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
2490
code is removed completely.
2491
2492
* html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
2493
elements as children of <html>. This isn't directly related to this bug, but it was easier
2494
to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
2495
2496
* html/HTMLParser.cpp:
2497
(WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
2498
Create a <head> it a <body> is created implicitly to contain some other element.
2499
(WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
2500
explicitly present in source.
2501
(WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
2502
2503
2009-05-04 Jakub Wieczorek <faw217@gmail.com>
2504
2505
Reviewed by Simon Hausmann.
2506
2507
As Qtish implementation of MIMETypeRegistry::getMIMETypeForExtension()
2508
returns the application/octet-stream mimetype when it can't associate
2509
extension with any mimetype, it can happen that the application/octet-stream
2510
mimetype will hit the list of supported image formats. For instance,
2511
it is possible when QImageReader or QImageWriter support an extension
2512
that is not in the extensions map.
2513
2514
Make sure that this mimetype is not treated as displayable image type.
2515
2516
* platform/MIMETypeRegistry.cpp:
2517
(WebCore::initializeSupportedImageMIMETypes):
2518
(WebCore::initializeSupportedImageMIMETypesForEncoding):
2519
2520
2009-05-03 Eric Seidel <eric@webkit.org>
2521
2522
Reviewed by Simon Fraser.
2523
2524
ASSERT(useTransforms) in SVG mapLocalToContainer implementations
2525
https://bugs.webkit.org/show_bug.cgi?id=25532
2526
2527
* rendering/RenderSVGRoot.cpp:
2528
(WebCore::RenderSVGRoot::mapLocalToContainer):
2529
* rendering/SVGRenderSupport.cpp:
2530
(WebCore::SVGRenderBase::mapLocalToContainer):
2531
2532
2009-05-03 Eric Seidel <eric@webkit.org>
2533
2534
Reviewed by Simon Fraser.
2535
2536
Remove m_absoluteBounds hack from RenderSVGText
2537
https://bugs.webkit.org/show_bug.cgi?id=25532
2538
2539
No functional changes (SVGs inside CSS transformed HTML should theoretically repaint better)
2540
2541
* rendering/RenderSVGText.cpp:
2542
(WebCore::RenderSVGText::layout):
2543
* rendering/RenderSVGText.h:
2544
2545
2009-05-03 Eric Seidel <eric@webkit.org>
2546
2547
Reviewed by Simon Fraser.
2548
2549
Remove the vestigial calculateLocalTransform()
2550
https://bugs.webkit.org/show_bug.cgi?id=25532
2551
2552
RenderSVGContainer is now the only render which needs this
2553
function, but it no longer returns the unused bool.
2554
2555
calculateLocalTransform() previously was called by the DOM before
2556
transform updates were part of layout().
2557
2558
* rendering/RenderForeignObject.cpp:
2559
(WebCore::RenderForeignObject::layout):
2560
* rendering/RenderForeignObject.h:
2561
(WebCore::RenderForeignObject::localTransform):
2562
* rendering/RenderPath.cpp:
2563
(WebCore::RenderPath::layout):
2564
* rendering/RenderPath.h:
2565
* rendering/RenderSVGContainer.cpp:
2566
* rendering/RenderSVGContainer.h:
2567
(WebCore::RenderSVGContainer::calculateLocalTransform):
2568
* rendering/RenderSVGImage.cpp:
2569
(WebCore::RenderSVGImage::layout):
2570
* rendering/RenderSVGImage.h:
2571
* rendering/RenderSVGText.cpp:
2572
(WebCore::RenderSVGText::layout):
2573
* rendering/RenderSVGText.h:
2574
* rendering/RenderSVGTransformableContainer.cpp:
2575
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
2576
* rendering/RenderSVGTransformableContainer.h:
2577
2578
2009-05-03 Eric Seidel <eric@webkit.org>
2579
2580
Reviewed by Simon Fraser.
2581
2582
Move more code into SVGRenderBase
2583
https://bugs.webkit.org/show_bug.cgi?id=25532
2584
2585
clippedOverflowRectForRepaint, computeRectForRepaint and mapLocalToContainer
2586
are now all shared via SVGRenderBase.
2587
2588
RenderForeignObject should also be sharing this code, but I've left it
2589
alone for now, as changing that would likely cause test changes.
2590
2591
No test changes. It's possible that transformed <svg:image> elements will
2592
now show up with better metrics in the inspector.
2593
2594
* rendering/RenderSVGImage.cpp:
2595
(WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
2596
(WebCore::RenderSVGImage::computeRectForRepaint):
2597
(WebCore::RenderSVGImage::mapLocalToContainer):
2598
* rendering/RenderSVGImage.h:
2599
* rendering/RenderSVGModelObject.cpp:
2600
(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
2601
(WebCore::RenderSVGModelObject::computeRectForRepaint):
2602
(WebCore::RenderSVGModelObject::mapLocalToContainer):
2603
* rendering/RenderSVGText.cpp:
2604
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
2605
(WebCore::RenderSVGText::computeRectForRepaint):
2606
(WebCore::RenderSVGText::mapLocalToContainer):
2607
* rendering/SVGRenderSupport.cpp:
2608
(WebCore::SVGRenderBase::clippedOverflowRectForRepaint):
2609
(WebCore::SVGRenderBase::computeRectForRepaint):
2610
(WebCore::SVGRenderBase::mapLocalToContainer):
2611
* rendering/SVGRenderSupport.h:
2612
2613
2009-05-03 Eric Seidel <eric@webkit.org>
2614
2615
Reviewed by Simon Fraser.
2616
2617
Add SVGRenderBase to share logic between SVG renderers
2618
https://bugs.webkit.org/show_bug.cgi?id=25532
2619
2620
I've added an SVGRenderBase base class which is shared by
2621
all of the SVG renders now. This patch is just moving code
2622
there are no functional changes in this patch.
2623
2624
Currently I've left these functions in SVGRenderSupport.h
2625
In a later patch I will rename SVGRenderSupport.* to SVGRenderBase.*
2626
2627
clampImageBufferSizeToViewport now takes a FrameView* which makes some code easier to read.
2628
2629
* rendering/RenderSVGBlock.h:
2630
* rendering/RenderSVGImage.h:
2631
* rendering/RenderSVGModelObject.h:
2632
* rendering/RenderSVGRoot.h:
2633
* rendering/SVGRenderSupport.cpp:
2634
(WebCore::SVGRenderBase::prepareToRenderSVGContent):
2635
(WebCore::SVGRenderBase::finishRenderSVGContent):
2636
(WebCore::clampImageBufferSizeToViewport):
2637
(WebCore::SVGRenderBase::computeContainerBoundingBox):
2638
(WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
2639
* rendering/SVGRenderSupport.h:
2640
* rendering/SVGRootInlineBox.cpp:
2641
(WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
2642
(WebCore::SVGRootInlineBoxPaintWalker::chunkEndCallback):
2643
(WebCore::SVGRootInlineBox::paint):
2644
* svg/SVGMaskElement.cpp:
2645
(WebCore::SVGMaskElement::drawMaskerContent):
2646
* svg/SVGPatternElement.cpp:
2647
(WebCore::SVGPatternElement::buildPattern):
2648
* svg/graphics/SVGPaintServerGradient.cpp:
2649
(WebCore::createMaskAndSwapContextForTextGradient):
2650
(WebCore::clipToTextMask):
2651
2652
2009-05-05 Simon Hausmann <simon.hausmann@nokia.com>
2653
2654
Unreviewed SVG build fix.
2655
2656
Include MappedAttribute.h after r43187.
2657
2658
* svg/SVGComponentTransferFunctionElement.cpp:
2659
* svg/SVGFEBlendElement.cpp:
2660
* svg/SVGFEColorMatrixElement.cpp:
2661
* svg/SVGFEComponentTransferElement.cpp:
2662
* svg/SVGFECompositeElement.cpp:
2663
* svg/SVGFEDiffuseLightingElement.cpp:
2664
* svg/SVGFEDisplacementMapElement.cpp:
2665
* svg/SVGFEGaussianBlurElement.cpp:
2666
* svg/SVGFEImageElement.cpp:
2667
* svg/SVGFELightElement.cpp:
2668
* svg/SVGFEMergeNodeElement.cpp:
2669
* svg/SVGFEOffsetElement.cpp:
2670
* svg/SVGFESpecularLightingElement.cpp:
2671
* svg/SVGFETileElement.cpp:
2672
* svg/SVGFETurbulenceElement.cpp:
2673
* svg/SVGFilterElement.cpp:
2674
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
2675
2676
2009-05-04 Brady Eidson <beidson@apple.com>
2677
2678
Reviewed by Sam 'The Belly' Weinig
2679
2680
<rdar://problem/6828894> - Facebook photo uploader applet broken on Leopard only
2681
2682
In r41568 we started adding a default codebase attribute to <applet> tags if they didn't specify one
2683
themselves. Leopard's Java plug-in mishandles this case and fails to load code for the applet.
2684
2685
The spirit of r41568 can be maintained by removing the "default codebase" piece and only performing
2686
the canLoad() check if a codebase was actually set on the applet tag.
2687
2688
* html/HTMLAppletElement.cpp:
2689
(WebCore::HTMLAppletElement::createRenderer): Don't create a default codebase attribute.
2690
2691
* loader/FrameLoader.cpp:
2692
(WebCore::FrameLoader::createJavaAppletWidget): Only perform the canLoad() check if the codebase was set.
2693
2694
2009-05-04 Adam Roben <aroben@apple.com>
2695
2696
Windows build fix
2697
2698
* html/HTMLCollection.h:
2699
* html/HTMLFormElement.h:
2700
Declare CollectionCache as a struct, not a class, to match its
2701
definition.
2702
2703
2009-05-04 Chris Fleizach <cfleizach@apple.com>
2704
2705
Reviewed by Beth Dakin, Oliver Hunt.
2706
2707
Bug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
2708
https://bugs.webkit.org/show_bug.cgi?id=25557
2709
2710
Test: accessibility/canvas.html
2711
2712
* page/AccessibilityRenderObject.cpp:
2713
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2714
(WebCore::AccessibilityRenderObject::roleValue):
2715
2716
2009-05-04 Brady Eidson <beidson@apple.com>
2717
2718
Fix an ancient Changelog entry where Sam Weinig flat out lied and confused my exploration of a bug.
2719
2720
* ChangeLog
2721
2722
2009-05-04 Kai Brüning <kai@granus.net>
2723
2724
Reviewed by Eric Seidel.
2725
2726
https://bugs.webkit.org/show_bug.cgi?id=24883
2727
24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp
2728
2729
Fixed test whether all the chunk has been processed to correctly count utf8 bytes.
2730
2731
Test: fast/innerHTML/innerHTML-nbsp.xhtml
2732
2733
* dom/XMLTokenizerLibxml2.cpp:
2734
(WebCore::parseXMLDocumentFragment):
2735
2736
2009-05-04 Darin Adler <darin@apple.com>
2737
2738
Reviewed by Eric Seidel.
2739
2740
Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
2741
and NamedMappedAttrMap.h include of MappedAttribute.h
2742
https://bugs.webkit.org/show_bug.cgi?id=24924
2743
2744
Make compiles faster, and debugging info smaller.
2745
2746
* GNUmakefile.am: Added new source files.
2747
* WebCore.pro: Ditto.
2748
* WebCore.scons: Ditto.
2749
* WebCore.vcproj/WebCore.vcproj: Ditto.
2750
* WebCore.xcodeproj/project.pbxproj: Ditto.
2751
* WebCoreSources.bkl: Ditto.
2752
2753
* bindings/js/JSHTMLCollectionCustom.cpp:
2754
(WebCore::toJS): Updated for new collection type names.
2755
2756
* dom/Document.cpp:
2757
(WebCore::Document::createAttribute): Added. No longer inline.
2758
(WebCore::Document::images): Updated for new collection type names.
2759
(WebCore::Document::applets): Ditto.
2760
(WebCore::Document::embeds): Ditto.
2761
(WebCore::Document::plugins): Ditto.
2762
(WebCore::Document::objects): Ditto.
2763
(WebCore::Document::scripts): Ditto.
2764
(WebCore::Document::links): Ditto.
2765
(WebCore::Document::forms): Ditto.
2766
(WebCore::Document::anchors): Ditto.
2767
(WebCore::Document::all): Ditto.
2768
(WebCore::Document::windowNamedItems): Ditto.
2769
(WebCore::Document::documentNamedItems): Ditto.
2770
(WebCore::Document::nameCollectionInfo): Ditto.
2771
2772
* dom/Document.h: Changed around includes and forward declarations.
2773
Updated for changes to collection types.
2774
2775
* dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
2776
2777
* html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp.
2778
Contains the class that used to be HTMLCollection::CollectionInfo.
2779
* html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h.
2780
Ditto.
2781
2782
* html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h.
2783
Has the enum that used to be HTMLCollection::Type.
2784
2785
* html/HTMLCollection.cpp:
2786
(WebCore::HTMLCollection::HTMLCollection): Update for collection type change.
2787
(WebCore::HTMLCollection::create): Ditto.
2788
(WebCore::HTMLCollection::resetCollectionInfo): Ditto.
2789
(WebCore::HTMLCollection::itemAfter): Ditto.
2790
* html/HTMLCollection.h: Ditto.
2791
2792
* html/HTMLElement.cpp:
2793
(WebCore::HTMLElement::children): Updated for new collection type names.
2794
* html/HTMLFormCollection.cpp:
2795
(WebCore::HTMLFormCollection::formCollectionInfo): Ditto.
2796
(WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
2797
* html/HTMLFormCollection.h: Ditto.
2798
* html/HTMLFormElement.h: Ditto.
2799
* html/HTMLMapElement.cpp:
2800
(WebCore::HTMLMapElement::areas): Ditto.
2801
* html/HTMLNameCollection.cpp:
2802
(WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
2803
* html/HTMLNameCollection.h:
2804
(WebCore::HTMLNameCollection::create): Ditto.
2805
* html/HTMLSelectElement.h:
2806
(WebCore::HTMLSelectElement::collectionInfo): Ditto.
2807
* html/HTMLTableElement.cpp:
2808
(WebCore::HTMLTableElement::tBodies):Ditto.
2809
* html/HTMLTableRowElement.cpp:
2810
(WebCore::HTMLTableRowElement::cells):Ditto.
2811
* html/HTMLTableRowsCollection.cpp:
2812
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
2813
* html/HTMLTableSectionElement.cpp:
2814
(WebCore::HTMLTableSectionElement::rows): Ditto.
2815
2816
* bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
2817
* bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
2818
* css/CSSStyleSelector.cpp: Ditto.
2819
* dom/Element.cpp: Ditto.
2820
* dom/InputElement.cpp: Ditto.
2821
* dom/NamedAttrMap.cpp: Ditto.
2822
* dom/NamedMappedAttrMap.cpp: Ditto.
2823
* dom/Node.cpp: Ditto.
2824
* dom/StyledElement.cpp: Ditto.
2825
* dom/StyledElement.h: Ditto.
2826
* editing/ApplyStyleCommand.cpp: Ditto.
2827
* editing/DeleteSelectionCommand.cpp: Ditto.
2828
* editing/Editor.cpp: Ditto.
2829
* editing/EditorCommand.cpp: Ditto.
2830
* editing/InsertParagraphSeparatorCommand.cpp: Ditto.
2831
* editing/ReplaceSelectionCommand.cpp: Ditto.
2832
* editing/markup.cpp: Ditto.
2833
* html/CanvasRenderingContext2D.cpp: Ditto.
2834
* html/HTMLAnchorElement.cpp: Ditto.
2835
* html/HTMLAppletElement.cpp: Ditto.
2836
* html/HTMLAreaElement.cpp: Ditto.
2837
* html/HTMLBRElement.cpp: Ditto.
2838
* html/HTMLBaseElement.cpp: Ditto.
2839
* html/HTMLBodyElement.cpp: Ditto.
2840
* html/HTMLButtonElement.cpp: Ditto.
2841
* html/HTMLCanvasElement.cpp: Ditto.
2842
* html/HTMLDivElement.cpp: Ditto.
2843
* html/HTMLEmbedElement.cpp: Ditto.
2844
* html/HTMLFontElement.cpp: Ditto.
2845
* html/HTMLFormControlElement.cpp: Ditto.
2846
* html/HTMLFormElement.cpp: Ditto.
2847
* html/HTMLFrameElement.cpp: Ditto.
2848
* html/HTMLFrameElementBase.cpp: Ditto.
2849
* html/HTMLFrameSetElement.cpp: Ditto.
2850
* html/HTMLHRElement.cpp: Ditto.
2851
* html/HTMLIFrameElement.cpp: Ditto.
2852
* html/HTMLImageElement.cpp: Ditto.
2853
* html/HTMLInputElement.cpp: Ditto.
2854
* html/HTMLIsIndexElement.cpp: Ditto.
2855
* html/HTMLKeygenElement.cpp: Ditto.
2856
* html/HTMLLIElement.cpp: Ditto.
2857
* html/HTMLLinkElement.cpp: Ditto.
2858
* html/HTMLMarqueeElement.cpp: Ditto.
2859
* html/HTMLMetaElement.cpp: Ditto.
2860
* html/HTMLOListElement.cpp: Ditto.
2861
* html/HTMLObjectElement.cpp: Ditto.
2862
* html/HTMLOptionElement.cpp: Ditto.
2863
* html/HTMLParagraphElement.cpp: Ditto.
2864
* html/HTMLParamElement.cpp: Ditto.
2865
* html/HTMLPlugInElement.cpp: Ditto.
2866
* html/HTMLPreElement.cpp: Ditto.
2867
* html/HTMLScriptElement.cpp: Ditto.
2868
* html/HTMLSelectElement.cpp: Ditto.
2869
* html/HTMLStyleElement.cpp: Ditto.
2870
* html/HTMLTableCaptionElement.cpp: Ditto.
2871
* html/HTMLTableCellElement.cpp: Ditto.
2872
* html/HTMLTableColElement.cpp: Ditto.
2873
* html/HTMLTablePartElement.cpp: Ditto.
2874
* html/HTMLTextAreaElement.cpp: Ditto.
2875
* html/HTMLTokenizer.cpp: Ditto.
2876
* html/HTMLUListElement.cpp: Ditto.
2877
* html/HTMLVideoElement.cpp: Ditto.
2878
* html/HTMLViewSourceDocument.cpp: Ditto.
2879
* loader/ImageDocument.cpp: Ditto.
2880
* page/Frame.cpp: Ditto.
2881
* rendering/RenderTreeAsText.cpp: Ditto.
2882
* svg/SVGAElement.cpp: Ditto.
2883
* svg/SVGAnimateMotionElement.cpp: Ditto.
2884
* svg/SVGAnimateTransformElement.cpp: Ditto.
2885
* svg/SVGAnimationElement.cpp: Ditto.
2886
* svg/SVGCircleElement.cpp: Ditto.
2887
* svg/SVGClipPathElement.cpp: Ditto.
2888
* svg/SVGCursorElement.cpp: Ditto.
2889
* svg/SVGElement.cpp: Ditto.
2890
* svg/SVGEllipseElement.cpp: Ditto.
2891
* svg/SVGExternalResourcesRequired.cpp: Ditto.
2892
* svg/SVGFitToViewBox.cpp: Ditto.
2893
* svg/SVGFontFaceElement.cpp: Ditto.
2894
* svg/SVGFontFaceUriElement.cpp: Ditto.
2895
* svg/SVGForeignObjectElement.cpp: Ditto.
2896
* svg/SVGGlyphElement.cpp: Ditto.
2897
* svg/SVGGradientElement.cpp: Ditto.
2898
* svg/SVGImageElement.cpp: Ditto.
2899
* svg/SVGLangSpace.cpp: Ditto.
2900
* svg/SVGLineElement.cpp: Ditto.
2901
* svg/SVGLinearGradientElement.cpp: Ditto.
2902
* svg/SVGMarkerElement.cpp: Ditto.
2903
* svg/SVGMaskElement.cpp: Ditto.
2904
* svg/SVGPathElement.cpp: Ditto.
2905
* svg/SVGPatternElement.cpp: Ditto.
2906
* svg/SVGPolyElement.cpp: Ditto.
2907
* svg/SVGRadialGradientElement.cpp: Ditto.
2908
* svg/SVGRectElement.cpp: Ditto.
2909
* svg/SVGSVGElement.cpp: Ditto.
2910
* svg/SVGScriptElement.cpp: Ditto.
2911
* svg/SVGStopElement.cpp: Ditto.
2912
* svg/SVGStyleElement.cpp: Ditto.
2913
* svg/SVGStyledElement.cpp: Ditto.
2914
* svg/SVGStyledTransformableElement.cpp: Ditto.
2915
* svg/SVGTests.cpp: Ditto.
2916
* svg/SVGTextContentElement.cpp: Ditto.
2917
* svg/SVGTextElement.cpp: Ditto.
2918
* svg/SVGTextPathElement.cpp: Ditto.
2919
* svg/SVGTextPositioningElement.cpp: Ditto.
2920
* svg/SVGURIReference.cpp: Ditto.
2921
* svg/SVGUseElement.cpp: Ditto.
2922
* svg/SVGViewElement.cpp: Ditto.
2923
* svg/animation/SVGSMILElement.cpp: Ditto.
2924
* xml/XPathStep.cpp: Ditto.
2925
2926
2009-05-04 Pavel Feldman <pfeldman@chromium.org>
2927
2928
Reviewed by Timothy Hatcher.
2929
2930
Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
2931
https://bugs.webkit.org/show_bug.cgi?id=25520
2932
2933
* inspector/front-end/inspector.js:
2934
(WebInspector.loaded):
2935
2936
2009-05-04 Brady Eidson <beidson@apple.com>
2937
2938
Reviewed by Darin Adler.
2939
2940
<rdar://problem/6839881> With "Mail Contents of This Page" in Safari images don't appear in the Tiger Mail compose window
2941
2942
DocumentLoader::subresource() is the implementation for the WebKit API [WebDataSource subresourceForURL:] and has
2943
particularly sticky behavior.
2944
2945
If the DocumentLoader represents a WebArchive, this method should return ArchiveResources from that archive. However, we
2946
prefer CachedResources over ArchiveResources because they might represent fresher data than what was originally loaded
2947
from the WebArchive.
2948
2949
In some instances, CachedResources are created and associated with the DocumentLoader but not immediately run through the
2950
loading delegate machinery. This was always a possibility, but the Preload Scanner made this significantly more likely.
2951
2952
When this happens and someone asks the WebDataSource for a subresource, it would prefer the CachedResource over an
2953
ArchiveResource it has even if the CachedResource hasn't been loaded yet. The CachedResource has nil data, so no
2954
WebResource is returned, and the client thinks the subresource doesn't exist even though it does.
2955
2956
This broke Tiger Mail and probably various other WebKit applications but has a fairly straightforward fix.
2957
2958
* loader/DocumentLoader.cpp:
2959
(WebCore::DocumentLoader::subresource): If there is a CachedResource but it hasn't been loaded yet, fallback to the
2960
ArchiveResource.
2961
2962
2009-05-04 Eric Carlson <eric.carlson@apple.com>
2963
2964
Reviewed by Adam Roben.
2965
2966
https://bugs.webkit.org/show_bug.cgi?id=25545
2967
Bug 25545: HTMLMediaElement: display anamorphic video correctly
2968
2969
Tell QuickTime to use clean aperture mode so movies with non-square pixels are sized
2970
and displayed correctly.
2971
2972
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2973
(WebCore::MediaPlayerPrivate::createQTMovie): Ask QuickTime to use clean aperture mode.
2974
* platform/graphics/win/QTMovieWin.cpp:
2975
(QTMovieWin::load): Ditto. Add ASSERT to ensure that static movie property array isn't
2976
filled beyond capacity.
2977
2978
2009-05-03 Mark Rowe <mrowe@apple.com>
2979
2980
Reviewed by Darin Adler.
2981
2982
Fix <https://bugs.webkit.org/show_bug.cgi?id=25332>.
2983
Bug 25332: Plug-in inserted in to DOM of PluginDocument fails to load
2984
2985
Only the first plug-in in a PluginDocument can use the main resource data. For all
2986
subsequent plug-ins, such as the plug-in that ClickToFlash inserts when swapping itself
2987
out for the real Flash plug-in, we need to load the resource data in the same manner
2988
as for other embedded plug-ins.
2989
2990
* loader/FrameLoader.cpp:
2991
(WebCore::FrameLoader::loadPlugin):
2992
2993
2009-05-04 Simon Hausmann <simon.hausmann@nokia.com>
2994
2995
Rubber-stamped by Ariya Hidayat.
2996
2997
Update the qrc file for the Web Inspector in the Qt build
2998
with missing files.
2999
3000
* inspector/front-end/WebKit.qrc:
3001
3002
2009-05-03 Eric Seidel <eric@webkit.org>
3003
3004
Reviewed by George Staikos.
3005
3006
Move absoluteRects and absoluteQuads into RenderSVGInline and remove absoluteTransform() usage
3007
https://bugs.webkit.org/show_bug.cgi?id=25532
3008
3009
* rendering/RenderSVGInline.cpp:
3010
(WebCore::RenderSVGInline::absoluteRects):
3011
(WebCore::RenderSVGInline::absoluteQuads):
3012
* rendering/RenderSVGInline.h:
3013
* rendering/RenderSVGTSpan.cpp:
3014
* rendering/RenderSVGTSpan.h:
3015
* rendering/RenderSVGTextPath.cpp:
3016
* rendering/RenderSVGTextPath.h:
3017
3018
2009-05-03 Eric Seidel <eric@webkit.org>
3019
3020
Reviewed by George Staikos.
3021
3022
Move RenderSVGText off of localToAbsolute()
3023
https://bugs.webkit.org/show_bug.cgi?id=25532
3024
3025
* rendering/RenderSVGText.cpp:
3026
(WebCore::RenderSVGText::absoluteRects):
3027
(WebCore::RenderSVGText::absoluteQuads):
3028
3029
2009-05-03 Eric Seidel <eric@webkit.org>
3030
3031
Reviewed by George Staikos.
3032
3033
Remove broken absoluteTransform() code from RenderSVGInlineText
3034
https://bugs.webkit.org/show_bug.cgi?id=25532
3035
3036
This improved SVG text focus rings.
3037
This also improved SVG.getScreenCTM() results.
3038
3039
SVGSVGElement::getScreenCTM was passing "true" for the second argument in
3040
localToAbsolute, which is "fixed" it meant to pass "true" for the
3041
third argument (useTransforms). That change alone caused no layout test changes, however
3042
before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer
3043
3044
mapLocalToContainer implementations really should be shared,
3045
but I'll do that in a later patch.
3046
3047
* rendering/RenderSVGInlineText.cpp:
3048
(WebCore::RenderSVGInlineText::styleDidChange):
3049
(WebCore::RenderSVGInlineText::absoluteQuads):
3050
(WebCore::RenderSVGInlineText::computeRepaintRectForRange):
3051
(WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
3052
* rendering/RenderSVGInlineText.h:
3053
* rendering/RenderSVGRoot.cpp:
3054
(WebCore::RenderSVGRoot::mapLocalToContainer):
3055
* rendering/RenderSVGRoot.h:
3056
* rendering/RenderSVGText.cpp:
3057
(WebCore::RenderSVGText::mapLocalToContainer):
3058
* rendering/RenderSVGText.h:
3059
* svg/SVGSVGElement.cpp:
3060
(WebCore::SVGSVGElement::getScreenCTM):
3061
3062
2009-05-03 Eric Seidel <eric@webkit.org>
3063
3064
Reviewed by George Staikos.
3065
3066
Remove dead code from RenderPath
3067
https://bugs.webkit.org/show_bug.cgi?id=25532
3068
3069
* rendering/RenderPath.cpp:
3070
* rendering/RenderPath.h:
3071
3072
2009-05-03 Eric Seidel <eric@webkit.org>
3073
3074
Reviewed by George Staikos.
3075
3076
Share layout code between RenderSVGViewportContainer and RenderSVGContainer
3077
https://bugs.webkit.org/show_bug.cgi?id=25532
3078
3079
* rendering/RenderSVGContainer.cpp:
3080
(WebCore::RenderSVGContainer::layout):
3081
* rendering/RenderSVGContainer.h:
3082
(WebCore::RenderSVGContainer::calcViewport):
3083
* rendering/RenderSVGViewportContainer.cpp:
3084
(WebCore::RenderSVGViewportContainer::applyViewportClip):
3085
* rendering/RenderSVGViewportContainer.h:
3086
3087
2009-05-03 Eric Seidel <eric@webkit.org>
3088
3089
Reviewed by George Staikos.
3090
3091
Remove redundant disableLayoutState() calls
3092
https://bugs.webkit.org/show_bug.cgi?id=25532
3093
3094
* rendering/RenderForeignObject.cpp:
3095
(WebCore::RenderForeignObject::layout):
3096
* rendering/RenderSVGContainer.cpp:
3097
(WebCore::RenderSVGContainer::layout):
3098
* rendering/RenderSVGViewportContainer.cpp:
3099
(WebCore::RenderSVGViewportContainer::layout):
3100
3101
2009-05-03 Eric Seidel <eric@webkit.org>
3102
3103
Reviewed by George Staikos.
3104
3105
Simplify RenderForeignObject::paint and fix a repaint bug.
3106
Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
3107
https://bugs.webkit.org/show_bug.cgi?id=16939
3108
3109
* rendering/RenderForeignObject.cpp:
3110
(WebCore::RenderForeignObject::paint):
3111
3112
2009-05-03 Hironori Bono <hbono@chromium.org>
3113
3114
Reviewed by Eric Seidel.
3115
3116
Test: editing/spelling/spellcheck-attribute.html
3117
3118
Bug 14552: Add a way to disable spell checking for specific element
3119
https://bugs.webkit.org/show_bug.cgi?id=14552
3120
3121
For compatibility with Firefox, this code ascends the DOM tree when an element does
3122
not have its "spellcheck" attribute.
3123
3124
* editing/Editor.cpp:
3125
(WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck"
3126
attribute of an element before calling a spell checker or a grammar checker.
3127
* html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
3128
3129
2009-05-03 Sam Weinig <sam@webkit.org>
3130
3131
Roll JSC API number marshaling back in one last time (I hope).
3132
3133
2009-05-03 Sam Weinig <sam@webkit.org>
3134
3135
Roll JSC API number marshaling back out. It still breaks windows.
3136
3137
2009-05-03 Sam Weinig <sam@webkit.org>
3138
3139
Roll JSC API number marshaling back in.
3140
3141
2009-05-02 Dan Bernstein <mitz@apple.com>
3142
3143
Reviewed by Darin Adler.
3144
3145
- another fix for <rdar://problem/6617298> Typing delete on an unquoted
3146
blank line unquotes the preceding, quoted blank line
3147
3148
Test: editing/deleting/type-delete-after-quote-2.html
3149
3150
* editing/DeleteSelectionCommand.cpp:
3151
(WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize
3152
m_startsAtEmptyLine.
3153
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): When the
3154
selection starts at an empty line, do not prevent the merging of blocks.
3155
This is what allows the text after the line break to be merged into the
3156
block containing the line break. Also set m_startsAtEmptyLine to true.
3157
(WebCore::DeleteSelectionCommand::mergeParagraphs): If
3158
m_startsAtEmptyLine is true, create a placeholder BR to serve as the
3159
merge destination.
3160
* editing/DeleteSelectionCommand.h:
3161
3162
2009-05-02 Geoffrey Garen <ggaren@apple.com>
3163
3164
Reviewed by Sam Weinig.
3165
3166
Simplified null-ish JSValues.
3167
3168
Replaced calls to noValue() with calls to JSValue() (which is what
3169
noValue() returned). Removed noValue().
3170
3171
Removed "JSValue()" initialiazers, since default construction happens...
3172
by default.
3173
3174
* bindings/js/JSDOMBinding.cpp:
3175
(WebCore::setDOMException):
3176
* bindings/js/JSDOMWindowCustom.cpp:
3177
(WebCore::JSDOMWindow::open):
3178
(WebCore::JSDOMWindow::showModalDialog):
3179
* bindings/js/JSEventListener.cpp:
3180
(WebCore::JSEventListener::handleEvent):
3181
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
3182
(WebCore::JSJavaScriptCallFrame::evaluate):
3183
* bindings/js/JSSQLResultSetRowListCustom.cpp:
3184
(WebCore::JSSQLResultSetRowList::item):
3185
* bindings/js/ScriptController.cpp:
3186
(WebCore::ScriptController::evaluate):
3187
* bindings/js/ScriptValue.h:
3188
(WebCore::ScriptValue::ScriptValue):
3189
(WebCore::ScriptValue::hasNoValue):
3190
* bindings/js/WorkerScriptController.cpp:
3191
(WebCore::WorkerScriptController::evaluate):
3192
* bridge/jni/jni_instance.cpp:
3193
(JavaInstance::invokeMethod):
3194
* bridge/jni/jni_runtime.cpp:
3195
(JavaField::dispatchValueFromInstance):
3196
(JavaField::dispatchSetValueToInstance):
3197
* bridge/runtime.h:
3198
(JSC::Bindings::Instance::invokeConstruct):
3199
3200
2009-05-02 Antti Koivisto <antti@apple.com>
3201
3202
Reviewed by Dan Bernstein.
3203
3204
<rdar://problem/6631735> Crash in WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*) (RenderStyle.h:454)
3205
3206
Avoid re-entering style selector from load delegates by not issuing resource loads synchronously during attach().
3207
3208
* dom/ContainerNode.cpp:
3209
(WebCore::ContainerNode::suspendPostAttachCallbacks):
3210
(WebCore::ContainerNode::resumePostAttachCallbacks):
3211
(WebCore::ContainerNode::attach):
3212
* dom/Element.cpp:
3213
(WebCore::Element::attach):
3214
* loader/loader.cpp:
3215
(WebCore::Loader::Loader):
3216
(WebCore::Loader::servePendingRequests):
3217
(WebCore::Loader::suspendPendingRequests):
3218
(WebCore::Loader::resumePendingRequests):
3219
(WebCore::Loader::Host::servePendingRequests):
3220
* loader/loader.h:
3221
(WebCore::Loader::isSuspendingPendingRequests):
3222
3223
2009-05-02 Darin Adler <darin@apple.com>
3224
3225
Reviewed by Dan Bernstein.
3226
3227
Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
3228
https://bugs.webkit.org/show_bug.cgi?id=25352
3229
rdar://problem/6823239
3230
3231
Test: http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html
3232
3233
* platform/network/HTTPParsers.cpp:
3234
(WebCore::extractMIMETypeFromMediaType): Allow comma as a separator.
3235
3236
2009-05-02 Darin Adler <darin@apple.com>
3237
3238
Reviewed by Brady Eidson.
3239
3240
Bug 25491: WebFrame leak when a subframe removes itself
3241
https://bugs.webkit.org/show_bug.cgi?id=25491
3242
rdar://problem/6833859
3243
3244
Test: fast/loading/subframe-removes-itself.html
3245
3246
* loader/FrameLoader.cpp:
3247
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true,
3248
treat load as complete, even if isLoadingInAPISense is still returning true.
3249
3250
2009-05-01 Sam Weinig <sam@webkit.org>
3251
3252
Roll out JavaScriptCore API number marshaling.
3253
3254
* bindings/js/ScriptValue.cpp:
3255
(WebCore::ScriptValue::isEqual):
3256
* inspector/JavaScriptProfile.cpp:
3257
(WebCore::getHeadCallback):
3258
* inspector/JavaScriptProfileNode.cpp:
3259
(WebCore::getChildren):
3260
(WebCore::getParent):
3261
(WebCore::getHead):
3262
3263
2009-05-01 Sam Weinig <sam@webkit.org>
3264
3265
Fix build.
3266
3267
* workers/WorkerContext.idl:
3268
3269
2009-05-01 Sam Weinig <sam@webkit.org>
3270
3271
Reviewed by Oliver Hunt.
3272
3273
Cleanup workers code a bit.
3274
3275
* bindings/js/JSWorkerContextBase.cpp:
3276
(WebCore::toJS):
3277
* bindings/js/JSWorkerContextBase.h:
3278
* bindings/js/JSWorkerContextCustom.cpp:
3279
(WebCore::JSWorkerContext::customGetOwnPropertySlot):
3280
* workers/WorkerContext.h:
3281
(WebCore::WorkerContext::toWorkerContext):
3282
(WebCore::WorkerContext::self):
3283
(WebCore::WorkerContext::setOnmessage):
3284
(WebCore::WorkerContext::onmessage):
3285
* workers/WorkerContext.idl:
3286
3287
2009-05-01 Sam Weinig <sam@webkit.org>
3288
3289
Reviewed by Darin Adler.
3290
3291
A little clean up.
3292
3293
* loader/FrameLoader.cpp:
3294
(WebCore::FrameLoader::createJavaAppletWidget):
3295
3296
2009-05-01 Sam Weinig <sam@webkit.org>
3297
3298
Fix the build.
3299
3300
* bindings/js/ScriptValue.cpp:
3301
(WebCore::ScriptValue::isEqual):
3302
* inspector/JavaScriptProfile.cpp:
3303
(WebCore::getHeadCallback):
3304
* inspector/JavaScriptProfileNode.cpp:
3305
(WebCore::getChildren):
3306
(WebCore::getParent):
3307
(WebCore::getHead):
3308
3309
2009-05-01 Brady Eidson <beidson@apple.com>
3310
3311
Reviewed by Oliver Hunt and Sam "Jon 'The Belly' Honeycutt" Weinig
3312
3313
Fix <rdar://problem/6848867> Addition of DOCTYPE node breaks Tiger Mail
3314
3315
* bindings/objc/DOMHTML.mm:
3316
(-[DOMHTMLDocument firstChild]): Add a Tiger Mail version of this method that skips DOCTYPE nodes.
3317
3318
2009-05-01 Geoffrey Garen <ggaren@apple.com>
3319
3320
Rubber Stamped by Sam Weinig.
3321
3322
Renamed JSValuePtr => JSValue.
3323
3324
* bindings/js/JSAttrCustom.cpp:
3325
(WebCore::JSAttr::setValue):
3326
* bindings/js/JSCDATASectionCustom.cpp:
3327
(WebCore::toJSNewlyCreated):
3328
* bindings/js/JSCSSRuleCustom.cpp:
3329
(WebCore::toJS):
3330
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
3331
(WebCore::JSCSSStyleDeclaration::nameGetter):
3332
(WebCore::JSCSSStyleDeclaration::customPut):
3333
* bindings/js/JSCSSValueCustom.cpp:
3334
(WebCore::toJS):
3335
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
3336
(WebCore::toJS):
3337
(WebCore::toHTMLCanvasStyle):
3338
(WebCore::JSCanvasRenderingContext2D::strokeStyle):
3339
(WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
3340
(WebCore::JSCanvasRenderingContext2D::fillStyle):
3341
(WebCore::JSCanvasRenderingContext2D::setFillStyle):
3342
(WebCore::JSCanvasRenderingContext2D::setFillColor):
3343
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
3344
(WebCore::JSCanvasRenderingContext2D::strokeRect):
3345
(WebCore::JSCanvasRenderingContext2D::drawImage):
3346
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
3347
(WebCore::JSCanvasRenderingContext2D::setShadow):
3348
(WebCore::JSCanvasRenderingContext2D::createPattern):
3349
(WebCore::JSCanvasRenderingContext2D::putImageData):
3350
(WebCore::JSCanvasRenderingContext2D::fillText):
3351
(WebCore::JSCanvasRenderingContext2D::strokeText):
3352
* bindings/js/JSClipboardCustom.cpp:
3353
(WebCore::JSClipboard::types):
3354
(WebCore::JSClipboard::clearData):
3355
(WebCore::JSClipboard::getData):
3356
(WebCore::JSClipboard::setData):
3357
(WebCore::JSClipboard::setDragImage):
3358
* bindings/js/JSConsoleCustom.cpp:
3359
(WebCore::JSConsole::profiles):
3360
* bindings/js/JSCoordinatesCustom.cpp:
3361
(WebCore::JSCoordinates::altitude):
3362
(WebCore::JSCoordinates::altitudeAccuracy):
3363
(WebCore::JSCoordinates::heading):
3364
(WebCore::JSCoordinates::speed):
3365
* bindings/js/JSCustomPositionCallback.cpp:
3366
(WebCore::JSCustomPositionCallback::handleEvent):
3367
* bindings/js/JSCustomPositionErrorCallback.cpp:
3368
(WebCore::JSCustomPositionErrorCallback::handleEvent):
3369
* bindings/js/JSCustomSQLStatementCallback.cpp:
3370
(WebCore::JSCustomSQLStatementCallback::handleEvent):
3371
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3372
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3373
* bindings/js/JSCustomSQLTransactionCallback.cpp:
3374
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
3375
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3376
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3377
* bindings/js/JSCustomVoidCallback.cpp:
3378
(WebCore::JSCustomVoidCallback::handleEvent):
3379
(WebCore::toVoidCallback):
3380
* bindings/js/JSCustomVoidCallback.h:
3381
* bindings/js/JSCustomXPathNSResolver.cpp:
3382
(WebCore::JSCustomXPathNSResolver::create):
3383
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3384
* bindings/js/JSCustomXPathNSResolver.h:
3385
* bindings/js/JSDOMApplicationCacheCustom.cpp:
3386
(WebCore::JSDOMApplicationCache::hasItem):
3387
(WebCore::JSDOMApplicationCache::add):
3388
(WebCore::JSDOMApplicationCache::remove):
3389
(WebCore::JSDOMApplicationCache::addEventListener):
3390
(WebCore::JSDOMApplicationCache::removeEventListener):
3391
* bindings/js/JSDOMBinding.cpp:
3392
(WebCore::jsStringOrNull):
3393
(WebCore::jsOwnedStringOrNull):
3394
(WebCore::jsStringOrUndefined):
3395
(WebCore::jsStringOrFalse):
3396
(WebCore::valueToStringWithNullCheck):
3397
(WebCore::valueToStringWithUndefinedOrNullCheck):
3398
(WebCore::reportException):
3399
(WebCore::reportCurrentException):
3400
(WebCore::setDOMException):
3401
(WebCore::objectToStringFunctionGetter):
3402
* bindings/js/JSDOMBinding.h:
3403
(WebCore::getDOMObjectWrapper):
3404
(WebCore::getDOMNodeWrapper):
3405
(WebCore::toJS):
3406
* bindings/js/JSDOMGlobalObject.cpp:
3407
(WebCore::JSDOMGlobalObject::findJSEventListener):
3408
(WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
3409
(WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
3410
* bindings/js/JSDOMGlobalObject.h:
3411
* bindings/js/JSDOMStringListCustom.cpp:
3412
(WebCore::JSDOMStringList::getByIndex):
3413
(WebCore::JSDOMStringList::item):
3414
* bindings/js/JSDOMWindowBase.cpp:
3415
(WebCore::JSDOMWindowBase::childFrameGetter):
3416
(WebCore::JSDOMWindowBase::indexGetter):
3417
(WebCore::JSDOMWindowBase::namedItemGetter):
3418
(WebCore::JSDOMWindowBase::getOwnPropertySlot):
3419
(WebCore::JSDOMWindowBase::put):
3420
(WebCore::JSDOMWindowBase::setReturnValueSlot):
3421
(WebCore::toJS):
3422
(WebCore::toJSDOMWindow):
3423
* bindings/js/JSDOMWindowBase.h:
3424
* bindings/js/JSDOMWindowCustom.cpp:
3425
(WebCore::JSDOMWindow::lookupGetter):
3426
(WebCore::JSDOMWindow::lookupSetter):
3427
(WebCore::JSDOMWindow::history):
3428
(WebCore::JSDOMWindow::location):
3429
(WebCore::JSDOMWindow::setLocation):
3430
(WebCore::JSDOMWindow::crypto):
3431
(WebCore::JSDOMWindow::event):
3432
(WebCore::JSDOMWindow::image):
3433
(WebCore::JSDOMWindow::option):
3434
(WebCore::JSDOMWindow::audio):
3435
(WebCore::JSDOMWindow::webKitPoint):
3436
(WebCore::JSDOMWindow::webKitCSSMatrix):
3437
(WebCore::JSDOMWindow::xmlHttpRequest):
3438
(WebCore::JSDOMWindow::xsltProcessor):
3439
(WebCore::JSDOMWindow::messageChannel):
3440
(WebCore::JSDOMWindow::worker):
3441
(WebCore::createWindow):
3442
(WebCore::JSDOMWindow::open):
3443
(WebCore::JSDOMWindow::showModalDialog):
3444
(WebCore::JSDOMWindow::postMessage):
3445
(WebCore::JSDOMWindow::setTimeout):
3446
(WebCore::JSDOMWindow::setInterval):
3447
(WebCore::JSDOMWindow::atob):
3448
(WebCore::JSDOMWindow::btoa):
3449
(WebCore::JSDOMWindow::addEventListener):
3450
(WebCore::JSDOMWindow::removeEventListener):
3451
(WebCore::toDOMWindow):
3452
* bindings/js/JSDOMWindowCustom.h:
3453
(WebCore::nonCachingStaticFunctionGetter):
3454
(WebCore::JSDOMWindow::customPut):
3455
* bindings/js/JSDOMWindowShell.cpp:
3456
(WebCore::JSDOMWindowShell::put):
3457
(WebCore::JSDOMWindowShell::putWithAttributes):
3458
(WebCore::JSDOMWindowShell::lookupGetter):
3459
(WebCore::JSDOMWindowShell::lookupSetter):
3460
(WebCore::toJS):
3461
* bindings/js/JSDOMWindowShell.h:
3462
(WebCore::JSDOMWindowShell::createStructure):
3463
* bindings/js/JSDatabaseCustom.cpp:
3464
(WebCore::JSDatabase::changeVersion):
3465
(WebCore::JSDatabase::transaction):
3466
* bindings/js/JSDocumentCustom.cpp:
3467
(WebCore::JSDocument::location):
3468
(WebCore::JSDocument::setLocation):
3469
(WebCore::toJS):
3470
* bindings/js/JSElementCustom.cpp:
3471
(WebCore::JSElement::setAttribute):
3472
(WebCore::JSElement::setAttributeNode):
3473
(WebCore::JSElement::setAttributeNS):
3474
(WebCore::JSElement::setAttributeNodeNS):
3475
(WebCore::toJSNewlyCreated):
3476
* bindings/js/JSEventCustom.cpp:
3477
(WebCore::JSEvent::clipboardData):
3478
(WebCore::toJS):
3479
* bindings/js/JSEventListener.cpp:
3480
(WebCore::JSEventListener::handleEvent):
3481
* bindings/js/JSEventTarget.cpp:
3482
(WebCore::toJS):
3483
(WebCore::toEventTarget):
3484
* bindings/js/JSEventTarget.h:
3485
* bindings/js/JSEventTargetBase.h:
3486
* bindings/js/JSGeolocationCustom.cpp:
3487
(WebCore::createPositionOptions):
3488
(WebCore::JSGeolocation::getCurrentPosition):
3489
(WebCore::JSGeolocation::watchPosition):
3490
* bindings/js/JSHTMLAllCollection.h:
3491
(WebCore::JSHTMLAllCollection::createStructure):
3492
* bindings/js/JSHTMLAppletElementCustom.cpp:
3493
(WebCore::JSHTMLAppletElement::customPut):
3494
(WebCore::JSHTMLAppletElement::nameGetter):
3495
* bindings/js/JSHTMLCollectionCustom.cpp:
3496
(WebCore::getNamedItems):
3497
(WebCore::callHTMLCollection):
3498
(WebCore::JSHTMLCollection::nameGetter):
3499
(WebCore::JSHTMLCollection::item):
3500
(WebCore::JSHTMLCollection::namedItem):
3501
(WebCore::toJS):
3502
* bindings/js/JSHTMLDocumentCustom.cpp:
3503
(WebCore::JSHTMLDocument::nameGetter):
3504
(WebCore::JSHTMLDocument::all):
3505
(WebCore::JSHTMLDocument::setAll):
3506
(WebCore::JSHTMLDocument::open):
3507
(WebCore::JSHTMLDocument::write):
3508
(WebCore::JSHTMLDocument::writeln):
3509
* bindings/js/JSHTMLEmbedElementCustom.cpp:
3510
(WebCore::JSHTMLEmbedElement::customPut):
3511
(WebCore::JSHTMLEmbedElement::nameGetter):
3512
* bindings/js/JSHTMLFormElementCustom.cpp:
3513
(WebCore::JSHTMLFormElement::nameGetter):
3514
(WebCore::JSHTMLFormElement::submit):
3515
* bindings/js/JSHTMLFrameElementCustom.cpp:
3516
(WebCore::JSHTMLFrameElement::setSrc):
3517
(WebCore::JSHTMLFrameElement::setLocation):
3518
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
3519
(WebCore::JSHTMLFrameSetElement::nameGetter):
3520
* bindings/js/JSHTMLIFrameElementCustom.cpp:
3521
(WebCore::JSHTMLIFrameElement::setSrc):
3522
* bindings/js/JSHTMLInputElementCustom.cpp:
3523
(WebCore::JSHTMLInputElement::selectionStart):
3524
(WebCore::JSHTMLInputElement::setSelectionStart):
3525
(WebCore::JSHTMLInputElement::selectionEnd):
3526
(WebCore::JSHTMLInputElement::setSelectionEnd):
3527
(WebCore::JSHTMLInputElement::setSelectionRange):
3528
* bindings/js/JSHTMLObjectElementCustom.cpp:
3529
(WebCore::JSHTMLObjectElement::customPut):
3530
(WebCore::JSHTMLObjectElement::nameGetter):
3531
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
3532
(WebCore::JSHTMLOptionsCollection::length):
3533
(WebCore::JSHTMLOptionsCollection::setLength):
3534
(WebCore::JSHTMLOptionsCollection::indexSetter):
3535
(WebCore::JSHTMLOptionsCollection::add):
3536
(WebCore::JSHTMLOptionsCollection::remove):
3537
* bindings/js/JSHTMLSelectElementCustom.cpp:
3538
(WebCore::JSHTMLSelectElement::remove):
3539
(WebCore::selectIndexSetter):
3540
(WebCore::JSHTMLSelectElement::indexSetter):
3541
* bindings/js/JSHTMLSelectElementCustom.h:
3542
* bindings/js/JSHistoryCustom.cpp:
3543
(WebCore::nonCachingStaticBackFunctionGetter):
3544
(WebCore::nonCachingStaticForwardFunctionGetter):
3545
(WebCore::nonCachingStaticGoFunctionGetter):
3546
(WebCore::JSHistory::customPut):
3547
* bindings/js/JSImageDataCustom.cpp:
3548
(WebCore::toJS):
3549
* bindings/js/JSInspectedObjectWrapper.cpp:
3550
(WebCore::JSInspectedObjectWrapper::wrap):
3551
(WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
3552
* bindings/js/JSInspectedObjectWrapper.h:
3553
(WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
3554
* bindings/js/JSInspectorCallbackWrapper.cpp:
3555
(WebCore::JSInspectorCallbackWrapper::wrap):
3556
(WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
3557
* bindings/js/JSInspectorCallbackWrapper.h:
3558
(WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
3559
* bindings/js/JSInspectorControllerCustom.cpp:
3560
(WebCore::JSInspectorController::highlightDOMNode):
3561
(WebCore::JSInspectorController::addResourceSourceToFrame):
3562
(WebCore::JSInspectorController::addSourceToFrame):
3563
(WebCore::JSInspectorController::getResourceDocumentNode):
3564
(WebCore::JSInspectorController::search):
3565
(WebCore::JSInspectorController::databaseTableNames):
3566
(WebCore::JSInspectorController::inspectedWindow):
3567
(WebCore::JSInspectorController::setting):
3568
(WebCore::JSInspectorController::setSetting):
3569
(WebCore::JSInspectorController::wrapCallback):
3570
(WebCore::JSInspectorController::currentCallFrame):
3571
(WebCore::JSInspectorController::profiles):
3572
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
3573
(WebCore::JSJavaScriptCallFrame::evaluate):
3574
(WebCore::JSJavaScriptCallFrame::thisObject):
3575
(WebCore::JSJavaScriptCallFrame::type):
3576
(WebCore::JSJavaScriptCallFrame::scopeChain):
3577
* bindings/js/JSLazyEventListener.cpp:
3578
(WebCore::JSLazyEventListener::parseCode):
3579
* bindings/js/JSLocationCustom.cpp:
3580
(WebCore::nonCachingStaticReplaceFunctionGetter):
3581
(WebCore::nonCachingStaticReloadFunctionGetter):
3582
(WebCore::nonCachingStaticAssignFunctionGetter):
3583
(WebCore::JSLocation::customPut):
3584
(WebCore::JSLocation::setHref):
3585
(WebCore::JSLocation::setProtocol):
3586
(WebCore::JSLocation::setHost):
3587
(WebCore::JSLocation::setHostname):
3588
(WebCore::JSLocation::setPort):
3589
(WebCore::JSLocation::setPathname):
3590
(WebCore::JSLocation::setSearch):
3591
(WebCore::JSLocation::setHash):
3592
(WebCore::JSLocation::replace):
3593
(WebCore::JSLocation::reload):
3594
(WebCore::JSLocation::assign):
3595
(WebCore::JSLocation::toString):
3596
(WebCore::JSLocationPrototype::customPut):
3597
* bindings/js/JSMessagePortCustom.cpp:
3598
(WebCore::JSMessagePort::startConversation):
3599
(WebCore::JSMessagePort::addEventListener):
3600
(WebCore::JSMessagePort::removeEventListener):
3601
* bindings/js/JSMimeTypeArrayCustom.cpp:
3602
(WebCore::JSMimeTypeArray::nameGetter):
3603
* bindings/js/JSNamedNodeMapCustom.cpp:
3604
(WebCore::JSNamedNodeMap::nameGetter):
3605
* bindings/js/JSNamedNodesCollection.cpp:
3606
(WebCore::JSNamedNodesCollection::lengthGetter):
3607
(WebCore::JSNamedNodesCollection::indexGetter):
3608
* bindings/js/JSNamedNodesCollection.h:
3609
(WebCore::JSNamedNodesCollection::createStructure):
3610
* bindings/js/JSNavigatorCustom.cpp:
3611
(WebCore::needsYouTubeQuirk):
3612
(WebCore::JSNavigator::appVersion):
3613
* bindings/js/JSNodeCustom.cpp:
3614
(WebCore::JSNode::insertBefore):
3615
(WebCore::JSNode::replaceChild):
3616
(WebCore::JSNode::removeChild):
3617
(WebCore::JSNode::appendChild):
3618
(WebCore::JSNode::addEventListener):
3619
(WebCore::JSNode::removeEventListener):
3620
(WebCore::createWrapper):
3621
(WebCore::toJSNewlyCreated):
3622
(WebCore::toJS):
3623
* bindings/js/JSNodeFilterCondition.cpp:
3624
(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
3625
(WebCore::JSNodeFilterCondition::acceptNode):
3626
* bindings/js/JSNodeFilterCondition.h:
3627
(WebCore::JSNodeFilterCondition::create):
3628
* bindings/js/JSNodeFilterCustom.cpp:
3629
(WebCore::JSNodeFilter::acceptNode):
3630
(WebCore::toNodeFilter):
3631
* bindings/js/JSNodeIteratorCustom.cpp:
3632
(WebCore::JSNodeIterator::nextNode):
3633
(WebCore::JSNodeIterator::previousNode):
3634
* bindings/js/JSNodeListCustom.cpp:
3635
(WebCore::callNodeList):
3636
(WebCore::JSNodeList::nameGetter):
3637
* bindings/js/JSPluginArrayCustom.cpp:
3638
(WebCore::JSPluginArray::nameGetter):
3639
* bindings/js/JSPluginCustom.cpp:
3640
(WebCore::JSPlugin::nameGetter):
3641
* bindings/js/JSPluginElementFunctions.cpp:
3642
(WebCore::runtimeObjectGetter):
3643
(WebCore::runtimeObjectPropertyGetter):
3644
(WebCore::runtimeObjectCustomPut):
3645
(WebCore::callPlugin):
3646
* bindings/js/JSPluginElementFunctions.h:
3647
* bindings/js/JSQuarantinedObjectWrapper.cpp:
3648
(WebCore::JSQuarantinedObjectWrapper::asWrapper):
3649
(WebCore::JSQuarantinedObjectWrapper::cachedValueGetter):
3650
(WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
3651
(WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot):
3652
(WebCore::JSQuarantinedObjectWrapper::put):
3653
(WebCore::JSQuarantinedObjectWrapper::construct):
3654
(WebCore::JSQuarantinedObjectWrapper::hasInstance):
3655
(WebCore::JSQuarantinedObjectWrapper::call):
3656
* bindings/js/JSQuarantinedObjectWrapper.h:
3657
(WebCore::JSQuarantinedObjectWrapper::createStructure):
3658
* bindings/js/JSRGBColor.cpp:
3659
(WebCore::getJSRGBColor):
3660
(jsRGBColorRed):
3661
(jsRGBColorGreen):
3662
(jsRGBColorBlue):
3663
* bindings/js/JSRGBColor.h:
3664
(WebCore::JSRGBColor::createStructure):
3665
* bindings/js/JSSQLResultSetRowListCustom.cpp:
3666
(WebCore::JSSQLResultSetRowList::item):
3667
* bindings/js/JSSQLTransactionCustom.cpp:
3668
(WebCore::JSSQLTransaction::executeSql):
3669
* bindings/js/JSSVGElementInstanceCustom.cpp:
3670
(WebCore::JSSVGElementInstance::addEventListener):
3671
(WebCore::JSSVGElementInstance::removeEventListener):
3672
(WebCore::toJS):
3673
* bindings/js/JSSVGLengthCustom.cpp:
3674
(WebCore::JSSVGLength::value):
3675
(WebCore::JSSVGLength::convertToSpecifiedUnits):
3676
* bindings/js/JSSVGMatrixCustom.cpp:
3677
(WebCore::JSSVGMatrix::inverse):
3678
(WebCore::JSSVGMatrix::rotateFromVector):
3679
* bindings/js/JSSVGPathSegCustom.cpp:
3680
(WebCore::toJS):
3681
* bindings/js/JSSVGPathSegListCustom.cpp:
3682
(WebCore::JSSVGPathSegList::clear):
3683
(WebCore::JSSVGPathSegList::initialize):
3684
(WebCore::JSSVGPathSegList::getItem):
3685
(WebCore::JSSVGPathSegList::insertItemBefore):
3686
(WebCore::JSSVGPathSegList::replaceItem):
3687
(WebCore::JSSVGPathSegList::removeItem):
3688
(WebCore::JSSVGPathSegList::appendItem):
3689
* bindings/js/JSSVGPointListCustom.cpp:
3690
(WebCore::finishGetter):
3691
(WebCore::finishSetter):
3692
(WebCore::finishSetterReadOnlyResult):
3693
(WebCore::JSSVGPointList::clear):
3694
(WebCore::JSSVGPointList::initialize):
3695
(WebCore::JSSVGPointList::getItem):
3696
(WebCore::JSSVGPointList::insertItemBefore):
3697
(WebCore::JSSVGPointList::replaceItem):
3698
(WebCore::JSSVGPointList::removeItem):
3699
(WebCore::JSSVGPointList::appendItem):
3700
* bindings/js/JSSVGTransformListCustom.cpp:
3701
(WebCore::finishGetter):
3702
(WebCore::finishSetter):
3703
(WebCore::finishSetterReadOnlyResult):
3704
(WebCore::JSSVGTransformList::clear):
3705
(WebCore::JSSVGTransformList::initialize):
3706
(WebCore::JSSVGTransformList::getItem):
3707
(WebCore::JSSVGTransformList::insertItemBefore):
3708
(WebCore::JSSVGTransformList::replaceItem):
3709
(WebCore::JSSVGTransformList::removeItem):
3710
(WebCore::JSSVGTransformList::appendItem):
3711
* bindings/js/JSStorageCustom.cpp:
3712
(WebCore::JSStorage::nameGetter):
3713
(WebCore::JSStorage::deleteProperty):
3714
(WebCore::JSStorage::customPut):
3715
* bindings/js/JSStyleSheetCustom.cpp:
3716
(WebCore::toJS):
3717
* bindings/js/JSStyleSheetListCustom.cpp:
3718
(WebCore::JSStyleSheetList::nameGetter):
3719
* bindings/js/JSTextCustom.cpp:
3720
(WebCore::toJSNewlyCreated):
3721
* bindings/js/JSTreeWalkerCustom.cpp:
3722
(WebCore::JSTreeWalker::parentNode):
3723
(WebCore::JSTreeWalker::firstChild):
3724
(WebCore::JSTreeWalker::lastChild):
3725
(WebCore::JSTreeWalker::nextSibling):
3726
(WebCore::JSTreeWalker::previousSibling):
3727
(WebCore::JSTreeWalker::previousNode):
3728
(WebCore::JSTreeWalker::nextNode):
3729
* bindings/js/JSWorkerContextCustom.cpp:
3730
(WebCore::JSWorkerContext::self):
3731
(WebCore::JSWorkerContext::setSelf):
3732
(WebCore::JSWorkerContext::xmlHttpRequest):
3733
(WebCore::JSWorkerContext::importScripts):
3734
(WebCore::JSWorkerContext::addEventListener):
3735
(WebCore::JSWorkerContext::removeEventListener):
3736
(WebCore::JSWorkerContext::setTimeout):
3737
(WebCore::JSWorkerContext::setInterval):
3738
* bindings/js/JSWorkerCustom.cpp:
3739
(WebCore::JSWorker::addEventListener):
3740
(WebCore::JSWorker::removeEventListener):
3741
* bindings/js/JSXMLHttpRequestCustom.cpp:
3742
(WebCore::JSXMLHttpRequest::open):
3743
(WebCore::JSXMLHttpRequest::setRequestHeader):
3744
(WebCore::JSXMLHttpRequest::send):
3745
(WebCore::JSXMLHttpRequest::getResponseHeader):
3746
(WebCore::JSXMLHttpRequest::overrideMimeType):
3747
(WebCore::JSXMLHttpRequest::addEventListener):
3748
(WebCore::JSXMLHttpRequest::removeEventListener):
3749
(WebCore::JSXMLHttpRequest::responseText):
3750
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
3751
(WebCore::JSXMLHttpRequestUpload::addEventListener):
3752
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
3753
* bindings/js/JSXSLTProcessorCustom.cpp:
3754
(WebCore::JSXSLTProcessor::importStylesheet):
3755
(WebCore::JSXSLTProcessor::transformToFragment):
3756
(WebCore::JSXSLTProcessor::transformToDocument):
3757
(WebCore::JSXSLTProcessor::setParameter):
3758
(WebCore::JSXSLTProcessor::getParameter):
3759
(WebCore::JSXSLTProcessor::removeParameter):
3760
* bindings/js/ScheduledAction.cpp:
3761
(WebCore::ScheduledAction::create):
3762
(WebCore::ScheduledAction::ScheduledAction):
3763
(WebCore::ScheduledAction::executeFunctionInContext):
3764
* bindings/js/ScheduledAction.h:
3765
* bindings/js/ScriptCallStack.cpp:
3766
(WebCore::ScriptCallStack::ScriptCallStack):
3767
(WebCore::ScriptCallStack::initialize):
3768
* bindings/js/ScriptCallStack.h:
3769
* bindings/js/ScriptController.cpp:
3770
(WebCore::ScriptController::jsObjectForPluginElement):
3771
* bindings/js/ScriptFunctionCall.cpp:
3772
(WebCore::ScriptFunctionCall::appendArgument):
3773
(WebCore::ScriptFunctionCall::call):
3774
(WebCore::ScriptFunctionCall::construct):
3775
* bindings/js/ScriptFunctionCall.h:
3776
* bindings/js/ScriptObject.cpp:
3777
(WebCore::ScriptGlobalObject::get):
3778
* bindings/js/ScriptValue.h:
3779
(WebCore::ScriptValue::ScriptValue):
3780
(WebCore::ScriptValue::jsValue):
3781
* bindings/objc/WebScriptObject.mm:
3782
(-[WebScriptObject callWebScriptMethod:withArguments:]):
3783
(-[WebScriptObject evaluateWebScript:]):
3784
(-[WebScriptObject valueForKey:]):
3785
(-[WebScriptObject webScriptValueAtIndex:]):
3786
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
3787
* bindings/objc/WebScriptObjectPrivate.h:
3788
* bridge/NP_jsobject.cpp:
3789
(_NPN_InvokeDefault):
3790
(_NPN_Invoke):
3791
(_NPN_Evaluate):
3792
(_NPN_GetProperty):
3793
(_NPN_HasMethod):
3794
(_NPN_Construct):
3795
* bridge/c/c_instance.cpp:
3796
(JSC::Bindings::CInstance::invokeMethod):
3797
(JSC::Bindings::CInstance::invokeDefaultMethod):
3798
(JSC::Bindings::CInstance::invokeConstruct):
3799
(JSC::Bindings::CInstance::defaultValue):
3800
(JSC::Bindings::CInstance::stringValue):
3801
(JSC::Bindings::CInstance::numberValue):
3802
(JSC::Bindings::CInstance::booleanValue):
3803
(JSC::Bindings::CInstance::valueOf):
3804
* bridge/c/c_instance.h:
3805
* bridge/c/c_runtime.cpp:
3806
(JSC::Bindings::CField::valueFromInstance):
3807
(JSC::Bindings::CField::setValueToInstance):
3808
* bridge/c/c_runtime.h:
3809
* bridge/c/c_utility.cpp:
3810
(JSC::Bindings::convertValueToNPVariant):
3811
(JSC::Bindings::convertNPVariantToValue):
3812
* bridge/c/c_utility.h:
3813
* bridge/jni/jni_instance.cpp:
3814
(JavaInstance::stringValue):
3815
(JavaInstance::numberValue):
3816
(JavaInstance::booleanValue):
3817
(JavaInstance::invokeMethod):
3818
(JavaInstance::defaultValue):
3819
(JavaInstance::valueOf):
3820
* bridge/jni/jni_instance.h:
3821
* bridge/jni/jni_jsobject.h:
3822
* bridge/jni/jni_jsobject.mm:
3823
(JavaJSObject::call):
3824
(JavaJSObject::eval):
3825
(JavaJSObject::getMember):
3826
(JavaJSObject::getSlot):
3827
(JavaJSObject::convertValueToJObject):
3828
(JavaJSObject::convertJObjectToValue):
3829
* bridge/jni/jni_objc.mm:
3830
(JSC::Bindings::dispatchJNICall):
3831
* bridge/jni/jni_runtime.cpp:
3832
(JavaArray::convertJObjectToArray):
3833
(JavaField::dispatchValueFromInstance):
3834
(JavaField::valueFromInstance):
3835
(JavaField::dispatchSetValueToInstance):
3836
(JavaField::setValueToInstance):
3837
(JavaArray::setValueAt):
3838
(JavaArray::valueAt):
3839
* bridge/jni/jni_runtime.h:
3840
* bridge/jni/jni_utility.cpp:
3841
(JSC::Bindings::convertArrayInstanceToJavaArray):
3842
(JSC::Bindings::convertValueToJValue):
3843
* bridge/jni/jni_utility.h:
3844
* bridge/objc/WebScriptObject.h:
3845
* bridge/objc/objc_class.h:
3846
* bridge/objc/objc_class.mm:
3847
(JSC::Bindings::ObjcClass::fallbackObject):
3848
* bridge/objc/objc_instance.h:
3849
* bridge/objc/objc_instance.mm:
3850
(ObjcInstance::invokeMethod):
3851
(ObjcInstance::invokeDefaultMethod):
3852
(ObjcInstance::setValueOfUndefinedField):
3853
(ObjcInstance::getValueOfUndefinedField):
3854
(ObjcInstance::defaultValue):
3855
(ObjcInstance::stringValue):
3856
(ObjcInstance::numberValue):
3857
(ObjcInstance::booleanValue):
3858
(ObjcInstance::valueOf):
3859
* bridge/objc/objc_runtime.h:
3860
(JSC::Bindings::ObjcFallbackObjectImp::createStructure):
3861
* bridge/objc/objc_runtime.mm:
3862
(JSC::Bindings::ObjcField::valueFromInstance):
3863
(JSC::Bindings::convertValueToObjcObject):
3864
(JSC::Bindings::ObjcField::setValueToInstance):
3865
(JSC::Bindings::ObjcArray::setValueAt):
3866
(JSC::Bindings::ObjcArray::valueAt):
3867
(JSC::Bindings::ObjcFallbackObjectImp::put):
3868
(JSC::Bindings::callObjCFallbackObject):
3869
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
3870
* bridge/objc/objc_utility.h:
3871
* bridge/objc/objc_utility.mm:
3872
(JSC::Bindings::convertValueToObjcValue):
3873
(JSC::Bindings::convertNSStringToString):
3874
(JSC::Bindings::convertObjcValueToValue):
3875
* bridge/runtime.h:
3876
(JSC::Bindings::Class::fallbackObject):
3877
(JSC::Bindings::Instance::setValueOfUndefinedField):
3878
(JSC::Bindings::Instance::invokeDefaultMethod):
3879
(JSC::Bindings::Instance::invokeConstruct):
3880
(JSC::Bindings::Instance::put):
3881
* bridge/runtime_array.cpp:
3882
(JSC::RuntimeArray::lengthGetter):
3883
(JSC::RuntimeArray::indexGetter):
3884
(JSC::RuntimeArray::put):
3885
* bridge/runtime_array.h:
3886
(JSC::RuntimeArray::createStructure):
3887
* bridge/runtime_method.cpp:
3888
(JSC::RuntimeMethod::lengthGetter):
3889
(JSC::callRuntimeMethod):
3890
* bridge/runtime_method.h:
3891
(JSC::RuntimeMethod::createStructure):
3892
* bridge/runtime_object.cpp:
3893
(JSC::RuntimeObjectImp::fallbackObjectGetter):
3894
(JSC::RuntimeObjectImp::fieldGetter):
3895
(JSC::RuntimeObjectImp::methodGetter):
3896
(JSC::RuntimeObjectImp::put):
3897
(JSC::RuntimeObjectImp::defaultValue):
3898
(JSC::callRuntimeObject):
3899
(JSC::callRuntimeConstructor):
3900
* bridge/runtime_object.h:
3901
(JSC::RuntimeObjectImp::createStructure):
3902
* inspector/JavaScriptCallFrame.cpp:
3903
(WebCore::JavaScriptCallFrame::evaluate):
3904
* inspector/JavaScriptCallFrame.h:
3905
* inspector/JavaScriptProfile.cpp:
3906
(WebCore::toJS):
3907
* inspector/JavaScriptProfile.h:
3908
* inspector/JavaScriptProfileNode.cpp:
3909
(WebCore::toJS):
3910
* inspector/JavaScriptProfileNode.h:
3911
3912
2009-05-01 Dimitri Glazkov <dglazkov@chromium.org>
3913
3914
Reviewed by Eric Seidel.
3915
3916
https://bugs.webkit.org/show_bug.cgi?id=25485
3917
Only use visitedURL in Qt. This is a follow-up change to http://trac.webkit.org/changeset/43052,
3918
which broke Chromium build.
3919
3920
* css/CSSStyleSelector.cpp:
3921
(WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState): Moved guards around to
3922
provide separate code paths for Qt and non-Qt ports. Also restored original
3923
order of execution.
3924
3925
2009-05-01 Anders Carlsson <andersca@apple.com>
3926
3927
Reviewed by Adele Peterson.
3928
3929
<rdar://problem/6839222>
3930
CrashTracer: Lots of crashes in Safari in hash table remove function inside DocumentLoader::removeSubresourceLoader
3931
3932
After calling m_client->didFail(), check if the subresource loader has reached its terminal state. If that's the case,
3933
return early to avoid calling removeSubresourceLoader on a null document loader. I don't think this is allowed to happen
3934
which is why I've added the ASSERT.
3935
3936
* loader/SubresourceLoader.cpp:
3937
(WebCore::SubresourceLoader::didCancel):
3938
3939
2009-05-01 Timothy Hatcher <timothy@apple.com>
3940
3941
Disallow the deletion UI for elements that have any overflow clipping.
3942
Also disallow the UI for the body element it isn't practical to delete,
3943
and the deletion UI would be clipped.
3944
3945
<rdar://problem/6840161> Deletion UI can be clipped by some
3946
elements (with overflow: hidden)
3947
3948
Reviewed by Darin Adler.
3949
3950
* editing/DeleteButtonController.cpp:
3951
(WebCore::isDeletableElement):
3952
3953
2009-05-01 Timothy Hatcher <timothy@apple.com>
3954
3955
Decrease the minimum height for deleteable elements to 16px, and increase the
3956
minimum width to 48px. This allows deleting shorter items like navigation bars.
3957
3958
<rdar://problem/6840735> Deletion UI does not show up for short
3959
elements (22px or less)
3960
3961
Reviewed by Adele Peterson.
3962
3963
* editing/DeleteButtonController.cpp:
3964
(WebCore::isDeletableElement):
3965
3966
2009-05-01 Timothy Hatcher <timothy@apple.com>
3967
3968
Clean up the comments and logic in the code for picking a
3969
deleteable element for the deletion UI.
3970
3971
Reviewed by Adele Peterson.
3972
3973
* editing/DeleteButtonController.cpp:
3974
(WebCore::isDeletableElement):
3975
3976
2009-05-01 Kevin McCullough <kmccullough@apple.com>
3977
3978
Reviewed by Adele Peterson and Darin Adler.
3979
3980
<rdar://problem/4815598> Stuck in double spacing mode after pasting a
3981
paragraph with padding/margin (or table mode !)
3982
3983
A lot of the issues in this bug were resolved on Mail's side by using
3984
WebKit to convert to plain text. This is the final issue, that floating
3985
style stays on copied nodes causing them to float when they are pasted
3986
which is not what the user intended.
3987
3988
* editing/markup.cpp:
3989
(WebCore::removeExteriorStyles):
3990
(WebCore::):
3991
(WebCore::appendStartMarkup):
3992
(WebCore::getStartMarkup):
3993
(WebCore::createMarkup):
3994
3995
2009-05-01 Pavel Feldman <pfeldman@chromium.org>
3996
3997
Reviewed by Timothy Hatcher.
3998
3999
Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
4000
This is the only resource-related information that is available in InspectorController
4001
and is missing in the FrameLoaderClient.
4002
4003
https://bugs.webkit.org/show_bug.cgi?id=25347
4004
4005
* WebCore.xcodeproj/project.pbxproj: Made ScriptSource private.
4006
* dom/Document.cpp: Made a call to a client along with the call to the InspectorController.
4007
(WebCore::Document::resourceRetrievedByXMLHttpRequest):
4008
* loader/EmptyClients.h: Added stub implementation.
4009
(WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
4010
* loader/FrameLoader.cpp: Call initiating dispatches.
4011
(WebCore::FrameLoader::resourceRetrievedByXMLHttpRequest):
4012
* loader/FrameLoader.h:
4013
* loader/FrameLoaderClient.h:
4014
4015
2009-04-30 Beth Dakin <bdakin@apple.com>
4016
4017
Reviewed by Oliver Hunt.
4018
4019
Fix for <rdar://problem/6841106> REGRESSION: Crash drag selecting
4020
To Do's in a Mail note (excessive recursion in mouse drag tracking)
4021
4022
Oliver's recent change to dragging seems to have revealed a long-
4023
time bug in passSubframeEventToSubframe where we did not set
4024
m_sendingEventToSubview to true before calling
4025
handleMouseMoveEvent() in the NSMouseMoved case. This patch fixes
4026
that and adds ASSERTions around all of the places where
4027
m_sendingEventToSubview is set to true and then false to make sure
4028
we are not trampling its state.
4029
4030
* page/mac/EventHandlerMac.mm:
4031
(WebCore::EventHandler::eventLoopHandleMouseDragged):
4032
(WebCore::EventHandler::eventLoopHandleMouseUp):
4033
(WebCore::EventHandler::passSubframeEventToSubframe):
4034
(WebCore::EventHandler::passWheelEventToWidget):
4035
4036
2009-04-30 Eric Carlson <eric.carlson@apple.com>
4037
4038
Reviewed by Simon Fraser.
4039
4040
MediaDocument falls back to plug-in unnecessarily
4041
https://bugs.webkit.org/show_bug.cgi?id=25504
4042
<rdar://problem/6844702>
4043
4044
Don't allow harmless media types to cause a MediaDocument to fall
4045
back to PluginDocument.
4046
4047
Test: media/video-document-types.html
4048
4049
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
4050
(WebCore::MediaPlayerPrivate::disableUnsupportedTracks): add timecode, timecode 64,
4051
odsm, and sdsm to allowed track types.
4052
4053
* platform/graphics/win/QTMovieWin.cpp:
4054
(QTMovieWin::disableUnsupportedTracks): Ditto.
4055
4056
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
4057
4058
Reviewed by Eric Seidel.
4059
4060
Add CHROMIUM guard to unfork Document.cpp
4061
4062
* dom/Document.cpp:
4063
(WebCore::Document::setFocusedNode): Added guard.
4064
4065
2009-04-30 David Kilzer <ddkilzer@apple.com>
4066
4067
Use OwnPtr<HTMLParserQuirks> for m_parserQuirks
4068
4069
Reviewed by Geoff Garen.
4070
4071
* html/HTMLParser.cpp:
4072
(WebCore::HTMLParser::~HTMLParser): Removed unneeded code.
4073
* html/HTMLParser.h: Made m_parserQuirks an OwnPtr.
4074
4075
2009-04-30 David Kilzer <ddkilzer@apple.com>
4076
4077
Provide a mechanism to create a quirks delegate for HTMLParser
4078
4079
Reviewed by David Hyatt.
4080
4081
No tests since there is no change in behavior.
4082
4083
HTMLParserQuirks.h defines an abstract base class that may be
4084
extended as needed. The ChromeClient::createHTMLParserQuirks()
4085
factory method should be used to return an HTMLParserQuirks
4086
subclassed object when needed.
4087
4088
* WebCore.xcodeproj/project.pbxproj: Added HTMLParserQuirks.h.
4089
* html/HTMLParser.cpp:
4090
(WebCore::HTMLParser::HTMLParser): Initialize m_parserQuirks
4091
using ChromeClient::createHTMLParserQuirks().
4092
(WebCore::HTMLParser::~HTMLParser): Delete m_parserQuirks if
4093
set.
4094
(WebCore::HTMLParser::reset): Call HTMLParserQuirks::reset() if
4095
m_parserQuirks is set.
4096
(WebCore::HTMLParser::insertNode): Call
4097
HTMLParserQuirks::shouldInsertNode() if m_parserQuirks is set,
4098
and return early if it returns false.
4099
(WebCore::HTMLParser::popBlock): Call
4100
HTMLParserQuirks::shouldPopBlock() if m_parserQuirks is set, and
4101
return early if it returns false.
4102
* html/HTMLParser.h: Added m_parserQuirks.
4103
* html/HTMLParserQuirks.h: Added.
4104
(WebCore::HTMLParserQuirks::HTMLParserQuirks):
4105
(WebCore::HTMLParserQuirks::~HTMLParserQuirks):
4106
* loader/EmptyClients.h:
4107
(WebCore::EmptyChromeClient::createHTMLParserQuirks): Added.
4108
* page/ChromeClient.h:
4109
(WebCore::ChromeClient::createHTMLParserQuirks): Added.
4110
4111
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
4112
4113
Reviewed by Eric Seidel.
4114
4115
https://bugs.webkit.org/show_bug.cgi?id=25492
4116
Add JSC guards around node wrapper cache calls. These are not used by V8.
4117
4118
Also, remove JSDOMBinding include, which is brought in by ScriptController.
4119
4120
* dom/Document.cpp:
4121
(WebCore::Document::~Document): Added JSC guard.
4122
* dom/Node.cpp:
4123
(WebCore::Node::setDocument): Ditto and removed JSDOMBinding include.
4124
4125
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
4126
4127
Reviewed by Eric Seidel.
4128
4129
https://bugs.webkit.org/show_bug.cgi?id=25493
4130
Remove debugger/profiler custom method stubs, catching V8 bindings up to
4131
http://trac.webkit.org/changeset/43072.
4132
4133
* bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed method stubs.
4134
4135
2009-04-30 Simon Fraser <simon.fraser@apple.com>
4136
4137
Reviewed by Darin Adler
4138
4139
<rdar://problem/6839338> VoiceOver does not take into account transforms when drawing outlines
4140
4141
Use transform-aware quad methods when computing the boundingBoxRect for
4142
an AccessibilityRenderObject. The code follows RenderObject::absoluteBoundingBoxRect().
4143
4144
Test: accessibility/transformed-element.html
4145
4146
* page/AccessibilityRenderObject.cpp:
4147
(WebCore::AccessibilityRenderObject::boundingBoxRect):
4148
4149
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
4150
4151
Unreviewed, Chromium build fix.
4152
4153
Catch up to ScriptObject changes from http://trac.webkit.org/changeset/42512.
4154
4155
* bindings/v8/ScriptObject.cpp:
4156
(WebCore::ScriptGlobalObject::get): Renamed from getObject.
4157
(WebCore::ScriptGlobalObject::remove): Added.
4158
* bindings/v8/ScriptObject.h: Ditto.
4159
4160
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
4161
4162
Unreviewed, build fix.
4163
4164
https://bugs.webkit.org/show_bug.cgi?id=25470
4165
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
4166
4167
* WebCore.pro: Fix copy-paste error.
4168
4169
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
4170
4171
Unreviewed, build fix.
4172
4173
https://bugs.webkit.org/show_bug.cgi?id=25470
4174
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
4175
4176
* GNUmakefile.am: Add ENABLE_JAVASCRIPT_DEBUGGER definitions.
4177
* WebCore.pro: Ditto.
4178
4179
2009-04-02 Eric Seidel <eric@webkit.org>
4180
4181
Reviewed by Darin Adler.
4182
4183
Change Position to pre-compute the AnchorType and store it.
4184
Also store a "legacy editing mode" bit on the Position.
4185
https://bugs.webkit.org/show_bug.cgi?id=24763
4186
4187
The old Postion(node, offset) constructor creates legacy positions
4188
but there are new constructors to create explicitly anchored positions
4189
which the next patch will use.
4190
4191
Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
4192
only affect legacy positions, we will be able to distinguish
4193
between [table, 1] and [table, after] in the code correctly!
4194
4195
* WebCore.base.exp:
4196
* WebCore.xcodeproj/project.pbxproj:
4197
* dom/Position.cpp:
4198
(WebCore::Position::Position):
4199
(WebCore::Position::moveToPosition):
4200
(WebCore::Position::moveToOffset):
4201
(WebCore::Position::anchorTypeForLegacyEditingPosition):
4202
(WebCore::Position::element):
4203
* dom/Position.h:
4204
(WebCore::Position::):
4205
(WebCore::Position::Position):
4206
(WebCore::Position::anchorType):
4207
(WebCore::Position::deprecatedEditingOffset):
4208
4209
2009-04-30 Sam Weinig <sam@webkit.org>
4210
4211
Reviewed by Alexey Proskuryakov.
4212
4213
Fix bug where the WorkerLocation and WorkerNavigator wrappers would be
4214
collected even if the WorkerContext is still alive.
4215
4216
Test: fast/workers/worker-context-gc.html
4217
4218
* bindings/js/JSWorkerContextCustom.cpp:
4219
(WebCore::JSWorkerContext::mark):
4220
* workers/WorkerContext.cpp:
4221
(WebCore::WorkerContext::WorkerContext):
4222
(WebCore::WorkerContext::completeURL):
4223
(WebCore::WorkerContext::location):
4224
* workers/WorkerContext.h:
4225
(WebCore::WorkerContext::optionalNavigator):
4226
(WebCore::WorkerContext::optionalLocation):
4227
4228
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
4229
4230
Reviewed by Timothy Hatcher.
4231
4232
https://bugs.webkit.org/show_bug.cgi?id=25470
4233
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.
4234
4235
* Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER.
4236
* WebCore.vcproj/build-generated-files.sh: Ditto.
4237
* bindings/js/JSConsoleCustom.cpp: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
4238
* bindings/js/JSDOMWindowBase.cpp: Ditto.
4239
* bindings/js/JSInspectorControllerCustom.cpp: Ditto.
4240
* inspector/InspectorController.cpp: Moved profiler/debugger methods under
4241
ENABLE(JAVASCRIPT_DEBUGGER) flag.
4242
* inspector/InspectorController.h: Ditto.
4243
* inspector/InspectorController.idl: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
4244
* page/Console.cpp: Replaced USE(JSC) with ENABLE(JAVASCRIPT_DEBUGGER) guard.
4245
4246
2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>
4247
4248
Unreviewed, build fix.
4249
4250
https://bugs.webkit.org/show_bug.cgi?id=25275
4251
This patch snuck in a re-definition of a local.
4252
4253
* bindings/v8/custom/V8DOMWindowCustom.cpp:
4254
(WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.
4255
4256
2009-04-30 Sam Weinig <sam@webkit.org>
4257
4258
Reviewed by Mark Rowe.
4259
4260
Fix a leak introduced yesterday. Don't allocate a ScheduledAction
4261
if the toString()ing throws an exception.
4262
4263
* bindings/js/ScheduledAction.cpp:
4264
(WebCore::ScheduledAction::create):
4265
4266
2009-04-30 Alexey Proskuryakov <ap@webkit.org>
4267
4268
Reviewed by Darin Adler.
4269
4270
https://bugs.webkit.org/show_bug.cgi?id=25379
4271
<rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails
4272
4273
Test: fast/forms/multiple-selected-options-innerHTML.html
4274
4275
This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
4276
For normal HTML parsing, it is called immediately after an element is inserted, but for
4277
innerHTML, it is only called after the whole subtree is inserted into a document.
4278
4279
It may make sense to harmonize these cases one day, but for now, I only made the minimal
4280
changes necessary to fix the bug.
4281
4282
* html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
4283
* html/HTMLSelectElement.h:
4284
Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide
4285
which one to keep selected themselves, because their logic assumes normal parsing, with
4286
insertedIntoTree() called after each element is inserted.
4287
4288
2009-04-30 Pavel Feldman <pfeldman@chromium.org>
4289
4290
Reviewed by Dimitri Glazkov.
4291
4292
https://bugs.webkit.org/show_bug.cgi?id=25342
4293
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
4294
4295
Chromium async/out-of-process version of WebInspector is currently not based on
4296
InspectorController. The reason was that we did not want to interfere with
4297
the unforking effort, yet wanted to experiment. So we came up with these
4298
agents concept that basically mimic InspectorController, but separating 'agent'
4299
nature from the 'transport'. Now that InspectorController is unforked, I am
4300
planning to bring these concepts into the WebKit land and use what we have in
4301
Chromium as a proof of concept / experimental playground.
4302
4303
* loader/EmptyClients.h: added MessageSource and MessageLevel parameters.
4304
(WebCore::EmptyChromeClient::addMessageToConsole): ditto
4305
* page/ChromeClient.h: ditto
4306
* page/Console.cpp: Used new method signature.
4307
(WebCore::Console::addMessage): ditto
4308
4309
2009-04-30 Dan Bernstein <mitz@apple.com>
4310
4311
Reviewed by Simon Fraser.
4312
4313
- fix https://bugs.webkit.org/show_bug.cgi?id=25476
4314
<rdar://problem/6841919> REGRESSION (r42987): Welcome to Safari 4
4315
animation is jittery
4316
4317
Reverted r42987.
4318
4319
* platform/graphics/cg/ImageCG.cpp:
4320
(WebCore::BitmapImage::draw):
4321
4322
2009-04-30 Brady Eidson <beidson@apple.com>
4323
4324
Reviewed by Maciej Stachowiak
4325
4326
<rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
4327
https://bugs.webkit.org/show_bug.cgi?id=21193
4328
4329
Some websites use for attributes in script elements to specify events that the script
4330
should be run for. One example is greekembassy.org which has the following in their <head>:
4331
4332
<script for=window event=onresize>
4333
location.reload(false);
4334
</script>
4335
4336
Since we don't support the full for attribute syntax, we would just blissfully ignore the
4337
condition and execute the code unconditionally. This caused breakage on multiple real-world
4338
sites besides greekembassy.org.
4339
4340
https://bugs.webkit.org/show_bug.cgi?id=16915 and <rdar://problem/4471751> track adding full
4341
support for the for attribute in scripts. In the meantime it's best to not execute them
4342
unconditionally.
4343
4344
Test: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html
4345
4346
* dom/ScriptElement.cpp:
4347
(WebCore::ScriptElementData::shouldExecuteAsJavaScript): After all other checks have
4348
passed, only return true if there is no for attribute in the script element.
4349
* dom/ScriptElement.h:
4350
4351
* html/HTMLScriptElement.cpp:
4352
(WebCore::HTMLScriptElement::forAttributeValue): Return the attribute value, if any.
4353
* html/HTMLScriptElement.h:
4354
4355
* svg/SVGScriptElement.cpp:
4356
(WebCore::SVGScriptElement::forAttributeValue): Return an empty string (like the other
4357
attribute getters do for SVGScriptElement)
4358
* svg/SVGScriptElement.h:
4359
4360
2009-04-30 Holger Hans Peter Freyther <zecke@selfish.org>
4361
4362
Reviewed by Darin Adler.
4363
4364
The Qt API exposes a global history patch CSSStyleSelector to make API consumers work again
4365
4366
https://bugs.webkit.org/show_bug.cgi?id=20952
4367
4368
The QtWebKit port made the mistake of exposing a global history. This broke
4369
with the addition of PageGroup and LinkHash. This needs to be repaired
4370
for Qt4.5.
4371
4372
Add a function to LinkHash.cpp that is resolving a URL. Use this
4373
function from within CSSStyleSelector to forward the url to the
4374
QWebHistoryInterface API.
4375
4376
It is sad that there is a path within visitedLinkHash which is now
4377
doing a memcpy, it is sad to add a PLATFORM(QT) define to CSSStyleSelector
4378
and using QtWebKit types within WebCore is a layering violation as well.
4379
4380
PageGroup::setShouldTrackVisitedLinks is currently not enabled. For
4381
Qt4.6 a second version of the QWebHistoryInterface is going to be
4382
added which will fix things up.
4383
4384
* css/CSSStyleSelector.cpp:
4385
(WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState):
4386
* platform/LinkHash.cpp:
4387
(WebCore::visitedURL):
4388
(WebCore::visitedLinkHash):
4389
* platform/LinkHash.h:
4390
4391
2009-04-30 Simon Hausmann <simon.hausmann@nokia.com>
4392
4393
Fix the Qt build.
4394
4395
* platform/graphics/SimpleFontData.cpp: Don't use initCharWidths() for the Qt build.
4396
* platform/graphics/qt/SimpleFontDataQt.cpp:
4397
(WebCore::SimpleFontData::platformCharWidthInit): Instead initialize the average and
4398
max char widths from QFontMetrics.
4399
4400
2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>
4401
4402
Unreview build fix after r43037.
4403
4404
Use MarkedArgumentBuffer instead of ArgList.
4405
4406
* bridge/qt/qt_runtime.cpp:
4407
(JSC::Bindings::QtConnectionObject::execute):
4408
4409
2009-04-29 Sam Weinig <sam@webkit.org>
4410
4411
Reviewed by Oliver Hunt.
4412
4413
Fix for https://bugs.webkit.org/show_bug.cgi?id=25440
4414
setTimeout should stringify non-string/non-function first arguments
4415
4416
Test: fast/dom/Window/setTimeout-string-argument.html
4417
4418
* bindings/js/JSDOMWindowCustom.cpp:
4419
(WebCore::JSDOMWindow::setTimeout):
4420
(WebCore::JSDOMWindow::setInterval):
4421
* bindings/js/JSWorkerContextCustom.cpp:
4422
(WebCore::JSWorkerContext::setTimeout):
4423
(WebCore::JSWorkerContext::setInterval):
4424
* bindings/js/ScheduledAction.cpp:
4425
(WebCore::ScheduledAction::create):
4426
* bindings/js/ScheduledAction.h:
4427
4428
2009-04-29 Dan Bernstein <mitz@apple.com>
4429
4430
Reviewed by Simon Fraser.
4431
4432
- WebCore part of <rdar://problem/6609509> Select All and then Delete
4433
should put Mail editing back into the same state as a new message
4434
4435
Test: editing/deleting/in-visibly-empty-root.html
4436
4437
* WebCore.base.exp: Exported VisibleSelection::isAll(bool).
4438
* editing/SelectionController.h:
4439
(WebCore::SelectionController::isAll): Added. Calls through to
4440
VisibleSelection.
4441
* editing/TypingCommand.cpp:
4442
(WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
4443
of the root editable element the selection is in, other than a
4444
placeholder. Returns true iff it did anything.
4445
(WebCore::TypingCommand::deleteKeyPressed): When there is only a single
4446
visible position in the root editable element, but it has children other
4447
than a placeholder, remove those children.
4448
* editing/TypingCommand.h:
4449
* editing/VisiblePosition.h:
4450
Added a StayInEditableContent enum and a FIXME.
4451
* editing/VisibleSelection.cpp:
4452
(WebCore::VisibleSelection::isAll): Added. Returns whether the
4453
selection encompasses all visible positions, either in the document or
4454
in the editable root.
4455
* editing/VisibleSelection.h:
4456
4457
2009-04-29 Sam Weinig <sam@webkit.org>
4458
4459
Fix style nit.
4460
4461
* editing/visible_units.cpp:
4462
(WebCore::getLeafBoxesInLogicalOrder):
4463
4464
2009-04-29 David Hyatt <hyatt@apple.com>
4465
4466
Reviewed by Dan Bernstein.
4467
4468
For now just drop the deferred layout on the floor, since it causes an infinite hang in mail. Even
4469
trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
4470
assertions.
4471
4472
Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
4473
and not do it (which is basically what was happening before).
4474
4475
* page/FrameView.cpp:
4476
(WebCore::FrameView::setContentsSize):
4477
(WebCore::FrameView::needsLayout):
4478
4479
2009-04-29 Douglas Davidson <ddavidso@apple.com>
4480
4481
Reviewed by Justin Garcia.
4482
4483
<rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly
4484
4485
Updates to the text checking code to enable text checking even if spellchecking is turned off
4486
and fix an off-by-one error in selection handling.
4487
4488
* editing/Editor.cpp:
4489
(WebCore::Editor::markMisspellingsAfterTypingToPosition):
4490
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
4491
(WebCore::Editor::markMisspellingsAndBadGrammar):
4492
* editing/Editor.h:
4493
* editing/TypingCommand.cpp:
4494
(WebCore::TypingCommand::markMisspellingsAfterTyping):
4495
4496
2009-04-29 Oliver Hunt <oliver@apple.com>
4497
4498
Reviewed by Gavin Barraclough.
4499
4500
Clean up ArgList to be a trivial type
4501
4502
Start using MarkedArgumentBuffer to create argument lists for function calls
4503
4504
* bindings/js/JSClipboardCustom.cpp:
4505
(WebCore::JSClipboard::types):
4506
* bindings/js/JSConsoleCustom.cpp:
4507
(WebCore::JSConsole::profiles):
4508
* bindings/js/JSCustomPositionCallback.cpp:
4509
(WebCore::JSCustomPositionCallback::handleEvent):
4510
* bindings/js/JSCustomPositionErrorCallback.cpp:
4511
(WebCore::JSCustomPositionErrorCallback::handleEvent):
4512
* bindings/js/JSCustomSQLStatementCallback.cpp:
4513
(WebCore::JSCustomSQLStatementCallback::handleEvent):
4514
* bindings/js/JSCustomSQLStatementErrorCallback.cpp:
4515
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
4516
* bindings/js/JSCustomSQLTransactionCallback.cpp:
4517
(WebCore::JSCustomSQLTransactionCallback::handleEvent):
4518
* bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
4519
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
4520
* bindings/js/JSCustomVoidCallback.cpp:
4521
(WebCore::JSCustomVoidCallback::handleEvent):
4522
* bindings/js/JSCustomXPathNSResolver.cpp:
4523
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
4524
* bindings/js/JSEventListener.cpp:
4525
(WebCore::JSEventListener::handleEvent):
4526
* bindings/js/JSInspectorControllerCustom.cpp:
4527
(WebCore::JSInspectorController::profiles):
4528
(WebCore::JSInspectorController::search):
4529
(WebCore::JSInspectorController::databaseTableNames):
4530
(WebCore::JSInspectorController::setting):
4531
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
4532
(WebCore::JSJavaScriptCallFrame::scopeChain):
4533
* bindings/js/JSLazyEventListener.cpp:
4534
(WebCore::JSLazyEventListener::parseCode):
4535
* bindings/js/JSNodeFilterCondition.cpp:
4536
(WebCore::JSNodeFilterCondition::acceptNode):
4537
* bindings/js/JSQuarantinedObjectWrapper.cpp:
4538
(WebCore::JSQuarantinedObjectWrapper::construct):
4539
(WebCore::JSQuarantinedObjectWrapper::call):
4540
* bindings/js/ScheduledAction.cpp:
4541
(WebCore::ScheduledAction::ScheduledAction):
4542
(WebCore::ScheduledAction::executeFunctionInContext):
4543
* bindings/js/ScriptFunctionCall.h:
4544
* bindings/objc/WebScriptObject.mm:
4545
(getListFromNSArray):
4546
(-[WebScriptObject callWebScriptMethod:withArguments:]):
4547
* bridge/NP_jsobject.cpp:
4548
(getListFromVariantArgs):
4549
(_NPN_InvokeDefault):
4550
(_NPN_Invoke):
4551
(_NPN_Construct):
4552
* bridge/jni/jni_jsobject.h:
4553
* bridge/jni/jni_jsobject.mm:
4554
(JavaJSObject::call):
4555
(JavaJSObject::getListFromJArray):
4556
4557
2009-04-29 Eric Seidel <eric@webkit.org>
4558
4559
No review, build fix only.
4560
4561
Fix m_offset uses added while I wasn't looking.
4562
4563
* editing/visible_units.cpp:
4564
(WebCore::logicalStartPositionForLine):
4565
(WebCore::logicalEndPositionForLine):
4566
4567
2009-04-29 Xiaomei Ji <xji@chromium.org>
4568
4569
Reviewed by Dan Bernstein.
4570
4571
Fix https://bugs.webkit.org/show_bug.cgi?id=24168
4572
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
4573
4574
Test: editing/selection/home-end.html
4575
4576
* editing/SelectionController.cpp:
4577
(WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
4578
to logicalEndOfLine() when granularity is LineBoundary.
4579
(WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
4580
to logicalEndOfLine() when granularity is LineBoundary
4581
(WebCore::SelectionController::modifyExtendingBackward): Change calling
4582
startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
4583
(WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
4584
to logicalStartOfLine() when granularity is LineBoundary.
4585
* editing/visible_units.cpp:
4586
(WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
4587
(WebCore::getLogicalStartBoxAndNode): Added.
4588
(WebCore::getLogicalEndBoxAndNode): Added.
4589
(WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
4590
(WebCore::logicalStartOfLine): Added. Similar to startOfLine.
4591
(WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
4592
(WebCore::inSameLogicalLine): Added.
4593
(WebCore::logicalEndOfLine): Added. Similar to endOfLine.
4594
* editing/visible_units.h:
4595
4596
2009-04-29 Eric Seidel <eric@webkit.org>
4597
4598
Reviewed by Darin Adler.
4599
4600
Make m_offset private and change all callers to use deprecatedEditingOffset().
4601
https://bugs.webkit.org/show_bug.cgi?id=25472
4602
4603
Per Darin's suggestion, this was just a simple search replace
4604
of .m_offset with .deprecatedEditingOffset().
4605
4606
There was one change in InsertParagraphSeparatorCommand::doApply to use
4607
Position::moveToOffset(0) instead of .m_offset = 0;
4608
4609
* dom/Position.cpp:
4610
(WebCore::Position::rendersInDifferentPosition):
4611
(WebCore::Position::leadingWhitespacePosition):
4612
* dom/Position.h:
4613
(WebCore::Position::deprecatedEditingOffset):
4614
(WebCore::Position::moveToOffset):
4615
(WebCore::operator==):
4616
* dom/PositionIterator.h:
4617
(WebCore::PositionIterator::PositionIterator):
4618
* dom/Range.cpp:
4619
(WebCore::Range::create):
4620
(WebCore::Range::compareBoundaryPoints):
4621
* editing/ApplyStyleCommand.cpp:
4622
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
4623
(WebCore::ApplyStyleCommand::applyInlineStyleToRange):
4624
(WebCore::ApplyStyleCommand::removeInlineStyle):
4625
(WebCore::ApplyStyleCommand::nodeFullySelected):
4626
(WebCore::ApplyStyleCommand::nodeFullyUnselected):
4627
(WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
4628
(WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
4629
(WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
4630
(WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
4631
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
4632
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
4633
(WebCore::ApplyStyleCommand::joinChildTextNodes):
4634
* editing/BreakBlockquoteCommand.cpp:
4635
(WebCore::BreakBlockquoteCommand::doApply):
4636
* editing/CompositeEditCommand.cpp:
4637
(WebCore::CompositeEditCommand::insertNodeAt):
4638
(WebCore::CompositeEditCommand::positionOutsideTabSpan):
4639
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
4640
(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
4641
(WebCore::CompositeEditCommand::deleteInsignificantText):
4642
(WebCore::CompositeEditCommand::moveParagraphs):
4643
(WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
4644
* editing/DeleteSelectionCommand.cpp:
4645
(WebCore::updatePositionForNodeRemoval):
4646
(WebCore::updatePositionForTextRemoval):
4647
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
4648
(WebCore::DeleteSelectionCommand::fixupWhitespace):
4649
* editing/Editor.cpp:
4650
(WebCore::Editor::setComposition):
4651
(WebCore::Editor::advanceToNextMisspelling):
4652
(WebCore::Editor::getCompositionSelection):
4653
* editing/InsertLineBreakCommand.cpp:
4654
(WebCore::InsertLineBreakCommand::doApply):
4655
* editing/InsertParagraphSeparatorCommand.cpp:
4656
(WebCore::InsertParagraphSeparatorCommand::doApply):
4657
* editing/InsertTextCommand.cpp:
4658
(WebCore::InsertTextCommand::performTrivialReplace):
4659
(WebCore::InsertTextCommand::input):
4660
(WebCore::InsertTextCommand::insertTab):
4661
* editing/MoveSelectionCommand.cpp:
4662
(WebCore::MoveSelectionCommand::doApply):
4663
* editing/ReplaceSelectionCommand.cpp:
4664
(WebCore::ReplaceSelectionCommand::doApply):
4665
* editing/SelectionController.cpp:
4666
(WebCore::SelectionController::debugRenderer):
4667
* editing/TextIterator.cpp:
4668
(WebCore::TextIterator::rangeFromLocationAndLength):
4669
* editing/TypingCommand.cpp:
4670
(WebCore::TypingCommand::deleteKeyPressed):
4671
(WebCore::TypingCommand::forwardDeleteKeyPressed):
4672
* editing/VisiblePosition.cpp:
4673
(WebCore::VisiblePosition::characterAfter):
4674
(WebCore::VisiblePosition::debugPosition):
4675
(WebCore::makeRange):
4676
(WebCore::setStart):
4677
(WebCore::setEnd):
4678
* editing/VisibleSelection.cpp:
4679
(WebCore::VisibleSelection::toNormalizedRange):
4680
(WebCore::makeSearchRange):
4681
(WebCore::VisibleSelection::debugPosition):
4682
(WebCore::VisibleSelection::showTreeForThis):
4683
* editing/htmlediting.cpp:
4684
(WebCore::comparePositions):
4685
(WebCore::rangeCompliantEquivalent):
4686
* editing/visible_units.cpp:
4687
(WebCore::previousBoundary):
4688
(WebCore::nextBoundary):
4689
(WebCore::startPositionForLine):
4690
(WebCore::startOfLine):
4691
(WebCore::endPositionForLine):
4692
(WebCore::nextLinePosition):
4693
(WebCore::startOfParagraph):
4694
(WebCore::endOfParagraph):
4695
(WebCore::logicalStartPositionForLine):
4696
(WebCore::logicalEndPositionForLine):
4697
* page/AccessibilityObject.cpp:
4698
(WebCore::updateAXLineStartForVisiblePosition):
4699
* page/AccessibilityRenderObject.cpp:
4700
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
4701
* page/DOMSelection.cpp:
4702
(WebCore::DOMSelection::anchorOffset):
4703
(WebCore::DOMSelection::focusOffset):
4704
(WebCore::DOMSelection::baseOffset):
4705
(WebCore::DOMSelection::extentOffset):
4706
* page/EventHandler.cpp:
4707
(WebCore::EventHandler::handleMousePressEventSingleClick):
4708
* page/Frame.cpp:
4709
(WebCore::Frame::selectionLayoutChanged):
4710
* page/mac/AccessibilityObjectWrapper.mm:
4711
(textMarkerForVisiblePosition):
4712
(visiblePositionForTextMarker):
4713
* rendering/RenderTextControl.cpp:
4714
(WebCore::RenderTextControl::indexForVisiblePosition):
4715
* rendering/RenderTreeAsText.cpp:
4716
(WebCore::writeSelection):
4717
4718
2009-04-29 Eric Seidel <eric@webkit.org>
4719
4720
No review, rolling out a patch.
4721
4722
Revert http://trac.webkit.org/changeset/43019
4723
4724
New tests failed because I removed the tabs from them
4725
when landing (since we avoid tabs in WebKit files).
4726
I couldn't tell if the new results were correct with
4727
spaces or not.
4728
4729
* editing/SelectionController.cpp:
4730
(WebCore::SelectionController::modifyExtendingForward):
4731
(WebCore::SelectionController::modifyMovingForward):
4732
(WebCore::SelectionController::modifyExtendingBackward):
4733
(WebCore::SelectionController::modifyMovingBackward):
4734
* editing/visible_units.cpp:
4735
* editing/visible_units.h:
4736
4737
2009-04-29 David Hyatt <hyatt@apple.com>
4738
4739
Reviewed by Dan Bernstein.
4740
4741
Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
4742
when the FrameView is resized. This bug was exposed by the elimination of the separate WebKit layout
4743
flag on Mac.
4744
4745
FrameView now defers setNeedsLayouts during size changes. Once all of the size changes are finished (including re-entrant ones
4746
from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.
4747
4748
* page/FrameView.cpp:
4749
(WebCore::FrameView::FrameView):
4750
(WebCore::FrameView::setContentsSize):
4751
(WebCore::FrameView::layout):
4752
(WebCore::FrameView::needsLayout):
4753
(WebCore::FrameView::setNeedsLayout):
4754
* page/FrameView.h:
4755
4756
2009-04-29 Eric Seidel <eric@webkit.org>
4757
4758
No review, rolling out a patch.
4759
4760
Revert 43020 as it caused accessibility/lists.html to fail
4761
and no one is around to tell me if it's a progression or not.
4762
4763
* page/AccessibilityObject.h:
4764
(WebCore::):
4765
* page/AccessibilityRenderObject.cpp:
4766
(WebCore::AccessibilityRenderObject::roleValue):
4767
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
4768
* page/mac/AccessibilityObjectWrapper.mm:
4769
(RoleEntry::):
4770
4771
2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>
4772
4773
Reviewed by Jon Honeycutt.
4774
4775
Add a new accessibility role for list items. Part of
4776
http://bugs.webkit.org/show_id.cgi?id=20013
4777
4778
Tests: platform/win/accessibility/listitem-role.html
4779
4780
* page/AccessibilityObject.h:
4781
(WebCore::): Add ListItemRole to accessibilityRole enum.
4782
* page/AccessibilityRenderObject.cpp:
4783
(WebCore::AccessibilityRenderObject::roleValue):Return
4784
listItemRole when rendered object is a list item.
4785
(WebCore::AccessibilityRenderObject::canSetFocusAttribute): Return
4786
true for ListItemRole, matching firefox.
4787
* page/mac/AccessibilityObjectWrapper.mm:
4788
(RoleEntry::): Map ListItemRole with NSAccessibilityGroupRole in
4789
MAC.
4790
4791
2009-04-29 Xiaomei Ji <xji@chromium.org>
4792
4793
Reviewed by Dan Bernstein.
4794
4795
Fix https://bugs.webkit.org/show_bug.cgi?id=24168
4796
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document
4797
4798
Test: editing/selection/home-end.html
4799
4800
* editing/SelectionController.cpp:
4801
(WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine()
4802
to logicalEndOfLine() when granularity is LineBoundary.
4803
(WebCore::SelectionController::modifyMovingForward): Change calling endOfLine()
4804
to logicalEndOfLine() when granularity is LineBoundary
4805
(WebCore::SelectionController::modifyExtendingBackward): Change calling
4806
startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
4807
(WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine()
4808
to logicalStartOfLine() when granularity is LineBoundary.
4809
* editing/visible_units.cpp:
4810
(WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order.
4811
(WebCore::getLogicalStartBoxAndNode): Added.
4812
(WebCore::getLogicalEndBoxAndNode): Added.
4813
(WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine.
4814
(WebCore::logicalStartOfLine): Added. Similar to startOfLine.
4815
(WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine.
4816
(WebCore::inSameLogicalLine): Added.
4817
(WebCore::logicalEndOfLine): Added. Similar to endOfLine.
4818
* editing/visible_units.h:
4819
4820
2009-04-29 Mike Belshe <mike@belshe.com>
4821
4822
Reviewed by Eric Seidel.
4823
4824
Update location while page is loading.
4825
https://bugs.webkit.org/show_bug.cgi?id=21597
4826
4827
Tested by:
4828
- fast/dom/location-new-window-no-crash
4829
- fast/dom/Window/window-open-pending-url
4830
4831
* page/Location.cpp:
4832
4833
2009-04-29 Feng Qian <feng@chromium.org>
4834
4835
Reviewed by Darin Adler.
4836
4837
Add Android port files to WebCore/platform.
4838
https://bugs.webkit.org/show_bug.cgi?id=23296
4839
4840
* platform/android: Added.
4841
* platform/android/ClipboardAndroid.cpp: Added.
4842
* platform/android/ClipboardAndroid.h: Added.
4843
4844
2009-04-29 Feng Qian <feng@chromium.org>
4845
4846
Reviewed by Darin Adler.
4847
4848
Add Android-specific files to the WebCore/page directory.
4849
https://bugs.webkit.org/show_bug.cgi?id=23295
4850
4851
* page/android: Added.
4852
* page/android/DragControllerAndroid.cpp: Added.
4853
* page/android/EventHandlerAndroid.cpp: Added.
4854
* page/android/InspectorControllerAndroid.cpp: Added.
4855
4856
2009-04-29 Pavel Feldman <pfeldman@chromium.org>
4857
4858
Reviewed by Timothy Hatcher.
4859
4860
Extract PageGroupLoadDeferrer from Chrome.cpp
4861
4862
* GNUmakefile.am: added PageGroupLoadDeferrer
4863
* WebCore.pro: ditto
4864
* WebCore.scons: ditto
4865
* WebCore.vcproj/WebCore.vcproj: ditto
4866
* WebCore.xcodeproj/project.pbxproj: ditto
4867
* WebCoreSources.bkl: ditto
4868
* page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
4869
* page/PageGroupLoadDeferrer.cpp: Added.
4870
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
4871
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
4872
* page/PageGroupLoadDeferrer.h: Added.
4873
4874
2009-04-24 Ojan Vafai <ojan@chromium.org>
4875
4876
Reviewed by Dan Bernstein.
4877
4878
Make textarea and text input metrics more closely match IEs.
4879
4880
This involves:
4881
-set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
4882
-set textarea width to cols*avgCharWidth
4883
-Make default CSS match IEs
4884
-Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
4885
4886
Those values for textarea and inputs were derived by doing a ton of manual
4887
testing of IE's width values for various textareas and fonts. On Windows we match
4888
IE exactly except for a couple fonts of the ~12 tested.
4889
4890
To get the average and max character width of a font, we do the following
4891
for each platform:
4892
-Win: TextMetrics expose avgCharWidth and maxCharWidth
4893
-SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
4894
maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
4895
-Linux: avgCharWidth = width of an '0', fallback on m_xHeight
4896
maxCharWidth = max of avgCharWidth and m_ascent
4897
-Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
4898
If either one is non-positive, then calculate the value using the Linux approach.
4899
4900
Tests: fast/forms/text-control-intrinsic-widths.html
4901
fast/forms/textarea-metrics.html
4902
svg/custom/svg-fonts-in-text-controls.html
4903
4904
* css/html4.css:
4905
* css/themeWin.css:
4906
* platform/graphics/SimpleFontData.cpp:
4907
(WebCore::SimpleFontData::SimpleFontData):
4908
(WebCore::SimpleFontData::initCharWidths):
4909
* platform/graphics/SimpleFontData.h:
4910
(WebCore::SimpleFontData::maxCharWidth):
4911
(WebCore::SimpleFontData::avgCharWidth):
4912
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
4913
(WebCore::SimpleFontData::platformCharWidthInit):
4914
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
4915
(WebCore::SimpleFontData::platformCharWidthInit):
4916
* platform/graphics/gtk/SimpleFontDataGtk.cpp:
4917
(WebCore::SimpleFontData::platformCharWidthInit):
4918
* platform/graphics/gtk/SimpleFontDataPango.cpp:
4919
(WebCore::SimpleFontData::platformCharWidthInit):
4920
* platform/graphics/mac/SimpleFontDataMac.mm:
4921
(WebCore::SimpleFontData::platformCharWidthInit):
4922
* platform/graphics/qt/SimpleFontDataQt.cpp:
4923
(WebCore::SimpleFontData::platformCharWidthInit):
4924
* platform/graphics/win/SimpleFontDataCGWin.cpp:
4925
(WebCore::SimpleFontData::platformCharWidthInit):
4926
* platform/graphics/win/SimpleFontDataCairoWin.cpp:
4927
(WebCore::SimpleFontData::platformInit):
4928
(WebCore::SimpleFontData::platformCharWidthInit):
4929
* platform/graphics/win/SimpleFontDataWin.cpp:
4930
(WebCore::SimpleFontData::initGDIFont):
4931
* platform/graphics/wx/SimpleFontDataWx.cpp:
4932
(WebCore::SimpleFontData::platformCharWidthInit):
4933
* rendering/RenderTextControl.cpp:
4934
(WebCore::RenderTextControl::calcPrefWidths):
4935
* rendering/RenderTextControlMultiLine.cpp:
4936
(WebCore::RenderTextControlMultiLine::createInnerTextStyle):
4937
* rendering/RenderTextControlSingleLine.cpp:
4938
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
4939
4940
2009-04-29 Brady Eidson <beidson@apple.com>
4941
4942
Reviewed by Darin Adler.
4943
4944
* bindings/objc/DOMCSS.mm:
4945
(kitClass): Added CSS_INITIAL to the switch statement, and changed to use the WebCore
4946
type and not the binding type.
4947
4948
2009-04-29 John Abd-El-Malek <jam@google.com>
4949
4950
Reviewed by Dimitri Glazkov.
4951
4952
Reverted my previous change to add resetChromiumPluginCache().
4953
https://bugs.webkit.org/show_bug.cgi?id=25318
4954
4955
* plugins/chromium/PluginDataChromium.cpp:
4956
4957
2009-04-29 Brady Eidson <beidson@apple.com>
4958
4959
Reviewed by Darin Adler.
4960
4961
<rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail
4962
4963
Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>
4964
4965
Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.
4966
4967
* loader/DocumentLoader.cpp:
4968
(WebCore::DocumentLoader::subresource): Remove the preload referenced check.
4969
4970
2009-04-29 Alpha Lam <hclam@chromium.org>
4971
4972
Reviewed by Dimitri Glazkov.
4973
4974
https://bugs.webkit.org/show_bug.cgi?id=25430
4975
4976
Provide style sheet for UI controls of media elements for Chromium port.
4977
4978
* rendering/RenderThemeChromiumWin.cpp:
4979
(WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):
4980
4981
2009-04-29 John Abd-El-Malek <jam@chromium.org>
4982
4983
Reviewed by Darin Adler.
4984
4985
Expose sudden termination to Chromium port.
4986
https://bugs.webkit.org/show_bug.cgi?id=25457
4987
4988
* platform/SuddenTermination.h:
4989
* platform/chromium/ChromiumBridge.h:
4990
* platform/chromium/SuddenTerminationChromium.cpp: Added.
4991
(WebCore::disableSuddenTermination):
4992
(WebCore::enableSuddenTermination):
4993
4994
2009-04-29 Sam Weinig <sam@webkit.org>
4995
4996
Reviewed by Dimitri Glazkov.
4997
4998
Remove unused EventListeners.
4999
5000
* page/DOMWindow.idl:
5001
5002
2009-04-29 Yury Semikhatsky <yurys@chromium.org>
5003
5004
Reveal current execution line once SourceFrame content is loaded.
5005
5006
https://bugs.webkit.org/show_bug.cgi?id=25448
5007
5008
Reviewed by Timothy Hatcher.
5009
5010
* inspector/front-end/SourceFrame.js:
5011
(WebInspector.SourceFrame.prototype._loaded):
5012
5013
2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
5014
5015
Reviewed by Simon Fraser.
5016
5017
[Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
5018
the default values of canvas attributes.
5019
5020
* platform/graphics/qt/ImageBufferQt.cpp:
5021
(WebCore::ImageBufferData::ImageBufferData):
5022
5023
2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
5024
5025
Fix the Qt build.
5026
5027
* bridge/qt/qt_runtime.cpp:
5028
(JSC::Bindings::findMethodIndex): Removed exec param from at() call.
5029
(JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
5030
5031
2009-04-28 Geoffrey Garen <ggaren@apple.com>
5032
5033
Rubber stamped by Beth Dakin.
5034
5035
Missed one.
5036
5037
* bindings/scripts/CodeGeneratorJS.pm:
5038
5039
2009-04-28 Geoffrey Garen <ggaren@apple.com>
5040
5041
Rubber stamped by Beth Dakin.
5042
5043
Removed scaffolding supporting dynamically converting between 32bit and
5044
64bit value representations.
5045
5046
* bindings/js/JSAudioConstructor.cpp:
5047
(WebCore::constructAudio):
5048
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
5049
(WebCore::JSCanvasRenderingContext2D::setFillColor):
5050
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
5051
(WebCore::JSCanvasRenderingContext2D::strokeRect):
5052
(WebCore::JSCanvasRenderingContext2D::drawImage):
5053
(WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
5054
(WebCore::JSCanvasRenderingContext2D::setShadow):
5055
(WebCore::JSCanvasRenderingContext2D::createPattern):
5056
(WebCore::JSCanvasRenderingContext2D::putImageData):
5057
(WebCore::JSCanvasRenderingContext2D::fillText):
5058
(WebCore::JSCanvasRenderingContext2D::strokeText):
5059
* bindings/js/JSClipboardCustom.cpp:
5060
(WebCore::JSClipboard::clearData):
5061
(WebCore::JSClipboard::getData):
5062
(WebCore::JSClipboard::setData):
5063
(WebCore::JSClipboard::setDragImage):
5064
* bindings/js/JSDOMApplicationCacheCustom.cpp:
5065
(WebCore::JSDOMApplicationCache::hasItem):
5066
(WebCore::JSDOMApplicationCache::add):
5067
(WebCore::JSDOMApplicationCache::remove):
5068
(WebCore::JSDOMApplicationCache::addEventListener):
5069
(WebCore::JSDOMApplicationCache::removeEventListener):
5070
* bindings/js/JSDOMStringListCustom.cpp:
5071
(WebCore::JSDOMStringList::item):
5072
* bindings/js/JSDOMWindowCustom.cpp:
5073
(WebCore::JSDOMWindow::open):
5074
(WebCore::JSDOMWindow::showModalDialog):
5075
(WebCore::JSDOMWindow::postMessage):
5076
(WebCore::JSDOMWindow::setTimeout):
5077
(WebCore::JSDOMWindow::setInterval):
5078
(WebCore::JSDOMWindow::atob):
5079
(WebCore::JSDOMWindow::btoa):
5080
(WebCore::JSDOMWindow::addEventListener):
5081
(WebCore::JSDOMWindow::removeEventListener):
5082
* bindings/js/JSDatabaseCustom.cpp:
5083
(WebCore::JSDatabase::changeVersion):
5084
(WebCore::JSDatabase::transaction):
5085
* bindings/js/JSElementCustom.cpp:
5086
(WebCore::JSElement::setAttribute):
5087
(WebCore::JSElement::setAttributeNode):
5088
(WebCore::JSElement::setAttributeNS):
5089
(WebCore::JSElement::setAttributeNodeNS):
5090
* bindings/js/JSGeolocationCustom.cpp:
5091
(WebCore::JSGeolocation::getCurrentPosition):
5092
(WebCore::JSGeolocation::watchPosition):
5093
* bindings/js/JSHTMLCollectionCustom.cpp:
5094
(WebCore::callHTMLCollection):
5095
(WebCore::JSHTMLCollection::item):
5096
(WebCore::JSHTMLCollection::namedItem):
5097
* bindings/js/JSHTMLDocumentCustom.cpp:
5098
(WebCore::documentWrite):
5099
* bindings/js/JSHTMLInputElementCustom.cpp:
5100
(WebCore::JSHTMLInputElement::setSelectionRange):
5101
* bindings/js/JSHTMLOptionsCollectionCustom.cpp:
5102
(WebCore::JSHTMLOptionsCollection::add):
5103
* bindings/js/JSHTMLSelectElementCustom.cpp:
5104
(WebCore::JSHTMLSelectElement::remove):
5105
* bindings/js/JSImageConstructor.cpp:
5106
(WebCore::constructImage):
5107
* bindings/js/JSInspectorControllerCustom.cpp:
5108
(WebCore::JSInspectorController::highlightDOMNode):
5109
(WebCore::JSInspectorController::addResourceSourceToFrame):
5110
(WebCore::JSInspectorController::addSourceToFrame):
5111
(WebCore::JSInspectorController::getResourceDocumentNode):
5112
(WebCore::JSInspectorController::search):
5113
(WebCore::JSInspectorController::databaseTableNames):
5114
(WebCore::JSInspectorController::setting):
5115
(WebCore::JSInspectorController::setSetting):
5116
(WebCore::JSInspectorController::wrapCallback):
5117
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
5118
(WebCore::JSJavaScriptCallFrame::evaluate):
5119
* bindings/js/JSLocationCustom.cpp:
5120
(WebCore::JSLocation::replace):
5121
(WebCore::JSLocation::assign):
5122
* bindings/js/JSMessagePortCustom.cpp:
5123
(WebCore::JSMessagePort::startConversation):
5124
(WebCore::JSMessagePort::addEventListener):
5125
(WebCore::JSMessagePort::removeEventListener):
5126
* bindings/js/JSNodeCustom.cpp:
5127
(WebCore::JSNode::insertBefore):
5128
(WebCore::JSNode::replaceChild):
5129
(WebCore::JSNode::removeChild):
5130
(WebCore::JSNode::appendChild):
5131
(WebCore::JSNode::addEventListener):
5132
(WebCore::JSNode::removeEventListener):
5133
* bindings/js/JSNodeFilterCustom.cpp:
5134
(WebCore::JSNodeFilter::acceptNode):
5135
* bindings/js/JSNodeListCustom.cpp:
5136
(WebCore::callNodeList):
5137
* bindings/js/JSOptionConstructor.cpp:
5138
(WebCore::constructHTMLOptionElement):
5139
* bindings/js/JSQuarantinedObjectWrapper.cpp:
5140
(WebCore::JSQuarantinedObjectWrapper::construct):
5141
(WebCore::JSQuarantinedObjectWrapper::call):
5142
* bindings/js/JSSQLResultSetRowListCustom.cpp:
5143
(WebCore::JSSQLResultSetRowList::item):
5144
* bindings/js/JSSQLTransactionCustom.cpp:
5145
(WebCore::JSSQLTransaction::executeSql):
5146
* bindings/js/JSSVGElementInstanceCustom.cpp:
5147
(WebCore::JSSVGElementInstance::addEventListener):
5148
(WebCore::JSSVGElementInstance::removeEventListener):
5149
* bindings/js/JSSVGLengthCustom.cpp:
5150
(WebCore::JSSVGLength::convertToSpecifiedUnits):
5151
* bindings/js/JSSVGMatrixCustom.cpp:
5152
(WebCore::JSSVGMatrix::rotateFromVector):
5153
* bindings/js/JSSVGPathSegListCustom.cpp:
5154
(WebCore::JSSVGPathSegList::initialize):
5155
(WebCore::JSSVGPathSegList::getItem):
5156
(WebCore::JSSVGPathSegList::insertItemBefore):
5157
(WebCore::JSSVGPathSegList::replaceItem):
5158
(WebCore::JSSVGPathSegList::removeItem):
5159
(WebCore::JSSVGPathSegList::appendItem):
5160
* bindings/js/JSSVGPointListCustom.cpp:
5161
(WebCore::JSSVGPointList::initialize):
5162
(WebCore::JSSVGPointList::getItem):
5163
(WebCore::JSSVGPointList::insertItemBefore):
5164
(WebCore::JSSVGPointList::replaceItem):
5165
(WebCore::JSSVGPointList::removeItem):
5166
(WebCore::JSSVGPointList::appendItem):
5167
* bindings/js/JSSVGTransformListCustom.cpp:
5168
(WebCore::JSSVGTransformList::initialize):
5169
(WebCore::JSSVGTransformList::getItem):
5170
(WebCore::JSSVGTransformList::insertItemBefore):
5171
(WebCore::JSSVGTransformList::replaceItem):
5172
(WebCore::JSSVGTransformList::removeItem):
5173
(WebCore::JSSVGTransformList::appendItem):
5174
* bindings/js/JSWebKitCSSMatrixConstructor.cpp:
5175
(WebCore::constructWebKitCSSMatrix):
5176
* bindings/js/JSWebKitPointConstructor.cpp:
5177
(WebCore::constructWebKitPoint):
5178
* bindings/js/JSWorkerConstructor.cpp:
5179
(WebCore::constructWorker):
5180
* bindings/js/JSWorkerContextCustom.cpp:
5181
(WebCore::JSWorkerContext::importScripts):
5182
(WebCore::JSWorkerContext::addEventListener):
5183
(WebCore::JSWorkerContext::removeEventListener):
5184
(WebCore::JSWorkerContext::setTimeout):
5185
(WebCore::JSWorkerContext::setInterval):
5186
* bindings/js/JSWorkerCustom.cpp:
5187
(WebCore::JSWorker::addEventListener):
5188
(WebCore::JSWorker::removeEventListener):
5189
* bindings/js/JSXMLHttpRequestCustom.cpp:
5190
(WebCore::JSXMLHttpRequest::open):
5191
(WebCore::JSXMLHttpRequest::setRequestHeader):
5192
(WebCore::JSXMLHttpRequest::send):
5193
(WebCore::JSXMLHttpRequest::getResponseHeader):
5194
(WebCore::JSXMLHttpRequest::overrideMimeType):
5195
(WebCore::JSXMLHttpRequest::addEventListener):
5196
(WebCore::JSXMLHttpRequest::removeEventListener):
5197
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
5198
(WebCore::JSXMLHttpRequestUpload::addEventListener):
5199
(WebCore::JSXMLHttpRequestUpload::removeEventListener):
5200
* bindings/js/JSXSLTProcessorCustom.cpp:
5201
(WebCore::JSXSLTProcessor::importStylesheet):
5202
(WebCore::JSXSLTProcessor::transformToFragment):
5203
(WebCore::JSXSLTProcessor::transformToDocument):
5204
(WebCore::JSXSLTProcessor::setParameter):
5205
(WebCore::JSXSLTProcessor::getParameter):
5206
(WebCore::JSXSLTProcessor::removeParameter):
5207
* bindings/js/ScheduledAction.cpp:
5208
(WebCore::ScheduledAction::create):
5209
(WebCore::ScheduledAction::ScheduledAction):
5210
* bindings/js/ScheduledAction.h:
5211
* bindings/js/ScriptCallFrame.cpp:
5212
(WebCore::ScriptCallFrame::ScriptCallFrame):
5213
* bindings/js/ScriptCallFrame.h:
5214
* bindings/js/ScriptCallStack.cpp:
5215
(WebCore::ScriptCallStack::ScriptCallStack):
5216
(WebCore::ScriptCallStack::initialize):
5217
* bridge/c/c_instance.cpp:
5218
(JSC::Bindings::CInstance::invokeMethod):
5219
(JSC::Bindings::CInstance::invokeDefaultMethod):
5220
(JSC::Bindings::CInstance::invokeConstruct):
5221
* bridge/jni/jni_instance.cpp:
5222
(JavaInstance::invokeMethod):
5223
* bridge/objc/objc_instance.mm:
5224
(ObjcInstance::invokeMethod):
5225
(ObjcInstance::invokeDefaultMethod):
5226
5227
2009-04-28 David Carson <dacarson@apple.com>
5228
5229
Reviewed by David Hyatt.
5230
5231
Restore alignment to device pixel boundaries.
5232
https://bugs.webkit.org/show_bug.cgi?id=25458
5233
5234
Adjust the adjusted destination rect to be device pixel aligned.
5235
5236
* platform/graphics/cg/ImageCG.cpp:
5237
(WebCore::BitmapImage::draw):
5238
5239
2009-04-28 Sam Weinig <sam@webkit.org>
5240
5241
Reviewed by Anders Carlsson.
5242
5243
Move unimplemented captureEvents and releaseEvents from JSDOMWindow
5244
to DOMWindow.
5245
5246
* bindings/js/JSDOMWindowCustom.cpp:
5247
* page/DOMWindow.cpp:
5248
(WebCore::DOMWindow::captureEvents):
5249
(WebCore::DOMWindow::releaseEvents):
5250
* page/DOMWindow.h:
5251
* page/DOMWindow.idl:
5252
5253
2009-04-28 Alexey Proskuryakov <ap@webkit.org>
5254
5255
Reviewed by Darin Adler.
5256
5257
https://bugs.webkit.org/show_bug.cgi?id=25420
5258
<rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin
5259
5260
Test: http/tests/xmlhttprequest/detaching-frame-2.html
5261
5262
This was caused by faulty DOMWindow::document(), which could return a new document from
5263
the window's frame after navigation.
5264
5265
* bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
5266
Removed an obsolete check that allowed access when document was null. Contrary to what a
5267
comment said, that can happen for a window that is no longer in frame, not to one whose
5268
document is not constructed yet.
5269
5270
* bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail
5271
out if context was not found. This currently happens due to a shortcoming in
5272
DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression
5273
test will be constructed successfully, but won't be sent, because its context will be
5274
frameless.
5275
5276
* page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't
5277
been replaced yet. Added FIXME comments about how this may be better fixed in the future.
5278
5279
* bindings/js/JSAudioConstructor.cpp:
5280
(WebCore::JSAudioConstructor::document):
5281
(WebCore::constructAudio):
5282
* bindings/js/JSImageConstructor.cpp:
5283
(WebCore::JSImageConstructor::document):
5284
(WebCore::constructImage):
5285
* bindings/js/JSMessageChannelConstructor.cpp:
5286
(WebCore::JSMessageChannelConstructor::construct):
5287
* bindings/js/JSOptionConstructor.cpp:
5288
(WebCore::JSOptionConstructor::document):
5289
(WebCore::constructHTMLOptionElement):
5290
Make matching changes to other constructors that hold a reference to global object.
5291
5292
2009-04-28 Kevin Ollivier <kevino@theolliviers.com>
5293
5294
wxMSW build fix. Switch JSCore build back to static.
5295
5296
* config.h:
5297
5298
2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
5299
5300
Reviewed by Simon Fraser.
5301
5302
<rdar://problem/6834830>
5303
5304
Make sure we cover the two possible values reported by event.total that are playback engine
5305
specific.
5306
5307
* media/progress-event-total-expected.txt: Match the new test.
5308
* media/progress-event-total.html: Test the two values.
5309
5310
2009-04-28 Timothy Hatcher <timothy@apple.com>
5311
5312
Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
5313
collects the individual rects, making sure to only include RenderText.
5314
5315
<rdar://problem/6810061>
5316
5317
Reviewed by Sam Weinig.
5318
5319
* bindings/objc/DOM.mm:
5320
(-[DOMNode textRects]): Added. Make a Range and call textRects.
5321
(-[DOMNode lineBoxRects]): Call textRects method.
5322
(-[DOMRange textRects]): Call Range::textRects.
5323
(-[DOMRange lineBoxRects]): Call textRects method.
5324
* bindings/objc/DOMPrivate.h: Add the new methods and a comment
5325
about lineBoxRects being deprecated.
5326
* dom/Range.cpp:
5327
(WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects).
5328
(WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the
5329
nodes instead of the RenderObjects to correctly account for offsets. Also
5330
only call absoluteRectsForRange on RenderText.
5331
* dom/Range.h: Renamed addLineBoxRects to textRects.
5332
* page/Frame.cpp:
5333
(WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
5334
* rendering/RenderObject.cpp:
5335
(WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this
5336
function very specific for the lineBoxRects API. These functions are still used
5337
by the InspectorController, and this change improves what the Inspector shows.
5338
(WebCore::RenderObject::absoluteQuadsForRange): Ditto.
5339
5340
2009-04-28 Timothy Hatcher <timothy@apple.com>
5341
5342
Remove the topLevel boolean argument from absolute{Rects,Quads}.
5343
This argument was default to true and no one ever passed false.
5344
5345
Reviewed by Sam Weinig.
5346
5347
* rendering/RenderBlock.cpp:
5348
(WebCore::RenderBlock::absoluteRects):
5349
(WebCore::RenderBlock::absoluteQuads):
5350
* rendering/RenderBlock.h:
5351
* rendering/RenderBox.cpp:
5352
(WebCore::RenderBox::absoluteRects):
5353
(WebCore::RenderBox::absoluteQuads):
5354
* rendering/RenderBox.h:
5355
* rendering/RenderInline.cpp:
5356
(WebCore::RenderInline::absoluteRects):
5357
(WebCore::RenderInline::absoluteQuads):
5358
* rendering/RenderInline.h:
5359
* rendering/RenderObject.h:
5360
(WebCore::RenderObject::absoluteRects):
5361
(WebCore::RenderObject::absoluteQuads):
5362
* rendering/RenderSVGHiddenContainer.cpp:
5363
(WebCore::RenderSVGHiddenContainer::absoluteRects):
5364
(WebCore::RenderSVGHiddenContainer::absoluteQuads):
5365
* rendering/RenderSVGHiddenContainer.h:
5366
* rendering/RenderSVGImage.cpp:
5367
(WebCore::RenderSVGImage::absoluteRects):
5368
(WebCore::RenderSVGImage::absoluteQuads):
5369
* rendering/RenderSVGImage.h:
5370
* rendering/RenderSVGInlineText.cpp:
5371
(WebCore::RenderSVGInlineText::absoluteRects):
5372
(WebCore::RenderSVGInlineText::absoluteQuads):
5373
* rendering/RenderSVGInlineText.h:
5374
* rendering/RenderSVGModelObject.cpp:
5375
(WebCore::RenderSVGModelObject::absoluteRects):
5376
(WebCore::RenderSVGModelObject::absoluteQuads):
5377
* rendering/RenderSVGModelObject.h:
5378
* rendering/RenderSVGTSpan.cpp:
5379
(WebCore::RenderSVGTSpan::absoluteRects):
5380
(WebCore::RenderSVGTSpan::absoluteQuads):
5381
* rendering/RenderSVGTSpan.h:
5382
* rendering/RenderSVGText.cpp:
5383
(WebCore::RenderSVGText::absoluteRects):
5384
(WebCore::RenderSVGText::absoluteQuads):
5385
* rendering/RenderSVGText.h:
5386
* rendering/RenderSVGTextPath.cpp:
5387
(WebCore::RenderSVGTextPath::absoluteQuads):
5388
* rendering/RenderSVGTextPath.h:
5389
* rendering/RenderText.cpp:
5390
(WebCore::RenderText::absoluteRects):
5391
* rendering/RenderText.h:
5392
* rendering/RenderView.cpp:
5393
(WebCore::RenderView::absoluteRects):
5394
(WebCore::RenderView::absoluteQuads):
5395
* rendering/RenderView.h:
5396
5397
2009-04-28 Eric Carlson <eric.carlson@apple.com>
5398
5399
Reviewed by Simon Fraser.
5400
5401
<rdar://problem/6794691> Media documents and <video controls> never show controls on Windows
5402
5403
RenderThemeWin doesn't implement the media element controller rendering methods, so media
5404
controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
5405
of the code in both places, the logic is in a new class that is called from both.
5406
5407
* WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.
5408
5409
* rendering/RenderMediaControls.cpp: Added.
5410
(WebCore::determineState): Translate renderer state to ThemeControlState.
5411
(WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb.
5412
(WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element.
5413
(WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
5414
* rendering/RenderMediaControls.h: Added.
5415
5416
* rendering/RenderThemeSafari.cpp:
5417
(WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never
5418
called for the media slider.
5419
(WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function.
5420
(WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto.
5421
(WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto.
5422
(WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto.
5423
(WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto.
5424
(WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto.
5425
(WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto.
5426
(WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.
5427
5428
* rendering/RenderThemeWin.cpp:
5429
(WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto.
5430
(WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto.
5431
(WebCore::RenderThemeWin::paintMediaMuteButton): Ditto.
5432
(WebCore::RenderThemeWin::paintMediaPlayButton): Ditto.
5433
(WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto.
5434
(WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto.
5435
(WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto.
5436
(WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
5437
* rendering/RenderThemeWin.h:
5438
5439
2009-04-28 Beth Dakin <bdakin@apple.com>
5440
5441
Reviewed by Sam Weinig.
5442
5443
Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
5444
images with % height are collapsed when printing
5445
5446
* rendering/RenderBox.cpp:
5447
(WebCore::RenderBox::calcHeight): Make sure we don't ignore
5448
printing here!
5449
1
5450
2009-04-28 Adele Peterson <adele@apple.com>
2
5451
3
5452
Reviewed by Darin Adler.
15346
20795
* html/HTMLAppletElement.cpp:
15347
20796
(WebCore::HTMLAppletElement::createRenderer):
15348
20797
* loader/FrameLoader.cpp:
15349
(WebCore::FrameLoader::loadItem):
20798
(WebCore::FrameLoader::createJavaAppletWidget):
15350
20799
15351
20800
2009-03-10 Justin Garcia <justin.garcia@apple.com>
15352
20801
Loggerhead is a web-based interface for Breezy
Version: 2.0.1