~ubuntu-branches/ubuntu/lucid/arista/lucid

« back to all changes in this revision

Viewing changes to debian/patches/02-log_extra_info_on_missing_plugins.patch

  • Committer: Bazaar Package Importer
  • Author(s): Alessio Treglia
  • Date: 2009-12-06 19:06:55 UTC
  • Revision ID: james.westby@ubuntu.com-20091206190655-iui4w0n40d9bl0o6
Tags: 0.9.3+repack-0ubuntu4
* debian/patches/02-log_extra_info_on_missing_plugins.patch:
  - arista/presets.py: Log some extra information while attempting to
    automagically install missing plugins.
* debian/patches/03-crash_with_high_dimension_video.patch:
  - presets/dvd.xml: Constrain DVD MPEG2 sizes as GStreamer DVD stuff
    doesn't seem to be totally spec compliant (LP: #399725).
* debian/patches/04-remember_last_opened_location.patch:
  - arista-gtk: Remember last opened location for file chooser dialog as
    a gconf setting (LP: #407146).
* debian/patches/05-ellipsize_filename.patch:
  - arista-gtk: Ellipsize long filenames so the window doesn't grow to a
    ridiculous size (LP: #407149). 
* debian/patches/06-non_utf8_locales.patch:
  - arista-gtk: Fix translation for non-UTF8 locale (LP: #410266).
* debian/patches/07-gstreamer_videocaps.patch:
  - arista/transcoder.py: Catch a rare case where GStreamer didn't set
    videocaps for a video file properly (LP: #441069).
* debian/patches/08-negative_remaining_time.patch:
  - arista/transcoder.py: Don't display strange negative status information,
    instead fall back to saying an unknown amount of time remains with no
    current status.

Show diffs side-by-side

added added

removed removed

Lines of Context:
 
1
Vendor: http://github.com/danielgtaylor/arista/commit/c997b075480db20bf5fefbca8331b2f20a0c0a7b
 
2
Description: Log some extra information while attempting to automagically
 
3
 install missing plugins. 
 
4
---
 
5
 arista/presets.py |    9 ++++++++-
 
6
 1 file changed, 8 insertions(+), 1 deletion(-)
 
7
 
 
8
--- arista-0.9.3+repack.orig/arista/presets.py
 
9
+++ arista-0.9.3+repack/arista/presets.py
 
10
@@ -228,13 +228,18 @@ class Preset(object):
 
11
         ]
 
12
         
 
13
         missing = []
 
14
+        missingdesc = ""
 
15
         for element in elements:
 
16
             if not gst.element_factory_find(element):
 
17
                 missing.append(gst.pbutils.missing_element_installer_detail_new(element))
 
18
+                if missingdesc:
 
19
+                    missingdesc += ", %s" % element
 
20
+                else:
 
21
+                    missingdesc += element
 
22
         
 
23
         if missing:
 
24
+            _log.info("Attempting to install elements: %s" % missingdesc)
 
25
             if gst.pbutils.install_plugins_supported():
 
26
-                
 
27
                 def install_done(result, null):
 
28
                     if result == gst.pbutils.INSTALL_PLUGINS_INSTALL_IN_PROGRESS:
 
29
                         # Ignore start of installer message
 
30
@@ -242,12 +247,14 @@ class Preset(object):
 
31
                     elif result == gst.pbutils.INSTALL_PLUGINS_SUCCESS:
 
32
                         callback(self, True, *args)
 
33
                     else:
 
34
+                        _log.error("Unable to install required elements!")
 
35
                         callback(self, False, *args)
 
36
             
 
37
                 context = gst.pbutils.InstallPluginsContext()
 
38
                 gst.pbutils.install_plugins_async(missing, context,
 
39
                                                   install_done, "")
 
40
             else:
 
41
+                _log.error("Installing elements not supported!")
 
42
                 gobject.idle_add(callback, self, False, *args)
 
43
         else:
 
44
             gobject.idle_add(callback, self, True, *args)