← Back to branch summary

~ubuntu-branches/ubuntu/lucid/kvirc/lucid-updates

« back to all changes in this revision

Viewing changes to src/modules/dcc/requests.cpp

  • Committer: Bazaar Package Importer
  • Author(s): Nathan Handler
  • Date: 2011-03-12 20:00:18 UTC
  • Revision ID: james.westby@ubuntu.com-20110312200018-o52wsh3pna2ymaaa
Tags: 4:4.0.0~svn3900+rc2-1ubuntu0.2
https://launchpad.net/bugs/612682
* SECURITY UPDATE: The IRC Protocol component in KVIrc 3.x and 4.x before 
  r4693 does not properly handle \ (backslash) characters, which allows
  remote authenticated users to execute arbitrary CTCP commands via vectors
  involving \r and \40 sequences, a different vulnerability than CVE-2010-2451
  and CVE-2010-2452.
  - 33_upstream_security_#858.patch
    - Patch based on upstream SVN revision 4693.
  - CVE-2010-2785:
    - http://www.cve.mitre.org/cgi-bin/cvename.cgi?name=2010-2785
  - LP: #612682

Show diffs side-by-side

added added

removed removed

Lines of Context:
src/modules/dcc/requests.cpp
86
86
        if(KVI_OPTION_BOOL(KviOption_boolNotifyFailedDccHandshakes))
87
87
        {
88
88
                QString szError = QString("Sorry, your DCC %1 request can't be satisfied: %2").arg(dcc->szType.ptr(), errText);
89
 
                dcc_module_reply_errmsg(dcc,szError);
 
89
                //since szError contains an user-suppplied string, we simplify it to avoid any kind of injection (bug #858)
 
90
                dcc_module_reply_errmsg(dcc,szError.simplified());
90
91
        }
91
92
}
92
93