« back to all changes in this revision
Viewing changes to ChangeLog
- browse files at revision 49
- compare with another revision
- download diff
- download tarball
- view history from revision 49
- Committer: Bazaar Package Importer
- Author(s): Timo Aaltonen
- Date: 2011-04-08 19:04:53 UTC
- mfrom: (1.1.13 upstream) (2.1.13 sid)
- Revision ID: james.westby@ubuntu.com-20110408190453-xvgvdjqp06ta0csm
Tags: 2:1.4.2-1ubuntu1
* Merge from Debian unstable, remaining changes:
- Add Latin locale.
- Add Klingon locale.
- Add 102_double_arrows_Compose.patch: compose keys for double arrows
(LP: 680143)
- Add Latin locale.
- Add Klingon locale.
- Add 102_double_arrows_Compose.patch: compose keys for double arrows
(LP: 680143)
- files added:
- debian/patches/102_double_arrows_Compose.diff
- files removed:
- debian/patches/102_double_arrows_Compose.patch
- files modified:
- ChangeLog
added
removed
ChangeLog
1
commit db8b20b789112717ac0590b40f0b4dc2171797d0
2
Author: Jeremy Huddleston <jeremyhu@apple.com>
3
Date: Thu Mar 17 16:15:00 2011 -0700
4
5
configure.ac: Bump version to 1.4.2
6
7
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
8
9
commit 83e1ba59c48c79f8b0a7e7aa0b9c9cfd84fa403d
10
Author: Jamey Sharp <jamey@minilop.net>
11
Date: Tue Mar 15 16:48:07 2011 -0700
12
13
Call _XErrorFunction without holding the Display lock.
14
15
Historically, Xlib dropped the Display lock around the upcall to any
16
user-supplied _XErrorFunction, but somewhere along the way I quit doing
17
that if you built with XCB. The reasons are lost somewhere in the
18
pre-git history of Xlib/XCB, and I can't now see any reason to hold the
19
lock.
20
21
The documentation for XSetErrorHandler still applies though:
22
23
Because this condition is not assumed to be fatal, it is acceptable
24
for your error handler to return; the returned value is ignored.
25
However, the error handler should not call any functions (directly
26
or indirectly) on the display that will generate protocol requests
27
or that will look for input events.
28
29
So while you are now once again permitted to re-enter Xlib from the
30
error handler, you're only allowed to call non-protocol functions.
31
32
Signed-off-by: Jamey Sharp <jamey@minilop.net>
33
34
commit fd85aca7a616c595fc17b2520f84316a11e8906f
35
Author: Jamey Sharp <jamey@minilop.net>
36
Date: Mon Mar 14 14:45:35 2011 -0700
37
38
Ignore user locks after sleeping in _XReply and _XReadEvents.
39
40
This bug appears as a hang in applications that wait for replies from
41
multiple threads, where one such thread has taken a user lock using
42
XLockDisplay.
43
44
Prior to this fix, the code could deadlock in this way: If thread 1 goes
45
to sleep waiting for a reply, and then thread 2 takes a user lock and
46
waits for a reply, then thread 2 will wait for thread 1 to process its
47
reply (because responses must be processed in order), but thread 1 will
48
wait for thread 2 to drop its user lock.
49
50
Fixed by making thread 1 not wait for thread 2 to drop its user lock.
51
This makes the semantics of user locks hard to define, but they were
52
already hard to define. The new behavior appears to be consistent with
53
the way Xlib worked historically, anyway.
54
55
Fixes: http://lists.freedesktop.org/archives/xcb/2011-March/006802.html
56
57
There was a similar potential for deadlock in _XReadEvents, fixed the
58
same way, with the same caveats about user-lock semantics.
59
60
Signed-off-by: Jamey Sharp <jamey@minilop.net>
61
62
commit 690f8bffd48a4e7e74298360ddd0431dc95dcd3f
63
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
64
Date: Tue Jan 18 15:58:20 2011 +0200
65
66
xkb: XkbPropertyPtr determined allocation success from wrong variables
67
68
Cannot reach dead statement "return NULL;"
69
70
Check for the NULLness of prop->name and prop->value instead of
71
name and value, which was checked earlier anyway. Decided against
72
using strdup due to curious memory allocation functions and the
73
rest of the xkb not using it either.
74
75
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
76
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
77
78
commit 6a4d027284e7bb5dd458157947bbb1ff580ad071
79
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
80
Date: Mon Jan 10 16:37:22 2011 +0200
81
82
keyBind: Use Xcalloc to initialize allocated _XKeytrans
83
84
Using uninitialized value "p->modifiers"
85
86
Small fix by using Xcalloc instead of Xmalloc
87
88
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
89
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
90
91
commit b993d73bb3214ecc24646f5427c8003b816c6921
92
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
93
Date: Mon Jan 10 16:22:45 2011 +0200
94
95
im/ximcp: release modifiermap before returning
96
97
Variable "map" goes out of scope
98
99
Release modifiermap before returning. Reordered code to call
100
XGetModifierMapping after the first return from the function.
101
102
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
103
Reviewed-by: Dirk Wallenstein <halsmit@t-online.de>
104
105
commit 807a7fc0354f2212dfa5ff1f9e4ede56d8e69ef4
106
Author: Gaetan Nadon <memsize@videotron.ca>
107
Date: Fri Feb 25 09:23:54 2011 -0500
108
109
Docbook: change the book id to match the xml file basename
110
111
This is required for the up-coming external references support.
112
113
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
114
115
commit 40812b53ff5fe548f6eaf43ba4c8781cb43dab43
116
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
117
Date: Mon Feb 21 21:54:17 2011 +0100
118
119
Make the Local XIM request key releases for braille
120
121
Braille chords management needs key release events. We need to explicitly
122
request then, else GTK would not pass them throught XFilterEvent and braille
123
wouldn't work.
124
125
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
126
127
commit c97c42c49cd5095462abecdf908b416fb0b540b6
128
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
129
Date: Mon Feb 21 17:27:38 2011 +0100
130
131
Match braille patterns with compose tree
132
133
Braille patterns should also be usable in Compose. This combines the
134
implementation of braille chords and compose tree: only emit the braille
135
pattern if it can not be found in the compose tree, if any.
136
137
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
138
139
commit 0c6ca565d7c8a47ef3ea823569a9ca5298a5307d
140
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
141
Date: Mon Feb 21 15:56:54 2011 +0100
142
143
Fix status reporting for braille patterns
144
145
_XimLocalMbLookupString can return a braille keysym even if _Xlcwctomb can't
146
convert to the current MB charset.
147
_XimLocalUtf8LookupString needs to set the braille keysym and status too.
148
149
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
150
151
commit 993abe751f4141f54d8d28b8b73588a1c9085970
152
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
153
Date: Fri Feb 11 14:49:17 2011 -0800
154
155
Clean up memory when first XCreateRegion succeeds and second fails
156
157
Error: Memory leak (CWE 401)
158
Memory leak of pointer 's' allocated with XCreateRegion()
159
at line 387 of /export/alanc/X.Org/sx86-gcc/lib/libX11/src/Region.c in function 'XShrinkRegion'.
160
's' allocated at line 387 with XCreateRegion().
161
s leaks when s != 0 at line 387.
162
Error: Memory leak (CWE 401)
163
Memory leak of pointer 'tra' allocated with XCreateRegion()
164
at line 1452 of /export/alanc/X.Org/sx86-gcc/lib/libX11/src/Region.c in function 'XXorRegion'.
165
'tra' allocated at line 1451 with XCreateRegion().
166
tra leaks when tra != 0 at line 1451.
167
168
[ This bug was found by the Parfait 0.3.6 bug checking tool.
169
For more information see http://labs.oracle.com/projects/parfait/ ]
170
171
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
172
173
commit 6ac417cea1136a3617f5e40f4b106aaa3f48d6c2
174
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
175
Date: Fri Feb 11 14:20:24 2011 -0800
176
177
ximcp: Prevent memory leak & double free if multiple %L in string
178
179
In the highly unlikely event that TransFileName was passed a path
180
containing multiple %L entries, for each entry it would call
181
_XlcFileName, leaking the previous results, and then for each entry it
182
would copy from that pointer and free it, resulting in invalid pointers
183
& possible double frees for each use after the first one freed it.
184
185
Error: Use after free (CWE 416)
186
Use after free of pointer 'lcCompose'
187
at line 358 of modules/im/ximcp/imLcPrs.c in function 'TransFileName'.
188
Previously freed at line 360 with free.
189
Error: Use after free (CWE 416)
190
Use after free of pointer 'lcCompose'
191
at line 359 of modules/im/ximcp/imLcPrs.c in function 'TransFileName'.
192
Previously freed at line 360 with free.
193
Error: Double free (CWE 415)
194
Double free of pointer 'lcCompose'
195
at line 360 of modules/im/ximcp/imLcPrs.c in function 'TransFileName'.
196
Previously freed at line 360 with free.
197
198
[ This bug was found by the Parfait 0.3.6 bug checking tool.
199
For more information see http://labs.oracle.com/projects/parfait/ ]
200
201
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
202
203
commit 502d414118c97d35a44f8e295709682022876331
204
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
205
Date: Thu Feb 3 17:08:57 2011 +0200
206
207
xcms/cmsProp: don't deal with uninitialized values, fail instead
208
209
Properly handle the return value of XGetWindowProperty by considering
210
if after the loop as well.
211
212
Using freed pointer "prop_ret"
213
214
There were numerous things wrong in how this function interacted with
215
XGetWindowProperty.
216
217
None of the local variables were initialized and remained that way if
218
the call to XGetWindowProperty returned 1 (not Succeed). That doesn't
219
result in after_ret being initialized in which case if it happens to
220
be 0, the loop was exited. In that case format_ret and nitems_ret were
221
uninitialized and the function might return with success (but with
222
uninitialized pointer in prop_ret) or XcmsFailure.
223
224
As the buffer enlarging code was called only when XGetWindowProperty
225
failed (returned not Success), after_ret would not have been
226
initialized. It would have been initialized only if the
227
XGetWindowProperty has returned Success earlier, but in that case the
228
code fragment would not have been reached.
229
230
This patch alters the function to return XcmsFailure if the call to
231
XGetWindowProperty fails.
232
233
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
234
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
235
Reviewed-by: Rami Ylimäki <rami.ylimaki@vincit.fi>
236
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
237
238
commit c37e278993b9e5b3d7025ef4c434373a011996ec
239
Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
240
Date: Mon Jan 31 14:02:07 2011 +0200
241
242
xcms/LRGB: don't double-free property_return
243
244
property_return was free'd before and in the case the conditional is true,
245
the call to XcmsGetProperty failed which means that property_return wasn't
246
set so there is no need to free it again.
247
248
Double free of pointer "property_return" in call to "free"
249
250
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
251
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
252
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
253
254
commit 50f4107811249806718a100f9d34f996c58e5e25
255
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
256
Date: Wed Feb 2 08:58:45 2011 -0800
257
258
Xrm.c: ReadInFile: refactor fstat error handling
259
260
We can simplify the fstat failure case now that the GetFileSize macro
261
has been expanded inline.
262
263
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
264
Reviewed-by: Julien Cristau <jcristau@debian.org>
265
266
commit 5e9c40fcb5da43c9fdacf12967d090bf202daf2a
267
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
268
Date: Wed Feb 2 08:56:00 2011 -0800
269
270
Expand GetSizeOfFile() macro at the one place it's called
271
272
Removes XrmI.h header that only contained this single macro
273
274
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
275
Reviewed-by: Julien Cristau <jcristau@debian.org>
276
277
commit 450e17422c0e374d25c643f343ea268cec68da38
278
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
279
Date: Mon Jan 31 14:01:57 2011 +0200
280
281
XlibInt: Use strncpy+zero termination instead of strcpy to enforce buffer size
282
283
Possible overrun of 8192 byte fixed size buffer "buffer" by copying
284
"ext->name" without length checking
285
286
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
287
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
288
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
289
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
290
291
commit e2566e43b02d2d7b7c1c3bb7db7c5ae81c1245fa
292
Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
293
Date: Mon Jan 31 14:02:13 2011 +0200
294
295
lc/def/lcDefConv: Use Xcalloc to avoid use of uninitialized memory
296
297
Fixed by zero'ing conv on allocation with Xcalloc. Then
298
close_converter works properly.
299
300
Using uninitialized value "conv->state" in call to function "close_converter"
301
302
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
303
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
304
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
305
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
306
307
commit 03f81ad8fb9783986cf9b17661dd31e95c396681
308
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
309
Date: Mon Jan 31 14:02:16 2011 +0200
310
311
xlibi18n/lcFile: Removed superfluous check for NULL target_dir
312
313
The situation is already handled before this code.
314
315
Cannot reach dead expression "0U" inside statement "if (1U + (target_dir ? strl..."
316
317
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
318
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
319
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
320
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
321
322
commit 1346b9ea3b3882201ff8c3ee462ff4b0d4edf639
323
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
324
Date: Mon Jan 31 14:02:15 2011 +0200
325
326
ximcp/imLckup: Handle negative return value from _Xlcwctomb
327
328
Fixed by negative value to memcpy by checking for the negative return
329
value of _Xlcwctomb and returning 0/XLookupNone in that case.
330
331
a negative value was passed to memcpy
332
333
Unfortunately the other return values for *status don't fit into the
334
error (which appears to indicate some internal error or running out of
335
memory). The other valid status codes are XBufferOverflow,
336
XLookupNone, XLookupChars, XLookupKeySym, and XLookupBoth. Each of
337
these has a specific meaning attached.
338
339
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
340
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
341
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
342
343
commit 79a5c86e020f08cc108184298a72e2777036de39
344
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
345
Date: Mon Jan 31 14:02:14 2011 +0200
346
347
ximcp/imTrX: Handle failing XGetWindowProperty
348
349
Checked return value of XGetWindowProperty and return false if it fails.
350
351
Return value of "XGetWindowProperty(im->core.display, spec->lib_connect_wid, prop, 0L, (length + bytes_after_ret + 3UL) / 4UL, 1, 0UL, &type_ret, &format_ret, &nitems, &bytes_after_ret, &prop_ret)" is not checked
352
353
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
354
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
355
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
356
357
commit 2ace8d5c89c8f6d9f42b4068f4b508ca28f0ced1
358
Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
359
Date: Mon Jan 31 14:02:12 2011 +0200
360
361
XlibInt: info_list->watch_data was reallocated, but result was discarded
362
363
info_list->watch_data was being reallocated, but the return value of
364
the reallocation was stored only into a local variable. This might
365
cause some funky behavior and crashes.
366
367
Variable "wd_array" goes out of scope
368
Value "wd_array" is overwritten in "wd_array = (XPointer*)realloc((char*)info_list->watch_data, (((dpy->watcher_count + 1) * 4U == 0U) ? 1U : ((dpy->watcher_count + 1) * 4U)))"
369
370
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
371
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
372
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
373
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
374
375
commit 2b16a7e683e355c9746290b2cee2fd0dd2bf342a
376
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
377
Date: Mon Jan 31 14:02:10 2011 +0200
378
379
GetProp: Zero-initialized error so its resourceID field is initialized
380
381
Using uninitialized value "error.resourceID" in call to function "_XError"
382
383
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
384
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
385
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
386
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
387
388
commit 85e9f38e016137f0ff2791eb0d092ab027382d2c
389
Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
390
Date: Tue Feb 1 11:07:25 2011 +0200
391
392
xcms/LRGB: Add a label for freeing property_return.
393
394
The rest of the code uses goto's to free memory allocated later
395
and prevent memory leaks, but there were several paths were
396
property_return was free'd just before a goto.
397
398
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
399
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
400
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
401
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
402
403
commit 3161dc57d4e9b70f852f05e5e474455e121b06ab
404
Author: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
405
Date: Mon Jan 31 14:02:08 2011 +0200
406
407
xcms/LRGB: Fix potential resource leak.
408
409
property_return was not free'd if the allocation of pRedTbl failed.
410
411
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
412
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
413
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
414
415
commit be3e6c205d94dedc1cdebf5d17b987f0f828377a
416
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
417
Date: Mon Jan 31 14:02:06 2011 +0200
418
419
Xrm: Handle the extremely unlikely situation of fstat failing
420
421
Tracked variable "size" was passed to a negative sink.
422
423
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
424
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
425
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
426
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
427
428
commit 3fae16c64d6ef76fd4a25a54c7f7de76596457db
429
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
430
Date: Mon Jan 31 14:02:05 2011 +0200
431
432
Xrm: NEWTABLE had a memory leak after a memory allocation error
433
434
The NEWTABLE macro missed freeing its allocated memory on subsequent
435
memory allocation errors. Added call to Xfree.
436
437
Variable "table" goes out of scope
438
439
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
440
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
441
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
442
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
443
444
commit 7110ac653349a23c80c365f11f6270dc27c8975a
445
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
446
Date: Mon Jan 31 14:02:03 2011 +0200
447
448
ImUtil: Handle a memory leak in one early return branch
449
450
Fixed memory leak by adding Xfree for image
451
452
Variable "image" goes out of scope
453
454
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
455
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
456
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
457
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
458
459
commit d695f5da9f5b778e54b6987d9177048e32818c4d
460
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
461
Date: Mon Jan 31 14:02:01 2011 +0200
462
463
ximcp/imRm: Handle leaking colormap_ret
464
465
Fixed memory leak by adding Xfree for colormap_ret
466
467
Variable "colormap_ret" goes out of scope
468
469
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
470
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
471
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
472
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
473
474
commit f9eda19d08c1ea0973dfe0bc10a2519d6fd26cc7
475
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
476
Date: Mon Jan 31 14:01:59 2011 +0200
477
478
ximcp/imRmAttr: Handle leaking missing_list
479
480
Fixed memory leak by adding Xfree and initializing missing_list with NULL
481
482
Variable "missing_list" goes out of scope
483
484
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
485
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
486
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
487
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
488
489
commit 3183269e0979c9dbce9d55d9e03937897dc9fb3b
490
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
491
Date: Mon Jan 31 14:01:58 2011 +0200
492
493
ximcp/imRmAttr: Handle leaking colormap_ret
494
495
XFree colormap_ret and initialize it when appropriate.
496
497
Variable "colormap_ret" goes out of scope
498
499
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
500
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
501
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
502
503
commit f66a032a937030f2d9baa81744d36dc585bb085c
504
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
505
Date: Mon Jan 31 14:01:56 2011 +0200
506
507
xlibi18n/lcGeneric: Initialize uninitialized local variable
508
509
Using uninitialized value "new"
510
511
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
512
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
513
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
514
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
515
516
commit d0266e06d38110ec908ca28379014eff743630b7
517
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
518
Date: Mon Jan 31 14:01:54 2011 +0200
519
520
xcmx/cmxColNm: Removed unused assignments to pBuf (in two functions)
521
522
Pointer "pBuf" returned from "fgets(buf, 256, stream)" is never used
523
524
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
525
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
526
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
527
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
528
529
commit cc686655d7bfdeab8b67e01a24bd452a2e9e3fcf
530
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
531
Date: Tue Feb 1 12:30:56 2011 +0200
532
533
XDefaultOMIF.c: Fix memory leaks in get_font_name
534
535
Instead of copying the value returned by get_prop_name and then releasing it,
536
directly use the return value of get_prop_name, which allocates memory for the
537
name.
538
539
If get_prop_name returns NULL, continue on to XFreeFont to release the font
540
before returning the NULL via the normal function return.
541
542
Reviewed-by: Erkki Seppälä <erkki.seppala@vincit.fi>
543
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
544
545
commit 95796351435d81eaef8166d49ba3a6e7b633d70a
546
Author: Gaetan Nadon <memsize@videotron.ca>
547
Date: Mon Jan 31 14:50:19 2011 -0500
548
549
config: comment, minor upgrade, quote and layout configure.ac
550
551
Group statements per section as per Autoconf standard layout
552
Quote statements where appropriate.
553
Autoconf recommends not using dnl instead of # for comments
554
555
Use AC_CONFIG_FILES to replace the deprecated AC_OUTPUT with parameters.
556
Remove redundant AC_CANONICAL_HOST included in XORG_DEFAULT_OPTIONS
557
558
This helps automated maintenance and release activities.
559
Details can be found in http://wiki.x.org/wiki/NewModuleGuidelines
560
561
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
562
563
commit e994ab227ed28655565c3193e63733630105e7f9
564
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
565
Date: Tue Jan 18 12:49:48 2011 +0200
566
567
Comparing array against NULL is not useful "&xkb->server->vmods != NULL"
568
569
Removed superfluous comparison.
570
571
Reviewed-by: Dirk Wallenstein <halsmit@t-online.de>
572
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
573
574
commit 4115f051e62f9b098efce691e070d44f09f30f1c
575
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
576
Date: Wed Jan 12 15:51:11 2011 +0200
577
578
Variable "entry" tracked as NULL was dereferenced.
579
580
Check entry for non-nullness before dereferencing it
581
582
Reviewed-by: Dirk Wallenstein <halsmit@t-online.de>
583
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
584
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
585
586
commit 0edb76d1d5fdca5a2543332699be2e72386dab24
587
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
588
Date: Thu Jan 27 09:54:00 2011 +0200
589
590
Dereferencing possibly NULL "str" in call to function "memcpy" (Deref assumed on the basis of 'nonnull' parameter attribute.)
591
592
If _XkbGetReadBufferPtr returns NULL, goto BAILOUT
593
594
Reviewed-by: Dirk Wallenstein <halsmit@t-online.de>
595
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
596
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
597
598
commit 59da8a211ef723909d0530c0331d541db8e63378
599
Author: Erkki Seppälä <erkki.seppala@vincit.fi>
600
Date: Mon Jan 10 16:17:47 2011 +0200
601
602
Using freed pointer "e"
603
604
Reordered code to first to do the comparison and then to release data
605
606
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
607
Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com>
608
Signed-off-by: Erkki Seppälä <erkki.seppala@vincit.fi>
609
610
commit 0f11c229f7099f7c5aeed4691b358dca151dac7d
611
Author: Matt Dew <marcoz@osource.org>
612
Date: Thu Jan 27 00:31:23 2011 -0700
613
614
Remove <literal> tags from compose-chart.pl so pdf building doesn't die on soft-hyphens.
615
616
Signed-off-by: Matt Dew <marcoz@osource.org>
617
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
618
619
commit ca00bb202f3afcdbbcb8c4cb50308c5dd03f2322
620
Author: Gaetan Nadon <memsize@videotron.ca>
621
Date: Fri Jan 28 16:07:07 2011 -0500
622
623
config: replace deprecated AC_HELP_STRING with AS_HELP_STRING
624
625
This silences an Automake warning.
626
627
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
628
629
commit 8dac08c7515cb6f8a8f4d0a721713697eae755d8
630
Author: Gaetan Nadon <memsize@videotron.ca>
631
Date: Fri Jan 28 14:59:04 2011 -0500
632
633
config: remove unrequired AC_HEADER_STDC
634
635
Autoconf says:
636
"This macro is obsolescent, as current systems have conforming
637
header files. New programs need not use this macro".
638
639
commit d4483375e37a72631d5821413cb75a423e990ffe
640
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
641
Date: Tue Jan 18 19:37:02 2011 -0800
642
643
config: Use correct AC_CONFIG_HEADERS macro
644
645
Replaces obsolete AM_CONFIG_HEADER and undocumented AC_CONFIG_HEADER
646
647
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
648
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
649
Reviewed-by: Dan Nicholson <dbn.lists@gmail.com>
650
651
commit c6405fe931f313a0d159bdad00244fc8aae12468
652
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
653
Date: Sun Jan 16 11:55:23 2011 -0800
654
655
config: remove AC_PROG_CC as it overrides AC_PROG_C_C99
656
657
XORG_STRICT_OPTION from XORG_DEFAULT_OPTIONS calls
658
AC_PROG_C_C99. This sets gcc with -std=gnu99.
659
If AC_PROG_CC macro is called afterwards, it resets CC to gcc.
660
661
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
662
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>
663
664
commit 17aa1f2305da0952ad594c7329d08aba21f13ac8
665
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
666
Date: Sun Jan 16 11:40:59 2011 -0800
667
668
Update to xf86bigfontproto >= 1.2.0 header name
669
670
Clears compile-time warning of:
671
"X11/extensions/xf86bigfstr.h", line 1: #warning: "xf86bigfstr.h is obsolete and may be removed in the future."
672
"X11/extensions/xf86bigfstr.h", line 2: #warning: "include <X11/extensions/xf86bigfproto.h> for the protocol defines."
673
674
Requires xf86bigfontproto >= 1.2.0 if --disable-xf86bigfont is not
675
passed to configure.
676
677
Also removes unnecessary AC_SUBST of BIGFONT_CFLAGS & BIGFONT_LIBS
678
that PKG_CHECK_MODULES does automatically
679
680
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
681
Reviewed-by: Julien Cristau <jcristau@debian.org>
682
1
683
commit a9228fcc676aacf9a760dd94891c89f9bc82b20d
2
684
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
3
685
Date: Tue Jan 11 17:55:22 2011 -0800
Loggerhead is a web-based interface for Breezy
Version: 2.0.1