← Back to branch summary

~ubuntu-branches/ubuntu/raring/software-center/raring-proposed

« back to all changes in this revision

Viewing changes to softwarecenter/backend/reviews/rnr.py

  • Committer: Package Import Robot
  • Author(s): Michael Vogt
  • Date: 2012-12-06 17:30:50 UTC
  • Revision ID: package-import@ubuntu.com-20121206173050-n7mxi5fzlsvtdh9l
Tags: 5.5.2
* lp:~mvo/software-center/fix-pygobject-deprecation-warnings:
  - fix deprecation warninings with the latest python-gi
* lp:~mvo/software-center/minor-logging-fixes:
  - drop some LOG.info() messages to LOG.debug() to spam the user
    less
* lp:~mvo/software-center/trivial-close-ui-tweak:
  - hide the main window immediately when closing down
* lp:~mvo/software-center/5.4-fix-save-person-to-config:
  - This branch ensures that the "username" is saved everytime
    that the ubuntu sso whoami call is done
* lp:~mvo/software-center/use-dpkg-builddeps:
  - use dpkg-checkbuilddeps to find test-dependencies
* lp:~mvo/software-center/update-sc-cmdline-flexibility:
  - update-software-center-agent: 
    + add --target-db-path commandline
  - update-software-center: 
    + add --app-install-desktop-dir and --target-db-path commandline
* lp:~mvo/software-center/raring-pep8:
  - fixes for new pep8

Show diffs side-by-side

added added

removed removed

Lines of Context:
softwarecenter/backend/reviews/rnr.py
25
25
 
26
26
from softwarecenter.backend.spawn_helper import SpawnHelper
27
27
from softwarecenter.backend.reviews import (
28
 
                                            ReviewLoader,
29
 
                                            Review,
30
 
                                            ReviewStats,
31
 
                                            UsefulnessCache,
32
 
                                            )
 
28
    ReviewLoader,
 
29
    Review,
 
30
    ReviewStats,
 
31
    UsefulnessCache,
 
32
)
33
33
from softwarecenter.backend.piston.rnrclient import RatingsAndReviewsAPI
34
34
from softwarecenter.backend.piston.rnrclient_pristine import ReviewDetails
35
35
from softwarecenter.db.database import Application
36
36
import softwarecenter.distro
37
37
from softwarecenter.netstatus import network_state_is_connected
38
 
from softwarecenter.paths import (SOFTWARE_CENTER_CACHE_DIR,
39
 
                                  PistonHelpers,
40
 
                                  RNRApps,
41
 
                                  )
42
 
from softwarecenter.utils import calc_dr, utf8, save_person_to_config
 
38
from softwarecenter.paths import (
 
39
    SOFTWARE_CENTER_CACHE_DIR,
 
40
    PistonHelpers,
 
41
    RNRApps,
 
42
)
 
43
from softwarecenter.utils import (
 
44
    calc_dr,
 
45
    utf8,
 
46
    save_person_to_config,
 
47
)
43
48
 
44
49
 
45
50
LOG = logging.getLogger(__name__)
49
54
# - python threads, slow and full of latency (GIL)
50
55
# - python multiprocessing, crashed when accessibility was turned on,
51
56
#                          does not work in the quest session (#743020)
52
 
# - GObject.spawn_async() looks good so far (using the SpawnHelper code)
 
57
# - GLib.spawn_async() looks good so far (using the SpawnHelper code)
53
58
class ReviewLoaderSpawningRNRClient(ReviewLoader):
54
59
    """ loader that uses multiprocessing to call rnrclient and
55
60
        a glib timeout watcher that polls periodically for the
112
117
               "--pkgname", str(app.pkgname),  # ensure its str, not unicode
113
118
               "--page", str(page),
114
119
               "--sort", sort_method,
115
 
              ]
 
120
               ]
116
121
        spawn_helper = SpawnHelper()
117
122
        spawn_helper.connect(
118
123
            "data-available", self._on_reviews_helper_data, app)
242
247
               "--review-id", review_id,
243
248
               "--parent-xid", "%s" % parent_xid,
244
249
               "--datadir", datadir,
245
 
              ]
 
250
               ]
246
251
        spawn_helper = SpawnHelper("json")
247
252
        spawn_helper.connect("exited",
248
253
                             self._on_report_abuse_finished,
268
273
               "--is-useful", "%s" % int(is_useful),
269
274
               "--parent-xid", "%s" % parent_xid,
270
275
               "--datadir", datadir,
271
 
              ]
 
276
               ]
272
277
        spawn_helper = SpawnHelper(format="none")
273
278
        spawn_helper.connect("exited",
274
279
                             self._on_submit_usefulness_finished,
320
325
               "--review-id", "%s" % review_id,
321
326
               "--parent-xid", "%s" % parent_xid,
322
327
               "--datadir", datadir,
323
 
              ]
 
328
               ]
324
329
        spawn_helper = SpawnHelper(format="none")
325
330
        spawn_helper.connect("exited",
326
331
                             self._on_delete_review_finished,