3
* Ensures that eval() is not used to create objects.
8
* @package PHP_CodeSniffer_MySource
9
* @author Greg Sherwood <gsherwood@squiz.net>
10
* @copyright 2006-2012 Squiz Pty Ltd (ABN 77 084 670 600)
11
* @license https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
12
* @link http://pear.php.net/package/PHP_CodeSniffer
16
* Ensures that eval() is not used to create objects.
19
* @package PHP_CodeSniffer_MySource
20
* @author Greg Sherwood <gsherwood@squiz.net>
21
* @copyright 2006-2012 Squiz Pty Ltd (ABN 77 084 670 600)
22
* @license https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
23
* @version Release: 1.5.0RC2
24
* @link http://pear.php.net/package/PHP_CodeSniffer
26
class MySource_Sniffs_PHP_EvalObjectFactorySniff implements PHP_CodeSniffer_Sniff
31
* Returns an array of tokens this test wants to listen for.
35
public function register()
43
* Processes this sniff, when one of its tokens is encountered.
45
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
46
* @param int $stackPtr The position of the current token in
47
* the stack passed in $tokens.
51
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
53
$tokens = $phpcsFile->getTokens();
56
We need to find all strings that will be in the eval
57
to determine if the "new" keyword is being used.
60
$openBracket = $phpcsFile->findNext(T_OPEN_PARENTHESIS, ($stackPtr + 1));
61
$closeBracket = $tokens[$openBracket]['parenthesis_closer'];
66
for ($i = ($openBracket + 1); $i < $closeBracket; $i++) {
67
if (in_array($tokens[$i]['code'], PHP_CodeSniffer_Tokens::$stringTokens) === true) {
68
$strings[$i] = $tokens[$i]['content'];
69
} else if ($tokens[$i]['code'] === T_VARIABLE) {
70
$vars[$i] = $tokens[$i]['content'];
75
We now have some variables that we need to expand into
76
the strings that were assigned to them, if any.
79
foreach ($vars as $varPtr => $varName) {
80
while (($prev = $phpcsFile->findPrevious(T_VARIABLE, ($varPtr - 1))) !== false) {
81
// Make sure this is an assignment of the variable. That means
82
// it will be the first thing on the line.
83
$prevContent = $phpcsFile->findPrevious(T_WHITESPACE, ($prev - 1), null, true);
84
if ($tokens[$prevContent]['line'] === $tokens[$prev]['line']) {
85
$varPtr = $prevContent;
89
if ($tokens[$prev]['content'] !== $varName) {
90
// This variable has a different name.
91
$varPtr = $prevContent;
99
if ($prev !== false) {
100
// Find all strings on the line.
101
$lineEnd = $phpcsFile->findNext(T_SEMICOLON, ($prev + 1));
102
for ($i = ($prev + 1); $i < $lineEnd; $i++) {
103
if (in_array($tokens[$i]['code'], PHP_CodeSniffer_Tokens::$stringTokens) === true) {
104
$strings[$i] = $tokens[$i]['content'];
110
foreach ($strings as $string) {
111
// If the string has "new" in it, it is not allowed.
112
// We don't bother checking if the word "new" is echo'd
113
// because that is unlikely to happen. We assume the use
114
// of "new" is for object instantiation.
115
if (strstr($string, ' new ') !== false) {
116
$error = 'Do not use eval() to create objects dynamically; use reflection instead';
117
$phpcsFile->addWarning($error, $stackPtr, 'Found');