← Back to branch summary

~ubuntu-filemanager-dev/ubuntu-filemanager-app/trunk

« back to all changes in this revision

Viewing changes to src/app/qml/ui/FolderListPage.qml

  • Committer: Tarmac
  • Author(s): Arto Jalkanen
  • Date: 2014-09-04 09:15:22 UTC
  • mfrom: (262.1.2 ubuntu-filemanager-app)
  • Revision ID: tarmac-20140904091522-8fsuxw3sfuja6ukd
Fixed focus issue with rename dialog (or any other dialog using ConfirmDialogWithInput.qml). Fixes: https://bugs.launchpad.net/bugs/1361744.

Approved by Ubuntu Phone Apps Jenkins Bot, Carlos Jose Mazieri.

Show diffs side-by-side

added added

removed removed

Lines of Context:
src/app/qml/ui/FolderListPage.qml
497
497
    Component {
498
498
        id: confirmRenameDialog
499
499
        ConfirmDialogWithInput {
500
 
            // IMPROVE: this does not seem good: the backend excepts row and new name.
 
500
            // IMPROVE: this does not seem good: the backend expects row and new name.
501
501
            // But what if new files are added/deleted in the background while user is
502
502
            // entering the new name? The indices change and wrong file is renamed.
503
503
            // Perhaps the backend should take as parameters the "old name" and "new name"?
517
517
                                        {
518
518
                                            title: i18n.tr("Could not rename"),
519
519
                                            text: i18n.tr("Insufficient permissions or name already exists?")
520
 
                                         })
 
520
                                        })
521
521
 
522
522
                    }
523
523
                } else {