« back to all changes in this revision
Viewing changes to plugins/dbus/src/dbus.h
- Committer: Daniel van Vugt
- Date: 2012-06-11 03:30:30 UTC
- mfrom: (3244.3.3 remove-availablePlugins)
- Revision ID: daniel.van.vugt@canonical.com-20120611033030-ql9n5vkt70qxs9j3
Remove dead code: availablePlugins() and *ListPlugins()
availablePlugins is unused except by dbus, and flawed by designed. It makes
no sense to have a function that claims to return the list of available
plugins, when that list is not complete. You could easily load other plugins
from LD_LIBRARY_PATH that availablePlugins doesn't know about. And you could
add or remove plugin binaries at runtime which would also invalidate what
availablePlugins knows. ListPlugins was only used by availablePlugins.
If you want a list of known plugins, call CompPlugin::getPlugins() instead.
availablePlugins is unused except by dbus, and flawed by designed. It makes
no sense to have a function that claims to return the list of available
plugins, when that list is not complete. You could easily load other plugins
from LD_LIBRARY_PATH that availablePlugins doesn't know about. And you could
add or remove plugin binaries at runtime which would also invalidate what
availablePlugins knows. ListPlugins was only used by availablePlugins.
If you want a list of known plugins, call CompPlugin::getPlugins() instead.
added
removed
plugins/dbus/src/dbus.h
