~vcs-imports/libice/master : changes

~vcs-imports/libice/master » Changes from revision 173

From Revision 173 to 154

Rev	Summary	Authors	Tags	Date
173	libICE 1.0.10 libICE 1.0.10 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith	libICE-1.0.10	4 years ago
172	cleanup: Separate variable assignment and test cleanup: Separate variable assignment and test Assigning and testing a value in a single statement hinders code clarity and may confuses static code analyzers. Separate the assignment and the test for clarity. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>	Olivier Fourdan		5 years ago
171	_IceRead: Avoid possible use-after-free _IceRead: Avoid possible use-after-free `_IceRead()` gets called from multiple places which do not expect the connection to be freed. Do not free the connection data in `_IceRead()` to avoid potential use-after-free issue in the various callers. The connection data will be freed eventually in `ProcessWantToClose()`, so not freeing it in `_IceRead()` should not introduce an memory leak. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>	Olivier Fourdan		5 years ago
170	IceListenForWellKnownConnections: Fix memleak IceListenForWellKnownConnections: Fix memleak The function `_IceTransMakeAllCOTSServerListeners` allocates memory for `transConns` which is leaked in case of error. Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>	Olivier Fourdan		5 years ago
169	IceWritePad: always use zero values for pad bytes IceWritePad: always use zero values for pad bytes Previously it would just bump the pointer in the buffer leaving whatever values were previously there in place. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		5 years ago
168	IceOpenConnection: check for malloc failure on connect_to_yo... IceOpenConnection: check for malloc failure on connect_to_you too Fixes: https://gitlab.freedesktop.org/xorg/lib/libice/issues/4 Reported-by: mahendra <mahendra.n@samsung.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		5 years ago
167	authutil: support $XDG_RUNTIME_DIR/ICEauthority authutil: support $XDG_RUNTIME_DIR/ICEauthority If we find that $XDG_RUNTIME_DIR is set (and $ICEAUTHORITY is not), then the ICEauthority file is stored in the XDG_RUNTIME_DIR instead of the home directory, and without a leading dot. https://bugs.freedesktop.org/show_bug.cgi?id=49173 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Allison Lortie		5 years ago
166	authutil: fix an out-of-bounds access authutil: fix an out-of-bounds access There is a theoretical edge case where the $HOME environment variable could be set to the empty string. IceAuthFileName() unconditionally checks index 1 of this string, which is out of bounds. Fix that up by rejecting empty strings in the same way as we reject NULL. https://bugs.freedesktop.org/show_bug.cgi?id=49173 Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Allison Lortie		5 years ago
165	Always terminate strncpy results. Always terminate strncpy results. The function strncpy does not guarantee to append a terminating NUL character to the destination. This patch merges libSM's way of handling this issue into libICE. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Tobias Stoeckmann		5 years ago
164	iceauth.c: FIX warning: unused variable 'ret' in 'arc4random... iceauth.c: FIX warning: unused variable 'ret' in 'arc4random_buf' commit ff5e59f32255913bb1cdf51441b98c9107ae165b left ret outside the #if causing a gcc warning: In function 'arc4random_buf': iceauth.c:89:13: warning: unused variable 'ret' [-Wunused-variable] fixed by moving #if 1 up Signed-off-by: Walter Harms <wharms@bfs.de> Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	walter harms		5 years ago
163	Update configure.ac bug URL for gitlab migration Update configure.ac bug URL for gitlab migration Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		5 years ago
162	Update README for gitlab migration Update README for gitlab migration Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		5 years ago
161	Remove obsolete B16 & B32 tags in struct definitions Remove obsolete B16 & B32 tags in struct definitions Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>	Alan Coopersmith		5 years ago
160	make IceProtocolShutdown() more readable make IceProtocolShutdown() more readable I found IceProtocolShutdown() hard to read only to find that was it does it aktually very simple. So i rearranged the code to make it more readable. Signed-off-by: Walter Harms <wharms@bfs.de> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> [Emil Velikov: whitespace fixes] Signed-off-by: Emil Velikov <emil.velikov@collabora.com>	walter harms		6 years ago
159	Drop NULL check prior to free() Drop NULL check prior to free() free() can handle NULL just fine - remove the check. Signed-off-by: Walter Harms <wharms@bfs.de> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>	walter harms		6 years ago
158	Make sure string is never NULL Make sure string is never NULL `error_message` is passed in to strncpy() without any check, which doesn't handle NULL itself, so let's make it a valid empty string in cases where it was NULL. Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> Acked-by: Walter Harms <wharms@bfs.de> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>	Eric Engestrom		6 years ago
157	Make sure error_message is a free-able string Make sure error_message is a free-able string Similar to the previous commit, assigning a static string would crash upon freeing. Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> Acked-by: Walter Harms <wharms@bfs.de> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>	Eric Engestrom		6 years ago
156	Make sure errorStr is a free-able string Make sure errorStr is a free-able string If the `errorClass` isn't handled by the switch, `errorStr`'s initial value would be a pointer to some static memory with an empty string, and freeing it would most likely crash. Let's set it to NULL instead, as is done in other similar places. Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com> Acked-by: Walter Harms <wharms@bfs.de> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>	Eric Engestrom		6 years ago
155	configure.ac: set TRANS_CLIENT/SERVER configure.ac: set TRANS_CLIENT/SERVER Similar to ICE_t just set the define globally and remove the multiple definitions throughout the tree Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)	Emil Velikov		6 years ago
154	Kill off local ICE_t definitions Kill off local ICE_t definitions Already defined at global scale in configure.ac Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> (IRC)	Emil Velikov		6 years ago

Older »